You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/07/28 10:44:42 UTC
[GitHub] [airflow] Taragolis opened a new issue, #25360: Extra Links do not works with mapped operators
Taragolis opened a new issue, #25360:
URL: https://github.com/apache/airflow/issues/25360
### Apache Airflow version
main (development)
### What happened
I found that Extra Links do not work with dynamic tasks at all - links inaccessible, but same Extra Links works fine with not mapped operators.
I think the nature of that extra links assign to parent task instance (i do not know how to correct name this TI) but not to actual mapped TIs.
As result we only have `number extra links defined` in operator not `(number extra links defined in operator) x number of mapped TIs.`
### What you think should happen instead
_No response_
### How to reproduce
```python
from pendulum import datetime
from airflow.decorators import dag
from airflow.sensors.external_task import ExternalTaskSensor
from airflow.operators.empty import EmptyOperator
EXTERNAL_DAG_IDS = [f"example_external_dag_{ix:02d}" for ix in range(3)]
DAG_KWARGS = {
"start_date": datetime(2022, 7, 1),
"schedule_interval": "@daily",
"catchup": False,
"tags": ["mapped_extra_links", "AIP-42", "serialization"],
}
def external_dags():
EmptyOperator(task_id="dummy")
@dag(**DAG_KWARGS)
def external_regular_task_sensor():
for external_dag_id in EXTERNAL_DAG_IDS:
ExternalTaskSensor(
task_id=f'wait_for_{external_dag_id}',
external_dag_id=external_dag_id,
poke_interval=5,
)
@dag(**DAG_KWARGS)
def external_mapped_task_sensor():
ExternalTaskSensor.partial(
task_id='wait',
poke_interval=5,
).expand(external_dag_id=EXTERNAL_DAG_IDS)
dag_external_regular_task_sensor = external_regular_task_sensor()
dag_external_mapped_task_sensor = external_mapped_task_sensor()
for dag_id in EXTERNAL_DAG_IDS:
globals()[dag_id] = dag(dag_id=dag_id, **DAG_KWARGS)(external_dags)()
```
https://user-images.githubusercontent.com/3998685/180994213-847b3fd3-d351-4836-b246-b54056f34ad6.mp4
### Operating System
macOs 12.5
### Versions of Apache Airflow Providers
_No response_
### Deployment
Other
### Deployment details
_No response_
### Anything else
_No response_
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://github.com/apache/airflow/blob/main/CODE_OF_CONDUCT.md)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] bbovenzi commented on issue #25360: Extra Links do not works with mapped operators
Posted by GitBox <gi...@apache.org>.
bbovenzi commented on issue #25360:
URL: https://github.com/apache/airflow/issues/25360#issuecomment-1203722711
> This looks like an issue in JavaScript? In the popup modal, the extra link button(s) should _not_ be shown in the “All X mapped instances” view, but only when a map index is selected. It seems like the buttons are not rendered because requests to `/extra_link` are not made when the map_index dropdown value is changed.
>
> cc @bbovenzi
Ok, I can do that part after your PR. There are a few UX improvements I want to make to the grid view mapped tasks too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on issue #25360: Extra Links do not works with mapped operators
Posted by GitBox <gi...@apache.org>.
uranusjr commented on issue #25360:
URL: https://github.com/apache/airflow/issues/25360#issuecomment-1203465292
This looks like an issue in JavaScript? In the popup modal, the extra link button(s) should not be shown in the “All X mapped instances” view, but only when a map index is selected. It seems like the buttons are not rendered because requests to `/extra_link` are not made when the map_index dropdown value is changed.
cc @bbovenzi
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr closed issue #25360: Extra Links do not works with mapped operators
Posted by GitBox <gi...@apache.org>.
uranusjr closed issue #25360: Extra Links do not works with mapped operators
URL: https://github.com/apache/airflow/issues/25360
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org