You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Michael Park <mp...@apache.org> on 2016/12/02 01:00:31 UTC
Review Request 54279: Made `configure.ac` default to use brew apr on
OS X in libprocess.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54279/
-----------------------------------------------------------
Review request for mesos and Benjamin Mahler.
Repository: mesos
Description
-------
See summary.
Diffs
-----
3rdparty/libprocess/configure.ac e65e5ca2f2231e649b01138de81a9915e308eb25
Diff: https://reviews.apache.org/r/54279/diff/
Testing
-------
Built on OS X 10.12.1 with `CC="ccache clang-3.7 -Wno-deprecated-declarations" CXX="ccache clang++-3.7 -Wno-deprecated-declarations" ../configure --enable-optimize --enable-libevent --enable-ssl --disable-python`.
Thanks,
Michael Park
Re: Review Request 54279: Made `configure.ac` default to use brew apr
on OS X in libprocess.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54279/#review157812
-----------------------------------------------------------
Ship it!
Maybe document that this brings it on par with the handling of --with-svn in terms of looking for the brew installation?
3rdparty/libprocess/configure.ac (lines 431 - 436)
<https://reviews.apache.org/r/54279/#comment228409>
A comment about the strategy taken here (that we look for brew's installation before trying the system-installed one) would be great!
- Benjamin Mahler
On Dec. 2, 2016, 1 a.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54279/
> -----------------------------------------------------------
>
> (Updated Dec. 2, 2016, 1 a.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/configure.ac e65e5ca2f2231e649b01138de81a9915e308eb25
>
> Diff: https://reviews.apache.org/r/54279/diff/
>
>
> Testing
> -------
>
> Built on OS X 10.12.1 with `CC="ccache clang-3.7 -Wno-deprecated-declarations" CXX="ccache clang++-3.7 -Wno-deprecated-declarations" ../configure --enable-optimize --enable-libevent --enable-ssl --disable-python`.
>
>
> Thanks,
>
> Michael Park
>
>