[GitHub] [hadoop] simbadzina commented on pull request #5078: HDFS-16821: Fixes regression in HDFS-13522 that enables observer reads by default

[GitBox <gi...@apache.org>]

simbadzina commented on PR #5078:
URL: https://github.com/apache/hadoop/pull/5078#issuecomment-1297360423

   > @simbadzina Thanks for your contribution. Make sense and looks good to me. I just realized that [HDFS-13522](https://issues.apache.org/jira/browse/HDFS-13522) has been merged, after looked into the relate code, I have a question and looking forward your feedback.
   > 
   > 1. Should Router support forwarding the read request to the Observer NameNodes from the client not using the ObserverReadProxyProvider?
   
   Hi @ZanderXu. Thanks for looking.
   No, clients not using ObserverReadProxyProvider shouldn't have their reads forwarded. Observer reads should be an opt-in feature since clients that participate may need to msync. To maintain backward compatibility, using ObserverReadProxyProvider was the method for opting in.
   A future improvement that can be made is to provide an alternative flag to opt-in.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org