You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@arrow.apache.org by ar...@apache.org on 2025/10/19 20:14:03 UTC

(arrow) branch main updated: GH-47830: [Release] Run RC verification source testing step in a subshell (#47831)

This is an automated email from the ASF dual-hosted git repository.

areeve pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/arrow.git


The following commit(s) were added to refs/heads/main by this push:
     new f6e48b48cd GH-47830: [Release] Run RC verification source testing step in a subshell (#47831)
f6e48b48cd is described below

commit f6e48b48cd91a9c5e3242c0ba7b6c93c54658e3d
Author: Adam Reeve <ad...@gmail.com>
AuthorDate: Mon Oct 20 09:13:57 2025 +1300

    GH-47830: [Release] Run RC verification source testing step in a subshell (#47831)
    
    ### Rationale for this change
    
    Isolates environment variable changes made when verifying the source from the tests that verify the binaries, to prevent these causing errors like in #47830.
    
    ### What changes are included in this PR?
    
    Changes `verify-release-candidate.sh` to run `test_source_distribution` in a subshell.
    
    ### Are these changes tested?
    
    I've tested this manually, I'm not sure if there are any existing CI tests that run this script on PRs.
    
    ### Are there any user-facing changes?
    
    No
    * GitHub Issue: #47830
    
    Authored-by: Adam Reeve <ad...@gmail.com>
    Signed-off-by: Adam Reeve <ad...@gmail.com>
---
 dev/release/verify-release-candidate.sh | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/dev/release/verify-release-candidate.sh b/dev/release/verify-release-candidate.sh
index 56c671910f..9213cdea01 100755
--- a/dev/release/verify-release-candidate.sh
+++ b/dev/release/verify-release-candidate.sh
@@ -1027,7 +1027,9 @@ TEST_SUCCESS=no
 
 setup_tempdir
 ensure_source_directory
-test_source_distribution
+# Run source tests in a subshell so environment variables
+# set for source testing aren't exposed to the binary tests.
+(test_source_distribution)
 test_binary_distribution
 
 TEST_SUCCESS=yes