You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by marco-m <gi...@git.apache.org> on 2015/04/17 17:43:06 UTC
[GitHub] thrift pull request: Thrift 3103
GitHub user marco-m opened a pull request:
https://github.com/apache/thrift/pull/449
Thrift 3103
See https://issues.apache.org/jira/browse/THRIFT-3103
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/marco-m/thrift THRIFT-3103
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/449.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #449
----
commit fe299785ad3971b076cd3c5a160d916e4b488bca
Author: Marco Molteni <ma...@laposte.net>
Date: 2015-04-17T08:18:35Z
THRIFT-3090 cmake build is broken on MacOSX.
commit 29b1304d663b4a8344ad1d681752ecd48c32351a
Author: Marco Molteni <ma...@laposte.net>
Date: 2015-04-17T11:48:36Z
THRIFT-3103 cmake is missing RPATH on MacOSX.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: Thrift 3103
Posted by bufferoverflow <gi...@git.apache.org>.
Github user bufferoverflow commented on the pull request:
https://github.com/apache/thrift/pull/449#issuecomment-96396686
@marco-m this is committed, could you please close the PR
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: Thrift 3103
Posted by marco-m <gi...@git.apache.org>.
Github user marco-m commented on the pull request:
https://github.com/apache/thrift/pull/449#issuecomment-94012877
Actually this pull request is only about THRIFT-3103, but you see also the previous THRIFT-3090 commit (which has a separate pull request, https://github.com/apache/thrift/pull/434), because this commit, THRIFT-3103, depends on THRIFT-3090. Hope it is clear :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: Thrift 3103
Posted by marco-m <gi...@git.apache.org>.
Github user marco-m closed the pull request at:
https://github.com/apache/thrift/pull/449
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: Thrift 3103
Posted by marco-m <gi...@git.apache.org>.
Github user marco-m commented on the pull request:
https://github.com/apache/thrift/pull/449#issuecomment-97174455
@bufferoverflow done, thanks for accepting the PR :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---