[GitHub] [griffin] lovelyqincai commented on a change in pull request #592: For task GRIFFIN-363:

[GitBox <gi...@apache.org>]

lovelyqincai commented on a change in pull request #592:
URL: https://github.com/apache/griffin/pull/592#discussion_r659300098



##########
File path: service/src/main/java/org/apache/griffin/core/metastore/hive/HiveMetaStoreProxy.java
##########
@@ -55,6 +59,28 @@ Licensed to the Apache Software Foundation (ASF) under one
 
     private IMetaStoreClient client = null;
 
+    @Value("${hive.krb5conf.path}")
+    private String hiveKrb5confPath;
+
+    @Value("${hive.keytab.path}")
+    private String keytabPath;
+
+    @Value("${hive.keytab.user}")
+    private String keytabUser;
+
+    @Value("${hive.need.kerberos}")
+    private String needKerberos;

Review comment:
       emmm,last pr for this variable 'hive.need.kerberos' i also think it type is boolean.
   but in  org.apache.griffin.core.metastore.hive.HiveMetaStoreServiceJdbcImpl line 73: needKerberos define as string.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@griffin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org