[GitHub] [spark] HeartSaVioR commented on a change in pull request #30203: [SPARK-33303][SQL] Deduplicate deterministic PythonUDF calls

[GitBox <gi...@apache.org>]

HeartSaVioR commented on a change in pull request #30203:
URL: https://github.com/apache/spark/pull/30203#discussion_r516936056



##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/python/ExtractPythonUDFs.scala
##########
@@ -218,13 +218,22 @@ object ExtractPythonUDFs extends Rule[LogicalPlan] with PredicateHelper {
     }
   }
 
+  private def canonicalizeDeterministic(u: PythonUDF) = {

Review comment:
       Just 2 cents, educating the users harder can be done in any way (regardless of the default value), and imagine the education doesn't work, deterministic by default would be much critical on the impact. (we can't trade off correctness and performance.) I'd in favor of consider it non-deterministic by default.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org