You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/12/08 12:05:08 UTC
[GitHub] [flink-connector-hbase] ferenc-csaky opened a new pull request, #4: [FLINK-30062][Connectors/HBase] ADDENDUM: Fix hbase-client 2.2 dependency handling
ferenc-csaky opened a new pull request, #4:
URL: https://github.com/apache/flink-connector-hbase/pull/4
Without this, we not package the HBase specific classes into the `flink-sql-connector-hbase-2.2` artifact.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-connector-hbase] ferenc-csaky commented on a diff in pull request #4: [FLINK-30062][Connectors/HBase] ADDENDUM: Fix hbase-client 2.2 dependency handling
Posted by GitBox <gi...@apache.org>.
ferenc-csaky commented on code in PR #4:
URL: https://github.com/apache/flink-connector-hbase/pull/4#discussion_r1045091779
##########
flink-connector-hbase-2.2/pom.xml:
##########
@@ -152,6 +148,18 @@ under the License.
<groupId>org.apache.hadoop</groupId>
<artifactId>hadoop-hdfs</artifactId>
</exclusion>
+ <exclusion>
+ <groupId>org.apache.commons</groupId>
+ <artifactId>commons-lang3</artifactId>
+ </exclusion>
+ <exclusion>
+ <groupId>commons-io</groupId>
+ <artifactId>commons-io</artifactId>
+ </exclusion>
+ <exclusion>
+ <groupId>org.jruby.jcodings</groupId>
+ <artifactId>jcodings</artifactId>
+ </exclusion>
Review Comment:
Both are excluded to achieve dependency convergence, but I reworked this part a bit now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-connector-hbase] ferenc-csaky commented on pull request #4: [FLINK-30062][Connectors/HBase] ADDENDUM: Bundle the exact same dependencies as it was in core
Posted by GitBox <gi...@apache.org>.
ferenc-csaky commented on PR #4:
URL: https://github.com/apache/flink-connector-hbase/pull/4#issuecomment-1345277395
> So netty-all is missing, as is commons-lang3.
>
> Now netty I get; 2.2 uses hbase-shaded-netty (but then I'd like a dedicated commit removing an excess dependency; can be a hotfix 🤷). But the commons-lang3 dependency does still seem to be there (but it's now being excluded for some reason).
`commons-lang3` got lost during the dependency convergence work, but now I added back both. I also made sure to use the same `commons-codec` version everywhere, cause that was also messed up. Now everything should be good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-connector-hbase] zentol commented on a diff in pull request #4: [FLINK-30062][Connectors/HBase] ADDENDUM: Fix hbase-client 2.2 dependency handling
Posted by GitBox <gi...@apache.org>.
zentol commented on code in PR #4:
URL: https://github.com/apache/flink-connector-hbase/pull/4#discussion_r1043332959
##########
flink-connector-hbase-2.2/pom.xml:
##########
@@ -152,6 +148,18 @@ under the License.
<groupId>org.apache.hadoop</groupId>
<artifactId>hadoop-hdfs</artifactId>
</exclusion>
+ <exclusion>
+ <groupId>org.apache.commons</groupId>
+ <artifactId>commons-lang3</artifactId>
+ </exclusion>
+ <exclusion>
+ <groupId>commons-io</groupId>
+ <artifactId>commons-io</artifactId>
+ </exclusion>
+ <exclusion>
+ <groupId>org.jruby.jcodings</groupId>
+ <artifactId>jcodings</artifactId>
+ </exclusion>
Review Comment:
I'm assuming we don't know why these are excluded?
##########
flink-sql-connector-hbase-2.2/pom.xml:
##########
@@ -39,15 +39,19 @@ under the License.
<groupId>org.apache.flink</groupId>
<artifactId>flink-connector-hbase-2.2</artifactId>
<version>${project.version}</version>
- <exclusions>
- <exclusion>
- <groupId>org.apache.hbase</groupId>
- <artifactId>hbase-client</artifactId>
- </exclusion>
- </exclusions>
</dependency>
</dependencies>
+ <dependencyManagement>
+ <dependencies>
+ <dependency>
+ <groupId>org.apache.hbase</groupId>
+ <artifactId>hbase-client</artifactId>
+ <version>${hbase2.version}</version>
+ </dependency>
Review Comment:
This entry shouldn't be necessary since `flink-connector-hbase-2.2` already sets the version to `hbase2.version`.
If it didn't we'd have bigger issues, because that'd mean users would have to do the same thing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-connector-hbase] zentol commented on pull request #4: [FLINK-30062][Connectors/HBase] ADDENDUM: Bundle the exact same dependencies as it was in core
Posted by GitBox <gi...@apache.org>.
zentol commented on PR #4:
URL: https://github.com/apache/flink-connector-hbase/pull/4#issuecomment-1346436879
> I compared the JAR files and all of them has the exact same content now, except the meta inf.
Apparently you missed https://github.com/apache/flink-connector-hbase/pull/4#pullrequestreview-1213179886 though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-connector-hbase] ferenc-csaky commented on pull request #4: [FLINK-30062][Connectors/HBase] ADDENDUM: Bundle the exact same dependencies as it was in core
Posted by GitBox <gi...@apache.org>.
ferenc-csaky commented on PR #4:
URL: https://github.com/apache/flink-connector-hbase/pull/4#issuecomment-1346371834
I compared the JAR files and all of them has the exact same content, except the meta inf.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-connector-hbase] zentol merged pull request #4: [FLINK-30062][Connectors/HBase] ADDENDUM: Bundle the exact same dependencies as it was in core
Posted by GitBox <gi...@apache.org>.
zentol merged PR #4:
URL: https://github.com/apache/flink-connector-hbase/pull/4
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-connector-hbase] zentol commented on a diff in pull request #4: [FLINK-30062][Connectors/HBase] ADDENDUM: Bundle the exact same dependencies as it was in core
Posted by GitBox <gi...@apache.org>.
zentol commented on code in PR #4:
URL: https://github.com/apache/flink-connector-hbase/pull/4#discussion_r1045591536
##########
flink-sql-connector-hbase-2.2/pom.xml:
##########
@@ -39,15 +39,25 @@ under the License.
<groupId>org.apache.flink</groupId>
<artifactId>flink-connector-hbase-2.2</artifactId>
<version>${project.version}</version>
- <exclusions>
- <exclusion>
- <groupId>org.apache.hbase</groupId>
- <artifactId>hbase-client</artifactId>
- </exclusion>
- </exclusions>
</dependency>
</dependencies>
+ <dependencyManagement>
+ <dependencies>
+ <dependency>
+ <groupId>commons-io</groupId>
+ <artifactId>commons-io</artifactId>
+ <version>2.11.0</version>
+ </dependency>
+
+ <dependency>
+ <groupId>org.apache.commons</groupId>
+ <artifactId>commons-lang3</artifactId>
+ <version>3.12.0</version>
Review Comment:
This is a different version than what we had in 1.16.0 (3.3.2)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-connector-hbase] zentol commented on a diff in pull request #4: [FLINK-30062][Connectors/HBase] ADDENDUM: Bundle the exact same dependencies as it was in core
Posted by GitBox <gi...@apache.org>.
zentol commented on code in PR #4:
URL: https://github.com/apache/flink-connector-hbase/pull/4#discussion_r1045592944
##########
flink-sql-connector-hbase-2.2/pom.xml:
##########
@@ -39,15 +39,25 @@ under the License.
<groupId>org.apache.flink</groupId>
<artifactId>flink-connector-hbase-2.2</artifactId>
<version>${project.version}</version>
- <exclusions>
- <exclusion>
- <groupId>org.apache.hbase</groupId>
- <artifactId>hbase-client</artifactId>
- </exclusion>
- </exclusions>
</dependency>
</dependencies>
+ <dependencyManagement>
+ <dependencies>
+ <dependency>
+ <groupId>commons-io</groupId>
+ <artifactId>commons-io</artifactId>
+ <version>2.11.0</version>
+ </dependency>
+
+ <dependency>
+ <groupId>org.apache.commons</groupId>
+ <artifactId>commons-lang3</artifactId>
+ <version>3.12.0</version>
Review Comment:
(I want this to be as dumb of a port as possible so we don't have to worry at all about it not working like the 1.16.0 version).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org