You are viewing a plain text version of this content. The canonical link for it is here.
Posted to cvs@httpd.apache.org by ja...@apache.org on 2016/03/11 22:16:48 UTC
svn commit: r1734635 - /httpd/httpd/trunk/modules/aaa/mod_auth_form.c
Author: jailletc36
Date: Fri Mar 11 21:16:48 2016
New Revision: 1734635
URL: http://svn.apache.org/viewvc?rev=1734635&view=rev
Log:
Silent a smatch warning:
mod_auth_form.c:626 get_form_auth() warn: variable dereferenced before check 'sent_user' (see line 616)
Modified:
httpd/httpd/trunk/modules/aaa/mod_auth_form.c
Modified: httpd/httpd/trunk/modules/aaa/mod_auth_form.c
URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/aaa/mod_auth_form.c?rev=1734635&r1=1734634&r2=1734635&view=diff
==============================================================================
--- httpd/httpd/trunk/modules/aaa/mod_auth_form.c (original)
+++ httpd/httpd/trunk/modules/aaa/mod_auth_form.c Fri Mar 11 21:16:48 2016
@@ -613,7 +613,7 @@ static int get_form_auth(request_rec * r
/* have we isolated the user and pw before? */
get_notes_auth(r, sent_user, sent_pw, sent_method, sent_mimetype);
- if (*sent_user && *sent_pw) {
+ if (sent_user && *sent_user && sent_pw && *sent_pw) {
return OK;
}