You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by agresch <gi...@git.apache.org> on 2018/06/04 14:17:28 UTC
[GitHub] storm pull request #2701: STORM-3091 don't allow workers to create heartbeat...
GitHub user agresch opened a pull request:
https://github.com/apache/storm/pull/2701
STORM-3091 don't allow workers to create heartbeat directory
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/agresch/storm agresch_storm-3091
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/2701.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2701
----
commit dbae31d8507aea5992d2e669da1de43d66442075
Author: Aaron Gresch <ag...@...>
Date: 2018-06-04T14:16:10Z
STORM-3091 don't allow workers to create heartbeat directory
----
---
[GitHub] storm pull request #2701: STORM-3091 don't allow workers to create heartbeat...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2701
---
[GitHub] storm issue #2701: STORM-3091 don't allow workers to create heartbeat direct...
Posted by agresch <gi...@git.apache.org>.
Github user agresch commented on the issue:
https://github.com/apache/storm/pull/2701
@revans2 - fixed the javadoc
---
[GitHub] storm issue #2701: STORM-3091 don't allow workers to create heartbeat direct...
Posted by danny0405 <gi...@git.apache.org>.
Github user danny0405 commented on the issue:
https://github.com/apache/storm/pull/2701
+ 1, thx for your contribution.
---
[GitHub] storm pull request #2701: STORM-3091 don't allow workers to create heartbeat...
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2701#discussion_r192757264
--- Diff: storm-client/src/jvm/org/apache/storm/utils/VersionedStore.java ---
@@ -25,9 +25,17 @@
private String _root;
- public VersionedStore(String path) throws IOException {
+ /**
+ * Creates a store at the given path.
+ *
+ * @path The path for the store
--- End diff --
Should be
`@param path The path for the store`
---