You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/08/31 07:17:58 UTC

[GitHub] [airflow] ephraimbuddy commented on a change in pull request #17891: Show error in UI when a DAG with same dag_id as another DAG is present

ephraimbuddy commented on a change in pull request #17891:
URL: https://github.com/apache/airflow/pull/17891#discussion_r699050319



##########
File path: airflow/models/dagbag.py
##########
@@ -466,6 +467,34 @@ def _bag_dag(self, *, dag, root_dag, recursive):
                         del self.dags[subdag.dag_id]
             raise
 
+    @provide_session
+    def _check_if_dupe(self, dag, session=None):

Review comment:
       ```suggestion
       def _check_if_duplicate(self, dag, session=None):
   ```
   I would suggest it's named as above for clarity




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org