You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@trafficserver.apache.org by zw...@apache.org on 2017/12/21 00:00:17 UTC
[trafficserver] branch 7.1.x updated (2689e7b -> 2efadb8)
This is an automated email from the ASF dual-hosted git repository.
zwoop pushed a change to branch 7.1.x
in repository https://gitbox.apache.org/repos/asf/trafficserver.git.
from 2689e7b Updated CHANGELOG and STATUS
new 4d84b93 Delete space after semi colon when deleting cookies with test to ensure not overflowing end of cookies char buffer.
new 2efadb8 Delete space after semi-colon when deleting cookies with a test to ensure not overflowing the cookies char buffer. Ensure idx + 1 is less than len before checking for space.
The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
plugins/header_rewrite/operators.cc | 5 +++++
1 file changed, 5 insertions(+)
--
To stop receiving notification emails like this one, please contact
['"commits@trafficserver.apache.org" <co...@trafficserver.apache.org>'].
[trafficserver] 02/02: Delete space after semi-colon when deleting
cookies with a test to ensure not overflowing the cookies char buffer.
Ensure idx + 1 is less than len before checking for space.
Posted by zw...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
zwoop pushed a commit to branch 7.1.x
in repository https://gitbox.apache.org/repos/asf/trafficserver.git
commit 2efadb84e072e22bab600caae524b24af432fd21
Author: Steven Feltner <sf...@godaddy.com>
AuthorDate: Mon Dec 18 07:17:19 2017 -0700
Delete space after semi-colon when deleting cookies with a test to ensure not overflowing the cookies char buffer. Ensure idx + 1 is less than len before checking for space.
(cherry picked from commit 08b560d57ac6c30f7c3ab11e796efbd11c9ec669)
---
plugins/header_rewrite/operators.cc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/plugins/header_rewrite/operators.cc b/plugins/header_rewrite/operators.cc
index fc818ad..d467f89 100644
--- a/plugins/header_rewrite/operators.cc
+++ b/plugins/header_rewrite/operators.cc
@@ -796,7 +796,7 @@ CookieHelper::cookieModifyHelper(const char *cookies, const size_t cookies_len,
}
// If we have not reached the end and there is a space after the
// semi-colon, advance one char
- if (idx < cookies_len && std::isspace(cookies[idx + 1])) {
+ if (idx + 1 < cookies_len && std::isspace(cookies[idx + 1])) {
idx++;
}
// cookie value is found
--
To stop receiving notification emails like this one, please contact
"commits@trafficserver.apache.org" <co...@trafficserver.apache.org>.
[trafficserver] 01/02: Delete space after semi colon when deleting
cookies with test to ensure not overflowing end of cookies char buffer.
Posted by zw...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
zwoop pushed a commit to branch 7.1.x
in repository https://gitbox.apache.org/repos/asf/trafficserver.git
commit 4d84b939c1cb186ef1631f84f2850f76358e3ed9
Author: Steven Feltner <sf...@godaddy.com>
AuthorDate: Tue Dec 12 13:44:45 2017 -0700
Delete space after semi colon when deleting cookies with test to ensure not overflowing end of cookies char buffer.
(cherry picked from commit d04ec06d5495d0a453290ea3f6f746534fe0dcf7)
---
plugins/header_rewrite/operators.cc | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/plugins/header_rewrite/operators.cc b/plugins/header_rewrite/operators.cc
index c54e167..fc818ad 100644
--- a/plugins/header_rewrite/operators.cc
+++ b/plugins/header_rewrite/operators.cc
@@ -794,6 +794,11 @@ CookieHelper::cookieModifyHelper(const char *cookies, const size_t cookies_len,
for (; idx < cookies_len && cookies[idx] != ';'; idx++) {
;
}
+ // If we have not reached the end and there is a space after the
+ // semi-colon, advance one char
+ if (idx < cookies_len && std::isspace(cookies[idx + 1])) {
+ idx++;
+ }
// cookie value is found
size_t value_end_idx = idx;
if (CookieHelper::COOKIE_OP_SET == cookie_op) {
--
To stop receiving notification emails like this one, please contact
"commits@trafficserver.apache.org" <co...@trafficserver.apache.org>.