You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@asterixdb.apache.org by "abdullah alamoudi (Code Review)" <do...@asterixdb.incubator.apache.org> on 2016/07/24 18:42:19 UTC

Change in asterixdb[master]: ASTERIX-1135 Fix Feed Policy Creation From File

abdullah alamoudi has uploaded a new change for review.

  https://asterix-gerrit.ics.uci.edu/1018

Change subject: ASTERIX-1135 Fix Feed Policy Creation From File
......................................................................

ASTERIX-1135 Fix Feed Policy Creation From File

Change-Id: I452ac11714e20e2ecc31ab8b96a9964ca9d9d6cd
---
M asterixdb/asterix-lang-aql/src/main/javacc/AQL.jj
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/18/1018/1

diff --git a/asterixdb/asterix-lang-aql/src/main/javacc/AQL.jj b/asterixdb/asterix-lang-aql/src/main/javacc/AQL.jj
index 7701278..f6f9c59 100644
--- a/asterixdb/asterix-lang-aql/src/main/javacc/AQL.jj
+++ b/asterixdb/asterix-lang-aql/src/main/javacc/AQL.jj
@@ -725,7 +725,7 @@
       {
         cfps = new CreateFeedPolicyStatement(policyName, basePolicyName, properties, definition, ifNotExists);
       }
-     |<PATH> sourcePolicyFile = Identifier() (<DEFINITION> definition = StringLiteral())?
+     |<PATH> sourcePolicyFile = StringLiteral() (<DEFINITION> definition = StringLiteral())?
       {
         cfps = new CreateFeedPolicyStatement(policyName, sourcePolicyFile, definition, ifNotExists);
       }

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1018
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I452ac11714e20e2ecc31ab8b96a9964ca9d9d6cd
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <ba...@gmail.com>

Change in asterixdb[master]: ASTERIXDB-1135 Fix Feed Policy Creation From File

Posted by "abdullah alamoudi (Code Review)" <do...@asterixdb.incubator.apache.org>.

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

    https://asterix-gerrit.ics.uci.edu/1018

to look at the new patch set (#5).

Change subject: ASTERIXDB-1135 Fix Feed Policy Creation From File
......................................................................

ASTERIXDB-1135 Fix Feed Policy Creation From File

Change-Id: I452ac11714e20e2ecc31ab8b96a9964ca9d9d6cd
---
A asterixdb/asterix-app/data/feed-policy/policy.properties
C asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/create-policy-from-file/create-policy-from-file.1.ddl.aql
C asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/create-policy-from-file/create-policy-from-file.2.query.aql
C asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/create-policy-from-file/create-policy-from-file.3.ddl.aql
D asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/feeds_04/feeds_04.1.ddl.aql
D asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/feeds_04/feeds_04.2.update.aql
D asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/feeds_04/feeds_04.3.query.aql
D asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/feeds_05/feeds_05.1.ddl.aql
D asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/feeds_05/feeds_05.3.query.aql
D asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/feeds_06/feeds_06.1.ddl.aql
D asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/feeds_06/feeds_06.2.update.aql
D asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/feeds_06/feeds_06.3.sleep.aql
D asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/feeds_06/feeds_06.4.update.aql
D asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/feeds_06/feeds_06.5.query.aql
D asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/issue_711_feeds/issue_711_feeds.1.ddl.aql
D asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/issue_711_feeds/issue_711_feeds.2.update.aql
D asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/issue_711_feeds/issue_711_feeds.3.query.aql
C asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/create-policy-from-file/create-policy-from-file.1.ddl.sqlpp
C asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/create-policy-from-file/create-policy-from-file.2.query.sqlpp
R asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/create-policy-from-file/create-policy-from-file.3.ddl.sqlpp
M asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/feeds_01/feeds_01.1.ddl.sqlpp
M asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/feeds_02/feeds_02.1.ddl.sqlpp
M asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/feeds_02/feeds_02.2.update.sqlpp
M asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/feeds_02/feeds_02.3.query.sqlpp
M asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/feeds_03/feeds_03.1.ddl.sqlpp
D asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/feeds_04/feeds_04.1.ddl.sqlpp
D asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/feeds_04/feeds_04.2.update.sqlpp
D asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/feeds_05/feeds_05.1.ddl.sqlpp
D asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/feeds_05/feeds_05.2.update.sqlpp
D asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/feeds_05/feeds_05.3.query.sqlpp
D asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/feeds_06/feeds_06.1.ddl.sqlpp
D asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/feeds_06/feeds_06.2.update.sqlpp
D asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/feeds_06/feeds_06.3.sleep.sqlpp
D asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/feeds_06/feeds_06.4.update.sqlpp
D asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/feeds_06/feeds_06.5.query.sqlpp
M asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/feeds_07/feeds_07.1.ddl.sqlpp
M asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/feeds_07/feeds_07.2.update.sqlpp
M asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/feeds_07/feeds_07.3.query.sqlpp
M asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/feeds_08/feeds_08.1.ddl.sqlpp
M asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/feeds_08/feeds_08.2.update.sqlpp
M asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/feeds_08/feeds_08.3.query.sqlpp
C asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/feeds_08/feeds_08.4.sleep.sqlpp
M asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/feeds_09/feeds_09.1.ddl.sqlpp
M asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/feeds_09/feeds_09.2.update.sqlpp
M asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/feeds_09/feeds_09.3.query.sqlpp
R asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/feeds_09/feeds_09.4.ddl.sqlpp
M asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/feeds_10/feeds_10.1.ddl.sqlpp
M asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/feeds_10/feeds_10.2.update.sqlpp
M asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/feeds_10/feeds_10.3.query.sqlpp
C asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/feeds_10/feeds_10.4.ddl.sqlpp
M asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/feeds_11/feeds_11.1.ddl.sqlpp
M asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/feeds_11/feeds_11.2.update.sqlpp
M asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/feeds_11/feeds_11.3.query.sqlpp
M asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/feeds_12/feeds_12.1.ddl.sqlpp
M asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/feeds_12/feeds_12.2.update.sqlpp
M asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/feeds_12/feeds_12.3.query.sqlpp
C asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/feeds_12/feeds_12.4.ddl.sqlpp
M asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/issue_230_feeds/issue_230_feeds.1.ddl.sqlpp
M asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/issue_230_feeds/issue_230_feeds.2.update.sqlpp
M asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/issue_230_feeds/issue_230_feeds.3.query.sqlpp
C asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/issue_230_feeds/issue_230_feeds.4.ddl.sqlpp
D asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/issue_711_feeds/issue_711_feeds.1.ddl.sqlpp
D asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/issue_711_feeds/issue_711_feeds.2.update.sqlpp
D asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/issue_711_feeds/issue_711_feeds.3.query.sqlpp
A asterixdb/asterix-app/src/test/resources/runtimets/results/feeds/create-policy-from-file/create-policy-from-file.1.adm
D asterixdb/asterix-app/src/test/resources/runtimets/results/feeds/feeds_04/feeds_04.1.adm
D asterixdb/asterix-app/src/test/resources/runtimets/results/feeds/feeds_05/feeds_05.1.adm
D asterixdb/asterix-app/src/test/resources/runtimets/results/feeds/feeds_06/feeds_06.1.adm
D asterixdb/asterix-app/src/test/resources/runtimets/results/feeds/issue_711_feeds/issue_711_feeds.1.adm
M asterixdb/asterix-app/src/test/resources/runtimets/testsuite.xml
M asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
M asterixdb/asterix-lang-aql/src/main/javacc/AQL.jj
M asterixdb/asterix-lang-sqlpp/src/main/javacc/SQLPP.jj
M asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/utils/MetadataLockManager.java
74 files changed, 417 insertions(+), 1,298 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/18/1018/5
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1018
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I452ac11714e20e2ecc31ab8b96a9964ca9d9d6cd
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <ba...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: Yingyi Bu <bu...@gmail.com>
Gerrit-Reviewer: abdullah alamoudi <ba...@gmail.com>

Change in asterixdb[master]: ASTERIXDB-1135 Fix Feed Policy Creation From File

Posted by "abdullah alamoudi (Code Review)" <do...@asterixdb.incubator.apache.org>.

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

    https://asterix-gerrit.ics.uci.edu/1018

to look at the new patch set (#3).

Change subject: ASTERIXDB-1135 Fix Feed Policy Creation From File
......................................................................

ASTERIXDB-1135 Fix Feed Policy Creation From File

Change-Id: I452ac11714e20e2ecc31ab8b96a9964ca9d9d6cd
---
A asterixdb/asterix-app/data/feed-policy/policy.properties
A asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/create-policy-from-file/create-policy-from-file.1.ddl.aql
A asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/create-policy-from-file/create-policy-from-file.2.query.aql
A asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/create-policy-from-file/create-policy-from-file.3.ddl.aql
A asterixdb/asterix-app/src/test/resources/runtimets/results/feeds/create-policy-from-file/create-policy-from-file.1.adm
M asterixdb/asterix-app/src/test/resources/runtimets/testsuite.xml
M asterixdb/asterix-lang-aql/src/main/javacc/AQL.jj
M asterixdb/asterix-lang-sqlpp/src/main/javacc/SQLPP.jj
M asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/utils/MetadataLockManager.java
9 files changed, 106 insertions(+), 4 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/18/1018/3
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1018
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I452ac11714e20e2ecc31ab8b96a9964ca9d9d6cd
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <ba...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: Yingyi Bu <bu...@gmail.com>
Gerrit-Reviewer: abdullah alamoudi <ba...@gmail.com>

Change in asterixdb[master]: ASTERIXDB-1135 Fix Feed Policy Creation From File

Posted by "Yingyi Bu (Code Review)" <do...@asterixdb.incubator.apache.org>.

Yingyi Bu has posted comments on this change.

Change subject: ASTERIXDB-1135 Fix Feed Policy Creation From File
......................................................................


Patch Set 6:

Just two comments (the first one is a question):

1. Are feed_04, feed_06, and feed_issue711 sth. that shouldn't work with the new feed design?  Or, they are still bugs and will be fixed later?  If it is the latter case, we probably should keep them, otherwise, I agree to remove them.

2. There are many white spaces in test ddl/update/query files.

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1018
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I452ac11714e20e2ecc31ab8b96a9964ca9d9d6cd
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <ba...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: Yingyi Bu <bu...@gmail.com>
Gerrit-Reviewer: abdullah alamoudi <ba...@gmail.com>
Gerrit-HasComments: No

Change in asterixdb[master]: ASTERIXDB-1135 Fix Feed Policy Creation From File

Posted by "Till Westmann (Code Review)" <do...@asterixdb.incubator.apache.org>.

Till Westmann has posted comments on this change.

Change subject: ASTERIXDB-1135 Fix Feed Policy Creation From File
......................................................................


Patch Set 6:

(55 comments)

Most comments are one the comments for the tests. There's quite q bit of strange whitespace in there. Also the comments often seem unrelated to the test ...

https://asterix-gerrit.ics.uci.edu/#/c/1018/6/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/feeds_02/feeds_02.1.ddl.sqlpp
File asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/feeds_02/feeds_02.1.ddl.sqlpp:

Line 20:  * Description  : Create a feed dataset that uses the feed simulator adapter. 
WS

Also, this seems to use the file adapter, not a simulator.


Line 21:                   Begin ingestion and verify contents of the dataset post completion.  
WS


https://asterix-gerrit.ics.uci.edu/#/c/1018/6/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/feeds_02/feeds_02.2.update.sqlpp
File asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/feeds_02/feeds_02.2.update.sqlpp:

Line 20:  * Description  : Create a feed dataset that uses the feed simulator adapter. 
WS

Also, this seems to use the file adapter, not a simulator.


Line 21:                   Begin ingestion and verify contents of the dataset post completion.  
WS


Line 25:  
WS


https://asterix-gerrit.ics.uci.edu/#/c/1018/6/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/feeds_02/feeds_02.3.query.sqlpp
File asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/feeds_02/feeds_02.3.query.sqlpp:

Line 20:  * Description  : Create a feed dataset that uses the feed simulator adapter. 
WS

Also, this seems to use the file adapter, not a simulator.


Line 21:                   Begin ingestion and verify contents of the dataset post completion.  
WS


Line 25:  
WS


https://asterix-gerrit.ics.uci.edu/#/c/1018/6/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/feeds_03/feeds_03.1.ddl.sqlpp
File asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/feeds_03/feeds_03.1.ddl.sqlpp:

Line 20:  * Description  : Create a feed dataset with an associated function and verify contents in Metadata
Where does the content verification in Metadata happen?


Line 35: }      
WS


https://asterix-gerrit.ics.uci.edu/#/c/1018/6/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/feeds_07/feeds_07.1.ddl.sqlpp
File asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/feeds_07/feeds_07.1.ddl.sqlpp:

Line 21:                   Create a dataset that has an associated rtree index.
There seems to be no index created ...


Line 22:                   The synthetic feed simulator uses the Social-Data generator to generate data and simulate a feed.
Is "twitter_firehose" a synthetic feed simulator?


https://asterix-gerrit.ics.uci.edu/#/c/1018/6/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/feeds_07/feeds_07.2.update.sqlpp
File asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/feeds_07/feeds_07.2.update.sqlpp:

Line 20:  * Description  : Create a feed using the synthetic feed simulator adapter.                   
WS

Other comments as before.


https://asterix-gerrit.ics.uci.edu/#/c/1018/6/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/feeds_07/feeds_07.3.query.sqlpp
File asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/feeds_07/feeds_07.3.query.sqlpp:

Line 20:  * Description  : Create a feed using the synthetic feed simulator adapter.                   
WS

Other comments as before.


Line 32: case 
WS


https://asterix-gerrit.ics.uci.edu/#/c/1018/6/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/feeds_08/feeds_08.1.ddl.sqlpp
File asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/feeds_08/feeds_08.1.ddl.sqlpp:

Line 22:                   The synthetic feed simulator uses the Social-Data generator
Again, wondering if twitter_firehose is a synthetic feed.


https://asterix-gerrit.ics.uci.edu/#/c/1018/6/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/feeds_08/feeds_08.2.update.sqlpp
File asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/feeds_08/feeds_08.2.update.sqlpp:

Line 22:                   The synthetic feed simulator uses the Social-Data generator
Comment as before.


https://asterix-gerrit.ics.uci.edu/#/c/1018/6/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/feeds_08/feeds_08.3.query.sqlpp
File asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/feeds_08/feeds_08.3.query.sqlpp:

Line 22:                   The synthetic feed simulator uses the Social-Data generator
Comment as before.


Line 34: case 
WS


https://asterix-gerrit.ics.uci.edu/#/c/1018/6/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/feeds_08/feeds_08.4.sleep.sqlpp
File asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/feeds_08/feeds_08.4.sleep.sqlpp:

Line 22:                   The synthetic feed simulator uses the Social-Data generator
Comment as before.


https://asterix-gerrit.ics.uci.edu/#/c/1018/6/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/feeds_09/feeds_09.1.ddl.sqlpp
File asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/feeds_09/feeds_09.1.ddl.sqlpp:

Line 20:  * Description  : Create a feed using the synthetic feed simulator adapter. 
WS


Line 22:                   The synthetic feed simulator uses the Social-Data generator to generate data and simulate a feed. 
WS

Comment as before.


Line 23:                   The feed lasts a configured duration with data arriving at a configured rate (tweets per second). 
WS


Line 25:  * Issue        : 711                 
WS


https://asterix-gerrit.ics.uci.edu/#/c/1018/6/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/feeds_09/feeds_09.2.update.sqlpp
File asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/feeds_09/feeds_09.2.update.sqlpp:

Line 20:  * Description  : Create a feed using the synthetic feed simulator adapter. 
WS

Comment as before.


Line 22:                   The synthetic feed simulator uses the Social-Data generator to generate data and simulate a feed. 
WS


Line 25:  * Issue        : 711                 
WS


https://asterix-gerrit.ics.uci.edu/#/c/1018/6/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/feeds_09/feeds_09.3.query.sqlpp
File asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/feeds_09/feeds_09.3.query.sqlpp:

Line 20:  * Description  : Create a feed using the synthetic feed simulator adapter. 
WS


Line 22:                   The synthetic feed simulator uses the Social-Data generator to generate data and simulate a feed. 
WS


Line 23:                   The feed lasts a configured duration with data arriving at a configured rate (tweets per second). 
WS


Line 25:  * Issue        : 711                 
WS


Line 32: case 
WS


https://asterix-gerrit.ics.uci.edu/#/c/1018/6/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/feeds_10/feeds_10.1.ddl.sqlpp
File asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/feeds_10/feeds_10.1.ddl.sqlpp:

Line 21:                   Create a feed that uses the file_feed adapter.
Adapter is called "localfs" now?


https://asterix-gerrit.ics.uci.edu/#/c/1018/6/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/feeds_10/feeds_10.2.update.sqlpp
File asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/feeds_10/feeds_10.2.update.sqlpp:

Line 21:                   Create a feed that uses the file_feed adapter.
Comment as before.


https://asterix-gerrit.ics.uci.edu/#/c/1018/6/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/feeds_10/feeds_10.3.query.sqlpp
File asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/feeds_10/feeds_10.3.query.sqlpp:

Line 21:                   Create a feed that uses the file_feed adapter.
Comment as before.


https://asterix-gerrit.ics.uci.edu/#/c/1018/6/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/feeds_10/feeds_10.4.ddl.sqlpp
File asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/feeds_10/feeds_10.4.ddl.sqlpp:

Line 21:                   Create a dataset that has an associated ngram index.
?? no ngrams here, are there?


https://asterix-gerrit.ics.uci.edu/#/c/1018/6/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/feeds_11/feeds_11.1.ddl.sqlpp
File asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/feeds_11/feeds_11.1.ddl.sqlpp:

Line 20:  * Description  : Create a feed dataset that uses the feed simulator adapter. 
WS


Line 21:                   Begin ingestion using a fully qualified name and verify contents of the dataset post completion.  
WS


https://asterix-gerrit.ics.uci.edu/#/c/1018/6/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/feeds_11/feeds_11.2.update.sqlpp
File asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/feeds_11/feeds_11.2.update.sqlpp:

Line 20:  * Description  : Create a feed dataset that uses the feed simulator adapter. 
WS


Line 21:                   Begin ingestion using a fully qualified name and verify contents of the dataset post completion.  
WS


https://asterix-gerrit.ics.uci.edu/#/c/1018/6/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/feeds_11/feeds_11.3.query.sqlpp
File asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/feeds_11/feeds_11.3.query.sqlpp:

Line 20:  * Description  : Create a feed dataset that uses the feed simulator adapter. 
WS


Line 21:                   Begin ingestion using a fully qualified name and verify contents of the dataset post completion.  
WS


https://asterix-gerrit.ics.uci.edu/#/c/1018/6/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/feeds_12/feeds_12.1.ddl.sqlpp
File asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/feeds_12/feeds_12.1.ddl.sqlpp:

Line 20:  * Description  : Create a feed from the contents of  a file using a file_feed adaptor. 
WS


Line 23:                   without an abort. 
WS


https://asterix-gerrit.ics.uci.edu/#/c/1018/6/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/feeds_12/feeds_12.2.update.sqlpp
File asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/feeds_12/feeds_12.2.update.sqlpp:

Line 20:  * Description  : Create a feed from the contents of  a file using a file_feed adaptor. 
WS


Line 23:                   without an abort. 
WS


https://asterix-gerrit.ics.uci.edu/#/c/1018/6/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/feeds_12/feeds_12.3.query.sqlpp
File asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/feeds_12/feeds_12.3.query.sqlpp:

Line 20:  * Description  : Create a feed from the contents of  a file using a file_feed adaptor. 
WS


Line 23:                   without an abort. 
WS


https://asterix-gerrit.ics.uci.edu/#/c/1018/6/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/feeds_12/feeds_12.4.ddl.sqlpp
File asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/feeds_12/feeds_12.4.ddl.sqlpp:

Line 22:                   The synthetic feed simulator uses the Social-Data generator to generate data and simulate a feed.
Comment is for anoethr test.


https://asterix-gerrit.ics.uci.edu/#/c/1018/6/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/issue_230_feeds/issue_230_feeds.1.ddl.sqlpp
File asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/issue_230_feeds/issue_230_feeds.1.ddl.sqlpp:

Line 20:  * Description  : Create a feed dataset that uses the feed simulator adapter. 
WS

seems to be localfs ...


Line 21:                   Begin ingestion using a fully qualified name and verify contents of the dataset post completion.  
WS


https://asterix-gerrit.ics.uci.edu/#/c/1018/6/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/issue_230_feeds/issue_230_feeds.2.update.sqlpp
File asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/issue_230_feeds/issue_230_feeds.2.update.sqlpp:

Line 20:  * Description  : Create a feed dataset that uses the feed simulator adapter. 
WS


Line 21:                   Begin ingestion using a fully qualified name and verify contents of the dataset post completion.  
WS


https://asterix-gerrit.ics.uci.edu/#/c/1018/6/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/issue_230_feeds/issue_230_feeds.3.query.sqlpp
File asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/issue_230_feeds/issue_230_feeds.3.query.sqlpp:

Line 20:  * Description  : Create a feed dataset that uses the feed simulator adapter. 
WS


Line 21:                   Begin ingestion using a fully qualified name and verify contents of the dataset post completion.  
WS


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1018
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I452ac11714e20e2ecc31ab8b96a9964ca9d9d6cd
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <ba...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: Yingyi Bu <bu...@gmail.com>
Gerrit-Reviewer: abdullah alamoudi <ba...@gmail.com>
Gerrit-HasComments: Yes

Change in asterixdb[master]: ASTERIXDB-1135 Fix Feed Policy Creation From File

Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.

Jenkins has posted comments on this change.

Change subject: ASTERIXDB-1135 Fix Feed Policy Creation From File
......................................................................


Patch Set 5:

Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/2027/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1018
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I452ac11714e20e2ecc31ab8b96a9964ca9d9d6cd
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <ba...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: Yingyi Bu <bu...@gmail.com>
Gerrit-Reviewer: abdullah alamoudi <ba...@gmail.com>
Gerrit-HasComments: No