[GitHub] [superset] geido commented on a diff in pull request #22417: chore: Force configuration for SafeMarkdown component

[GitBox <gi...@apache.org>]

geido commented on code in PR #22417:
URL: https://github.com/apache/superset/pull/22417#discussion_r1048559167


##########
superset-frontend/packages/superset-ui-core/src/components/SafeMarkdown.tsx:
##########
@@ -25,15 +25,16 @@ import { FeatureFlag, isFeatureEnabled } from '../utils';
 
 interface SafeMarkdownProps {
   source: string;
-  htmlSanitization?: boolean;
-  htmlSchemaOverrides?: typeof defaultSchema;
 }
 
-function SafeMarkdown({
-  source,
-  htmlSanitization = true,
-  htmlSchemaOverrides = {},
-}: SafeMarkdownProps) {
+function SafeMarkdown({ source }: SafeMarkdownProps) {
+  const appContainer = document.getElementById('app');

Review Comment:
   I think we need a separate discussion for that. Certain components like this case should indeed be dependent on the configuration of the overall application as we don’t want that they can be implemented in an unsafe way or that configurations are skipped entirely as is the case of Handlebars. We could for example wrap the component within another and warn if the component is accessed directly. However, for now I can fix the Handlebars configuration problem only and we can have a broader conversation later



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org