[GitHub] gengliangwang commented on a change in pull request #23714: [SPARK-26744][SQL]Support schema validation in FileDataSourceV2 framework

[GitBox <gi...@apache.org>]

gengliangwang commented on a change in pull request #23714: [SPARK-26744][SQL]Support schema validation in FileDataSourceV2 framework
URL: https://github.com/apache/spark/pull/23714#discussion_r256687375
 
 

 ##########
 File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/FileWriteBuilder.scala
 ##########
 @@ -104,12 +104,24 @@ abstract class FileWriteBuilder(options: DataSourceOptions)
       options: Map[String, String],
       dataSchema: StructType): OutputWriterFactory
 
+  /**
+   * Returns whether this format supports the given [[DataType]] in write path.
+   * By default all data types are supported.
+   */
+  def supportDataType(dataType: DataType): Boolean = true
 
 Review comment:
   I proposed to change the name as "supports..." in previous PR: https://github.com/apache/spark/pull/23639
   
   See the opposed comment here:  https://github.com/apache/spark/pull/23639#pullrequestreview-196362643

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org