You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mina.apache.org by GitBox <gi...@apache.org> on 2022/09/25 13:15:51 UTC
[GitHub] [mina] tomaswolf opened a new pull request, #35: [DIRMINA-1169] Fix unbinding a serverSocketChannel
tomaswolf opened a new pull request, #35:
URL: https://github.com/apache/mina/pull/35
Since Java 11, closing a ServerSocketChannel may release the socket
only on the next select() call. If we try to register a new binding for
an unbound socket before the next select, a BindException may be thrown.
Ensure that there is a select() call between unbinding some sockets and
binding new sockets. Mark the unbind futures as "done" only after that
intervening select().
Test plan:
- check out this PR
- replace NioSocketAcceptor by the 2.0.23 version
- run the SocketAcceptorTest on a JVM 11 (or newer). It should fail with a BindException.
- git reset --hard
- run the SocketAcceptorTest on a JVM 11 (or newer) again. It should pass.
Note that if SocketAcceptorTest is run on a JVM 8, it will succeed in either case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For additional commands, e-mail: dev-help@mina.apache.org
[GitHub] [mina] tomaswolf commented on pull request #35: [DIRMINA-1169] Fix unbinding a serverSocketChannel
Posted by "tomaswolf (via GitHub)" <gi...@apache.org>.
tomaswolf commented on PR #35:
URL: https://github.com/apache/mina/pull/35#issuecomment-1555823619
> Merged in 2.2.X
But not correctly. See my [comment](https://github.com/apache/mina/commit/36f4e9718d43509d0182b153277ff186148660f3#r114177942).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For additional commands, e-mail: dev-help@mina.apache.org
[GitHub] [mina] chrjohn commented on pull request #35: [DIRMINA-1169] Fix unbinding a serverSocketChannel
Posted by "chrjohn (via GitHub)" <gi...@apache.org>.
chrjohn commented on PR #35:
URL: https://github.com/apache/mina/pull/35#issuecomment-1523040118
No problem at all. :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For additional commands, e-mail: dev-help@mina.apache.org
[GitHub] [mina] chrjohn commented on pull request #35: [DIRMINA-1169] Fix unbinding a serverSocketChannel
Posted by GitBox <gi...@apache.org>.
chrjohn commented on PR #35:
URL: https://github.com/apache/mina/pull/35#issuecomment-1333873016
@elecharny Any chance that this could be integrated into 2.1.x (and later 2.2.x) and released? It causes spurious failures in our test suite.
Thank you in advance
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For additional commands, e-mail: dev-help@mina.apache.org
[GitHub] [mina] chrjohn commented on pull request #35: [DIRMINA-1169] Fix unbinding a serverSocketChannel
Posted by GitBox <gi...@apache.org>.
chrjohn commented on PR #35:
URL: https://github.com/apache/mina/pull/35#issuecomment-1257198626
Would be good if this could also be merged to 2.2.x then. It causes intermittent failures in our test suite (QuickFIX/J)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For additional commands, e-mail: dev-help@mina.apache.org
[GitHub] [mina] elecharny commented on pull request #35: [DIRMINA-1169] Fix unbinding a serverSocketChannel
Posted by "elecharny (via GitHub)" <gi...@apache.org>.
elecharny commented on PR #35:
URL: https://github.com/apache/mina/pull/35#issuecomment-1556764578
Also merged in 2.1.X
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For additional commands, e-mail: dev-help@mina.apache.org
[GitHub] [mina] tomaswolf commented on pull request #35: [DIRMINA-1169] Fix unbinding a serverSocketChannel
Posted by GitBox <gi...@apache.org>.
tomaswolf commented on PR #35:
URL: https://github.com/apache/mina/pull/35#issuecomment-1264660539
@elecharny could you please take look and merge this if you think it's OK? And then merge or cherry-pick it to the 2.1.X and 2.2.X branches? I'm a bit confused by the git history of this repo, and it's not clear to me how you manage back-ports or fixes in old versions, otherwise I might be able to do so myself. The three 2.* branches seem to be completely separate. That's not what I'm used to from EGit or JGit, where after a fix on an old maintenance branch we merge the change up to the current master/main branch.
Having a 2.0.24 including the fix would also be useful. Currently we have disabled one test in Apache MINA sshd because of this problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For additional commands, e-mail: dev-help@mina.apache.org
[GitHub] [mina] elecharny commented on pull request #35: [DIRMINA-1169] Fix unbinding a serverSocketChannel
Posted by "elecharny (via GitHub)" <gi...@apache.org>.
elecharny commented on PR #35:
URL: https://github.com/apache/mina/pull/35#issuecomment-1523035898
Will check that for 2.1 and 2.2 this week. Sorry for the delay...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For additional commands, e-mail: dev-help@mina.apache.org
[GitHub] [mina] elecharny commented on pull request #35: [DIRMINA-1169] Fix unbinding a serverSocketChannel
Posted by "elecharny (via GitHub)" <gi...@apache.org>.
elecharny commented on PR #35:
URL: https://github.com/apache/mina/pull/35#issuecomment-1555522769
Merged in 2.2.X
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For additional commands, e-mail: dev-help@mina.apache.org