You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/04/24 00:20:40 UTC

[GitHub] [incubator-superset] codecov-io commented on issue #7348: Feature flag for client cache

codecov-io commented on issue #7348: Feature flag for client cache
URL: https://github.com/apache/incubator-superset/pull/7348#issuecomment-486020794
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/7348?src=pr&el=h1) Report
   > Merging [#7348](https://codecov.io/gh/apache/incubator-superset/pull/7348?src=pr&el=desc) into [lyftga](https://codecov.io/gh/apache/incubator-superset/commit/8fd7d4b670dd2a09e0012183b4d213246ca47974?src=pr&el=desc) will **decrease** coverage by `0.02%`.
   > The diff coverage is `80%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/7348/graphs/tree.svg?width=650&token=KsB0fHcx6l&height=150&src=pr)](https://codecov.io/gh/apache/incubator-superset/pull/7348?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           lyftga    #7348      +/-   ##
   ==========================================
   - Coverage   64.68%   64.66%   -0.03%     
   ==========================================
     Files         426      426              
     Lines       20897    20909      +12     
     Branches     2302     2306       +4     
   ==========================================
   + Hits        13517    13520       +3     
   - Misses       7256     7265       +9     
     Partials      124      124
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/7348?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/7348/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `93.78% <100%> (ø)` | :arrow_up: |
   | [superset/assets/src/featureFlags.ts](https://codecov.io/gh/apache/incubator-superset/pull/7348/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9mZWF0dXJlRmxhZ3MudHM=) | `75% <100%> (+3.57%)` | :arrow_up: |
   | [superset/assets/src/chart/chartAction.js](https://codecov.io/gh/apache/incubator-superset/pull/7348/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9jaGFydC9jaGFydEFjdGlvbi5qcw==) | `49.25% <66.66%> (+0.01%)` | :arrow_up: |
   | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/7348/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.19% <0%> (-0.38%)` | :arrow_down: |
   | [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/7348/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `83.46% <0%> (-0.11%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/7348?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/7348?src=pr&el=footer). Last update [8fd7d4b...6aad1c6](https://codecov.io/gh/apache/incubator-superset/pull/7348?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org