You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2022/01/25 20:08:44 UTC
[GitHub] [calcite] julianhyde commented on a change in pull request #2701: [CALCITE-4994] Memoizing FieldMap information in SqlToRelConvertor's BlackBoard
julianhyde commented on a change in pull request #2701:
URL: https://github.com/apache/calcite/pull/2701#discussion_r792075264
##########
File path: core/src/main/java/org/apache/calcite/sql2rel/SqlToRelConverter.java
##########
@@ -4817,13 +4819,17 @@ void setRoot(List<RelNode> inputs) {
if (node == null) {
Review comment:
is node ever null? if not, remove this `if`.
##########
File path: core/src/main/java/org/apache/calcite/sql2rel/SqlToRelConverter.java
##########
@@ -4817,13 +4819,17 @@ void setRoot(List<RelNode> inputs) {
if (node == null) {
Review comment:
also, does `lookupExp` ever return null due to a user error? I don't think so. There's only one caller, and it throws if it receives null. So let's tighten this down, and make the function throw rather than ever returning null.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org