[GitHub] [daffodil] jadams-tresys commented on a change in pull request #694: Check for RepType when getting element length

[GitBox <gi...@apache.org>]

jadams-tresys commented on a change in pull request #694:
URL: https://github.com/apache/daffodil/pull/694#discussion_r761351999



##########
File path: daffodil-test/src/test/resources/org/apache/daffodil/extensions/type_calc/inputTypeCalc.tdml
##########
@@ -50,6 +50,8 @@
       </xs:complexType>
     </xs:element>
 
+    <xs:element name="keysetValue_03" type="tns:keysetValue_01" dfdl:lengthKind="implicit"/>

Review comment:
       Will do.  Not a workaround, merely setting it to implicit to trigger the bug that the code changes fixed.  The problem had been that it was thinking that the keysetValue_01 type was a string, which when lengthKind="implicit" causing it to complain about a missing maxLength property as you can't have an implicit length string without one.
   
   This was one of the things we were missing when we were trying to debug the P8 schema yesterday.  The tests that were working had a lengthKind="delimited", which was fine given that it thought it was processing a string.  Adding dfdl:lengthKind="implicit" seemed like the easiest way to trigger the bug we were seeing in the P8 schema.
   
   I'll work on adding some comments and a better name for the test now.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org