You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/02/26 23:53:43 UTC
[GitHub] [kafka] rondagostino opened a new pull request #10225: MINOR: fix security_test for ZK case due to error change
rondagostino opened a new pull request #10225:
URL: https://github.com/apache/kafka/pull/10225
The ZooKeeper version of this system test is failing because the producer is no longer seeing `LEADER_NOT_AVAILABLE`. When the broker sees a METADATA request for the test topic after it restarts the auto topic creation manager is determining that the topic needs to be created due to the TLS hostname verification failure on the inter-broker security protocol. It also thinks there aren't enough brokers available to meet the default topic replication factor (it sees 0 available due to the TLS issue), so it returns`INVALID_REPLICATION_FACTOR` for that topic in the Metadata response. In other words, the flow has changed and the inability to produce is not manifesting as it was before, and the test is failing. This patch updates the test to check for `INVALID_REPLICATION_FACTOR` instead of `LEADER_NOT_AVAILABLE`.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] rondagostino commented on pull request #10225: MINOR: fix security_test for ZK case due to error change
Posted by GitBox <gi...@apache.org>.
rondagostino commented on pull request #10225:
URL: https://github.com/apache/kafka/pull/10225#issuecomment-788226851
This PR "fixes" the issue by changing the system test to check for the new error. We can close this PR in favor of another one if @abbccdda decides the behavior change is incorrect and can be corrected.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] rondagostino commented on pull request #10225: MINOR: fix security_test for ZK case due to error change
Posted by GitBox <gi...@apache.org>.
rondagostino commented on pull request #10225:
URL: https://github.com/apache/kafka/pull/10225#issuecomment-786955706
@abbccdda, @cmccabe. Ported from #10199 to discuss separately. We used to see this error message in `verifiable_producer.log` when `security_protocol='PLAINTEXT', interbroker_security_protocol='SSL'`:
```
WARN [Producer clientId=producer-1] Error while fetching metadata with correlation id 1 : {test_topic=LEADER_NOT_AVAILABLE} (org.apache.kafka.clients.NetworkClient)
```
The test does a `grep LEADER_NOT_AVAILABLE` on the log in this case, and it used to pass.
Now we are instead seeing this in the log file:
```
WARN [Producer clientId=producer-1] Error while fetching metadata with correlation id 1 : {test_topic=INVALID_REPLICATION_FACTOR} (org.apache.kafka.clients.NetworkClient)
```
And of course now the test fails.
The `INVALID_REPLICATION_FACTOR` is coming from the auto topic creation manager as I described above.
It is a simple matter to make the test pass -- I have confirmed that it passes if we `grep` for `INVALID_REPLICATION_FACTOR` in the log file instead of `LEADER_NOT_AVAILABLE`.
I think we just need to decide if this change in behavior is acceptable or not.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] rondagostino commented on pull request #10225: MINOR: fix security_test for ZK case due to error change
Posted by GitBox <gi...@apache.org>.
rondagostino commented on pull request #10225:
URL: https://github.com/apache/kafka/pull/10225#issuecomment-788225857
https://issues.apache.org/jira/browse/KAFKA-12381
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] rondagostino commented on pull request #10225: MINOR: fix security_test for ZK case due to error change
Posted by GitBox <gi...@apache.org>.
rondagostino commented on pull request #10225:
URL: https://github.com/apache/kafka/pull/10225#issuecomment-793057316
Closed in favor of https://github.com/apache/kafka/pull/10240/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] rondagostino closed pull request #10225: MINOR: fix security_test for ZK case due to error change
Posted by GitBox <gi...@apache.org>.
rondagostino closed pull request #10225:
URL: https://github.com/apache/kafka/pull/10225
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] hachikuji commented on pull request #10225: MINOR: fix security_test for ZK case due to error change
Posted by GitBox <gi...@apache.org>.
hachikuji commented on pull request #10225:
URL: https://github.com/apache/kafka/pull/10225#issuecomment-786959937
@rondagostino Thanks for identifying the issue. Returning `INVALID_REPLICATION_FACTOR` seems like a mistake to me if we were previously returning `LEADER_NOT_AVAILABLE`. I'd suggest we fix the code. Would you mind filing a JIRA for this so that we can mark it as a 2.8 blocker?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org