You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@xtable.apache.org by "vinishjail97 (via GitHub)" <gi...@apache.org> on 2026/07/20 23:39:56 UTC
[PR] [infra] Require CI status checks to merge (main + branch-0.4) [incubator-xtable]
vinishjail97 opened a new pull request, #848:
URL: https://github.com/apache/incubator-xtable/pull/848
## What
Makes CI green a hard requirement to merge. `.asf.yaml` branch protection is read **only from the default branch (`main`)** and previously declared no `required_status_checks`, so passing builds were informational, not gating — and `branch-0.4` had no protection at all.
Required checks added:
- **`main`:** `Maven CI Build`, `License Check`
- **`branch-0.4`:** `Maven CI Build`, `License Check`, `validate-spark-runtime-bundle (3.4.3)`, `validate-spark-runtime-bundle (3.5.9)`
(The Spark checks are `branch-0.4`-only — there is no spark-runtime module on `main`.)
## Job rename
`Maven CI Build` and `License Check` both used a job named `build`, so both reported the **same** status context `build` and couldn't be required distinctly. Each now sets a unique job `name`, giving contexts `Maven CI Build` and `License Check`. A companion PR applies the same rename on `branch-0.4` so those contexts exist there too.
## Merge order
Merge **after #843 lands on `branch-0.4`** (it adds the `spark-runtime-validation` workflow and its matrix). INFRA applies `.asf.yaml` wholesale on merge here, so if these rules land first, new `branch-0.4` PRs would block on Spark contexts that aren't running yet. Also merge the `branch-0.4` job-rename PR before/with this so the `Maven CI Build` / `License Check` contexts are produced there.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@xtable.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [infra] Require CI status checks to merge (main + branch-0.4) [incubator-xtable]
Posted by "rangareddy (via GitHub)" <gi...@apache.org>.
rangareddy commented on code in PR #848:
URL: https://github.com/apache/incubator-xtable/pull/848#discussion_r3642810143
##########
.asf.yaml:
##########
@@ -35,6 +35,19 @@ github:
main:
required_pull_request_reviews:
required_approving_review_count: 1
+ required_status_checks:
+ contexts:
+ - "Maven CI Build"
+ - "License Check"
+ branch-0.4:
+ required_pull_request_reviews:
+ required_approving_review_count: 1
+ required_status_checks:
+ contexts:
+ - "Maven CI Build"
+ - "License Check"
+ - "validate-spark-runtime-bundle (3.4.3)"
+ - "validate-spark-runtime-bundle (3.5.9)"
Review Comment:
No — GitHub required status checks are exact-string matches (no wildcards/globs), and `.asf.yaml` passes `contexts` straight through to GitHub branch protection, so a matrix job forces us to enumerate each version.
The standard workaround is a single aggregate "gate" job that `needs:` the matrix and passes only if every leg succeeds, then require that one stable context. I've opened #862 against `branch-0.4` adding a `spark-runtime-validation-required` job to `spark-runtime-validation.yml` (uses `if: always()` so it still reports rather than being skipped when a leg fails).
Once #862 lands, drop the two versioned lines here and require just the one gate context, so the `branch-0.4` block reads:
```yaml
required_status_checks:
contexts:
- "Maven CI Build"
- "License Check"
- "spark-runtime-validation-required"
```
That way `.asf.yaml` never needs editing when the Spark matrix changes. Merge order: #862 to `branch-0.4` first, then apply this here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@xtable.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MINOR] Require CI status checks to merge (main + branch-0.4) [incubator-xtable]
Posted by "vinishjail97 (via GitHub)" <gi...@apache.org>.
vinishjail97 commented on code in PR #848:
URL: https://github.com/apache/incubator-xtable/pull/848#discussion_r4010170560
##########
.asf.yaml:
##########
@@ -35,6 +35,19 @@ github:
main:
required_pull_request_reviews:
required_approving_review_count: 1
+ required_status_checks:
+ contexts:
+ - "Maven CI Build"
+ - "License Check"
+ branch-0.4:
+ required_pull_request_reviews:
+ required_approving_review_count: 1
+ required_status_checks:
+ contexts:
+ - "Maven CI Build"
+ - "License Check"
+ - "validate-spark-runtime-bundle (3.4.3)"
+ - "validate-spark-runtime-bundle (3.5.9)"
Review Comment:
Not for status check contexts, unfortunately. GitHub matches them as exact strings, and the REST branch protection API takes a plain list of names with no glob support. Wildcards work only for branch name patterns, through GraphQL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@xtable.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [infra] Require CI status checks to merge (main + branch-0.4) [incubator-xtable]
Posted by "rangareddy (via GitHub)" <gi...@apache.org>.
rangareddy commented on code in PR #848:
URL: https://github.com/apache/incubator-xtable/pull/848#discussion_r3642810143
##########
.asf.yaml:
##########
@@ -35,6 +35,19 @@ github:
main:
required_pull_request_reviews:
required_approving_review_count: 1
+ required_status_checks:
+ contexts:
+ - "Maven CI Build"
+ - "License Check"
+ branch-0.4:
+ required_pull_request_reviews:
+ required_approving_review_count: 1
+ required_status_checks:
+ contexts:
+ - "Maven CI Build"
+ - "License Check"
+ - "validate-spark-runtime-bundle (3.4.3)"
+ - "validate-spark-runtime-bundle (3.5.9)"
Review Comment:
No — GitHub required status checks are exact-string matches (no wildcards/globs), and `.asf.yaml` passes `contexts` straight through to GitHub branch protection, so a matrix job forces us to enumerate each version.
The standard workaround is a single aggregate "gate" job that `needs:` the matrix and passes only if every leg succeeds, then require that one stable context. I've opened #862 against `branch-0.4` adding a `spark-runtime-validation-required` job to `spark-runtime-validation.yml` (uses `if: always()` so it still reports rather than being skipped when a leg fails).
Once #862 lands, this block can drop the two versioned entries and require just:
```suggestion
- "Maven CI Build"
- "License Check"
- "spark-runtime-validation-required"
```
Merge order: #862 to `branch-0.4` first, then apply this here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@xtable.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MINOR] Require CI status checks to merge (main + branch-0.4) [incubator-xtable]
Posted by "vinishjail97 (via GitHub)" <gi...@apache.org>.
vinishjail97 merged PR #848:
URL: https://github.com/apache/incubator-xtable/pull/848
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@xtable.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [infra] Require CI status checks to merge (main + branch-0.4) [incubator-xtable]
Posted by "the-other-tim-brown (via GitHub)" <gi...@apache.org>.
the-other-tim-brown commented on code in PR #848:
URL: https://github.com/apache/incubator-xtable/pull/848#discussion_r3640709309
##########
.asf.yaml:
##########
@@ -35,6 +35,19 @@ github:
main:
required_pull_request_reviews:
required_approving_review_count: 1
+ required_status_checks:
+ contexts:
+ - "Maven CI Build"
+ - "License Check"
+ branch-0.4:
+ required_pull_request_reviews:
+ required_approving_review_count: 1
+ required_status_checks:
+ contexts:
+ - "Maven CI Build"
+ - "License Check"
+ - "validate-spark-runtime-bundle (3.4.3)"
+ - "validate-spark-runtime-bundle (3.5.9)"
Review Comment:
Is there a way to use a wildcard so we don't need the versions listed here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@xtable.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [infra] Require CI status checks to merge (main + branch-0.4) [incubator-xtable]
Posted by "rangareddy (via GitHub)" <gi...@apache.org>.
rangareddy commented on code in PR #848:
URL: https://github.com/apache/incubator-xtable/pull/848#discussion_r3642810143
##########
.asf.yaml:
##########
@@ -35,6 +35,19 @@ github:
main:
required_pull_request_reviews:
required_approving_review_count: 1
+ required_status_checks:
+ contexts:
+ - "Maven CI Build"
+ - "License Check"
+ branch-0.4:
+ required_pull_request_reviews:
+ required_approving_review_count: 1
+ required_status_checks:
+ contexts:
+ - "Maven CI Build"
+ - "License Check"
+ - "validate-spark-runtime-bundle (3.4.3)"
+ - "validate-spark-runtime-bundle (3.5.9)"
Review Comment:
No — GitHub required status checks are exact-string matches (no wildcards/globs), and `.asf.yaml` passes `contexts` straight through to GitHub branch protection, so a matrix job forces us to enumerate each version.
The standard workaround is a single aggregate "gate" job that `needs:` the matrix and passes only if every leg succeeds, then require that one stable context. I've opened #862 against `branch-0.4` adding a `spark-runtime-validation-required` job to `spark-runtime-validation.yml` (uses `if: always()` so it still reports rather than being skipped when a leg fails).
Once #862 lands, drop the two versioned lines here and require just the one gate context, so the `branch-0.4` block reads:
```yaml
required_status_checks:
contexts:
- "Maven CI Build"
- "License Check"
- "spark-runtime-validation-required"
```
That way `.asf.yaml` never needs editing when the Spark matrix changes. Merge order: #862 to `branch-0.4` first, then apply this here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@xtable.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org