You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/12/02 16:30:44 UTC
[GitHub] [camel-quarkus] jamesnetherton opened a new pull request #2052: Google PubSub native support
jamesnetherton opened a new pull request #2052:
URL: https://github.com/apache/camel-quarkus/pull/2052
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga commented on a change in pull request #2052: Google PubSub native support
Posted by GitBox <gi...@apache.org>.
ppalaga commented on a change in pull request #2052:
URL: https://github.com/apache/camel-quarkus/pull/2052#discussion_r534824841
##########
File path: docs/modules/ROOT/pages/reference/extensions/google-pubsub.adoc
##########
@@ -32,3 +32,12 @@ Please refer to the above link for usage and configuration details.
----
Check the xref:user-guide/index.adoc[User guide] for more information about writing Camel Quarkus applications.
+
+== Camel Quarkus limitations
+
+By default, the Camel PubSub component uses JDK object serialization via `ObjectOutputStream` whenever the message body is anything other than `String` or `byte[]`.
+
+Since such serialization is not yet supported by GraalVM, this extension provides a custom Jackson based serializer to serialize complex message payloads as JSON.
Review comment:
The custom Jackson based serializer is used in both JVM and native modes (the text seems to suggest that).
BTW, we'll see by tomorrow, whether serialization will be supported in GraalVM 21 https://github.com/oracle/graal/pull/2730#issuecomment-737135245
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga commented on a change in pull request #2052: Google PubSub native support
Posted by GitBox <gi...@apache.org>.
ppalaga commented on a change in pull request #2052:
URL: https://github.com/apache/camel-quarkus/pull/2052#discussion_r534824841
##########
File path: docs/modules/ROOT/pages/reference/extensions/google-pubsub.adoc
##########
@@ -32,3 +32,12 @@ Please refer to the above link for usage and configuration details.
----
Check the xref:user-guide/index.adoc[User guide] for more information about writing Camel Quarkus applications.
+
+== Camel Quarkus limitations
+
+By default, the Camel PubSub component uses JDK object serialization via `ObjectOutputStream` whenever the message body is anything other than `String` or `byte[]`.
+
+Since such serialization is not yet supported by GraalVM, this extension provides a custom Jackson based serializer to serialize complex message payloads as JSON.
Review comment:
The custom Jackson based serializer is used in both JVM and native modes (the text seems to suggest that)?
BTW, we'll see by tomorrow, whether serialization will be supported in GraalVM 21 https://github.com/oracle/graal/pull/2730#issuecomment-737135245
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] jamesnetherton merged pull request #2052: Google PubSub native support
Posted by GitBox <gi...@apache.org>.
jamesnetherton merged pull request #2052:
URL: https://github.com/apache/camel-quarkus/pull/2052
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] jamesnetherton commented on a change in pull request #2052: Google PubSub native support
Posted by GitBox <gi...@apache.org>.
jamesnetherton commented on a change in pull request #2052:
URL: https://github.com/apache/camel-quarkus/pull/2052#discussion_r534830143
##########
File path: docs/modules/ROOT/pages/reference/extensions/google-pubsub.adoc
##########
@@ -32,3 +32,12 @@ Please refer to the above link for usage and configuration details.
----
Check the xref:user-guide/index.adoc[User guide] for more information about writing Camel Quarkus applications.
+
+== Camel Quarkus limitations
+
+By default, the Camel PubSub component uses JDK object serialization via `ObjectOutputStream` whenever the message body is anything other than `String` or `byte[]`.
+
+Since such serialization is not yet supported by GraalVM, this extension provides a custom Jackson based serializer to serialize complex message payloads as JSON.
Review comment:
> The custom Jackson based serializer is used in both JVM and native modes
Yes, it's better IMO to be consistent and have the same behaviour in both modes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga commented on a change in pull request #2052: Google PubSub native support
Posted by GitBox <gi...@apache.org>.
ppalaga commented on a change in pull request #2052:
URL: https://github.com/apache/camel-quarkus/pull/2052#discussion_r534833201
##########
File path: docs/modules/ROOT/pages/reference/extensions/google-pubsub.adoc
##########
@@ -32,3 +32,12 @@ Please refer to the above link for usage and configuration details.
----
Check the xref:user-guide/index.adoc[User guide] for more information about writing Camel Quarkus applications.
+
+== Camel Quarkus limitations
+
+By default, the Camel PubSub component uses JDK object serialization via `ObjectOutputStream` whenever the message body is anything other than `String` or `byte[]`.
+
+Since such serialization is not yet supported by GraalVM, this extension provides a custom Jackson based serializer to serialize complex message payloads as JSON.
+
+If your payload contains binary data, then you will need to handle that by creating a custom Jackson Serializer / Deserializer.
Review comment:
I guess the readers could find this link to Quarkus Jackson guide helpful https://quarkus.io/guides/writing-extensions#customizing-jackson where they explain how to write serializers.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org