You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by JPercivall <gi...@git.apache.org> on 2016/11/29 23:40:49 UTC

[GitHub] nifi pull request #1282: NIFI-3112 Revert "NIFI-2199 - allows nifi.sh restar...

GitHub user JPercivall opened a pull request:

    https://github.com/apache/nifi/pull/1282

    NIFI-3112 Revert "NIFI-2199 - allows nifi.sh restart through ssh"

    This reverts commit 88d125137e3bf3faf80b522edf5cf14f99419d60.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/JPercivall/nifi NIFI-3112

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/1282.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1282
    
----
commit 05cadd2b82cb5519a80120c2d5e9b945a7b1f29b
Author: jpercivall <jp...@apache.org>
Date:   2016-11-29T23:42:17Z

    NIFI-3112 Revert "NIFI-2199 - allows nifi.sh restart through ssh"
    
    This reverts commit 88d125137e3bf3faf80b522edf5cf14f99419d60.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #1282: NIFI-3112 Revert "NIFI-2199 - allows nifi.sh restart throu...

Posted by JPercivall <gi...@git.apache.org>.
Github user JPercivall commented on the issue:

    https://github.com/apache/nifi/pull/1282
  
    @trixpan I have not tried as a service since the original ticket didn't mention it. That said without redirection the nifi.sh call would hang because the bootstrap is still running. If you redirect stdout and stderr in the ssh call (like in the command I put on the ticket) it works as expected. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request #1282: NIFI-3112 Revert "NIFI-2199 - allows nifi.sh restar...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/nifi/pull/1282


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #1282: NIFI-3112 Revert "NIFI-2199 - allows nifi.sh restart throu...

Posted by alopresto <gi...@git.apache.org>.
Github user alopresto commented on the issue:

    https://github.com/apache/nifi/pull/1282
  
    Reviewing...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #1282: NIFI-3112 Revert "NIFI-2199 - allows nifi.sh restart throu...

Posted by trixpan <gi...@git.apache.org>.
Github user trixpan commented on the issue:

    https://github.com/apache/nifi/pull/1282
  
    Joe, Andy,  I am away from my dev station but assuming both "ssh host.name service nifi restart",  "ssh host.name /path/to/nifi/bin/nifi.sh restart" continue working I would imagine nobody will miss the redirection. If those stop working we will have to try to find a solution as both approaches tend to be used by puppet, ansible, etc
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #1282: NIFI-3112 Revert "NIFI-2199 - allows nifi.sh restart throu...

Posted by alopresto <gi...@git.apache.org>.
Github user alopresto commented on the issue:

    https://github.com/apache/nifi/pull/1282
  
    Ok, ran `contrib-check`, all tests, etc. even though this change didn't affect them. Built the application and intentionally introduced an invalid property value to `nifi.properties` to reproduce. On bootstrap startup via `./bin/nifi.sh start`, the errors were correctly propagated to `logs/nifi-app.log`. I resolved the invalid property and restarted successfully. 
    
    +1, merged. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---