You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/04/07 06:12:05 UTC
[GitHub] [incubator-nuttx] anchao opened a new pull request, #6001: arm/armv[7|8]-m: skip the fpu save/restore if stack frame is integer-only
anchao opened a new pull request, #6001:
URL: https://github.com/apache/incubator-nuttx/pull/6001
## Summary
arm/armv[7|8]-m: skip the fpu save/restore if stack frame is integer-only
https://developer.arm.com/documentation/100701/0100/The-ARMv8-M-exception-model/EXC-RETURN-register
## Impact
armv7/8-m
## Testing
armv7-m/armv8-m board
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] masayuki2009 merged pull request #6001: arm/armv[7|8]-m: skip the fpu save/restore if stack frame is integer-only
Posted by GitBox <gi...@apache.org>.
masayuki2009 merged PR #6001:
URL: https://github.com/apache/incubator-nuttx/pull/6001
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] masayuki2009 commented on pull request #6001: arm/armv[7|8]-m: skip the fpu save/restore if stack frame is integer-only
Posted by GitBox <gi...@apache.org>.
masayuki2009 commented on PR #6001:
URL: https://github.com/apache/incubator-nuttx/pull/6001#issuecomment-1092455442
>@anchao
>Yes, it works without this PR. I'm now testing with your branch directly. So let me test with the upstream + this PR later.
@anchao
Hmm, I can not reproduce the issue now.
If I find the issue again, I will let you know.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] anchao commented on a diff in pull request #6001: arm/armv[7|8]-m: skip the fpu save/restore if stack frame is integer-only
Posted by GitBox <gi...@apache.org>.
anchao commented on code in PR #6001:
URL: https://github.com/apache/incubator-nuttx/pull/6001#discussion_r845041042
##########
arch/arm/src/armv7-m/gnu/arm_exception.S:
##########
@@ -176,6 +180,10 @@ exception_common:
vstmdb sp!, {s16-s31} /* Save the non-volatile FP context */
+ b end_fp_save
+skip_fp_save:
Review Comment:
I have replace the label tag to string, please review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] masayuki2009 commented on pull request #6001: arm/armv[7|8]-m: skip the fpu save/restore if stack frame is integer-only
Posted by GitBox <gi...@apache.org>.
masayuki2009 commented on PR #6001:
URL: https://github.com/apache/incubator-nuttx/pull/6001#issuecomment-1092428822
>@masayuki2009 could you please help to confirm further that if without this patch, the music can be played successfully?
@anchao
Yes, it works without this PR. I'm now testing with your branch directly. So let me test with the upstream + this PR later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] anchao commented on pull request #6001: arm/armv[7|8]-m: skip the fpu save/restore if stack frame is integer-only
Posted by GitBox <gi...@apache.org>.
anchao commented on PR #6001:
URL: https://github.com/apache/incubator-nuttx/pull/6001#issuecomment-1092394675
> It seems that spresense:wifi_smp + nxplayer has a problem.
@masayuki2009 could you please help to confirm further that if without this patch, the music can be played successfully?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] masayuki2009 commented on pull request #6001: arm/armv[7|8]-m: skip the fpu save/restore if stack frame is integer-only
Posted by GitBox <gi...@apache.org>.
masayuki2009 commented on PR #6001:
URL: https://github.com/apache/incubator-nuttx/pull/6001#issuecomment-1092391871
I've just tested this PR with spresense:wifi and spresense:wifi_smp.
It seems that spresense:wifi_smp + nxplayer has a problem.
```
nxplayer> play http://192.168.10.11/~ishikawa/audio/test.wav
nxplayer> packet_write_wait: Connection to UNKNOWN port 65535: Broken pipe
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6001: arm/armv[7|8]-m: skip the fpu save/restore if stack frame is integer-only
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #6001:
URL: https://github.com/apache/incubator-nuttx/pull/6001#discussion_r844874217
##########
arch/arm/src/armv7-m/gnu/arm_exception.S:
##########
@@ -176,6 +180,10 @@ exception_common:
vstmdb sp!, {s16-s31} /* Save the non-volatile FP context */
+ b end_fp_save
+skip_fp_save:
Review Comment:
let's keep use the local label(e.g. 2:, 3) like the original code.
##########
arch/arm/src/armv7-m/gnu/arm_exception.S:
##########
@@ -225,7 +233,15 @@ exception_common:
ldmia r0!, {r2-r11,r14} /* Recover R4-R11, r14 + 2 temp values */
#ifdef CONFIG_ARCH_FPU
- vldmia r0!, {s16-s31} /* Recover S16-S31 */
+ /* Switched-in task including volatile FP registers ? */
+
+ tst r14, #EXC_RETURN_STD_CONTEXT
+ bne skip_fp_restore
+
+ vldmia r0, {s16-s31} /* Recover S16-S31 */
+
+skip_fp_restore:
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] anchao commented on pull request #6001: arm/armv[7|8]-m: skip the fpu save/restore if stack frame is integer-only
Posted by GitBox <gi...@apache.org>.
anchao commented on PR #6001:
URL: https://github.com/apache/incubator-nuttx/pull/6001#issuecomment-1092467404
> @anchao Hmm, I can not reproduce the issue now. If I find the issue again, I will let you know.
Thanks a lot for your time, I think there may be other issue in the network stack, we have doing some network testing locally and will update later if we find anything.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org