You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by "cshannon (via GitHub)" <gi...@apache.org> on 2023/04/12 10:48:35 UTC
[GitHub] [activemq] cshannon opened a new pull request, #998: AMQ-9243 - Remove deprecated jetty-continuation dependency
cshannon opened a new pull request, #998:
URL: https://github.com/apache/activemq/pull/998
This commit removes the dependency on jetty-continuation and updates the MessageServlet and AjaxListener servlets to use the Servlet Async api directly for async requests through a new Async holder object that is used to track/manage the request.
As I mentioned in the Jira, this is also fine to backport to 5.18.x as there's no public facing API changes, it's just an internal detail. Jetty was already using the Async api and we are doing the same, just more directly now.
The tests in the activemq-web-demo can be run to test out and demonstrate the new changes. Running the [AjaxTest](https://github.com/cshannon/activemq/blob/6a979685c6a7d5cb6a091cb85e42bd03093adfa4/activemq-web-demo/src/test/java/org/apache/activemq/web/AjaxTest.java) in that project shows the AjaxListener still works with async requests and I also added a couple more tests to [RestTest](https://github.com/cshannon/activemq/blob/6a979685c6a7d5cb6a091cb85e42bd03093adfa4/activemq-web-demo/src/test/java/org/apache/activemq/web/RestTest.java) in this PR to demonstrate that the Async request/resume is working with the changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq] cshannon merged pull request #998: AMQ-9243 - Remove deprecated jetty-continuation dependency
Posted by "cshannon (via GitHub)" <gi...@apache.org>.
cshannon merged PR #998:
URL: https://github.com/apache/activemq/pull/998
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org