You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2020/04/17 20:29:23 UTC

[GitHub] [trafficcontrol] alficles commented on a change in pull request #4644: Remove cacheurl from Delivery Services

alficles commented on a change in pull request #4644: Remove cacheurl from Delivery Services
URL: https://github.com/apache/trafficcontrol/pull/4644#discussion_r410454399
 
 

 ##########
 File path: lib/go-tc/deliveryservices.go
 ##########
 @@ -198,7 +198,6 @@ type DeliveryServiceNullableV11 struct {
 	//
 	Active                   *bool                   `json:"active" db:"active"`
 	AnonymousBlockingEnabled *bool                   `json:"anonymousBlockingEnabled" db:"anonymous_blocking_enabled"`
-	CacheURL                 *string                 `json:"cacheurl" db:"cacheurl"`
 
 Review comment:
   This breaks backward compatibility at a code level. Shouldn't this stay present but empty here and only be removed in later versions of the type? As it is, code that uses the V11 struct will break.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services