You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/12/02 00:32:48 UTC

[GitHub] [spark] HyukjinKwon opened a new pull request #26729: [SPARK-29851][SQL][FOLLOW-UP] Use foreach instead of misusing map

HyukjinKwon opened a new pull request #26729: [SPARK-29851][SQL][FOLLOW-UP] Use foreach instead of misusing map
URL: https://github.com/apache/spark/pull/26729
 
 
   ### What changes were proposed in this pull request?
   
   This PR proposes to use foreach instead of misusing map. This could cause some weird errors potentially and it's not a good practice anyway. See also SPARK-16694
   
   ### Why are the changes needed?
   To avoid potential issues like SPARK-16694
   
   ### Does this PR introduce any user-facing change?
   No
   
   
   ### How was this patch tested?
   Existing tests should cover.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org