You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@subversion.apache.org by st...@apache.org on 2015/10/11 18:51:43 UTC

svn commit: r1707999 - /subversion/trunk/subversion/libsvn_repos/rev_hunt.c

Author: stefan2
Date: Sun Oct 11 16:51:43 2015
New Revision: 1707999

URL: http://svn.apache.org/viewvc?rev=1707999&view=rev
Log:
Speed up revprop access in svn_repos_get_file_revs2() by using the latest
FS API.

* subversion/libsvn_repos/rev_hunt.c
  (send_path_revision): Read revprops from the FS cache if we can. 
  (svn_repos_get_file_revs2): Refresh the revprops only once, at the start
                              of the operation.  This is the only public
                              function that calls the above.
                              Therefore, we still fulfill the visibility
                              guarantees for revprop changes.

Modified:
    subversion/trunk/subversion/libsvn_repos/rev_hunt.c

Modified: subversion/trunk/subversion/libsvn_repos/rev_hunt.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_repos/rev_hunt.c?rev=1707999&r1=1707998&r2=1707999&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_repos/rev_hunt.c (original)
+++ subversion/trunk/subversion/libsvn_repos/rev_hunt.c Sun Oct 11 16:51:43 2015
@@ -1359,8 +1359,9 @@ send_path_revision(struct path_revision
   svn_pool_clear(sb->iterpool);
 
   /* Get the revision properties. */
-  SVN_ERR(svn_fs_revision_proplist(&rev_props, repos->fs,
-                                   path_rev->revnum, sb->iterpool));
+  SVN_ERR(svn_fs_revision_proplist2(&rev_props, repos->fs,
+                                    path_rev->revnum, FALSE,
+                                    sb->iterpool, sb->iterpool));
 
   /* Open the revision root. */
   SVN_ERR(svn_fs_revision_root(&root, repos->fs, path_rev->revnum,
@@ -1595,6 +1596,10 @@ svn_repos_get_file_revs2(svn_repos_t *re
         end = youngest_rev;
     }
 
+  /* Make sure we catch up on the latest revprop changes.  This is the only
+   * time we will refresh the revprop data in this query. */
+  SVN_ERR(svn_fs_refresh_revision_props(repos->fs, scratch_pool));
+
   if (end < start)
     {
       if (include_merged_revisions)