You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2022/06/14 09:14:37 UTC

[GitHub] [cordova-android] erisu opened a new pull request, #1441: feat: android 12 splash screen

erisu opened a new pull request, #1441:
URL: https://github.com/apache/cordova-android/pull/1441

### Motivation and Context

Support only Android 12 Splash Screen

### Description

**Old Splash Screen**

* Drop old copy resources for previous previous splash screen plugin.
* Remove old resource files

**New Splash Screen**

* Created new template resources
* Added compat library to support older devices
* Added new `preference`
* `AndroidPostSplashScreenTheme`
* Considered as advance feature and use at own risk. Unsupported feature.
* `AndroidWindowSplashScreenAnimationDuration`
* Manages the duration of the animation, not the delay of the splash screen.
* `AndroidWindowSplashScreenAnimatedIcon`
* This contains the icon that is display on the splash screen.
* Icon image can be either `xml` Android Drawable, or `png`.
* Follow the design specs from Android: https://developer.android.com/guide/topics/ui/splash-screen#splash_screen_dimensions
* `AndroidWindowSplashScreenBackground`
* Background color of the splash screen. Default is white (`#FFFFFF`)
* `AndroidWindowSplashScreenBrandingImage`
* Adds an image to the bottom of the splash screen.
* `AndroidWindowSplashScreenIconBackgroundColor`

### Testing

- `npm t`
- `cordova build android`
- `cordova run android`

| API 31 | API 23 |
| -- | -- |
| ![Screenshot_20220614_175352](https://user-images.githubusercontent.com/1029107/173540350-a9aeb72b-a58a-460a-aa4c-9482883b0f1e.png) | ![Screenshot_1655196639](https://user-images.githubusercontent.com/1029107/173540290-ec869b2c-ae03-4bd1-a5f5-6ccfa83a2441.png) |

Note:
* Some simulators do not display the splash screen when launch from Android Studio. This appears to be a bug from AS. Launching the app from within the simulator will show the splash screen.
* The default splash screen is an XML Android Drawable. It has a resolution of 512x512. It is padded and the inner icon size is 384x384. It is also scalled by 50% and pivotX/Y of 256.

### Checklist

- [x] I've run the tests to see all new and existing tests pass
- [ ] I added automated test coverage as appropriate for this change
- [ ] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)
- [ ] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
- [ ] I've updated the documentation if necessary

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org