You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "garyparrot (via GitHub)" <gi...@apache.org> on 2023/03/16 02:53:23 UTC
[GitHub] [kafka] garyparrot opened a new pull request, #13398: MINOR: Fix typos in valid range of socket buffer size
garyparrot opened a new pull request, #13398:
URL: https://github.com/apache/kafka/pull/13398
Fix the following typos in Kafka connect configs: [send.buffer.bytes](https://kafka.apache.org/documentation/#connectconfigs_send.buffer.bytes) and [receive.buffer.bytes](https://kafka.apache.org/documentation/#connectconfigs_receive.buffer.bytes)
Currently, the valid values start from `0`, although the documentation states `-1` is also a valid value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] chia7712 commented on pull request #13398: KAFKA-6891: send.buffer.bytes should be allowed to set -1 in KafkaConnect
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on PR #13398:
URL: https://github.com/apache/kafka/pull/13398#issuecomment-1475559543
@garyparrot could you merge trunk to trigger QA again?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] garyparrot commented on pull request #13398: KAFKA-6891: send.buffer.bytes should be allowed to set -1 in KafkaConnect
Posted by "garyparrot (via GitHub)" <gi...@apache.org>.
garyparrot commented on PR #13398:
URL: https://github.com/apache/kafka/pull/13398#issuecomment-1474093045
Sure thing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] chia7712 commented on pull request #13398: KAFKA-6891: send.buffer.bytes should be allowed to set -1 in KafkaConnect
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on PR #13398:
URL: https://github.com/apache/kafka/pull/13398#issuecomment-1474011607
linked to stale PR (#4995)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] chia7712 commented on pull request #13398: MINOR: Fix typos in valid range of socket buffer size
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on PR #13398:
URL: https://github.com/apache/kafka/pull/13398#issuecomment-1471424149
@garyparrot nice catch. It is not only typo but also incorrect validation. the `atLeast(0)` disables users to input `-1` for socket buffer. Hence, this PR is fixing a `bug` rather than a `typo`. If this is related to a bug, could you file a JIRA with new topic and description. That can help reader in the future to trace similar issue. thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] chia7712 commented on pull request #13398: KAFKA-6891: send.buffer.bytes should be allowed to set -1 in KafkaConnect
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on PR #13398:
URL: https://github.com/apache/kafka/pull/13398#issuecomment-1477456249
@garyparrot thanks for this contribution
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] garyparrot commented on pull request #13398: KAFKA-6891: send.buffer.bytes should be allowed to set -1 in KafkaConnect
Posted by "garyparrot (via GitHub)" <gi...@apache.org>.
garyparrot commented on PR #13398:
URL: https://github.com/apache/kafka/pull/13398#issuecomment-1473504714
@chia7712 Thanks for your opinion. Indeed this issue should be treated as a bug (The contribution guide has addressed this, sorry I am not familiar with the rules here).
I find this issue has already been mentioned at [KAFKA-6891](https://issues.apache.org/jira/browse/KAFKA-6891). I have self-assigned that issue and updated the description.
Please take another look, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] chia7712 commented on pull request #13398: KAFKA-6891: send.buffer.bytes should be allowed to set -1 in KafkaConnect
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on PR #13398:
URL: https://github.com/apache/kafka/pull/13398#issuecomment-1477443749
```
[2023-03-20T05:31:14.475Z] BUILD SUCCESSFUL in 1h 44m 21s
[2023-03-20T05:31:14.475Z] 224 actionable tasks: 120 executed, 104 up-to-date
```
the tests pass. will merge it later
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] chia7712 merged pull request #13398: KAFKA-6891: send.buffer.bytes should be allowed to set -1 in KafkaConnect
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 merged PR #13398:
URL: https://github.com/apache/kafka/pull/13398
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] chia7712 commented on pull request #13398: KAFKA-6891: send.buffer.bytes should be allowed to set -1 in KafkaConnect
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on PR #13398:
URL: https://github.com/apache/kafka/pull/13398#issuecomment-1473999823
@garyparrot could you rebase PR to trigger QA again?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org