You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@parquet.apache.org by Junjie Chen <ch...@gmail.com> on 2020/02/11 13:11:23 UTC

Re: [DISCUSS] merge bloom filter branch to master

Thanks for the patch @Walid.

@Gabor,  do I need to create a PR for merging, or committer will help to
merge?


On Sun, Jan 12, 2020 at 7:39 PM Gara Walid <gw...@gmail.com> wrote:

> Hi Junjie,
>
> Thank you Junjie and the community for all your efforts on the bloom filter
> topic.
> I've been testing the bloom filter branch with Map Reduce examples and it
> sounds good.
> I'll add an example to the parquet-hadoop package.
>
> Cheers,
> Walid
>
> Le ven. 10 janv. 2020 à 09:22, Junjie Chen <ch...@gmail.com> a
> écrit :
>
> > Hi Community
> >
> > The bloom filter branch now contains a basic functional logic that
> includes
> > read/write and filtering.  Though the feature still needs polishing and
> > improving, I 'd suggest merging back to master first so that more people
> > could use it and provide feedback. What do you think?
> >
>


-- 
Best Regards

Re: [DISCUSS] merge bloom filter branch to master

Posted by Gabor Szadovszky <ga...@apache.org>.
I think, the best way is to create a PR. It would be more transparent.

On Tue, Feb 11, 2020 at 2:11 PM Junjie Chen <ch...@gmail.com>
wrote:

> Thanks for the patch @Walid.
>
> @Gabor,  do I need to create a PR for merging, or committer will help to
> merge?
>
>
> On Sun, Jan 12, 2020 at 7:39 PM Gara Walid <gw...@gmail.com> wrote:
>
> > Hi Junjie,
> >
> > Thank you Junjie and the community for all your efforts on the bloom
> filter
> > topic.
> > I've been testing the bloom filter branch with Map Reduce examples and it
> > sounds good.
> > I'll add an example to the parquet-hadoop package.
> >
> > Cheers,
> > Walid
> >
> > Le ven. 10 janv. 2020 à 09:22, Junjie Chen <ch...@gmail.com> a
> > écrit :
> >
> > > Hi Community
> > >
> > > The bloom filter branch now contains a basic functional logic that
> > includes
> > > read/write and filtering.  Though the feature still needs polishing and
> > > improving, I 'd suggest merging back to master first so that more
> people
> > > could use it and provide feedback. What do you think?
> > >
> >
>
>
> --
> Best Regards
>