You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "terrymanu (via GitHub)" <gi...@apache.org> on 2026/09/10 15:28:49 UTC
[PR] Refactor Maven dependency and plugin version declarations [shardingsphere]
terrymanu opened a new pull request, #39792:
URL: https://github.com/apache/shardingsphere/pull/39792
### Result
**Review Result: Mergeable**
The candidate is minimal in scope. Effective dependency versions remain unchanged, reporting and distribution plugin versions are centralized, and focused verification passed.
### Evidence
- Effective POM generation succeeded for all seven projects, with no unexpected model changes.
- The effective versions and scopes of the five dependencies remain unchanged.
- All six reporting plugins now have explicit versions. PMD reporting targets Java 8, preventing PMD 3.20 from incorrectly using Java 21.
- MCP packaging succeeded with 109 runtime dependencies and the expected script permissions. Dependency Plugin 3.6.0 and 3.8.1 produced identical dependency sets.
- The Proxy Exec Maven Plugin 3.1.0 smoke test passed.
- Spotless, RAT, XML parsing, and `git diff --check` passed.
- The complete Site build eventually fails while Maven Project Info reads module POMs. An equivalent unmodified HEAD mirror fails at the same point with the same error, so this is not caused by the candidate.
### Coverage
- Candidate type: standalone local candidate.
- Task baseline: `ee9b9e32eab49b83b14ad4653ad439fd968cb186`.
- Change size: 7 files, 12 insertions, 10 deletions.
- `pom.xml` → removed the unused Vert.x property and redundant JUnit version, pinned reporting plugin versions, and constrained the PMD target → removes unused configuration and makes reporting reproducible → required.
- `examples/shardingsphere-jdbc-example-generator/pom.xml` → removed the redundant JUnit Engine version → uses the BOM-managed version → required.
- `test/e2e/agent/fixture/jdbc-fixture/pom.xml` → removed the redundant H2 version → uses dependency management → required.
- `test/infra/framework/pom.xml` → removed the redundant Logback version → uses dependency management → required.
- `test/it/binder/pom.xml` → removed the redundant Mockito version → uses dependency management → required.
- `distribution/proxy/pom.xml` → changed Exec Maven Plugin to use the centralized property → resolves the 3.0.0/3.1.0 divergence → required.
- `distribution/mcp/pom.xml` → changed the Dependency and Antrun plugins to use centralized properties → removes local version overrides → required.
- Checkstyle: not applicable to POM-only changes.
- Spotless: passed for the root POM and five governed module POMs. The independent examples project does not configure Spotless.
- Performance: no supported runtime path changed, so no benchmark was required.
- This was a code-correctness review. Remote CI was not reviewed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Refactor Maven dependency and plugin version declarations [shardingsphere]
Posted by "terrymanu (via GitHub)" <gi...@apache.org>.
terrymanu merged PR #39792:
URL: https://github.com/apache/shardingsphere/pull/39792
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Refactor Maven dependency and plugin version declarations [shardingsphere]
Posted by "terrymanu (via GitHub)" <gi...@apache.org>.
terrymanu commented on PR #39792:
URL: https://github.com/apache/shardingsphere/pull/39792#issuecomment-5621183568
### Result
**Review Result: Mergeable**
The candidate is minimal in scope. Effective dependency versions remain unchanged, reporting and distribution plugin versions are centralized, and focused verification passed.
### Evidence
- Effective POM generation succeeded for all seven projects, with no unexpected model changes.
- The effective versions and scopes of the five dependencies remain unchanged.
- All six reporting plugins now have explicit versions. PMD reporting targets Java 8, preventing PMD 3.20 from incorrectly using Java 21.
- MCP packaging succeeded with 109 runtime dependencies and the expected script permissions. Dependency Plugin 3.6.0 and 3.8.1 produced identical dependency sets.
- The Proxy Exec Maven Plugin 3.1.0 smoke test passed.
- Spotless, RAT, XML parsing, and `git diff --check` passed.
- The complete Site build eventually fails while Maven Project Info reads module POMs. An equivalent unmodified HEAD mirror fails at the same point with the same error, so this is not caused by the candidate.
### Coverage
- Candidate type: standalone local candidate.
- Task baseline: `ee9b9e32eab49b83b14ad4653ad439fd968cb186`.
- Change size: 7 files, 12 insertions, 10 deletions.
- `pom.xml` → removed the unused Vert.x property and redundant JUnit version, pinned reporting plugin versions, and constrained the PMD target → removes unused configuration and makes reporting reproducible → required.
- `examples/shardingsphere-jdbc-example-generator/pom.xml` → removed the redundant JUnit Engine version → uses the BOM-managed version → required.
- `test/e2e/agent/fixture/jdbc-fixture/pom.xml` → removed the redundant H2 version → uses dependency management → required.
- `test/infra/framework/pom.xml` → removed the redundant Logback version → uses dependency management → required.
- `test/it/binder/pom.xml` → removed the redundant Mockito version → uses dependency management → required.
- `distribution/proxy/pom.xml` → changed Exec Maven Plugin to use the centralized property → resolves the 3.0.0/3.1.0 divergence → required.
- `distribution/mcp/pom.xml` → changed the Dependency and Antrun plugins to use centralized properties → removes local version overrides → required.
- Checkstyle: not applicable to POM-only changes.
- Spotless: passed for the root POM and five governed module POMs. The independent examples project does not configure Spotless.
- Performance: no supported runtime path changed, so no benchmark was required.
- This was a code-correctness review. Remote CI was not reviewed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org