You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jiang Yan Xu <ya...@jxu.me> on 2017/12/12 00:30:20 UTC
Review Request 64514: Refactor out `authorizeReserveResources` that
takes a `Resources`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64514/
-----------------------------------------------------------
Review request for mesos, Alexander Rojas and James Peach.
Bugs: MESOS-8306
https://issues.apache.org/jira/browse/MESOS-8306
Repository: mesos
Description
-------
This allows us to authorize static resource reservations that don't
come from `Offer::Operation::Reserve`.
Diffs
-----
src/master/master.hpp 232cc3758f240db626c4fdaf852163fa48af4dd7
src/master/master.cpp b10d0341276090bfa70aaa4fd6317a560e3334ea
Diff: https://reviews.apache.org/r/64514/diff/1/
Testing
-------
make check.
Thanks,
Jiang Yan Xu
Re: Review Request 64514: Refactor out `authorizeReserveResources`
that takes a `Resources`.
Posted by Alexander Rojas <al...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64514/#review193664
-----------------------------------------------------------
Ship it!
src/master/master.hpp
Lines 784-785 (patched)
<https://reviews.apache.org/r/64514/#comment272250>
I'm face with a conundrum, should this follow the patter of the other authorization methods and use Doxygen, or should it follow the pattern of the rest of the file?
I'll let it up to you.
- Alexander Rojas
On Dec. 12, 2017, 1:30 a.m., Jiang Yan Xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64514/
> -----------------------------------------------------------
>
> (Updated Dec. 12, 2017, 1:30 a.m.)
>
>
> Review request for mesos, Alexander Rojas and James Peach.
>
>
> Bugs: MESOS-8306
> https://issues.apache.org/jira/browse/MESOS-8306
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This allows us to authorize static resource reservations that don't
> come from `Offer::Operation::Reserve`.
>
>
> Diffs
> -----
>
> src/master/master.hpp 232cc3758f240db626c4fdaf852163fa48af4dd7
> src/master/master.cpp b10d0341276090bfa70aaa4fd6317a560e3334ea
>
>
> Diff: https://reviews.apache.org/r/64514/diff/1/
>
>
> Testing
> -------
>
> make check.
>
>
> Thanks,
>
> Jiang Yan Xu
>
>
Re: Review Request 64514: Refactor out `authorizeReserveResources`
that takes a `Resources`.
Posted by James Peach <jp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64514/#review195040
-----------------------------------------------------------
Ship it!
Ship It!
- James Peach
On Dec. 13, 2017, 10:53 a.m., Jiang Yan Xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64514/
> -----------------------------------------------------------
>
> (Updated Dec. 13, 2017, 10:53 a.m.)
>
>
> Review request for mesos, Alexander Rojas and James Peach.
>
>
> Bugs: MESOS-8306
> https://issues.apache.org/jira/browse/MESOS-8306
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This allows authorization of static resource reservations.
>
> These reservations do not arrived to the master through an
> `Offer::Operation::Reserve` API call but during agent
> registration.
>
>
> Diffs
> -----
>
> src/master/master.hpp 8fe9420dbe03ea2cefc6a40b0f64284aa9fe7915
> src/master/master.cpp 282fdf8ac38e3613c621c1c8e5c50f27bde9dafd
>
>
> Diff: https://reviews.apache.org/r/64514/diff/3/
>
>
> Testing
> -------
>
> make check.
>
>
> Thanks,
>
> Jiang Yan Xu
>
>
Re: Review Request 64514: Refactor out `authorizeReserveResources`
that takes a `Resources`.
Posted by Jiang Yan Xu <ya...@jxu.me>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64514/
-----------------------------------------------------------
(Updated Dec. 13, 2017, 11:53 a.m.)
Review request for mesos, Alexander Rojas and James Peach.
Bugs: MESOS-8306
https://issues.apache.org/jira/browse/MESOS-8306
Repository: mesos
Description (updated)
-------
This allows authorization of static resource reservations.
These reservations do not arrived to the master through an
`Offer::Operation::Reserve` API call but during agent
registration.
Diffs
-----
src/master/master.hpp 232cc3758f240db626c4fdaf852163fa48af4dd7
src/master/master.cpp b10d0341276090bfa70aaa4fd6317a560e3334ea
Diff: https://reviews.apache.org/r/64514/diff/1/
Testing
-------
make check.
Thanks,
Jiang Yan Xu