You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@whimsical.apache.org by Craig Russell <ap...@gmail.com> on 2020/06/29 22:31:26 UTC

A little help please with roster-emeritus

I'm testing the "move to emeritus" function with the changes that will move emeritus-requests-received/member.txt to emeritus.

All the code is in branch roster-emeritus. I'm getting this error from memstat.json.rb when processing the move to  emeritus. I don't know if it's really a credentials issue or not. The transcript messages are not very helpful...

Any help?

Thanks,
Craig

{
  "transcript": [
    "$ svn checkout --non-interactive --depth empty -- https://svn.apache.org/repos/private/foundation /var/folders/mx/t44d3_bs437dpnywzk_mwl_0002msd/T/d20200629-3669-14icn6l",
    " U   /var/folders/mx/t44d3_bs437dpnywzk_mwl_0002msd/T/d20200629-3669-14icn6l",
    "Checked out revision 97873.",
    "",
    "$ svn update --non-interactive -- /var/folders/mx/t44d3_bs437dpnywzk_mwl_0002msd/T/d20200629-3669-14icn6l/members.txt",
    "Updating '/var/folders/mx/t44d3_bs437dpnywzk_mwl_0002msd/T/d20200629-3669-14icn6l/members.txt':",
    "A    /var/folders/mx/t44d3_bs437dpnywzk_mwl_0002msd/T/d20200629-3669-14icn6l/members.txt",
    "Updated to revision 97873.",
    "",
    "$ svnmucc --non-interactive --extra-args /var/folders/mx/t44d3_bs437dpnywzk_mwl_0002msd/T/d20200629-3669-14icn6l/svnmucc_input20200629-3669-1pq2n8h --message Action\\ emeritus\\ for\\ sanjiva --no-auth-cache --revision 97873",
    "svnmucc: missing argument: --password",
    "Type 'svnmucc --help' for usage."
  ],
  "exception": "#<RuntimeError: svnmucc failure 1 committing>",
  "backtrace": [
    "/Users/clr/apache/git/whimsy/lib/whimsy/asf/svn.rb:768:in `multiUpdate_'",
    "/Users/clr/apache/git/whimsy/www/roster/views/actions/memstat.json.rb:22:in `_evaluate'",
    "/Users/clr/apache/git/whimsy/www/roster/main.rb:204:in `block in <top (required)>'",
    "/Users/clr/apache/git/whimsy/lib/whimsy/asf/rack.rb:223:in `call'",
    "/Users/clr/apache/git/whimsy/lib/whimsy/asf/rack.rb:48:in `call'",
    "/Users/clr/apache/git/whimsy/lib/whimsy/asf/rack.rb:200:in `call'",
    "/Users/clr/apache/git/whimsy/lib/whimsy/asf/rack.rb:254:in `call'"
  ]
}
Craig L Russell
clr@apache.org

Re: A little help please with roster-emeritus

Posted by sebb <se...@gmail.com>.

On Tue, 30 Jun 2020 at 14:16, Craig Russell <ap...@gmail.com> wrote:
>
> Anything more to add here? Please?

AFAICT multiUpdate_ and svnmucc_ are working OK.

Therefore suspicion falls on the env object -- does it actually
contain a password?

Hence my previous suggestion to check whether that is the case or not.

> Craig
>
> > On Jun 29, 2020, at 4:29 PM, Craig Russell <ap...@gmail.com> wrote:
> >
> > I'm just confused why the password is needed, since the "_" contains user and password.
> >
> > Where does the password go when using multiUpdate? It's in the "_" that's passed in. Where is the password missing?
> >
> > Thanks,
> > Craig
> >
> >> On Jun 29, 2020, at 3:56 PM, sebb <se...@gmail.com> wrote:
> >>
> >> On Mon, 29 Jun 2020 at 23:31, Craig Russell <ap...@gmail.com> wrote:
> >>>
> >>> I'm testing the "move to emeritus" function with the changes that will move emeritus-requests-received/member.txt to emeritus.
> >>>
> >>> All the code is in branch roster-emeritus. I'm getting this error from memstat.json.rb when processing the move to  emeritus. I don't know if it's really a credentials issue or not. The transcript messages are not very helpful...
> >>>
> >>> Any help?
> >>
> >> Try putting some debug into the code, e.g. at memstat.json.rb:21 add:
> >>
> >> raise RuntimeError.new("No password") unless env.password
> >>
> >> You should also be able to add items to the transcript using
> >>
> >> Wunderbar.warn
> >> or perhaps
> >> _.system('echo',...)
> >>
> >>> Thanks,
> >>> Craig
> >>>
> >>> {
> >>> "transcript": [
> >>>   "$ svn checkout --non-interactive --depth empty -- https://svn.apache.org/repos/private/foundation /var/folders/mx/t44d3_bs437dpnywzk_mwl_0002msd/T/d20200629-3669-14icn6l",
> >>>   " U   /var/folders/mx/t44d3_bs437dpnywzk_mwl_0002msd/T/d20200629-3669-14icn6l",
> >>>   "Checked out revision 97873.",
> >>>   "",
> >>>   "$ svn update --non-interactive -- /var/folders/mx/t44d3_bs437dpnywzk_mwl_0002msd/T/d20200629-3669-14icn6l/members.txt",
> >>>   "Updating '/var/folders/mx/t44d3_bs437dpnywzk_mwl_0002msd/T/d20200629-3669-14icn6l/members.txt':",
> >>>   "A    /var/folders/mx/t44d3_bs437dpnywzk_mwl_0002msd/T/d20200629-3669-14icn6l/members.txt",
> >>>   "Updated to revision 97873.",
> >>>   "",
> >>>   "$ svnmucc --non-interactive --extra-args /var/folders/mx/t44d3_bs437dpnywzk_mwl_0002msd/T/d20200629-3669-14icn6l/svnmucc_input20200629-3669-1pq2n8h --message Action\\ emeritus\\ for\\ sanjiva --no-auth-cache --revision 97873",
> >>>   "svnmucc: missing argument: --password",
> >>>   "Type 'svnmucc --help' for usage."
> >>> ],
> >>> "exception": "#<RuntimeError: svnmucc failure 1 committing>",
> >>> "backtrace": [
> >>>   "/Users/clr/apache/git/whimsy/lib/whimsy/asf/svn.rb:768:in `multiUpdate_'",
> >>>   "/Users/clr/apache/git/whimsy/www/roster/views/actions/memstat.json.rb:22:in `_evaluate'",
> >>>   "/Users/clr/apache/git/whimsy/www/roster/main.rb:204:in `block in <top (required)>'",
> >>>   "/Users/clr/apache/git/whimsy/lib/whimsy/asf/rack.rb:223:in `call'",
> >>>   "/Users/clr/apache/git/whimsy/lib/whimsy/asf/rack.rb:48:in `call'",
> >>>   "/Users/clr/apache/git/whimsy/lib/whimsy/asf/rack.rb:200:in `call'",
> >>>   "/Users/clr/apache/git/whimsy/lib/whimsy/asf/rack.rb:254:in `call'"
> >>> ]
> >>> }
> >>> Craig L Russell
> >>> clr@apache.org
> >>>
> >
> > Craig L Russell
> > clr@apache.org
> >
>
> Craig L Russell
> clr@apache.org
>

Re: A little help please with roster-emeritus

Posted by Sam Ruby <ru...@intertwingly.net>.

On Wed, Jul 1, 2020 at 10:17 AM sebb <se...@gmail.com> wrote:
>
> On Wed, 1 Jul 2020 at 14:40, Craig Russell <ap...@gmail.com> wrote:
> >
> > So IIUC:
> > svnmucc always  needs an explicit password
>
> No.
>
> However svnmucc always requires modify access.
> All ASF repos require a password to allow modification.
> So svnmucc always needs a password to operate against an ASF repo.
>
> > local testing does not use a password
>
> Depends what you mean by local testing.
>
> If you mean testing against a local repo, svnmucc generally won't need
> a password.
> Though you can set up the local repo to require passwords.
>
> If you mean running Whimsy locally against a remote repo, then it
> depends on how the server was set up.
> By default the Docker version will prompt for username and password.
>
> > svnmucc cannot be tested locally
>
> No true.

I agree with Sebb.

Everything can be tested locally if you are determined enough.

Unit testing functions that invoke svnmucc can be done via mocks[1].

As Sebb mentioned, integration and system testing can be done using
svnadmin[2] to create local (file://) databases.

I've been building this support into the Node.js implementation.  When
run in development mode, it is totally transparent: you operate
against the production repositories up until the very first commit, at
which point a local snapshot is taken of the repository and the commit
will be issued against that.  In testing, mocks are used with test
data and writes are done in memory only.  There is no reason why any
of this can't apply to CGIs.

I invite you to play with the node.js board agenda application - find
something that isn't completely implemented yet or doesn't have
adequate tests in place.  Once you have done that, perhaps we can
either port more applications to Node.js; alternately perhaps the test
support can be "back ported" to Ruby.

I continue to see a number of advantages to the Node implementation.
There is less to set up and configure.  Everything is self contained.
There is no need to update a file in an /etc directory.  Test support
includes client side testing.  And frankly everything is noticeably
faster.

The question I would like everybody to ponder: at the moment we have
four-ish active developers (Sebb, Craig, Sam, Shane).  What would it
take to double that?

If you look at the current COI application, it actually isn't all that
much code.  But it was unnecessarily hard to create.  While the
implementation language was a small part of that, there are too many
finicky things that need to be set up and configured correctly, and
when things go wrong tend only to put out stack traces that obscure
rather than enlighten.  And even then, those stack traces are often
placed in out of the way places.

- Sam Ruby

[1] https://github.com/rspec/rspec-mocks
[2] http://svnbook.red-bean.com/en/1.7/svn.ref.svnadmin.html

> > Craig
> >
> > > On Jun 30, 2020, at 3:19 PM, sebb <se...@gmail.com> wrote:
> > >
> > > On Tue, 30 Jun 2020 at 22:58, Craig Russell <ap...@gmail.com> wrote:
> > >>
> > >> I updated /private/etc/apache2/other/whimsy.conf by prepending PATH with the location in my file system to svnmucc: /usr/local/opt/subversion/bin. Both svn and svnmucc are the 2020 versions.
> > >> svn, version 1.14.0 (r1876290)
> > >>   compiled Jun 22 2020, 22:13:07 on x86_64-apple-darwin18.7.0
> > >> svnmucc, version 1.14.0 (r1876290)
> > >>   compiled Jun 22 2020, 22:13:07 on x86_64-apple-darwin18.7.0
> > >>
> > >> Then, svnmucc told me that "move" is not an action. [1]
> > >
> > > Try 'svnmucc --help'
> > >
> > >> So I changed the memstat.json.rb to use "mv" instead of "move".
> > >>
> > >> Now, [2] svnmucc is unable to understand that I want to move a file to a different directory. I have used this with svn via the system command and it works fine.
> > >>
> > >> 1. Is svnmucc really at a back level compared to svn? It doesn't know what "move" is?
> > >
> > > It is much simpler than SVN; it is not a full CLI client.
> > > It is intended for scripted/batch usage.
> > >
> > > It requires full path names.
> > >
> > > As the help says, svnmucc is used to:
> > >
> > >  Perform one or more Subversion repository URL-based ACTIONs, committing
> > >  the result as a (single) new revision.
> > >
> > >> 2. So do I have to go back and send both the file name clr.txt as well as the url https://svn.apache.org/repos/private/documents/emeritus-requests-rescinded/clr.txt ?
> > >
> > > Yes.
> > >
> > > Almost all svnmucc operations take place directly in the repository,
> > > and need full path names.
> > > The only exception is for a 'put' which copies a local file to the repo.
> > >
> > >> Call me confused. Again.
> > >>
> > >> Craig
> > >>
> > >> [1] {
> > >>  "transcript": [
> > >>    "$ svn checkout --non-interactive --depth empty -- https://svn.apache.org/repos/private/foundation /var/folders/zz/zyxvpxvq6csfxvn_n000008r000026/T/d20200630-49756-3i8lef",
> > >>    " U   /var/folders/zz/zyxvpxvq6csfxvn_n000008r000026/T/d20200630-49756-3i8lef",
> > >>    "Checked out revision 97889.",
> > >>    "",
> > >>    "$ svn update --non-interactive -- /var/folders/zz/zyxvpxvq6csfxvn_n000008r000026/T/d20200630-49756-3i8lef/members.txt",
> > >>    "Updating '/var/folders/zz/zyxvpxvq6csfxvn_n000008r000026/T/d20200630-49756-3i8lef/members.txt':",
> > >>    "A    /var/folders/zz/zyxvpxvq6csfxvn_n000008r000026/T/d20200630-49756-3i8lef/members.txt",
> > >>    "Updated to revision 97889.",
> > >>    "",
> > >>    "$ svnmucc --non-interactive --extra-args /var/folders/zz/zyxvpxvq6csfxvn_n000008r000026/T/d20200630-49756-3i8lef/svnmucc_input20200630-49756-s5rv19 --message Action\\ emeritus\\ for\\ sanjiva --no-auth-cache --revision 97889",
> > >>    "svnmucc: E200004: 'move' is not an action",
> > >>    ""
> > >>  ],
> > >>  "exception": "#<RuntimeError: svnmucc failure 1 committing>",
> > >>  "backtrace": [
> > >>    "/Users/clr/apache/git/whimsy/lib/whimsy/asf/svn.rb:768:in `multiUpdate_'",
> > >>    "/Users/clr/apache/git/whimsy/www/roster/views/actions/memstat.json.rb:22:in `_evaluate'",
> > >>    "/Users/clr/apache/git/whimsy/www/roster/main.rb:204:in `block in <top (required)>'",
> > >>    "/Users/clr/apache/git/whimsy/lib/whimsy/asf/rack.rb:223:in `call'",
> > >>    "/Users/clr/apache/git/whimsy/lib/whimsy/asf/rack.rb:48:in `call'",
> > >>    "/Users/clr/apache/git/whimsy/lib/whimsy/asf/rack.rb:200:in `call'",
> > >>    "/Users/clr/apache/git/whimsy/lib/whimsy/asf/rack.rb:254:in `call'",
> > >>    "/usr/local/Cellar/passenger/6.0.5/libexec/src/ruby_supportlib/phusion_passenger/rack/thread_handler_extension.rb:107:in `process_request'",
> > >>    "/usr/local/Cellar/passenger/6.0.5/libexec/src/ruby_supportlib/phusion_passenger/request_handler/thread_handler.rb:157:in `accept_and_process_next_request'",
> > >>    "/usr/local/Cellar/passenger/6.0.5/libexec/src/ruby_supportlib/phusion_passenger/request_handler/thread_handler.rb:110:in `main_loop'",
> > >>    "/usr/local/Cellar/passenger/6.0.5/libexec/src/ruby_supportlib/phusion_passenger/request_handler.rb:415:in `block (3 levels) in start_threads'",
> > >>    "/usr/local/Cellar/passenger/6.0.5/libexec/src/ruby_supportlib/phusion_passenger/utils.rb:113:in `block in create_thread_and_abort_on_exception'"
> > >>  ]
> > >> }
> > >> [2] {
> > >>  "transcript": [
> > >>    "$ svn checkout --non-interactive --depth empty -- https://svn.apache.org/repos/private/foundation /var/folders/zz/zyxvpxvq6csfxvn_n000008r000026/T/d20200630-29367-10t68d3",
> > >>    " U   /var/folders/zz/zyxvpxvq6csfxvn_n000008r000026/T/d20200630-29367-10t68d3",
> > >>    "Checked out revision 97889.",
> > >>    "",
> > >>    "$ svn update --non-interactive -- /var/folders/zz/zyxvpxvq6csfxvn_n000008r000026/T/d20200630-29367-10t68d3/members.txt",
> > >>    "Updating '/var/folders/zz/zyxvpxvq6csfxvn_n000008r000026/T/d20200630-29367-10t68d3/members.txt':",
> > >>    "A    /var/folders/zz/zyxvpxvq6csfxvn_n000008r000026/T/d20200630-29367-10t68d3/members.txt",
> > >>    "Updated to revision 97889.",
> > >>    "",
> > >>    "$ svnmucc --non-interactive --extra-args /var/folders/zz/zyxvpxvq6csfxvn_n000008r000026/T/d20200630-29367-10t68d3/svnmucc_input20200630-29367-1l9t19h --message Action\\ emeritus\\ for\\ sanjiva --no-auth-cache --revision 97889",
> > >>    "svnmucc: E160020: Path 'documents/emeritus' already exists"
> > >>  ],
> > >>  "exception": "#<RuntimeError: svnmucc failure 1 committing>",
> > >>  "backtrace": [
> > >>    "/Users/clr/apache/git/whimsy/lib/whimsy/asf/svn.rb:768:in `multiUpdate_'",
> > >>    "/Users/clr/apache/git/whimsy/www/roster/views/actions/memstat.json.rb:22:in `_evaluate'",
> > >>    "/Users/clr/apache/git/whimsy/www/roster/main.rb:204:in `block in <top (required)>'",
> > >>    "/Users/clr/apache/git/whimsy/lib/whimsy/asf/rack.rb:223:in `call'",
> > >>    "/Users/clr/apache/git/whimsy/lib/whimsy/asf/rack.rb:48:in `call'",
> > >>    "/Users/clr/apache/git/whimsy/lib/whimsy/asf/rack.rb:200:in `call'",
> > >>    "/Users/clr/apache/git/whimsy/lib/whimsy/asf/rack.rb:254:in `call'",
> > >>    "/usr/local/Cellar/passenger/6.0.5/libexec/src/ruby_supportlib/phusion_passenger/rack/thread_handler_extension.rb:107:in `process_request'",
> > >>    "/usr/local/Cellar/passenger/6.0.5/libexec/src/ruby_supportlib/phusion_passenger/request_handler/thread_handler.rb:157:in `accept_and_process_next_request'",
> > >>    "/usr/local/Cellar/passenger/6.0.5/libexec/src/ruby_supportlib/phusion_passenger/request_handler/thread_handler.rb:110:in `main_loop'",
> > >>    "/usr/local/Cellar/passenger/6.0.5/libexec/src/ruby_supportlib/phusion_passenger/request_handler.rb:415:in `block (3 levels) in start_threads'",
> > >>    "/usr/local/Cellar/passenger/6.0.5/libexec/src/ruby_supportlib/phusion_passenger/utils.rb:113:in `block in create_thread_and_abort_on_exception'"
> > >>  ]
> > >> }
> > >>
> > >>> On Jun 30, 2020, at 12:41 PM, Sam Ruby <ru...@intertwingly.net> wrote:
> > >>>
> > >>> On Tue, Jun 30, 2020 at 2:33 PM Craig Russell <ap...@gmail.com> wrote:
> > >>>>
> > >>>>> On Jun 30, 2020, at 11:06 AM, Sam Ruby <ru...@intertwingly.net> wrote:
> > >>>>>
> > >>>>> What does `which svnmucc` return?  If it is not present, install it
> > >>>>> via `brew install subversion`.  If it is present, make sure that its
> > >>>>> path is included by the web server.
> > >>>>
> > >>>> [MacBook-Pro-10:~/apache/git/whimsy] clr% which svnmucc
> > >>>> /opt/local/bin/svnmucc
> > >>>>
> > >>>> Where do I look for the path used by the web server?
> > >>>
> > >>> /private/etc/apache2/other/whimsy.conf
> > >>>
> > >>> Meanwhile, I've pushed a fix to setupmymac to automatically insert this for you.
> > >>>
> > >>>> I'm connected and can access the whimsy pages via Safari, but cannot connect to https://whimsy.local from either Firefox or Chrome.
> > >>>
> > >>> Try http (instead of https).
> > >>>
> > >>>> Craig
> > >>>
> > >>> - Sam Ruby
> > >>
> > >> Craig L Russell
> > >> clr@apache.org
> > >>
> >
> > Craig L Russell
> > clr@apache.org
> >