You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by ji...@apache.org on 2022/02/21 12:14:22 UTC
[shardingsphere] branch master updated: Minor changes of DistSQL IT (#15553)
This is an automated email from the ASF dual-hosted git repository.
jianglongtao pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git
The following commit(s) were added to refs/heads/master by this push:
new 6425342 Minor changes of DistSQL IT (#15553)
6425342 is described below
commit 6425342fe40a0ec02b536841edec83f2a29dc962
Author: Liang Zhang <zh...@apache.org>
AuthorDate: Mon Feb 21 20:12:29 2022 +0800
Minor changes of DistSQL IT (#15553)
* Refactor GeneralRDLIT
* Refactor GeneralRQLIT
* Refactor GeneralRALIT
---
.../test/integration/engine/ral/GeneralRALIT.java | 14 +++++---------
.../test/integration/engine/rdl/GeneralRDLIT.java | 14 +++++---------
.../test/integration/engine/rql/GeneralRQLIT.java | 14 +++++---------
3 files changed, 15 insertions(+), 27 deletions(-)
diff --git a/shardingsphere-test/shardingsphere-integration-test/shardingsphere-integration-test-suite/src/test/java/org/apache/shardingsphere/test/integration/engine/ral/GeneralRALIT.java b/shardingsphere-test/shardingsphere-integration-test/shardingsphere-integration-test-suite/src/test/java/org/apache/shardingsphere/test/integration/engine/ral/GeneralRALIT.java
index 7764367..f0ddad5 100644
--- a/shardingsphere-test/shardingsphere-integration-test/shardingsphere-integration-test-suite/src/test/java/org/apache/shardingsphere/test/integration/engine/ral/GeneralRALIT.java
+++ b/shardingsphere-test/shardingsphere-integration-test/shardingsphere-integration-test-suite/src/test/java/org/apache/shardingsphere/test/integration/engine/ral/GeneralRALIT.java
@@ -47,15 +47,11 @@ public final class GeneralRALIT extends BaseRALIT {
@Test
public void assertExecute() throws SQLException, ParseException {
try (Connection connection = getTargetDataSource().getConnection()) {
- assertExecuteForStatement(connection);
- }
- }
-
- private void assertExecuteForStatement(final Connection connection) throws SQLException, ParseException {
- try (
- Statement statement = connection.createStatement();
- ResultSet resultSet = statement.executeQuery(getSQL())) {
- assertResultSet(resultSet);
+ try (
+ Statement statement = connection.createStatement();
+ ResultSet resultSet = statement.executeQuery(getSQL())) {
+ assertResultSet(resultSet);
+ }
}
}
}
diff --git a/shardingsphere-test/shardingsphere-integration-test/shardingsphere-integration-test-suite/src/test/java/org/apache/shardingsphere/test/integration/engine/rdl/GeneralRDLIT.java b/shardingsphere-test/shardingsphere-integration-test/shardingsphere-integration-test-suite/src/test/java/org/apache/shardingsphere/test/integration/engine/rdl/GeneralRDLIT.java
index a74ea7f..b466604 100644
--- a/shardingsphere-test/shardingsphere-integration-test/shardingsphere-integration-test-suite/src/test/java/org/apache/shardingsphere/test/integration/engine/rdl/GeneralRDLIT.java
+++ b/shardingsphere-test/shardingsphere-integration-test/shardingsphere-integration-test-suite/src/test/java/org/apache/shardingsphere/test/integration/engine/rdl/GeneralRDLIT.java
@@ -47,15 +47,11 @@ public final class GeneralRDLIT extends BaseRDLIT {
@Test
public void assertExecute() throws SQLException, ParseException {
try (Connection connection = getTargetDataSource().getConnection()) {
- assertExecuteForStatement(connection);
- }
- }
-
- private void assertExecuteForStatement(final Connection connection) throws SQLException, ParseException {
- try (
- Statement statement = connection.createStatement();
- ResultSet resultSet = statement.executeQuery(getSQL())) {
- assertResultSet(resultSet);
+ try (
+ Statement statement = connection.createStatement();
+ ResultSet resultSet = statement.executeQuery(getSQL())) {
+ assertResultSet(resultSet);
+ }
}
}
}
diff --git a/shardingsphere-test/shardingsphere-integration-test/shardingsphere-integration-test-suite/src/test/java/org/apache/shardingsphere/test/integration/engine/rql/GeneralRQLIT.java b/shardingsphere-test/shardingsphere-integration-test/shardingsphere-integration-test-suite/src/test/java/org/apache/shardingsphere/test/integration/engine/rql/GeneralRQLIT.java
index 6eceed0..7d51dd0 100644
--- a/shardingsphere-test/shardingsphere-integration-test/shardingsphere-integration-test-suite/src/test/java/org/apache/shardingsphere/test/integration/engine/rql/GeneralRQLIT.java
+++ b/shardingsphere-test/shardingsphere-integration-test/shardingsphere-integration-test-suite/src/test/java/org/apache/shardingsphere/test/integration/engine/rql/GeneralRQLIT.java
@@ -47,15 +47,11 @@ public final class GeneralRQLIT extends BaseRQLIT {
@Test
public void assertExecute() throws SQLException, ParseException {
try (Connection connection = getTargetDataSource().getConnection()) {
- assertExecuteForStatement(connection);
- }
- }
-
- private void assertExecuteForStatement(final Connection connection) throws SQLException, ParseException {
- try (
- Statement statement = connection.createStatement();
- ResultSet resultSet = statement.executeQuery(getSQL())) {
- assertResultSet(resultSet);
+ try (
+ Statement statement = connection.createStatement();
+ ResultSet resultSet = statement.executeQuery(getSQL())) {
+ assertResultSet(resultSet);
+ }
}
}
}