[GitHub] [airflow] ryanyuan commented on a change in pull request #5546: [AIRFLOW-4908] BigQuery Hooks/Operators for update_dataset, patch_dataset, get_dataset

[GitBox <gi...@apache.org>]

ryanyuan commented on a change in pull request #5546: [AIRFLOW-4908] BigQuery Hooks/Operators for update_dataset, patch_dataset, get_dataset
URL: https://github.com/apache/airflow/pull/5546#discussion_r313200415
 
 

 ##########
 File path: airflow/contrib/hooks/bigquery_hook.py
 ##########
 @@ -1718,6 +1718,97 @@ def get_datasets_list(self, project_id=None):
 
         return datasets_list
 
+    def patch_dataset(self, dataset_id, dataset_resource, project_id=None):
 
 Review comment:
   @mik-laj I am still confused about your reply. I understood why we introduced the decorator, but it's not quite relevant to my previous comment. 
   
   The decorator can only be used by the functions inside the classes that which inherits `GoogleCloudBaseHook`. So if I put the decorator on my functions, it will not work because my functions are in `BigQueryBaseCursor`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services