You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/02/04 12:45:53 UTC

[GitHub] [skywalking] kezhenxu94 opened a new pull request #6322: Save Envoy http access logs when error occurs

kezhenxu94 opened a new pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322


   <!--
       ⚠️ Please make sure to read this template first, pull requests that don't accord with this template
       maybe closed without notice.
       Texts surrounded by `<` and `>` are meant to be replaced by you, e.g. <framework name>, <issue number>.
       Put an `x` in the `[ ]` to mark the item as CHECKED. `[x]`
   -->
   
   <!-- ==== 🐛 Remove this line WHEN AND ONLY WHEN you're fixing a bug, follow the checklist 👇 ====
   ### Fix <bug description or the bug issue number or bug issue link>
   - [ ] Add a unit test to verify that the fix works.
   - [ ] Explain briefly why the bug exists and how to fix it.
        ==== 🐛 Remove this line WHEN AND ONLY WHEN you're fixing a bug, follow the checklist 👆 ==== -->
   
   <!-- ==== 🔌 Remove this line WHEN AND ONLY WHEN you're adding a new plugin, follow the checklist 👇 ====
   ### Add an agent plugin to support <framework name>
   - [ ] Add a test case for the new plugin, refer to [the doc](https://github.com/apache/skywalking/blob/master/docs/en/guides/Plugin-test.md)
   - [ ] Add a component id in [the component-libraries.yml](https://github.com/apache/skywalking/blob/master/oap-server/server-bootstrap/src/main/resources/component-libraries.yml)
   - [ ] Add a logo in [the UI repo](https://github.com/apache/skywalking-rocketbot-ui/tree/master/src/views/components/topology/assets)
        ==== 🔌 Remove this line WHEN AND ONLY WHEN you're adding a new plugin, follow the checklist 👆 ==== -->
   
   <!-- ==== 📈 Remove this line WHEN AND ONLY WHEN you're improving the performance, follow the checklist 👇 ====
   ### Improve the performance of <class or module or ...>
   - [ ] Add a benchmark for the improvement, refer to [the existing ones](https://github.com/apache/skywalking/blob/master/apm-commons/apm-datacarrier/src/test/java/org/apache/skywalking/apm/commons/datacarrier/LinkedArrayBenchmark.java)
   - [ ] The benchmark result.
   ```text
   <Paste the benchmark results here>
   ```
   - [ ] Links/URLs to the theory proof or discussion articles/blogs. <links/URLs here>
        ==== 📈 Remove this line WHEN AND ONLY WHEN you're improving the performance, follow the checklist 👆 ==== -->
   
   <!-- ==== 🆕 Remove this line WHEN AND ONLY WHEN you're adding a new feature, follow the checklist 👇 ====
   ### <Feature description>
   - [ ] If this is non-trivial feature, paste the links/URLs to the design doc.
   - [ ] Update the documentation to include this new feature.
   - [ ] Tests(including UT, IT, E2E) are added to verify the new feature.
   - [ ] If it's UI related, attach the screenshots below.
        ==== 🆕 Remove this line WHEN AND ONLY WHEN you're adding a new feature, follow the checklist 👆 ==== -->
   
   - [x] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #6247.
   - [x] Update the [`CHANGES` log](https://github.com/apache/skywalking/blob/master/CHANGES.md).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (5d644ce) into [master](https://codecov.io/gh/apache/skywalking/commit/6bc3ba025f889b0682d651d07f5b8037f41fff9c?el=desc) (6bc3ba0) will **increase** coverage by `18.64%`.
   > The diff coverage is `8.23%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #6322       +/-   ##
   =============================================
   + Coverage     31.05%   49.69%   +18.64%     
   - Complexity     2180     3551     +1371     
   =============================================
     Files           964      985       +21     
     Lines         23384    24161      +777     
     Branches       2263     2332       +69     
   =============================================
   + Hits           7262    12007     +4745     
   + Misses        15570    11109     -4461     
   - Partials        552     1045      +493     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `24.21% <0.00%> (+15.34%)` | `4.00 <0.00> (+3.00)` | |
   | [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `23.52% <0.00%> (+5.01%)` | `1.00 <0.00> (-1.00)` | :arrow_up: |
   | [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `55.55% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `59.61% <0.00%> (ø)` | `6.00 <0.00> (ø)` | |
   | [...iver/envoy/als/mx/MetaExchangeALSHTTPAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L01ldGFFeGNoYW5nZUFMU0hUVFBBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../receiver/envoy/als/mx/ServiceMetaInfoAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L1NlcnZpY2VNZXRhSW5mb0FkYXB0ZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | ... and [351 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [6bc3ba0...91e7ed7](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (8190912) into [master](https://codecov.io/gh/apache/skywalking/commit/b1a8238c159eaebda35771cd7c9c548e5eedfee1?el=desc) (b1a8238) will **increase** coverage by `6.57%`.
   > The diff coverage is `8.23%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6322      +/-   ##
   ============================================
   + Coverage     41.42%   47.99%   +6.57%     
   - Complexity     2959     3411     +452     
   ============================================
     Files           953      956       +3     
     Lines         23209    23364     +155     
     Branches       2262     2275      +13     
   ============================================
   + Hits           9614    11214    +1600     
   + Misses        12754    11178    -1576     
   - Partials        841      972     +131     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `8.04% <0.00%> (-0.82%)` | `1.00 <0.00> (ø)` | |
   | [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `23.52% <0.00%> (+5.01%)` | `1.00 <0.00> (-1.00)` | :arrow_up: |
   | [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `53.33% <0.00%> (+53.33%)` | `1.00 <0.00> (+1.00)` | |
   | [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `55.55% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `59.61% <0.00%> (ø)` | `6.00 <0.00> (ø)` | |
   | [...iver/envoy/als/mx/MetaExchangeALSHTTPAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L01ldGFFeGNoYW5nZUFMU0hUVFBBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../receiver/envoy/als/mx/ServiceMetaInfoAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L1NlcnZpY2VNZXRhSW5mb0FkYXB0ZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | ... and [177 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [b1a8238...dbd6ae9](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (dbd6ae9) into [master](https://codecov.io/gh/apache/skywalking/commit/b1a8238c159eaebda35771cd7c9c548e5eedfee1?el=desc) (b1a8238) will **increase** coverage by `4.17%`.
   > The diff coverage is `8.23%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6322      +/-   ##
   ============================================
   + Coverage     41.42%   45.59%   +4.17%     
   + Complexity     2959     2609     -350     
   ============================================
     Files           953      805     -148     
     Lines         23209    19710    -3499     
     Branches       2262     1848     -414     
   ============================================
   - Hits           9614     8987     -627     
   + Misses        12754    10035    -2719     
   + Partials        841      688     -153     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `8.04% <0.00%> (-0.82%)` | `1.00 <0.00> (ø)` | |
   | [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `23.52% <0.00%> (+5.01%)` | `1.00 <0.00> (-1.00)` | :arrow_up: |
   | [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `55.55% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `59.61% <0.00%> (ø)` | `6.00 <0.00> (ø)` | |
   | [...iver/envoy/als/mx/MetaExchangeALSHTTPAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L01ldGFFeGNoYW5nZUFMU0hUVFBBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../receiver/envoy/als/mx/ServiceMetaInfoAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L1NlcnZpY2VNZXRhSW5mb0FkYXB0ZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | ... and [306 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [b1a8238...dbd6ae9](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (5d644ce) into [master](https://codecov.io/gh/apache/skywalking/commit/6bc3ba025f889b0682d651d07f5b8037f41fff9c?el=desc) (6bc3ba0) will **increase** coverage by `18.37%`.
   > The diff coverage is `8.23%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #6322       +/-   ##
   =============================================
   + Coverage     31.05%   49.42%   +18.37%     
   - Complexity     2180     3541     +1361     
   =============================================
     Files           964      985       +21     
     Lines         23384    24161      +777     
     Branches       2263     2332       +69     
   =============================================
   + Hits           7262    11942     +4680     
   + Misses        15570    11190     -4380     
   - Partials        552     1029      +477     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `24.21% <0.00%> (+15.34%)` | `4.00 <0.00> (+3.00)` | |
   | [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `23.52% <0.00%> (+5.01%)` | `1.00 <0.00> (-1.00)` | :arrow_up: |
   | [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `55.55% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `59.61% <0.00%> (ø)` | `6.00 <0.00> (ø)` | |
   | [...iver/envoy/als/mx/MetaExchangeALSHTTPAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L01ldGFFeGNoYW5nZUFMU0hUVFBBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../receiver/envoy/als/mx/ServiceMetaInfoAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L1NlcnZpY2VNZXRhSW5mb0FkYXB0ZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | ... and [351 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [6bc3ba0...91e7ed7](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (b9cf4d4) into [master](https://codecov.io/gh/apache/skywalking/commit/b1a8238c159eaebda35771cd7c9c548e5eedfee1?el=desc) (b1a8238) will **increase** coverage by `5.73%`.
   > The diff coverage is `14.60%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6322      +/-   ##
   ============================================
   + Coverage     41.42%   47.15%   +5.73%     
   + Complexity     2959     2792     -167     
   ============================================
     Files           953     1767     +814     
     Lines         23209    37355   +14146     
     Branches       2262     4303    +2041     
   ============================================
   + Hits           9614    17616    +8002     
   - Misses        12754    18755    +6001     
   - Partials        841      984     +143     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `24.21% <0.00%> (+15.34%)` | `4.00 <0.00> (+3.00)` | |
   | [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `23.52% <0.00%> (+5.01%)` | `1.00 <0.00> (-1.00)` | :arrow_up: |
   | [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `18.51% <0.00%> (-37.04%)` | `2.00 <0.00> (ø)` | |
   | [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `65.71% <0.00%> (+65.71%)` | `0.00 <0.00> (ø)` | |
   | [...iver/envoy/als/mx/MetaExchangeALSHTTPAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L01ldGFFeGNoYW5nZUFMU0hUVFBBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../receiver/envoy/als/mx/ServiceMetaInfoAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L1NlcnZpY2VNZXRhSW5mb0FkYXB0ZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/persistence/LogsPersistence.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvcGVyc2lzdGVuY2UvTG9nc1BlcnNpc3RlbmNlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `31.81% <50.00%> (-61.04%)` | `3.00 <0.00> (ø)` | |
   | [...ver/receiver/envoy/ServiceMetaInfoFactoryImpl.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvU2VydmljZU1ldGFJbmZvRmFjdG9yeUltcGwuamF2YQ==) | `50.00% <50.00%> (ø)` | `2.00 <2.00> (?)` | |
   | ... and [1360 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [b1a8238...dbd6ae9](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] wu-sheng commented on a change in pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#discussion_r585394086



##########
File path: oap-server/server-bootstrap/src/main/resources/lal/envoy-als.yaml
##########
@@ -0,0 +1,47 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+rules:
+  - name: envoy-als
+    dsl: |
+      filter {
+        json {
+        }
+        // only collect abnormal logs (http status code >= 300, or commonProperties?.responseFlags is not empty)
+        if (parsed?.response?.responseCode < 300 && !parsed?.commonProperties?.responseFlags) {
+          abort {}
+        }
+        extractor {
+          tag 'status.code': parsed?.response?.responseCode as int
+          tag 'response.flag': parsed?.commonProperties?.responseFlags?.keySet()
+        }
+        sink {
+          sampler {
+            if (parsed?.commonProperties?.responseFlags) {
+              // use service:errorCode as sampler id so that each service:errorCode has its own sampler,
+              // e.g. checkoutservice:[upstreamConnectionFailure], checkoutservice:[upstreamRetryLimitExceeded]
+              rateLimit("${log.service}:${parsed?.commonProperties?.responseFlags?.keySet()}") {

Review comment:
       Got it. I have some self-doubt whether I am too paranoid to worry about OOM. Let's keep this for now. This at least makes sure we don't miss important error logs.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (45dc5d6) into [master](https://codecov.io/gh/apache/skywalking/commit/6bc3ba025f889b0682d651d07f5b8037f41fff9c?el=desc) (6bc3ba0) will **increase** coverage by `20.27%`.
   > The diff coverage is `15.29%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #6322       +/-   ##
   =============================================
   + Coverage     31.05%   51.33%   +20.27%     
   - Complexity     2180     3711     +1531     
   =============================================
     Files           964      985       +21     
     Lines         23384    24257      +873     
     Branches       2263     2345       +82     
   =============================================
   + Hits           7262    12452     +5190     
   + Misses        15570    10751     -4819     
   - Partials        552     1054      +502     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `8.04% <0.00%> (-0.82%)` | `1.00 <0.00> (ø)` | |
   | [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `23.52% <0.00%> (+5.01%)` | `1.00 <0.00> (-1.00)` | :arrow_up: |
   | [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `55.55% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `59.61% <0.00%> (ø)` | `6.00 <0.00> (ø)` | |
   | [...iver/envoy/als/mx/MetaExchangeALSHTTPAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L01ldGFFeGNoYW5nZUFMU0hUVFBBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../receiver/envoy/als/mx/ServiceMetaInfoAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L1NlcnZpY2VNZXRhSW5mb0FkYXB0ZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/persistence/LogsPersistence.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvcGVyc2lzdGVuY2UvTG9nc1BlcnNpc3RlbmNlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | ... and [414 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [6bc3ba0...d501f73](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (5d644ce) into [master](https://codecov.io/gh/apache/skywalking/commit/6bc3ba025f889b0682d651d07f5b8037f41fff9c?el=desc) (6bc3ba0) will **increase** coverage by `5.61%`.
   > The diff coverage is `8.23%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6322      +/-   ##
   ============================================
   + Coverage     31.05%   36.66%   +5.61%     
   + Complexity     2180     2159      -21     
   ============================================
     Files           964      805     -159     
     Lines         23384    19671    -3713     
     Branches       2263     1844     -419     
   ============================================
   - Hits           7262     7213      -49     
   + Misses        15570    11911    -3659     
   + Partials        552      547       -5     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `8.04% <0.00%> (-0.82%)` | `1.00 <0.00> (ø)` | |
   | [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `23.52% <0.00%> (+5.01%)` | `1.00 <0.00> (-1.00)` | :arrow_up: |
   | [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `55.55% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `59.61% <0.00%> (ø)` | `6.00 <0.00> (ø)` | |
   | [...iver/envoy/als/mx/MetaExchangeALSHTTPAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L01ldGFFeGNoYW5nZUFMU0hUVFBBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../receiver/envoy/als/mx/ServiceMetaInfoAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L1NlcnZpY2VNZXRhSW5mb0FkYXB0ZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | ... and [194 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [6bc3ba0...91e7ed7](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] kezhenxu94 commented on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-788004078


   @wu-sheng tags (responseStatusCode, errorCode) and sampler (per service) are added
   
   Updated screenshot 
   
   <img width="1791" alt="image" src="https://user-images.githubusercontent.com/15965696/109513284-e6003100-7adf-11eb-8fa1-338675eab1bf.png">
   <img width="1791" alt="image" src="https://user-images.githubusercontent.com/15965696/109513320-ee586c00-7adf-11eb-9116-f7fee6e7e8fa.png">
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (b9cf4d4) into [master](https://codecov.io/gh/apache/skywalking/commit/b1a8238c159eaebda35771cd7c9c548e5eedfee1?el=desc) (b1a8238) will **decrease** coverage by `2.91%`.
   > The diff coverage is `8.23%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6322      +/-   ##
   ============================================
   - Coverage     41.42%   38.50%   -2.92%     
   + Complexity     2959     2221     -738     
   ============================================
     Files           953      805     -148     
     Lines         23209    19551    -3658     
     Branches       2262     1814     -448     
   ============================================
   - Hits           9614     7528    -2086     
   + Misses        12754    11468    -1286     
   + Partials        841      555     -286     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `8.04% <0.00%> (-0.82%)` | `1.00 <0.00> (ø)` | |
   | [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `23.52% <0.00%> (+5.01%)` | `1.00 <0.00> (-1.00)` | :arrow_up: |
   | [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `55.55% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `59.61% <0.00%> (ø)` | `6.00 <0.00> (ø)` | |
   | [...iver/envoy/als/mx/MetaExchangeALSHTTPAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L01ldGFFeGNoYW5nZUFMU0hUVFBBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../receiver/envoy/als/mx/ServiceMetaInfoAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L1NlcnZpY2VNZXRhSW5mb0FkYXB0ZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | ... and [310 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [b1a8238...dbd6ae9](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] wu-sheng commented on a change in pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#discussion_r585194213



##########
File path: oap-server/server-bootstrap/src/main/resources/lal/envoy.yaml
##########
@@ -0,0 +1,39 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+rules:
+  - name: envoy
+    dsl: |
+      filter {
+        json {
+        }
+        // only collect error logs
+        if (parsed?.response?.responseCode < 500 && !parsed?.commonProperties?.responseFlags) {

Review comment:
        Yes, even there is no internal error.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (5d644ce) into [master](https://codecov.io/gh/apache/skywalking/commit/6bc3ba025f889b0682d651d07f5b8037f41fff9c?el=desc) (6bc3ba0) will **increase** coverage by `14.50%`.
   > The diff coverage is `8.23%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #6322       +/-   ##
   =============================================
   + Coverage     31.05%   45.56%   +14.50%     
   - Complexity     2180     3347     +1167     
   =============================================
     Files           964      985       +21     
     Lines         23384    24106      +722     
     Branches       2263     2330       +67     
   =============================================
   + Hits           7262    10983     +3721     
   + Misses        15570    12199     -3371     
   - Partials        552      924      +372     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `8.04% <0.00%> (-0.82%)` | `1.00 <0.00> (ø)` | |
   | [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `23.52% <0.00%> (+5.01%)` | `1.00 <0.00> (-1.00)` | :arrow_up: |
   | [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `55.55% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `59.61% <0.00%> (ø)` | `6.00 <0.00> (ø)` | |
   | [...iver/envoy/als/mx/MetaExchangeALSHTTPAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L01ldGFFeGNoYW5nZUFMU0hUVFBBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../receiver/envoy/als/mx/ServiceMetaInfoAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L1NlcnZpY2VNZXRhSW5mb0FkYXB0ZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | ... and [319 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [6bc3ba0...91e7ed7](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (8190912) into [master](https://codecov.io/gh/apache/skywalking/commit/b1a8238c159eaebda35771cd7c9c548e5eedfee1?el=desc) (b1a8238) will **increase** coverage by `16.19%`.
   > The diff coverage is `15.29%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #6322       +/-   ##
   =============================================
   + Coverage     41.42%   57.61%   +16.19%     
   - Complexity     2959     4018     +1059     
   =============================================
     Files           953      986       +33     
     Lines         23209    24366     +1157     
     Branches       2262     2366      +104     
   =============================================
   + Hits           9614    14039     +4425     
   + Misses        12754     9124     -3630     
   - Partials        841     1203      +362     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `24.21% <0.00%> (+15.34%)` | `4.00 <0.00> (+3.00)` | |
   | [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `23.52% <0.00%> (+5.01%)` | `1.00 <0.00> (-1.00)` | :arrow_up: |
   | [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `55.55% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `59.61% <0.00%> (ø)` | `6.00 <0.00> (ø)` | |
   | [...iver/envoy/als/mx/MetaExchangeALSHTTPAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L01ldGFFeGNoYW5nZUFMU0hUVFBBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../receiver/envoy/als/mx/ServiceMetaInfoAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L1NlcnZpY2VNZXRhSW5mb0FkYXB0ZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/persistence/LogsPersistence.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvcGVyc2lzdGVuY2UvTG9nc1BlcnNpc3RlbmNlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | ... and [280 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [b1a8238...dbd6ae9](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (3287a8b) into [master](https://codecov.io/gh/apache/skywalking/commit/63bfb8d9ed90319553671b15627fa067db084996?el=desc) (63bfb8d) will **decrease** coverage by `4.72%`.
   > The diff coverage is `19.35%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6322      +/-   ##
   ============================================
   - Coverage     58.16%   53.44%   -4.73%     
   + Complexity     4059     3820     -239     
   ============================================
     Files           984      986       +2     
     Lines         24336    24345       +9     
     Branches       2365     2370       +5     
   ============================================
   - Hits          14155    13010    -1145     
   - Misses         8947    10199    +1252     
   + Partials       1234     1136      -98     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...king/apm/agent/core/remote/GRPCChannelManager.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsTWFuYWdlci5qYXZh) | `48.88% <ø> (ø)` | `12.00 <0.00> (ø)` | |
   | [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `24.21% <0.00%> (-2.23%)` | `4.00 <0.00> (ø)` | |
   | [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `23.52% <0.00%> (+5.01%)` | `1.00 <0.00> (-1.00)` | :arrow_up: |
   | [...lking/oap/server/core/source/EndpointRelation.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0VuZHBvaW50UmVsYXRpb24uamF2YQ==) | `100.00% <ø> (ø)` | `4.00 <0.00> (ø)` | |
   | [...ap/server/core/source/ServiceInstanceRelation.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL1NlcnZpY2VJbnN0YW5jZVJlbGF0aW9uLmphdmE=) | `100.00% <ø> (ø)` | `5.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `55.55% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `59.61% <0.00%> (ø)` | `6.00 <0.00> (ø)` | |
   | ... and [109 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [5289996...8875f7e](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (dbd6ae9) into [master](https://codecov.io/gh/apache/skywalking/commit/b1a8238c159eaebda35771cd7c9c548e5eedfee1?el=desc) (b1a8238) will **increase** coverage by `1.04%`.
   > The diff coverage is `8.23%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6322      +/-   ##
   ============================================
   + Coverage     41.42%   42.46%   +1.04%     
   + Complexity     2959     2452     -507     
   ============================================
     Files           953      805     -148     
     Lines         23209    19671    -3538     
     Branches       2262     1844     -418     
   ============================================
   - Hits           9614     8354    -1260     
   + Misses        12754    10681    -2073     
   + Partials        841      636     -205     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `8.04% <0.00%> (-0.82%)` | `1.00 <0.00> (ø)` | |
   | [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `23.52% <0.00%> (+5.01%)` | `1.00 <0.00> (-1.00)` | :arrow_up: |
   | [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `55.55% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `59.61% <0.00%> (ø)` | `6.00 <0.00> (ø)` | |
   | [...iver/envoy/als/mx/MetaExchangeALSHTTPAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L01ldGFFeGNoYW5nZUFMU0hUVFBBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../receiver/envoy/als/mx/ServiceMetaInfoAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L1NlcnZpY2VNZXRhSW5mb0FkYXB0ZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | ... and [274 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [b1a8238...dbd6ae9](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (b9cf4d4) into [master](https://codecov.io/gh/apache/skywalking/commit/b1a8238c159eaebda35771cd7c9c548e5eedfee1?el=desc) (b1a8238) will **increase** coverage by `5.44%`.
   > The diff coverage is `14.60%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6322      +/-   ##
   ============================================
   + Coverage     41.42%   46.86%   +5.44%     
   + Complexity     2959     2767     -192     
   ============================================
     Files           953     1767     +814     
     Lines         23209    37355   +14146     
     Branches       2262     4303    +2041     
   ============================================
   + Hits           9614    17507    +7893     
   - Misses        12754    18863    +6109     
   - Partials        841      985     +144     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `24.21% <0.00%> (+15.34%)` | `4.00 <0.00> (+3.00)` | |
   | [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `23.52% <0.00%> (+5.01%)` | `1.00 <0.00> (-1.00)` | :arrow_up: |
   | [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `18.51% <0.00%> (-37.04%)` | `2.00 <0.00> (ø)` | |
   | [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `65.71% <0.00%> (+65.71%)` | `0.00 <0.00> (ø)` | |
   | [...iver/envoy/als/mx/MetaExchangeALSHTTPAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L01ldGFFeGNoYW5nZUFMU0hUVFBBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../receiver/envoy/als/mx/ServiceMetaInfoAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L1NlcnZpY2VNZXRhSW5mb0FkYXB0ZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/persistence/LogsPersistence.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvcGVyc2lzdGVuY2UvTG9nc1BlcnNpc3RlbmNlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `31.81% <50.00%> (-61.04%)` | `3.00 <0.00> (ø)` | |
   | [...ver/receiver/envoy/ServiceMetaInfoFactoryImpl.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvU2VydmljZU1ldGFJbmZvRmFjdG9yeUltcGwuamF2YQ==) | `50.00% <50.00%> (ø)` | `2.00 <2.00> (?)` | |
   | ... and [1355 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [b1a8238...dbd6ae9](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (dbd6ae9) into [master](https://codecov.io/gh/apache/skywalking/commit/b1a8238c159eaebda35771cd7c9c548e5eedfee1?el=desc) (b1a8238) will **decrease** coverage by `7.17%`.
   > The diff coverage is `8.23%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6322      +/-   ##
   ============================================
   - Coverage     54.02%   46.85%   -7.18%     
   + Complexity     3785     2805     -980     
   ============================================
     Files           984      835     -149     
     Lines         24286    20559    -3727     
     Branches       2365     1930     -435     
   ============================================
   - Hits          13121     9633    -3488     
   - Misses        10099    10179      +80     
   + Partials       1066      747     -319     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `8.04% <0.00%> (-0.82%)` | `1.00 <0.00> (ø)` | |
   | [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `23.52% <0.00%> (+5.01%)` | `1.00 <0.00> (-1.00)` | :arrow_up: |
   | [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (-90.00%)` | `0.00 <0.00> (-2.00)` | |
   | [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `55.55% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `59.61% <0.00%> (ø)` | `6.00 <0.00> (ø)` | |
   | [...iver/envoy/als/mx/MetaExchangeALSHTTPAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L01ldGFFeGNoYW5nZUFMU0hUVFBBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../receiver/envoy/als/mx/ServiceMetaInfoAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L1NlcnZpY2VNZXRhSW5mb0FkYXB0ZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | ... and [347 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [b1a8238...dbd6ae9](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (b9cf4d4) into [master](https://codecov.io/gh/apache/skywalking/commit/b1a8238c159eaebda35771cd7c9c548e5eedfee1?el=desc) (b1a8238) will **decrease** coverage by `1.05%`.
   > The diff coverage is `21.34%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6322      +/-   ##
   ============================================
   - Coverage     53.20%   52.15%   -1.06%     
   + Complexity     3755     3212     -543     
   ============================================
     Files           984     1777     +793     
     Lines         24276    37689   +13413     
     Branches       2364     4313    +1949     
   ============================================
   + Hits          12915    19655    +6740     
   - Misses        10311    17055    +6744     
   + Partials       1050      979      -71     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `24.21% <0.00%> (+15.34%)` | `4.00 <0.00> (+3.00)` | |
   | [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `23.52% <0.00%> (+5.01%)` | `1.00 <0.00> (-1.00)` | :arrow_up: |
   | [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `18.51% <0.00%> (-37.04%)` | `2.00 <0.00> (ø)` | |
   | [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `65.71% <0.00%> (+65.71%)` | `0.00 <0.00> (ø)` | |
   | [...iver/envoy/als/mx/MetaExchangeALSHTTPAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L01ldGFFeGNoYW5nZUFMU0hUVFBBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../receiver/envoy/als/mx/ServiceMetaInfoAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L1NlcnZpY2VNZXRhSW5mb0FkYXB0ZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/persistence/LogsPersistence.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvcGVyc2lzdGVuY2UvTG9nc1BlcnNpc3RlbmNlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `31.81% <50.00%> (-61.04%)` | `3.00 <0.00> (ø)` | |
   | [...ver/receiver/envoy/ServiceMetaInfoFactoryImpl.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvU2VydmljZU1ldGFJbmZvRmFjdG9yeUltcGwuamF2YQ==) | `50.00% <50.00%> (ø)` | `2.00 <2.00> (?)` | |
   | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `50.00% <50.00%> (+50.00%)` | `0.00 <0.00> (ø)` | |
   | ... and [1257 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [b1a8238...dbd6ae9](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (45dc5d6) into [master](https://codecov.io/gh/apache/skywalking/commit/6bc3ba025f889b0682d651d07f5b8037f41fff9c?el=desc) (6bc3ba0) will **increase** coverage by `17.77%`.
   > The diff coverage is `15.29%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #6322       +/-   ##
   =============================================
   + Coverage     31.05%   48.83%   +17.77%     
   - Complexity     2180     3527     +1347     
   =============================================
     Files           964      985       +21     
     Lines         23384    24239      +855     
     Branches       2263     2344       +81     
   =============================================
   + Hits           7262    11836     +4574     
   + Misses        15570    11419     -4151     
   - Partials        552      984      +432     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `8.04% <0.00%> (-0.82%)` | `1.00 <0.00> (ø)` | |
   | [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `23.52% <0.00%> (+5.01%)` | `1.00 <0.00> (-1.00)` | :arrow_up: |
   | [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `55.55% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `59.61% <0.00%> (ø)` | `6.00 <0.00> (ø)` | |
   | [...iver/envoy/als/mx/MetaExchangeALSHTTPAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L01ldGFFeGNoYW5nZUFMU0hUVFBBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../receiver/envoy/als/mx/ServiceMetaInfoAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L1NlcnZpY2VNZXRhSW5mb0FkYXB0ZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/persistence/LogsPersistence.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvcGVyc2lzdGVuY2UvTG9nc1BlcnNpc3RlbmNlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | ... and [372 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [6bc3ba0...d501f73](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (45c1b75) into [master](https://codecov.io/gh/apache/skywalking/commit/d12d3f201a315241bd7aeb5cc97c2d5103e67c02?el=desc) (d12d3f2) will **decrease** coverage by `3.15%`.
   > The diff coverage is `30.95%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6322      +/-   ##
   ============================================
   - Coverage     53.22%   50.06%   -3.16%     
   + Complexity     3845     3517     -328     
   ============================================
     Files          1731      947     -784     
     Lines         36905    23500   -13405     
     Branches       4076     2295    -1781     
   ============================================
   - Hits          19642    11766    -7876     
   + Misses        16288    10658    -5630     
   - Partials        975     1076     +101     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...erver/core/analysis/data/MergableBufferedData.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9NZXJnYWJsZUJ1ZmZlcmVkRGF0YS5qYXZh) | `76.92% <0.00%> (-7.70%)` | `4.00 <0.00> (ø)` | |
   | [...lysis/manual/networkalias/NetworkAddressAlias.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL25ldHdvcmthbGlhcy9OZXR3b3JrQWRkcmVzc0FsaWFzLmphdmE=) | `2.43% <0.00%> (-56.10%)` | `0.00 <0.00> (-5.00)` | |
   | [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (-56.25%)` | `0.00 <0.00> (ø)` | |
   | [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-12.20%)` | `0.00 <0.00> (ø)` | |
   | [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-62.80%)` | `0.00 <0.00> (ø)` | |
   | [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <0.00%> (-58.14%)` | `0.00 <0.00> (ø)` | |
   | [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-50.00%)` | `0.00 <0.00> (ø)` | |
   | [...oap/server/core/analysis/metrics/CountMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Db3VudE1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (-85.72%)` | `0.00 <0.00> (ø)` | |
   | [...server/core/analysis/metrics/MaxDoubleMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhEb3VibGVNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...p/server/core/analysis/metrics/MaxLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhMb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-87.50%)` | `0.00 <0.00> (ø)` | |
   | ... and [1278 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [1e78a0a...ad99d9b](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (ad99d9b) into [master](https://codecov.io/gh/apache/skywalking/commit/d12d3f201a315241bd7aeb5cc97c2d5103e67c02?el=desc) (d12d3f2) will **decrease** coverage by `13.08%`.
   > The diff coverage is `29.76%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #6322       +/-   ##
   =============================================
   - Coverage     53.22%   40.14%   -13.09%     
   + Complexity     3845     2348     -1497     
   =============================================
     Files          1731      796      -935     
     Lines         36905    19847    -17058     
     Branches       4076     1873     -2203     
   =============================================
   - Hits          19642     7967    -11675     
   + Misses        16288    11281     -5007     
   + Partials        975      599      -376     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...erver/core/analysis/data/MergableBufferedData.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9NZXJnYWJsZUJ1ZmZlcmVkRGF0YS5qYXZh) | `76.92% <0.00%> (-7.70%)` | `4.00 <0.00> (ø)` | |
   | [...lysis/manual/networkalias/NetworkAddressAlias.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL25ldHdvcmthbGlhcy9OZXR3b3JrQWRkcmVzc0FsaWFzLmphdmE=) | `2.43% <0.00%> (-56.10%)` | `0.00 <0.00> (-5.00)` | |
   | [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (-56.25%)` | `0.00 <0.00> (ø)` | |
   | [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-12.20%)` | `0.00 <0.00> (ø)` | |
   | [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-62.80%)` | `0.00 <0.00> (ø)` | |
   | [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <0.00%> (-58.14%)` | `0.00 <0.00> (ø)` | |
   | [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-50.00%)` | `0.00 <0.00> (ø)` | |
   | [...oap/server/core/analysis/metrics/CountMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Db3VudE1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (-85.72%)` | `0.00 <0.00> (ø)` | |
   | [...server/core/analysis/metrics/MaxDoubleMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhEb3VibGVNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...p/server/core/analysis/metrics/MaxLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhMb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-87.50%)` | `0.00 <0.00> (ø)` | |
   | ... and [1383 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [1e78a0a...ad99d9b](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (3287a8b) into [master](https://codecov.io/gh/apache/skywalking/commit/63bfb8d9ed90319553671b15627fa067db084996?el=desc) (63bfb8d) will **decrease** coverage by `2.85%`.
   > The diff coverage is `19.35%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6322      +/-   ##
   ============================================
   - Coverage     58.16%   55.31%   -2.86%     
   + Complexity     4059     3920     -139     
   ============================================
     Files           984      986       +2     
     Lines         24336    24364      +28     
     Branches       2365     2370       +5     
   ============================================
   - Hits          14155    13476     -679     
   - Misses         8947     9713     +766     
   + Partials       1234     1175      -59     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...king/apm/agent/core/remote/GRPCChannelManager.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsTWFuYWdlci5qYXZh) | `48.88% <ø> (ø)` | `12.00 <0.00> (ø)` | |
   | [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `24.21% <0.00%> (-2.23%)` | `4.00 <0.00> (ø)` | |
   | [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `23.52% <0.00%> (+5.01%)` | `1.00 <0.00> (-1.00)` | :arrow_up: |
   | [...lking/oap/server/core/source/EndpointRelation.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0VuZHBvaW50UmVsYXRpb24uamF2YQ==) | `100.00% <ø> (ø)` | `4.00 <0.00> (ø)` | |
   | [...ap/server/core/source/ServiceInstanceRelation.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL1NlcnZpY2VJbnN0YW5jZVJlbGF0aW9uLmphdmE=) | `100.00% <ø> (ø)` | `5.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `55.55% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `59.61% <0.00%> (ø)` | `6.00 <0.00> (ø)` | |
   | ... and [82 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [5289996...8875f7e](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (45c1b75) into [master](https://codecov.io/gh/apache/skywalking/commit/d12d3f201a315241bd7aeb5cc97c2d5103e67c02?el=desc) (d12d3f2) will **increase** coverage by `3.25%`.
   > The diff coverage is `32.14%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6322      +/-   ##
   ============================================
   + Coverage     53.22%   56.48%   +3.25%     
   - Complexity     3845     3850       +5     
   ============================================
     Files          1731      947     -784     
     Lines         36905    23577   -13328     
     Branches       4076     2302    -1774     
   ============================================
   - Hits          19642    13317    -6325     
   + Misses        16288     9092    -7196     
   - Partials        975     1168     +193     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...erver/core/analysis/data/MergableBufferedData.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9NZXJnYWJsZUJ1ZmZlcmVkRGF0YS5qYXZh) | `76.92% <0.00%> (-7.70%)` | `4.00 <0.00> (ø)` | |
   | [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (-56.25%)` | `0.00 <0.00> (ø)` | |
   | [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-12.20%)` | `0.00 <0.00> (ø)` | |
   | [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-62.80%)` | `0.00 <0.00> (ø)` | |
   | [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <0.00%> (-58.14%)` | `0.00 <0.00> (ø)` | |
   | [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-50.00%)` | `0.00 <0.00> (ø)` | |
   | [...oap/server/core/analysis/metrics/CountMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Db3VudE1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (-85.72%)` | `0.00 <0.00> (ø)` | |
   | [...server/core/analysis/metrics/MaxDoubleMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhEb3VibGVNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...p/server/core/analysis/metrics/MaxLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhMb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-87.50%)` | `0.00 <0.00> (ø)` | |
   | [...king/oap/server/core/analysis/metrics/Metrics.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NZXRyaWNzLmphdmE=) | `63.63% <ø> (-27.28%)` | `10.00 <0.00> (ø)` | |
   | ... and [1250 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [1e78a0a...ad99d9b](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (d501f73) into [master](https://codecov.io/gh/apache/skywalking/commit/6bc3ba025f889b0682d651d07f5b8037f41fff9c?el=desc) (6bc3ba0) will **increase** coverage by `10.69%`.
   > The diff coverage is `14.60%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #6322       +/-   ##
   =============================================
   + Coverage     31.05%   41.75%   +10.69%     
   - Complexity     2180     2285      +105     
   =============================================
     Files           964     1767      +803     
     Lines         23384    37338    +13954     
     Branches       2263     4297     +2034     
   =============================================
   + Hits           7262    15589     +8327     
   - Misses        15570    20756     +5186     
   - Partials        552      993      +441     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `7.36% <0.00%> (-1.50%)` | `1.00 <0.00> (ø)` | |
   | [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `23.52% <0.00%> (+5.01%)` | `1.00 <0.00> (-1.00)` | :arrow_up: |
   | [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `18.51% <0.00%> (-37.04%)` | `2.00 <0.00> (ø)` | |
   | [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `65.71% <0.00%> (+65.71%)` | `0.00 <0.00> (ø)` | |
   | [...iver/envoy/als/mx/MetaExchangeALSHTTPAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L01ldGFFeGNoYW5nZUFMU0hUVFBBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../receiver/envoy/als/mx/ServiceMetaInfoAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L1NlcnZpY2VNZXRhSW5mb0FkYXB0ZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/persistence/LogsPersistence.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvcGVyc2lzdGVuY2UvTG9nc1BlcnNpc3RlbmNlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `31.81% <50.00%> (-61.04%)` | `3.00 <0.00> (ø)` | |
   | [...ver/receiver/envoy/ServiceMetaInfoFactoryImpl.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvU2VydmljZU1ldGFJbmZvRmFjdG9yeUltcGwuamF2YQ==) | `50.00% <50.00%> (ø)` | `2.00 <2.00> (?)` | |
   | ... and [1391 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [6bc3ba0...d501f73](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] wu-sheng commented on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773279566






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] kezhenxu94 edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
kezhenxu94 edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773279087


   
   <img width="1792" alt="Screen Shot 2021-02-04 at 20 35 48" src="https://user-images.githubusercontent.com/15965696/106894537-11cf0780-672a-11eb-874d-f9d30c5e0966.png">
   
   <img width="1792" alt="Screen Shot 2021-02-04 at 20 35 33" src="https://user-images.githubusercontent.com/15965696/106894554-1693bb80-672a-11eb-866b-80ebf2ee6ac9.png">
   
   
   @wu-sheng can we discuss what else tags should be extracted?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (5d644ce) into [master](https://codecov.io/gh/apache/skywalking/commit/6bc3ba025f889b0682d651d07f5b8037f41fff9c?el=desc) (6bc3ba0) will **increase** coverage by `22.37%`.
   > The diff coverage is `15.29%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #6322       +/-   ##
   =============================================
   + Coverage     31.05%   53.43%   +22.37%     
   - Complexity     2180     3784     +1604     
   =============================================
     Files           964      986       +22     
     Lines         23384    24348      +964     
     Branches       2263     2350       +87     
   =============================================
   + Hits           7262    13010     +5748     
   + Misses        15570    10219     -5351     
   - Partials        552     1119      +567     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `24.21% <0.00%> (+15.34%)` | `4.00 <0.00> (+3.00)` | |
   | [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `23.52% <0.00%> (+5.01%)` | `1.00 <0.00> (-1.00)` | :arrow_up: |
   | [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `55.55% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `59.61% <0.00%> (ø)` | `6.00 <0.00> (ø)` | |
   | [...iver/envoy/als/mx/MetaExchangeALSHTTPAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L01ldGFFeGNoYW5nZUFMU0hUVFBBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../receiver/envoy/als/mx/ServiceMetaInfoAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L1NlcnZpY2VNZXRhSW5mb0FkYXB0ZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/persistence/LogsPersistence.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvcGVyc2lzdGVuY2UvTG9nc1BlcnNpc3RlbmNlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | ... and [408 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [6bc3ba0...91e7ed7](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (45c1b75) into [master](https://codecov.io/gh/apache/skywalking/commit/d12d3f201a315241bd7aeb5cc97c2d5103e67c02?el=desc) (d12d3f2) will **increase** coverage by `3.59%`.
   > The diff coverage is `39.28%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6322      +/-   ##
   ============================================
   + Coverage     53.22%   56.81%   +3.59%     
   - Complexity     3845     3868      +23     
   ============================================
     Files          1731      947     -784     
     Lines         36905    23577   -13328     
     Branches       4076     2302    -1774     
   ============================================
   - Hits          19642    13396    -6246     
   + Misses        16288     9015    -7273     
   - Partials        975     1166     +191     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...erver/core/analysis/data/MergableBufferedData.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9NZXJnYWJsZUJ1ZmZlcmVkRGF0YS5qYXZh) | `76.92% <0.00%> (-7.70%)` | `4.00 <0.00> (ø)` | |
   | [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (-56.25%)` | `0.00 <0.00> (ø)` | |
   | [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-12.20%)` | `0.00 <0.00> (ø)` | |
   | [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-62.80%)` | `0.00 <0.00> (ø)` | |
   | [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <0.00%> (-58.14%)` | `0.00 <0.00> (ø)` | |
   | [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-50.00%)` | `0.00 <0.00> (ø)` | |
   | [...oap/server/core/analysis/metrics/CountMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Db3VudE1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (-85.72%)` | `0.00 <0.00> (ø)` | |
   | [...server/core/analysis/metrics/MaxDoubleMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhEb3VibGVNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...p/server/core/analysis/metrics/MaxLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhMb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-87.50%)` | `0.00 <0.00> (ø)` | |
   | [...king/oap/server/core/analysis/metrics/Metrics.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NZXRyaWNzLmphdmE=) | `63.63% <ø> (-27.28%)` | `10.00 <0.00> (ø)` | |
   | ... and [1246 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [1e78a0a...ad99d9b](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (45dc5d6) into [master](https://codecov.io/gh/apache/skywalking/commit/6bc3ba025f889b0682d651d07f5b8037f41fff9c?el=desc) (6bc3ba0) will **increase** coverage by `21.01%`.
   > The diff coverage is `15.29%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #6322       +/-   ##
   =============================================
   + Coverage     31.05%   52.06%   +21.01%     
   - Complexity     2180     3752     +1572     
   =============================================
     Files           964      986       +22     
     Lines         23384    24302      +918     
     Branches       2263     2349       +86     
   =============================================
   + Hits           7262    12653     +5391     
   + Misses        15570    10572     -4998     
   - Partials        552     1077      +525     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `8.04% <0.00%> (-0.82%)` | `1.00 <0.00> (ø)` | |
   | [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `23.52% <0.00%> (+5.01%)` | `1.00 <0.00> (-1.00)` | :arrow_up: |
   | [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `55.55% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `59.61% <0.00%> (ø)` | `6.00 <0.00> (ø)` | |
   | [...iver/envoy/als/mx/MetaExchangeALSHTTPAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L01ldGFFeGNoYW5nZUFMU0hUVFBBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../receiver/envoy/als/mx/ServiceMetaInfoAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L1NlcnZpY2VNZXRhSW5mb0FkYXB0ZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/persistence/LogsPersistence.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvcGVyc2lzdGVuY2UvTG9nc1BlcnNpc3RlbmNlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | ... and [424 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [6bc3ba0...d501f73](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (5d644ce) into [master](https://codecov.io/gh/apache/skywalking/commit/6bc3ba025f889b0682d651d07f5b8037f41fff9c?el=desc) (6bc3ba0) will **increase** coverage by `18.62%`.
   > The diff coverage is `8.23%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #6322       +/-   ##
   =============================================
   + Coverage     31.05%   49.68%   +18.62%     
   - Complexity     2180     3549     +1369     
   =============================================
     Files           964      985       +21     
     Lines         23384    24161      +777     
     Branches       2263     2332       +69     
   =============================================
   + Hits           7262    12004     +4742     
   + Misses        15570    11112     -4458     
   - Partials        552     1045      +493     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `24.21% <0.00%> (+15.34%)` | `4.00 <0.00> (+3.00)` | |
   | [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `23.52% <0.00%> (+5.01%)` | `1.00 <0.00> (-1.00)` | :arrow_up: |
   | [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `55.55% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `59.61% <0.00%> (ø)` | `6.00 <0.00> (ø)` | |
   | [...iver/envoy/als/mx/MetaExchangeALSHTTPAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L01ldGFFeGNoYW5nZUFMU0hUVFBBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../receiver/envoy/als/mx/ServiceMetaInfoAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L1NlcnZpY2VNZXRhSW5mb0FkYXB0ZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | ... and [351 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [6bc3ba0...91e7ed7](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (45dc5d6) into [master](https://codecov.io/gh/apache/skywalking/commit/6bc3ba025f889b0682d651d07f5b8037f41fff9c?el=desc) (6bc3ba0) will **increase** coverage by `8.57%`.
   > The diff coverage is `15.29%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6322      +/-   ##
   ============================================
   + Coverage     31.05%   39.63%   +8.57%     
   - Complexity     2180     2324     +144     
   ============================================
     Files           964      805     -159     
     Lines         23384    19815    -3569     
     Branches       2263     1857     -406     
   ============================================
   + Hits           7262     7853     +591     
   + Misses        15570    11390    -4180     
   - Partials        552      572      +20     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `8.04% <0.00%> (-0.82%)` | `1.00 <0.00> (ø)` | |
   | [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `23.52% <0.00%> (+5.01%)` | `1.00 <0.00> (-1.00)` | :arrow_up: |
   | [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `55.55% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `59.61% <0.00%> (ø)` | `6.00 <0.00> (ø)` | |
   | [...iver/envoy/als/mx/MetaExchangeALSHTTPAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L01ldGFFeGNoYW5nZUFMU0hUVFBBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../receiver/envoy/als/mx/ServiceMetaInfoAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L1NlcnZpY2VNZXRhSW5mb0FkYXB0ZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/persistence/LogsPersistence.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvcGVyc2lzdGVuY2UvTG9nc1BlcnNpc3RlbmNlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | ... and [246 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [6bc3ba0...d501f73](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (dbd6ae9) into [master](https://codecov.io/gh/apache/skywalking/commit/b1a8238c159eaebda35771cd7c9c548e5eedfee1?el=desc) (b1a8238) will **increase** coverage by `0.35%`.
   > The diff coverage is `8.23%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6322      +/-   ##
   ============================================
   + Coverage     41.42%   41.77%   +0.35%     
   + Complexity     2959     2416     -543     
   ============================================
     Files           953      805     -148     
     Lines         23209    19671    -3538     
     Branches       2262     1844     -418     
   ============================================
   - Hits           9614     8218    -1396     
   + Misses        12754    10825    -1929     
   + Partials        841      628     -213     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `8.04% <0.00%> (-0.82%)` | `1.00 <0.00> (ø)` | |
   | [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `23.52% <0.00%> (+5.01%)` | `1.00 <0.00> (-1.00)` | :arrow_up: |
   | [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `55.55% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `59.61% <0.00%> (ø)` | `6.00 <0.00> (ø)` | |
   | [...iver/envoy/als/mx/MetaExchangeALSHTTPAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L01ldGFFeGNoYW5nZUFMU0hUVFBBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../receiver/envoy/als/mx/ServiceMetaInfoAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L1NlcnZpY2VNZXRhSW5mb0FkYXB0ZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | ... and [263 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [b1a8238...dbd6ae9](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (b9cf4d4) into [master](https://codecov.io/gh/apache/skywalking/commit/b1a8238c159eaebda35771cd7c9c548e5eedfee1?el=desc) (b1a8238) will **increase** coverage by `2.37%`.
   > The diff coverage is `14.60%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6322      +/-   ##
   ============================================
   + Coverage     49.16%   51.54%   +2.37%     
   + Complexity     3505     3108     -397     
   ============================================
     Files           984     1777     +793     
     Lines         24141    37687   +13546     
     Branches       2351     4313    +1962     
   ============================================
   + Hits          11870    19427    +7557     
   - Misses        11272    17279    +6007     
   + Partials        999      981      -18     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `24.21% <0.00%> (+15.34%)` | `4.00 <0.00> (+3.00)` | |
   | [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `23.52% <0.00%> (+5.01%)` | `1.00 <0.00> (-1.00)` | :arrow_up: |
   | [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `18.51% <0.00%> (-37.04%)` | `2.00 <0.00> (ø)` | |
   | [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `65.71% <0.00%> (+65.71%)` | `0.00 <0.00> (ø)` | |
   | [...iver/envoy/als/mx/MetaExchangeALSHTTPAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L01ldGFFeGNoYW5nZUFMU0hUVFBBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../receiver/envoy/als/mx/ServiceMetaInfoAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L1NlcnZpY2VNZXRhSW5mb0FkYXB0ZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/persistence/LogsPersistence.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvcGVyc2lzdGVuY2UvTG9nc1BlcnNpc3RlbmNlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `31.81% <50.00%> (-61.04%)` | `3.00 <0.00> (ø)` | |
   | [...ver/receiver/envoy/ServiceMetaInfoFactoryImpl.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvU2VydmljZU1ldGFJbmZvRmFjdG9yeUltcGwuamF2YQ==) | `50.00% <50.00%> (ø)` | `2.00 <2.00> (?)` | |
   | ... and [1274 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [b1a8238...dbd6ae9](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (45c1b75) into [master](https://codecov.io/gh/apache/skywalking/commit/d12d3f201a315241bd7aeb5cc97c2d5103e67c02?el=desc) (d12d3f2) will **decrease** coverage by `8.85%`.
   > The diff coverage is `29.76%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6322      +/-   ##
   ============================================
   - Coverage     53.22%   44.36%   -8.86%     
   + Complexity     3845     3153     -692     
   ============================================
     Files          1731      947     -784     
     Lines         36905    23350   -13555     
     Branches       4076     2250    -1826     
   ============================================
   - Hits          19642    10359    -9283     
   + Misses        16288    12067    -4221     
   + Partials        975      924      -51     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...erver/core/analysis/data/MergableBufferedData.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9NZXJnYWJsZUJ1ZmZlcmVkRGF0YS5qYXZh) | `76.92% <0.00%> (-7.70%)` | `4.00 <0.00> (ø)` | |
   | [...lysis/manual/networkalias/NetworkAddressAlias.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL25ldHdvcmthbGlhcy9OZXR3b3JrQWRkcmVzc0FsaWFzLmphdmE=) | `2.43% <0.00%> (-56.10%)` | `0.00 <0.00> (-5.00)` | |
   | [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (-56.25%)` | `0.00 <0.00> (ø)` | |
   | [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-12.20%)` | `0.00 <0.00> (ø)` | |
   | [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-62.80%)` | `0.00 <0.00> (ø)` | |
   | [...r/function/avg/AvgHistogramPercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbVBlcmNlbnRpbGVGdW5jdGlvbi5qYXZh) | `0.00% <0.00%> (-62.12%)` | `0.00 <0.00> (-25.00)` | |
   | [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <0.00%> (-58.14%)` | `0.00 <0.00> (ø)` | |
   | [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-50.00%)` | `0.00 <0.00> (ø)` | |
   | [...oap/server/core/analysis/metrics/CountMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Db3VudE1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (-85.72%)` | `0.00 <0.00> (ø)` | |
   | [...server/core/analysis/metrics/MaxDoubleMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhEb3VibGVNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | ... and [1306 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [1e78a0a...ad99d9b](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (5d644ce) into [master](https://codecov.io/gh/apache/skywalking/commit/6bc3ba025f889b0682d651d07f5b8037f41fff9c?el=desc) (6bc3ba0) will **increase** coverage by `24.75%`.
   > The diff coverage is `15.29%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #6322       +/-   ##
   =============================================
   + Coverage     31.05%   55.80%   +24.75%     
   - Complexity     2180     3959     +1779     
   =============================================
     Files           964      986       +22     
     Lines         23384    24366      +982     
     Branches       2263     2351       +88     
   =============================================
   + Hits           7262    13598     +6336     
   + Misses        15570     9571     -5999     
   - Partials        552     1197      +645     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `24.21% <0.00%> (+15.34%)` | `4.00 <0.00> (+3.00)` | |
   | [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `23.52% <0.00%> (+5.01%)` | `1.00 <0.00> (-1.00)` | :arrow_up: |
   | [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `55.55% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `59.61% <0.00%> (ø)` | `6.00 <0.00> (ø)` | |
   | [...iver/envoy/als/mx/MetaExchangeALSHTTPAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L01ldGFFeGNoYW5nZUFMU0hUVFBBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../receiver/envoy/als/mx/ServiceMetaInfoAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L1NlcnZpY2VNZXRhSW5mb0FkYXB0ZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/persistence/LogsPersistence.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvcGVyc2lzdGVuY2UvTG9nc1BlcnNpc3RlbmNlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | ... and [450 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [6bc3ba0...91e7ed7](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (45dc5d6) into [master](https://codecov.io/gh/apache/skywalking/commit/6bc3ba025f889b0682d651d07f5b8037f41fff9c?el=desc) (6bc3ba0) will **increase** coverage by `24.74%`.
   > The diff coverage is `15.29%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #6322       +/-   ##
   =============================================
   + Coverage     31.05%   55.80%   +24.74%     
   - Complexity     2180     3943     +1763     
   =============================================
     Files           964      986       +22     
     Lines         23384    24371      +987     
     Branches       2263     2370      +107     
   =============================================
   + Hits           7262    13600     +6338     
   + Misses        15570     9624     -5946     
   - Partials        552     1147      +595     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `24.21% <0.00%> (+15.34%)` | `4.00 <0.00> (+3.00)` | |
   | [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `23.52% <0.00%> (+5.01%)` | `1.00 <0.00> (-1.00)` | :arrow_up: |
   | [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `55.55% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `59.61% <0.00%> (ø)` | `6.00 <0.00> (ø)` | |
   | [...iver/envoy/als/mx/MetaExchangeALSHTTPAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L01ldGFFeGNoYW5nZUFMU0hUVFBBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../receiver/envoy/als/mx/ServiceMetaInfoAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L1NlcnZpY2VNZXRhSW5mb0FkYXB0ZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/persistence/LogsPersistence.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvcGVyc2lzdGVuY2UvTG9nc1BlcnNpc3RlbmNlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | ... and [460 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [6bc3ba0...d501f73](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (8190912) into [master](https://codecov.io/gh/apache/skywalking/commit/b1a8238c159eaebda35771cd7c9c548e5eedfee1?el=desc) (b1a8238) will **increase** coverage by `16.14%`.
   > The diff coverage is `15.29%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #6322       +/-   ##
   =============================================
   + Coverage     41.42%   57.57%   +16.14%     
   - Complexity     2959     4015     +1056     
   =============================================
     Files           953      986       +33     
     Lines         23209    24366     +1157     
     Branches       2262     2366      +104     
   =============================================
   + Hits           9614    14028     +4414     
   + Misses        12754     9135     -3619     
   - Partials        841     1203      +362     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `24.21% <0.00%> (+15.34%)` | `4.00 <0.00> (+3.00)` | |
   | [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `23.52% <0.00%> (+5.01%)` | `1.00 <0.00> (-1.00)` | :arrow_up: |
   | [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `55.55% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `59.61% <0.00%> (ø)` | `6.00 <0.00> (ø)` | |
   | [...iver/envoy/als/mx/MetaExchangeALSHTTPAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L01ldGFFeGNoYW5nZUFMU0hUVFBBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../receiver/envoy/als/mx/ServiceMetaInfoAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L1NlcnZpY2VNZXRhSW5mb0FkYXB0ZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/persistence/LogsPersistence.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvcGVyc2lzdGVuY2UvTG9nc1BlcnNpc3RlbmNlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | ... and [280 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [b1a8238...dbd6ae9](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (b9cf4d4) into [master](https://codecov.io/gh/apache/skywalking/commit/b1a8238c159eaebda35771cd7c9c548e5eedfee1?el=desc) (b1a8238) will **decrease** coverage by `0.76%`.
   > The diff coverage is `21.34%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6322      +/-   ##
   ============================================
   - Coverage     53.20%   52.43%   -0.77%     
   + Complexity     3755     3282     -473     
   ============================================
     Files           984     1777     +793     
     Lines         24276    37757   +13481     
     Branches       2364     4321    +1957     
   ============================================
   + Hits          12915    19797    +6882     
   - Misses        10311    16976    +6665     
   + Partials       1050      984      -66     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `24.21% <0.00%> (+15.34%)` | `4.00 <0.00> (+3.00)` | |
   | [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `23.52% <0.00%> (+5.01%)` | `1.00 <0.00> (-1.00)` | :arrow_up: |
   | [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `18.51% <0.00%> (-37.04%)` | `2.00 <0.00> (ø)` | |
   | [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `65.71% <0.00%> (+65.71%)` | `0.00 <0.00> (ø)` | |
   | [...iver/envoy/als/mx/MetaExchangeALSHTTPAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L01ldGFFeGNoYW5nZUFMU0hUVFBBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../receiver/envoy/als/mx/ServiceMetaInfoAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L1NlcnZpY2VNZXRhSW5mb0FkYXB0ZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/persistence/LogsPersistence.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvcGVyc2lzdGVuY2UvTG9nc1BlcnNpc3RlbmNlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `31.81% <50.00%> (-61.04%)` | `3.00 <0.00> (ø)` | |
   | [...ver/receiver/envoy/ServiceMetaInfoFactoryImpl.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvU2VydmljZU1ldGFJbmZvRmFjdG9yeUltcGwuamF2YQ==) | `50.00% <50.00%> (ø)` | `2.00 <2.00> (?)` | |
   | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `50.00% <50.00%> (+50.00%)` | `0.00 <0.00> (ø)` | |
   | ... and [1250 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [b1a8238...dbd6ae9](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (b9cf4d4) into [master](https://codecov.io/gh/apache/skywalking/commit/b1a8238c159eaebda35771cd7c9c548e5eedfee1?el=desc) (b1a8238) will **increase** coverage by `8.52%`.
   > The diff coverage is `14.60%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6322      +/-   ##
   ============================================
   + Coverage     41.42%   49.94%   +8.52%     
   - Complexity     2959     2995      +36     
   ============================================
     Files           953     1777     +824     
     Lines         23209    37687   +14478     
     Branches       2262     4313    +2051     
   ============================================
   + Hits           9614    18823    +9209     
   - Misses        12754    17881    +5127     
   - Partials        841      983     +142     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `24.21% <0.00%> (+15.34%)` | `4.00 <0.00> (+3.00)` | |
   | [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `23.52% <0.00%> (+5.01%)` | `1.00 <0.00> (-1.00)` | :arrow_up: |
   | [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `18.51% <0.00%> (-37.04%)` | `2.00 <0.00> (ø)` | |
   | [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `65.71% <0.00%> (+65.71%)` | `0.00 <0.00> (ø)` | |
   | [...iver/envoy/als/mx/MetaExchangeALSHTTPAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L01ldGFFeGNoYW5nZUFMU0hUVFBBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../receiver/envoy/als/mx/ServiceMetaInfoAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L1NlcnZpY2VNZXRhSW5mb0FkYXB0ZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/persistence/LogsPersistence.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvcGVyc2lzdGVuY2UvTG9nc1BlcnNpc3RlbmNlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `31.81% <50.00%> (-61.04%)` | `3.00 <0.00> (ø)` | |
   | [...ver/receiver/envoy/ServiceMetaInfoFactoryImpl.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvU2VydmljZU1ldGFJbmZvRmFjdG9yeUltcGwuamF2YQ==) | `50.00% <50.00%> (ø)` | `2.00 <2.00> (?)` | |
   | ... and [1324 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [b1a8238...dbd6ae9](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (b9cf4d4) into [master](https://codecov.io/gh/apache/skywalking/commit/b1a8238c159eaebda35771cd7c9c548e5eedfee1?el=desc) (b1a8238) will **increase** coverage by `8.44%`.
   > The diff coverage is `14.60%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6322      +/-   ##
   ============================================
   + Coverage     41.42%   49.86%   +8.44%     
   - Complexity     2959     2992      +33     
   ============================================
     Files           953     1777     +824     
     Lines         23209    37687   +14478     
     Branches       2262     4313    +2051     
   ============================================
   + Hits           9614    18794    +9180     
   - Misses        12754    17910    +5156     
   - Partials        841      983     +142     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `24.21% <0.00%> (+15.34%)` | `4.00 <0.00> (+3.00)` | |
   | [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `23.52% <0.00%> (+5.01%)` | `1.00 <0.00> (-1.00)` | :arrow_up: |
   | [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `18.51% <0.00%> (-37.04%)` | `2.00 <0.00> (ø)` | |
   | [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `65.71% <0.00%> (+65.71%)` | `0.00 <0.00> (ø)` | |
   | [...iver/envoy/als/mx/MetaExchangeALSHTTPAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L01ldGFFeGNoYW5nZUFMU0hUVFBBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../receiver/envoy/als/mx/ServiceMetaInfoAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L1NlcnZpY2VNZXRhSW5mb0FkYXB0ZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/persistence/LogsPersistence.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvcGVyc2lzdGVuY2UvTG9nc1BlcnNpc3RlbmNlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `31.81% <50.00%> (-61.04%)` | `3.00 <0.00> (ø)` | |
   | [...ver/receiver/envoy/ServiceMetaInfoFactoryImpl.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvU2VydmljZU1ldGFJbmZvRmFjdG9yeUltcGwuamF2YQ==) | `50.00% <50.00%> (ø)` | `2.00 <2.00> (?)` | |
   | ... and [1324 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [b1a8238...dbd6ae9](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (5d644ce) into [master](https://codecov.io/gh/apache/skywalking/commit/6bc3ba025f889b0682d651d07f5b8037f41fff9c?el=desc) (6bc3ba0) will **increase** coverage by `14.80%`.
   > The diff coverage is `8.23%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #6322       +/-   ##
   =============================================
   + Coverage     31.05%   45.86%   +14.80%     
   - Complexity     2180     3361     +1181     
   =============================================
     Files           964      985       +21     
     Lines         23384    24106      +722     
     Branches       2263     2330       +67     
   =============================================
   + Hits           7262    11056     +3794     
   + Misses        15570    12115     -3455     
   - Partials        552      935      +383     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `8.04% <0.00%> (-0.82%)` | `1.00 <0.00> (ø)` | |
   | [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `23.52% <0.00%> (+5.01%)` | `1.00 <0.00> (-1.00)` | :arrow_up: |
   | [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `55.55% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `59.61% <0.00%> (ø)` | `6.00 <0.00> (ø)` | |
   | [...iver/envoy/als/mx/MetaExchangeALSHTTPAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L01ldGFFeGNoYW5nZUFMU0hUVFBBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../receiver/envoy/als/mx/ServiceMetaInfoAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L1NlcnZpY2VNZXRhSW5mb0FkYXB0ZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | ... and [323 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [6bc3ba0...91e7ed7](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (b9cf4d4) into [master](https://codecov.io/gh/apache/skywalking/commit/b1a8238c159eaebda35771cd7c9c548e5eedfee1?el=desc) (b1a8238) will **increase** coverage by `9.32%`.
   > The diff coverage is `14.60%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6322      +/-   ##
   ============================================
   + Coverage     41.42%   50.74%   +9.32%     
   - Complexity     2959     3060     +101     
   ============================================
     Files           953     1777     +824     
     Lines         23209    37687   +14478     
     Branches       2262     4313    +2051     
   ============================================
   + Hits           9614    19124    +9510     
   - Misses        12754    17581    +4827     
   - Partials        841      982     +141     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `24.21% <0.00%> (+15.34%)` | `4.00 <0.00> (+3.00)` | |
   | [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `23.52% <0.00%> (+5.01%)` | `1.00 <0.00> (-1.00)` | :arrow_up: |
   | [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `18.51% <0.00%> (-37.04%)` | `2.00 <0.00> (ø)` | |
   | [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `65.71% <0.00%> (+65.71%)` | `0.00 <0.00> (ø)` | |
   | [...iver/envoy/als/mx/MetaExchangeALSHTTPAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L01ldGFFeGNoYW5nZUFMU0hUVFBBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../receiver/envoy/als/mx/ServiceMetaInfoAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L1NlcnZpY2VNZXRhSW5mb0FkYXB0ZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/persistence/LogsPersistence.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvcGVyc2lzdGVuY2UvTG9nc1BlcnNpc3RlbmNlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `31.81% <50.00%> (-61.04%)` | `3.00 <0.00> (ø)` | |
   | [...ver/receiver/envoy/ServiceMetaInfoFactoryImpl.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvU2VydmljZU1ldGFJbmZvRmFjdG9yeUltcGwuamF2YQ==) | `50.00% <50.00%> (ø)` | `2.00 <2.00> (?)` | |
   | ... and [1335 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [b1a8238...dbd6ae9](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (d501f73) into [master](https://codecov.io/gh/apache/skywalking/commit/6bc3ba025f889b0682d651d07f5b8037f41fff9c?el=desc) (6bc3ba0) will **increase** coverage by `16.22%`.
   > The diff coverage is `14.60%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #6322       +/-   ##
   =============================================
   + Coverage     31.05%   47.27%   +16.22%     
   - Complexity     2180     2757      +577     
   =============================================
     Files           964     1777      +813     
     Lines         23384    37670    +14286     
     Branches       2263     4307     +2044     
   =============================================
   + Hits           7262    17810    +10548     
   - Misses        15570    18872     +3302     
   - Partials        552      988      +436     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `7.36% <0.00%> (-1.50%)` | `1.00 <0.00> (ø)` | |
   | [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `23.52% <0.00%> (+5.01%)` | `1.00 <0.00> (-1.00)` | :arrow_up: |
   | [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `18.51% <0.00%> (-37.04%)` | `2.00 <0.00> (ø)` | |
   | [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `65.71% <0.00%> (+65.71%)` | `0.00 <0.00> (ø)` | |
   | [...iver/envoy/als/mx/MetaExchangeALSHTTPAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L01ldGFFeGNoYW5nZUFMU0hUVFBBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../receiver/envoy/als/mx/ServiceMetaInfoAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L1NlcnZpY2VNZXRhSW5mb0FkYXB0ZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/persistence/LogsPersistence.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvcGVyc2lzdGVuY2UvTG9nc1BlcnNpc3RlbmNlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `31.81% <50.00%> (-61.04%)` | `3.00 <0.00> (ø)` | |
   | [...ver/receiver/envoy/ServiceMetaInfoFactoryImpl.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvU2VydmljZU1ldGFJbmZvRmFjdG9yeUltcGwuamF2YQ==) | `50.00% <50.00%> (ø)` | `2.00 <2.00> (?)` | |
   | ... and [1354 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [6bc3ba0...d501f73](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (b9cf4d4) into [master](https://codecov.io/gh/apache/skywalking/commit/b1a8238c159eaebda35771cd7c9c548e5eedfee1?el=desc) (b1a8238) will **increase** coverage by `0.53%`.
   > The diff coverage is `8.23%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6322      +/-   ##
   ============================================
   + Coverage     41.42%   41.95%   +0.53%     
   + Complexity     2959     2415     -544     
   ============================================
     Files           953      805     -148     
     Lines         23209    19607    -3602     
     Branches       2262     1819     -443     
   ============================================
   - Hits           9614     8226    -1388     
   + Misses        12754    10769    -1985     
   + Partials        841      612     -229     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `24.21% <0.00%> (+15.34%)` | `4.00 <0.00> (+3.00)` | |
   | [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `23.52% <0.00%> (+5.01%)` | `1.00 <0.00> (-1.00)` | :arrow_up: |
   | [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `55.55% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `59.61% <0.00%> (ø)` | `6.00 <0.00> (ø)` | |
   | [...iver/envoy/als/mx/MetaExchangeALSHTTPAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L01ldGFFeGNoYW5nZUFMU0hUVFBBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../receiver/envoy/als/mx/ServiceMetaInfoAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L1NlcnZpY2VNZXRhSW5mb0FkYXB0ZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | ... and [351 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [b1a8238...dbd6ae9](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (8190912) into [master](https://codecov.io/gh/apache/skywalking/commit/b1a8238c159eaebda35771cd7c9c548e5eedfee1?el=desc) (b1a8238) will **increase** coverage by `6.79%`.
   > The diff coverage is `8.23%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6322      +/-   ##
   ============================================
   + Coverage     41.42%   48.22%   +6.79%     
   - Complexity     2959     3525     +566     
   ============================================
     Files           953      986      +33     
     Lines         23209    24191     +982     
     Branches       2262     2356      +94     
   ============================================
   + Hits           9614    11665    +2051     
   + Misses        12754    11522    -1232     
   - Partials        841     1004     +163     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `8.04% <0.00%> (-0.82%)` | `1.00 <0.00> (ø)` | |
   | [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `23.52% <0.00%> (+5.01%)` | `1.00 <0.00> (-1.00)` | :arrow_up: |
   | [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `53.33% <0.00%> (+53.33%)` | `1.00 <0.00> (+1.00)` | |
   | [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `55.55% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `59.61% <0.00%> (ø)` | `6.00 <0.00> (ø)` | |
   | [...iver/envoy/als/mx/MetaExchangeALSHTTPAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L01ldGFFeGNoYW5nZUFMU0hUVFBBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../receiver/envoy/als/mx/ServiceMetaInfoAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L1NlcnZpY2VNZXRhSW5mb0FkYXB0ZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | ... and [220 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [b1a8238...dbd6ae9](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (4aa0aa8) into [master](https://codecov.io/gh/apache/skywalking/commit/b1a8238c159eaebda35771cd7c9c548e5eedfee1?el=desc) (b1a8238) will **decrease** coverage by `3.84%`.
   > The diff coverage is `8.23%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6322      +/-   ##
   ============================================
   - Coverage     41.42%   37.58%   -3.85%     
   + Complexity     2959     2334     -625     
   ============================================
     Files           953      835     -118     
     Lines         23209    20540    -2669     
     Branches       2262     1929     -333     
   ============================================
   - Hits           9614     7719    -1895     
   + Misses        12754    12221     -533     
   + Partials        841      600     -241     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `8.04% <0.00%> (-0.82%)` | `1.00 <0.00> (ø)` | |
   | [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `23.52% <0.00%> (+5.01%)` | `1.00 <0.00> (-1.00)` | :arrow_up: |
   | [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `55.55% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `59.61% <0.00%> (ø)` | `6.00 <0.00> (ø)` | |
   | [...iver/envoy/als/mx/MetaExchangeALSHTTPAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L01ldGFFeGNoYW5nZUFMU0hUVFBBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../receiver/envoy/als/mx/ServiceMetaInfoAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L1NlcnZpY2VNZXRhSW5mb0FkYXB0ZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | ... and [327 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [b1a8238...dbd6ae9](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (91e7ed7) into [master](https://codecov.io/gh/apache/skywalking/commit/6bc3ba025f889b0682d651d07f5b8037f41fff9c?el=desc) (6bc3ba0) will **increase** coverage by `16.35%`.
   > The diff coverage is `8.23%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #6322       +/-   ##
   =============================================
   + Coverage     31.05%   47.41%   +16.35%     
   - Complexity     2180     3414     +1234     
   =============================================
     Files           964      986       +22     
     Lines         23384    24151      +767     
     Branches       2263     2354       +91     
   =============================================
   + Hits           7262    11451     +4189     
   + Misses        15570    11722     -3848     
   - Partials        552      978      +426     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `8.04% <0.00%> (-0.82%)` | `1.00 <0.00> (ø)` | |
   | [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `23.52% <0.00%> (+5.01%)` | `1.00 <0.00> (-1.00)` | :arrow_up: |
   | [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `55.55% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `59.61% <0.00%> (ø)` | `6.00 <0.00> (ø)` | |
   | [...iver/envoy/als/mx/MetaExchangeALSHTTPAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L01ldGFFeGNoYW5nZUFMU0hUVFBBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../receiver/envoy/als/mx/ServiceMetaInfoAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L1NlcnZpY2VNZXRhSW5mb0FkYXB0ZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | ... and [333 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [6bc3ba0...91e7ed7](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (d501f73) into [master](https://codecov.io/gh/apache/skywalking/commit/6bc3ba025f889b0682d651d07f5b8037f41fff9c?el=desc) (6bc3ba0) will **increase** coverage by `16.70%`.
   > The diff coverage is `14.60%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #6322       +/-   ##
   =============================================
   + Coverage     31.05%   47.76%   +16.70%     
   - Complexity     2180     2803      +623     
   =============================================
     Files           964     1777      +813     
     Lines         23384    37670    +14286     
     Branches       2263     4307     +2044     
   =============================================
   + Hits           7262    17993    +10731     
   - Misses        15570    18690     +3120     
   - Partials        552      987      +435     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `7.36% <0.00%> (-1.50%)` | `1.00 <0.00> (ø)` | |
   | [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `23.52% <0.00%> (+5.01%)` | `1.00 <0.00> (-1.00)` | :arrow_up: |
   | [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `18.51% <0.00%> (-37.04%)` | `2.00 <0.00> (ø)` | |
   | [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `65.71% <0.00%> (+65.71%)` | `0.00 <0.00> (ø)` | |
   | [...iver/envoy/als/mx/MetaExchangeALSHTTPAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L01ldGFFeGNoYW5nZUFMU0hUVFBBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../receiver/envoy/als/mx/ServiceMetaInfoAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L1NlcnZpY2VNZXRhSW5mb0FkYXB0ZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/persistence/LogsPersistence.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvcGVyc2lzdGVuY2UvTG9nc1BlcnNpc3RlbmNlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `31.81% <50.00%> (-61.04%)` | `3.00 <0.00> (ø)` | |
   | [...ver/receiver/envoy/ServiceMetaInfoFactoryImpl.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvU2VydmljZU1ldGFJbmZvRmFjdG9yeUltcGwuamF2YQ==) | `50.00% <50.00%> (ø)` | `2.00 <2.00> (?)` | |
   | ... and [1361 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [6bc3ba0...d501f73](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (5d644ce) into [master](https://codecov.io/gh/apache/skywalking/commit/6bc3ba025f889b0682d651d07f5b8037f41fff9c?el=desc) (6bc3ba0) will **increase** coverage by `24.62%`.
   > The diff coverage is `15.29%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #6322       +/-   ##
   =============================================
   + Coverage     31.05%   55.67%   +24.62%     
   - Complexity     2180     3951     +1771     
   =============================================
     Files           964      986       +22     
     Lines         23384    24366      +982     
     Branches       2263     2351       +88     
   =============================================
   + Hits           7262    13566     +6304     
   + Misses        15570     9603     -5967     
   - Partials        552     1197      +645     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `24.21% <0.00%> (+15.34%)` | `4.00 <0.00> (+3.00)` | |
   | [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `23.52% <0.00%> (+5.01%)` | `1.00 <0.00> (-1.00)` | :arrow_up: |
   | [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `55.55% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `59.61% <0.00%> (ø)` | `6.00 <0.00> (ø)` | |
   | [...iver/envoy/als/mx/MetaExchangeALSHTTPAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L01ldGFFeGNoYW5nZUFMU0hUVFBBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../receiver/envoy/als/mx/ServiceMetaInfoAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L1NlcnZpY2VNZXRhSW5mb0FkYXB0ZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/persistence/LogsPersistence.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvcGVyc2lzdGVuY2UvTG9nc1BlcnNpc3RlbmNlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | ... and [447 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [6bc3ba0...91e7ed7](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (45c1b75) into [master](https://codecov.io/gh/apache/skywalking/commit/d12d3f201a315241bd7aeb5cc97c2d5103e67c02?el=desc) (d12d3f2) will **increase** coverage by `2.19%`.
   > The diff coverage is `32.14%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6322      +/-   ##
   ============================================
   + Coverage     53.22%   55.42%   +2.19%     
   + Complexity     3845     3777      -68     
   ============================================
     Files          1731      947     -784     
     Lines         36905    23549   -13356     
     Branches       4076     2297    -1779     
   ============================================
   - Hits          19642    13051    -6591     
   + Misses        16288     9350    -6938     
   - Partials        975     1148     +173     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...erver/core/analysis/data/MergableBufferedData.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9NZXJnYWJsZUJ1ZmZlcmVkRGF0YS5qYXZh) | `76.92% <0.00%> (-7.70%)` | `4.00 <0.00> (ø)` | |
   | [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (-56.25%)` | `0.00 <0.00> (ø)` | |
   | [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-12.20%)` | `0.00 <0.00> (ø)` | |
   | [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-62.80%)` | `0.00 <0.00> (ø)` | |
   | [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <0.00%> (-58.14%)` | `0.00 <0.00> (ø)` | |
   | [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-50.00%)` | `0.00 <0.00> (ø)` | |
   | [...oap/server/core/analysis/metrics/CountMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Db3VudE1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (-85.72%)` | `0.00 <0.00> (ø)` | |
   | [...server/core/analysis/metrics/MaxDoubleMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhEb3VibGVNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...p/server/core/analysis/metrics/MaxLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhMb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-87.50%)` | `0.00 <0.00> (ø)` | |
   | [...king/oap/server/core/analysis/metrics/Metrics.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NZXRyaWNzLmphdmE=) | `63.63% <ø> (-27.28%)` | `10.00 <0.00> (ø)` | |
   | ... and [1255 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [1e78a0a...ad99d9b](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (b9cf4d4) into [master](https://codecov.io/gh/apache/skywalking/commit/b1a8238c159eaebda35771cd7c9c548e5eedfee1?el=desc) (b1a8238) will **increase** coverage by `4.44%`.
   > The diff coverage is `14.60%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6322      +/-   ##
   ============================================
   + Coverage     46.70%   51.15%   +4.44%     
   + Complexity     3244     3085     -159     
   ============================================
     Files           953     1777     +824     
     Lines         23245    37687   +14442     
     Branches       2263     4313    +2050     
   ============================================
   + Hits          10856    19277    +8421     
   - Misses        11461    17429    +5968     
   - Partials        928      981      +53     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `24.21% <0.00%> (+15.34%)` | `4.00 <0.00> (+3.00)` | |
   | [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `23.52% <0.00%> (+5.01%)` | `1.00 <0.00> (-1.00)` | :arrow_up: |
   | [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `18.51% <0.00%> (-37.04%)` | `2.00 <0.00> (ø)` | |
   | [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `65.71% <0.00%> (+65.71%)` | `0.00 <0.00> (ø)` | |
   | [...iver/envoy/als/mx/MetaExchangeALSHTTPAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L01ldGFFeGNoYW5nZUFMU0hUVFBBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../receiver/envoy/als/mx/ServiceMetaInfoAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L1NlcnZpY2VNZXRhSW5mb0FkYXB0ZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/persistence/LogsPersistence.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvcGVyc2lzdGVuY2UvTG9nc1BlcnNpc3RlbmNlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `31.81% <50.00%> (-61.04%)` | `3.00 <0.00> (ø)` | |
   | [...ver/receiver/envoy/ServiceMetaInfoFactoryImpl.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvU2VydmljZU1ldGFJbmZvRmFjdG9yeUltcGwuamF2YQ==) | `50.00% <50.00%> (ø)` | `2.00 <2.00> (?)` | |
   | ... and [1313 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [b1a8238...dbd6ae9](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (d501f73) into [master](https://codecov.io/gh/apache/skywalking/commit/6bc3ba025f889b0682d651d07f5b8037f41fff9c?el=desc) (6bc3ba0) will **increase** coverage by `9.74%`.
   > The diff coverage is `14.60%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6322      +/-   ##
   ============================================
   + Coverage     31.05%   40.80%   +9.74%     
   - Complexity     2180     2196      +16     
   ============================================
     Files           964     1767     +803     
     Lines         23384    37338   +13954     
     Branches       2263     4297    +2034     
   ============================================
   + Hits           7262    15235    +7973     
   - Misses        15570    21115    +5545     
   - Partials        552      988     +436     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `7.36% <0.00%> (-1.50%)` | `1.00 <0.00> (ø)` | |
   | [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `23.52% <0.00%> (+5.01%)` | `1.00 <0.00> (-1.00)` | :arrow_up: |
   | [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `18.51% <0.00%> (-37.04%)` | `2.00 <0.00> (ø)` | |
   | [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `65.71% <0.00%> (+65.71%)` | `0.00 <0.00> (ø)` | |
   | [...iver/envoy/als/mx/MetaExchangeALSHTTPAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L01ldGFFeGNoYW5nZUFMU0hUVFBBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../receiver/envoy/als/mx/ServiceMetaInfoAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L1NlcnZpY2VNZXRhSW5mb0FkYXB0ZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/persistence/LogsPersistence.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvcGVyc2lzdGVuY2UvTG9nc1BlcnNpc3RlbmNlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `31.81% <50.00%> (-61.04%)` | `3.00 <0.00> (ø)` | |
   | [...ver/receiver/envoy/ServiceMetaInfoFactoryImpl.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvU2VydmljZU1ldGFJbmZvRmFjdG9yeUltcGwuamF2YQ==) | `50.00% <50.00%> (ø)` | `2.00 <2.00> (?)` | |
   | ... and [1385 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [6bc3ba0...d501f73](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (b9cf4d4) into [master](https://codecov.io/gh/apache/skywalking/commit/b1a8238c159eaebda35771cd7c9c548e5eedfee1?el=desc) (b1a8238) will **increase** coverage by `5.17%`.
   > The diff coverage is `14.60%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6322      +/-   ##
   ============================================
   + Coverage     41.42%   46.59%   +5.17%     
   + Complexity     2959     2747     -212     
   ============================================
     Files           953     1767     +814     
     Lines         23209    37355   +14146     
     Branches       2262     4303    +2041     
   ============================================
   + Hits           9614    17406    +7792     
   - Misses        12754    18971    +6217     
   - Partials        841      978     +137     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `24.21% <0.00%> (+15.34%)` | `4.00 <0.00> (+3.00)` | |
   | [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `23.52% <0.00%> (+5.01%)` | `1.00 <0.00> (-1.00)` | :arrow_up: |
   | [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `18.51% <0.00%> (-37.04%)` | `2.00 <0.00> (ø)` | |
   | [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `65.71% <0.00%> (+65.71%)` | `0.00 <0.00> (ø)` | |
   | [...iver/envoy/als/mx/MetaExchangeALSHTTPAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L01ldGFFeGNoYW5nZUFMU0hUVFBBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../receiver/envoy/als/mx/ServiceMetaInfoAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L1NlcnZpY2VNZXRhSW5mb0FkYXB0ZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/persistence/LogsPersistence.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvcGVyc2lzdGVuY2UvTG9nc1BlcnNpc3RlbmNlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `31.81% <50.00%> (-61.04%)` | `3.00 <0.00> (ø)` | |
   | [...ver/receiver/envoy/ServiceMetaInfoFactoryImpl.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvU2VydmljZU1ldGFJbmZvRmFjdG9yeUltcGwuamF2YQ==) | `50.00% <50.00%> (ø)` | `2.00 <2.00> (?)` | |
   | ... and [1350 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [b1a8238...dbd6ae9](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (5d644ce) into [master](https://codecov.io/gh/apache/skywalking/commit/6bc3ba025f889b0682d651d07f5b8037f41fff9c?el=desc) (6bc3ba0) will **increase** coverage by `25.50%`.
   > The diff coverage is `15.29%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #6322       +/-   ##
   =============================================
   + Coverage     31.05%   56.56%   +25.50%     
   - Complexity     2180     3994     +1814     
   =============================================
     Files           964      986       +22     
     Lines         23384    24383      +999     
     Branches       2263     2352       +89     
   =============================================
   + Hits           7262    13792     +6530     
   + Misses        15570     9381     -6189     
   - Partials        552     1210      +658     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `24.21% <0.00%> (+15.34%)` | `4.00 <0.00> (+3.00)` | |
   | [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `23.52% <0.00%> (+5.01%)` | `1.00 <0.00> (-1.00)` | :arrow_up: |
   | [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `55.55% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `59.61% <0.00%> (ø)` | `6.00 <0.00> (ø)` | |
   | [...iver/envoy/als/mx/MetaExchangeALSHTTPAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L01ldGFFeGNoYW5nZUFMU0hUVFBBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../receiver/envoy/als/mx/ServiceMetaInfoAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L1NlcnZpY2VNZXRhSW5mb0FkYXB0ZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/persistence/LogsPersistence.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvcGVyc2lzdGVuY2UvTG9nc1BlcnNpc3RlbmNlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | ... and [451 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [6bc3ba0...91e7ed7](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (3287a8b) into [master](https://codecov.io/gh/apache/skywalking/commit/63bfb8d9ed90319553671b15627fa067db084996?el=desc) (63bfb8d) will **decrease** coverage by `18.92%`.
   > The diff coverage is `12.90%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #6322       +/-   ##
   =============================================
   - Coverage     58.16%   39.23%   -18.93%     
   + Complexity     4059     2314     -1745     
   =============================================
     Files           984      805      -179     
     Lines         24336    19787     -4549     
     Branches       2365     1856      -509     
   =============================================
   - Hits          14155     7764     -6391     
   - Misses         8947    11446     +2499     
   + Partials       1234      577      -657     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `8.04% <0.00%> (-18.40%)` | `1.00 <0.00> (-3.00)` | |
   | [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `23.52% <0.00%> (+5.01%)` | `1.00 <0.00> (-1.00)` | :arrow_up: |
   | [...lking/oap/server/core/source/EndpointRelation.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0VuZHBvaW50UmVsYXRpb24uamF2YQ==) | `100.00% <ø> (ø)` | `4.00 <0.00> (ø)` | |
   | [...ap/server/core/source/ServiceInstanceRelation.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL1NlcnZpY2VJbnN0YW5jZVJlbGF0aW9uLmphdmE=) | `100.00% <ø> (ø)` | `5.00 <0.00> (ø)` | |
   | [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (-90.00%)` | `0.00 <0.00> (-2.00)` | |
   | [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `55.55% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `59.61% <0.00%> (ø)` | `6.00 <0.00> (ø)` | |
   | ... and [439 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [5289996...8875f7e](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (5876350) into [master](https://codecov.io/gh/apache/skywalking/commit/6bc3ba025f889b0682d651d07f5b8037f41fff9c?el=desc) (6bc3ba0) will **increase** coverage by `17.83%`.
   > The diff coverage is `8.23%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #6322       +/-   ##
   =============================================
   + Coverage     31.05%   48.89%   +17.83%     
   - Complexity     2180     3636     +1456     
   =============================================
     Files           964     1021       +57     
     Lines         23384    25041     +1657     
     Branches       2263     2448      +185     
   =============================================
   + Hits           7262    12243     +4981     
   + Misses        15570    11726     -3844     
   - Partials        552     1072      +520     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `24.21% <0.00%> (+15.34%)` | `4.00 <0.00> (+3.00)` | |
   | [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `23.52% <0.00%> (+5.01%)` | `1.00 <0.00> (-1.00)` | :arrow_up: |
   | [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `55.55% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `59.61% <0.00%> (ø)` | `6.00 <0.00> (ø)` | |
   | [...iver/envoy/als/mx/MetaExchangeALSHTTPAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L01ldGFFeGNoYW5nZUFMU0hUVFBBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../receiver/envoy/als/mx/ServiceMetaInfoAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L1NlcnZpY2VNZXRhSW5mb0FkYXB0ZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | ... and [417 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [6bc3ba0...91e7ed7](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (dbd6ae9) into [master](https://codecov.io/gh/apache/skywalking/commit/b1a8238c159eaebda35771cd7c9c548e5eedfee1?el=desc) (b1a8238) will **decrease** coverage by `6.86%`.
   > The diff coverage is `8.23%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6322      +/-   ##
   ============================================
   - Coverage     53.20%   46.33%   -6.87%     
   + Complexity     3755     2782     -973     
   ============================================
     Files           984      835     -149     
     Lines         24276    20545    -3731     
     Branches       2364     1929     -435     
   ============================================
   - Hits          12915     9519    -3396     
   + Misses        10311    10286      -25     
   + Partials       1050      740     -310     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `8.04% <0.00%> (-0.82%)` | `1.00 <0.00> (ø)` | |
   | [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `23.52% <0.00%> (+5.01%)` | `1.00 <0.00> (-1.00)` | :arrow_up: |
   | [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (-90.00%)` | `0.00 <0.00> (-2.00)` | |
   | [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `55.55% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `59.61% <0.00%> (ø)` | `6.00 <0.00> (ø)` | |
   | [...iver/envoy/als/mx/MetaExchangeALSHTTPAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L01ldGFFeGNoYW5nZUFMU0hUVFBBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../receiver/envoy/als/mx/ServiceMetaInfoAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L1NlcnZpY2VNZXRhSW5mb0FkYXB0ZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | ... and [356 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [b1a8238...dbd6ae9](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (b9cf4d4) into [master](https://codecov.io/gh/apache/skywalking/commit/b1a8238c159eaebda35771cd7c9c548e5eedfee1?el=desc) (b1a8238) will **increase** coverage by `8.52%`.
   > The diff coverage is `14.60%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6322      +/-   ##
   ============================================
   + Coverage     41.42%   49.94%   +8.52%     
   - Complexity     2959     2996      +37     
   ============================================
     Files           953     1777     +824     
     Lines         23209    37687   +14478     
     Branches       2262     4313    +2051     
   ============================================
   + Hits           9614    18824    +9210     
   - Misses        12754    17880    +5126     
   - Partials        841      983     +142     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `24.21% <0.00%> (+15.34%)` | `4.00 <0.00> (+3.00)` | |
   | [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `23.52% <0.00%> (+5.01%)` | `1.00 <0.00> (-1.00)` | :arrow_up: |
   | [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `18.51% <0.00%> (-37.04%)` | `2.00 <0.00> (ø)` | |
   | [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `65.71% <0.00%> (+65.71%)` | `0.00 <0.00> (ø)` | |
   | [...iver/envoy/als/mx/MetaExchangeALSHTTPAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L01ldGFFeGNoYW5nZUFMU0hUVFBBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../receiver/envoy/als/mx/ServiceMetaInfoAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L1NlcnZpY2VNZXRhSW5mb0FkYXB0ZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/persistence/LogsPersistence.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvcGVyc2lzdGVuY2UvTG9nc1BlcnNpc3RlbmNlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `31.81% <50.00%> (-61.04%)` | `3.00 <0.00> (ø)` | |
   | [...ver/receiver/envoy/ServiceMetaInfoFactoryImpl.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvU2VydmljZU1ldGFJbmZvRmFjdG9yeUltcGwuamF2YQ==) | `50.00% <50.00%> (ø)` | `2.00 <2.00> (?)` | |
   | ... and [1324 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [b1a8238...dbd6ae9](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (5876350) into [master](https://codecov.io/gh/apache/skywalking/commit/6bc3ba025f889b0682d651d07f5b8037f41fff9c?el=desc) (6bc3ba0) will **increase** coverage by `11.96%`.
   > The diff coverage is `8.23%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #6322       +/-   ##
   =============================================
   + Coverage     31.05%   43.01%   +11.96%     
   - Complexity     2180     3158      +978     
   =============================================
     Files           964      991       +27     
     Lines         23384    24045      +661     
     Branches       2263     2354       +91     
   =============================================
   + Hits           7262    10344     +3082     
   + Misses        15570    12811     -2759     
   - Partials        552      890      +338     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `24.21% <0.00%> (+15.34%)` | `4.00 <0.00> (+3.00)` | |
   | [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `23.52% <0.00%> (+5.01%)` | `1.00 <0.00> (-1.00)` | :arrow_up: |
   | [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `55.55% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `59.61% <0.00%> (ø)` | `6.00 <0.00> (ø)` | |
   | [...iver/envoy/als/mx/MetaExchangeALSHTTPAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L01ldGFFeGNoYW5nZUFMU0hUVFBBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../receiver/envoy/als/mx/ServiceMetaInfoAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L1NlcnZpY2VNZXRhSW5mb0FkYXB0ZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | ... and [294 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [6bc3ba0...91e7ed7](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (45c1b75) into [master](https://codecov.io/gh/apache/skywalking/commit/d12d3f201a315241bd7aeb5cc97c2d5103e67c02?el=desc) (d12d3f2) will **decrease** coverage by `2.24%`.
   > The diff coverage is `30.95%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6322      +/-   ##
   ============================================
   - Coverage     53.22%   50.98%   -2.25%     
   + Complexity     3845     3551     -294     
   ============================================
     Files          1731      947     -784     
     Lines         36905    23510   -13395     
     Branches       4076     2296    -1780     
   ============================================
   - Hits          19642    11986    -7656     
   + Misses        16288    10431    -5857     
   - Partials        975     1093     +118     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...erver/core/analysis/data/MergableBufferedData.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9NZXJnYWJsZUJ1ZmZlcmVkRGF0YS5qYXZh) | `76.92% <0.00%> (-7.70%)` | `4.00 <0.00> (ø)` | |
   | [...lysis/manual/networkalias/NetworkAddressAlias.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL25ldHdvcmthbGlhcy9OZXR3b3JrQWRkcmVzc0FsaWFzLmphdmE=) | `2.43% <0.00%> (-56.10%)` | `0.00 <0.00> (-5.00)` | |
   | [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (-56.25%)` | `0.00 <0.00> (ø)` | |
   | [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-12.20%)` | `0.00 <0.00> (ø)` | |
   | [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-62.80%)` | `0.00 <0.00> (ø)` | |
   | [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <0.00%> (-58.14%)` | `0.00 <0.00> (ø)` | |
   | [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-50.00%)` | `0.00 <0.00> (ø)` | |
   | [...oap/server/core/analysis/metrics/CountMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Db3VudE1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (-85.72%)` | `0.00 <0.00> (ø)` | |
   | [...server/core/analysis/metrics/MaxDoubleMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhEb3VibGVNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...p/server/core/analysis/metrics/MaxLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhMb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-87.50%)` | `0.00 <0.00> (ø)` | |
   | ... and [1278 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [1e78a0a...ad99d9b](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (45c1b75) into [master](https://codecov.io/gh/apache/skywalking/commit/d12d3f201a315241bd7aeb5cc97c2d5103e67c02?el=desc) (d12d3f2) will **decrease** coverage by `8.34%`.
   > The diff coverage is `29.76%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6322      +/-   ##
   ============================================
   - Coverage     53.22%   44.87%   -8.35%     
   + Complexity     3845     3183     -662     
   ============================================
     Files          1731      947     -784     
     Lines         36905    23350   -13555     
     Branches       4076     2250    -1826     
   ============================================
   - Hits          19642    10479    -9163     
   + Misses        16288    11939    -4349     
   + Partials        975      932      -43     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...erver/core/analysis/data/MergableBufferedData.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9NZXJnYWJsZUJ1ZmZlcmVkRGF0YS5qYXZh) | `76.92% <0.00%> (-7.70%)` | `4.00 <0.00> (ø)` | |
   | [...lysis/manual/networkalias/NetworkAddressAlias.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL25ldHdvcmthbGlhcy9OZXR3b3JrQWRkcmVzc0FsaWFzLmphdmE=) | `2.43% <0.00%> (-56.10%)` | `0.00 <0.00> (-5.00)` | |
   | [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (-56.25%)` | `0.00 <0.00> (ø)` | |
   | [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-12.20%)` | `0.00 <0.00> (ø)` | |
   | [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-62.80%)` | `0.00 <0.00> (ø)` | |
   | [...r/function/avg/AvgHistogramPercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbVBlcmNlbnRpbGVGdW5jdGlvbi5qYXZh) | `0.00% <0.00%> (-62.12%)` | `0.00 <0.00> (-25.00)` | |
   | [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <0.00%> (-58.14%)` | `0.00 <0.00> (ø)` | |
   | [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-50.00%)` | `0.00 <0.00> (ø)` | |
   | [...oap/server/core/analysis/metrics/CountMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Db3VudE1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (-85.72%)` | `0.00 <0.00> (ø)` | |
   | [...server/core/analysis/metrics/MaxDoubleMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhEb3VibGVNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | ... and [1305 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [1e78a0a...ad99d9b](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (45dc5d6) into [master](https://codecov.io/gh/apache/skywalking/commit/6bc3ba025f889b0682d651d07f5b8037f41fff9c?el=desc) (6bc3ba0) will **increase** coverage by `23.57%`.
   > The diff coverage is `15.29%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #6322       +/-   ##
   =============================================
   + Coverage     31.05%   54.63%   +23.57%     
   - Complexity     2180     3876     +1696     
   =============================================
     Files           964      986       +22     
     Lines         23384    24349      +965     
     Branches       2263     2369      +106     
   =============================================
   + Hits           7262    13303     +6041     
   + Misses        15570     9916     -5654     
   - Partials        552     1130      +578     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `8.04% <0.00%> (-0.82%)` | `1.00 <0.00> (ø)` | |
   | [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `23.52% <0.00%> (+5.01%)` | `1.00 <0.00> (-1.00)` | :arrow_up: |
   | [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `55.55% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `59.61% <0.00%> (ø)` | `6.00 <0.00> (ø)` | |
   | [...iver/envoy/als/mx/MetaExchangeALSHTTPAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L01ldGFFeGNoYW5nZUFMU0hUVFBBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../receiver/envoy/als/mx/ServiceMetaInfoAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L1NlcnZpY2VNZXRhSW5mb0FkYXB0ZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/persistence/LogsPersistence.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvcGVyc2lzdGVuY2UvTG9nc1BlcnNpc3RlbmNlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | ... and [449 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [6bc3ba0...d501f73](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (91e7ed7) into [master](https://codecov.io/gh/apache/skywalking/commit/6bc3ba025f889b0682d651d07f5b8037f41fff9c?el=desc) (6bc3ba0) will **increase** coverage by `13.36%`.
   > The diff coverage is `8.23%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #6322       +/-   ##
   =============================================
   + Coverage     31.05%   44.42%   +13.36%     
   - Complexity     2180     2645      +465     
   =============================================
     Files           964      835      -129     
     Lines         23384    20522     -2862     
     Branches       2263     1928      -335     
   =============================================
   + Hits           7262     9116     +1854     
   + Misses        15570    10716     -4854     
   - Partials        552      690      +138     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `8.04% <0.00%> (-0.82%)` | `1.00 <0.00> (ø)` | |
   | [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `23.52% <0.00%> (+5.01%)` | `1.00 <0.00> (-1.00)` | :arrow_up: |
   | [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `55.55% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `59.61% <0.00%> (ø)` | `6.00 <0.00> (ø)` | |
   | [...iver/envoy/als/mx/MetaExchangeALSHTTPAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L01ldGFFeGNoYW5nZUFMU0hUVFBBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../receiver/envoy/als/mx/ServiceMetaInfoAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L1NlcnZpY2VNZXRhSW5mb0FkYXB0ZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | ... and [327 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [6bc3ba0...91e7ed7](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (45dc5d6) into [master](https://codecov.io/gh/apache/skywalking/commit/6bc3ba025f889b0682d651d07f5b8037f41fff9c?el=desc) (6bc3ba0) will **increase** coverage by `20.26%`.
   > The diff coverage is `15.29%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #6322       +/-   ##
   =============================================
   + Coverage     31.05%   51.32%   +20.26%     
   - Complexity     2180     3709     +1529     
   =============================================
     Files           964      985       +21     
     Lines         23384    24257      +873     
     Branches       2263     2345       +82     
   =============================================
   + Hits           7262    12449     +5187     
   + Misses        15570    10754     -4816     
   - Partials        552     1054      +502     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `8.04% <0.00%> (-0.82%)` | `1.00 <0.00> (ø)` | |
   | [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `23.52% <0.00%> (+5.01%)` | `1.00 <0.00> (-1.00)` | :arrow_up: |
   | [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `55.55% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `59.61% <0.00%> (ø)` | `6.00 <0.00> (ø)` | |
   | [...iver/envoy/als/mx/MetaExchangeALSHTTPAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L01ldGFFeGNoYW5nZUFMU0hUVFBBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../receiver/envoy/als/mx/ServiceMetaInfoAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L1NlcnZpY2VNZXRhSW5mb0FkYXB0ZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/persistence/LogsPersistence.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvcGVyc2lzdGVuY2UvTG9nc1BlcnNpc3RlbmNlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | ... and [414 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [6bc3ba0...d501f73](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] kezhenxu94 commented on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773279087






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (8190912) into [master](https://codecov.io/gh/apache/skywalking/commit/b1a8238c159eaebda35771cd7c9c548e5eedfee1?el=desc) (b1a8238) will **increase** coverage by `9.90%`.
   > The diff coverage is `8.23%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6322      +/-   ##
   ============================================
   + Coverage     41.42%   51.33%   +9.90%     
   - Complexity     2959     3663     +704     
   ============================================
     Files           953      986      +33     
     Lines         23209    24213    +1004     
     Branches       2262     2357      +95     
   ============================================
   + Hits           9614    12429    +2815     
   + Misses        12754    10681    -2073     
   - Partials        841     1103     +262     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `24.21% <0.00%> (+15.34%)` | `4.00 <0.00> (+3.00)` | |
   | [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `23.52% <0.00%> (+5.01%)` | `1.00 <0.00> (-1.00)` | :arrow_up: |
   | [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `53.33% <0.00%> (+53.33%)` | `1.00 <0.00> (+1.00)` | |
   | [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `55.55% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `59.61% <0.00%> (ø)` | `6.00 <0.00> (ø)` | |
   | [...iver/envoy/als/mx/MetaExchangeALSHTTPAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L01ldGFFeGNoYW5nZUFMU0hUVFBBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../receiver/envoy/als/mx/ServiceMetaInfoAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L1NlcnZpY2VNZXRhSW5mb0FkYXB0ZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | ... and [241 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [b1a8238...dbd6ae9](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (45dc5d6) into [master](https://codecov.io/gh/apache/skywalking/commit/6bc3ba025f889b0682d651d07f5b8037f41fff9c?el=desc) (6bc3ba0) will **increase** coverage by `24.89%`.
   > The diff coverage is `15.29%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #6322       +/-   ##
   =============================================
   + Coverage     31.05%   55.95%   +24.89%     
   - Complexity     2180     3950     +1770     
   =============================================
     Files           964      986       +22     
     Lines         23384    24371      +987     
     Branches       2263     2370      +107     
   =============================================
   + Hits           7262    13636     +6374     
   + Misses        15570     9577     -5993     
   - Partials        552     1158      +606     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `24.21% <0.00%> (+15.34%)` | `4.00 <0.00> (+3.00)` | |
   | [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `23.52% <0.00%> (+5.01%)` | `1.00 <0.00> (-1.00)` | :arrow_up: |
   | [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `55.55% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `59.61% <0.00%> (ø)` | `6.00 <0.00> (ø)` | |
   | [...iver/envoy/als/mx/MetaExchangeALSHTTPAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L01ldGFFeGNoYW5nZUFMU0hUVFBBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../receiver/envoy/als/mx/ServiceMetaInfoAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L1NlcnZpY2VNZXRhSW5mb0FkYXB0ZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/persistence/LogsPersistence.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvcGVyc2lzdGVuY2UvTG9nc1BlcnNpc3RlbmNlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | ... and [463 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [6bc3ba0...d501f73](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (b9cf4d4) into [master](https://codecov.io/gh/apache/skywalking/commit/b1a8238c159eaebda35771cd7c9c548e5eedfee1?el=desc) (b1a8238) will **increase** coverage by `9.30%`.
   > The diff coverage is `14.60%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6322      +/-   ##
   ============================================
   + Coverage     41.42%   50.72%   +9.30%     
   - Complexity     2959     3055      +96     
   ============================================
     Files           953     1777     +824     
     Lines         23209    37687   +14478     
     Branches       2262     4313    +2051     
   ============================================
   + Hits           9614    19117    +9503     
   - Misses        12754    17588    +4834     
   - Partials        841      982     +141     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `24.21% <0.00%> (+15.34%)` | `4.00 <0.00> (+3.00)` | |
   | [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `23.52% <0.00%> (+5.01%)` | `1.00 <0.00> (-1.00)` | :arrow_up: |
   | [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `18.51% <0.00%> (-37.04%)` | `2.00 <0.00> (ø)` | |
   | [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `65.71% <0.00%> (+65.71%)` | `0.00 <0.00> (ø)` | |
   | [...iver/envoy/als/mx/MetaExchangeALSHTTPAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L01ldGFFeGNoYW5nZUFMU0hUVFBBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../receiver/envoy/als/mx/ServiceMetaInfoAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L1NlcnZpY2VNZXRhSW5mb0FkYXB0ZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/persistence/LogsPersistence.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvcGVyc2lzdGVuY2UvTG9nc1BlcnNpc3RlbmNlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `31.81% <50.00%> (-61.04%)` | `3.00 <0.00> (ø)` | |
   | [...ver/receiver/envoy/ServiceMetaInfoFactoryImpl.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvU2VydmljZU1ldGFJbmZvRmFjdG9yeUltcGwuamF2YQ==) | `50.00% <50.00%> (ø)` | `2.00 <2.00> (?)` | |
   | ... and [1335 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [b1a8238...dbd6ae9](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] commented on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (45c1b75) into [master](https://codecov.io/gh/apache/skywalking/commit/d12d3f201a315241bd7aeb5cc97c2d5103e67c02?el=desc) (d12d3f2) will **decrease** coverage by `26.46%`.
   > The diff coverage is `16.66%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #6322       +/-   ##
   =============================================
   - Coverage     53.22%   26.75%   -26.47%     
   + Complexity     3845     1628     -2217     
   =============================================
     Files          1731      778      -953     
     Lines         36905    19046    -17859     
     Branches       4076     1752     -2324     
   =============================================
   - Hits          19642     5096    -14546     
   + Misses        16288    13579     -2709     
   + Partials        975      371      -604     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...erver/core/analysis/data/MergableBufferedData.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9NZXJnYWJsZUJ1ZmZlcmVkRGF0YS5qYXZh) | `76.92% <0.00%> (-7.70%)` | `4.00 <0.00> (ø)` | |
   | [...lysis/manual/networkalias/NetworkAddressAlias.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL25ldHdvcmthbGlhcy9OZXR3b3JrQWRkcmVzc0FsaWFzLmphdmE=) | `2.43% <0.00%> (-56.10%)` | `0.00 <0.00> (-5.00)` | |
   | [...on/endpoint/EndpointRelationServerSideMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3JlbGF0aW9uL2VuZHBvaW50L0VuZHBvaW50UmVsYXRpb25TZXJ2ZXJTaWRlTWV0cmljcy5qYXZh) | `1.92% <0.00%> (-73.08%)` | `0.00 <0.00> (-7.00)` | |
   | [...ance/ServiceInstanceRelationClientSideMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3JlbGF0aW9uL2luc3RhbmNlL1NlcnZpY2VJbnN0YW5jZVJlbGF0aW9uQ2xpZW50U2lkZU1ldHJpY3MuamF2YQ==) | `1.69% <0.00%> (-69.50%)` | `0.00 <0.00> (-7.00)` | |
   | [...ance/ServiceInstanceRelationServerSideMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3JlbGF0aW9uL2luc3RhbmNlL1NlcnZpY2VJbnN0YW5jZVJlbGF0aW9uU2VydmVyU2lkZU1ldHJpY3MuamF2YQ==) | `1.69% <0.00%> (-69.50%)` | `0.00 <0.00> (-7.00)` | |
   | [...tion/service/ServiceRelationClientSideMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3JlbGF0aW9uL3NlcnZpY2UvU2VydmljZVJlbGF0aW9uQ2xpZW50U2lkZU1ldHJpY3MuamF2YQ==) | `2.12% <0.00%> (-70.22%)` | `0.00 <0.00> (-7.00)` | |
   | [...tion/service/ServiceRelationServerSideMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3JlbGF0aW9uL3NlcnZpY2UvU2VydmljZVJlbGF0aW9uU2VydmVyU2lkZU1ldHJpY3MuamF2YQ==) | `2.12% <0.00%> (-70.22%)` | `0.00 <0.00> (-7.00)` | |
   | [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (-56.25%)` | `0.00 <0.00> (ø)` | |
   | [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-12.20%)` | `0.00 <0.00> (ø)` | |
   | [.../core/analysis/meter/function/avg/AvgFunction.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0Z1bmN0aW9uLmphdmE=) | `4.10% <0.00%> (-67.52%)` | `2.00 <0.00> (-12.00)` | |
   | ... and [1453 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [1e78a0a...ad99d9b](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (45c1b75) into [master](https://codecov.io/gh/apache/skywalking/commit/d12d3f201a315241bd7aeb5cc97c2d5103e67c02?el=desc) (d12d3f2) will **decrease** coverage by `3.52%`.
   > The diff coverage is `30.95%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6322      +/-   ##
   ============================================
   - Coverage     53.22%   49.69%   -3.53%     
   + Complexity     3845     3490     -355     
   ============================================
     Files          1731      947     -784     
     Lines         36905    23500   -13405     
     Branches       4076     2295    -1781     
   ============================================
   - Hits          19642    11679    -7963     
   + Misses        16288    10743    -5545     
   - Partials        975     1078     +103     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...erver/core/analysis/data/MergableBufferedData.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9NZXJnYWJsZUJ1ZmZlcmVkRGF0YS5qYXZh) | `76.92% <0.00%> (-7.70%)` | `4.00 <0.00> (ø)` | |
   | [...lysis/manual/networkalias/NetworkAddressAlias.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL25ldHdvcmthbGlhcy9OZXR3b3JrQWRkcmVzc0FsaWFzLmphdmE=) | `2.43% <0.00%> (-56.10%)` | `0.00 <0.00> (-5.00)` | |
   | [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (-56.25%)` | `0.00 <0.00> (ø)` | |
   | [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-12.20%)` | `0.00 <0.00> (ø)` | |
   | [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-62.80%)` | `0.00 <0.00> (ø)` | |
   | [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <0.00%> (-58.14%)` | `0.00 <0.00> (ø)` | |
   | [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-50.00%)` | `0.00 <0.00> (ø)` | |
   | [...oap/server/core/analysis/metrics/CountMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Db3VudE1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (-85.72%)` | `0.00 <0.00> (ø)` | |
   | [...server/core/analysis/metrics/MaxDoubleMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhEb3VibGVNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...p/server/core/analysis/metrics/MaxLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhMb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-87.50%)` | `0.00 <0.00> (ø)` | |
   | ... and [1274 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [1e78a0a...ad99d9b](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (5d644ce) into [master](https://codecov.io/gh/apache/skywalking/commit/6bc3ba025f889b0682d651d07f5b8037f41fff9c?el=desc) (6bc3ba0) will **increase** coverage by `6.22%`.
   > The diff coverage is `8.23%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6322      +/-   ##
   ============================================
   + Coverage     31.05%   37.28%   +6.22%     
   - Complexity     2180     2192      +12     
   ============================================
     Files           964      805     -159     
     Lines         23384    19683    -3701     
     Branches       2263     1844     -419     
   ============================================
   + Hits           7262     7338      +76     
   + Misses        15570    11798    -3772     
   + Partials        552      547       -5     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `8.04% <0.00%> (-0.82%)` | `1.00 <0.00> (ø)` | |
   | [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `23.52% <0.00%> (+5.01%)` | `1.00 <0.00> (-1.00)` | :arrow_up: |
   | [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `55.55% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `59.61% <0.00%> (ø)` | `6.00 <0.00> (ø)` | |
   | [...iver/envoy/als/mx/MetaExchangeALSHTTPAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L01ldGFFeGNoYW5nZUFMU0hUVFBBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../receiver/envoy/als/mx/ServiceMetaInfoAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L1NlcnZpY2VNZXRhSW5mb0FkYXB0ZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | ... and [213 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [6bc3ba0...91e7ed7](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (5876350) into [master](https://codecov.io/gh/apache/skywalking/commit/6bc3ba025f889b0682d651d07f5b8037f41fff9c?el=desc) (6bc3ba0) will **increase** coverage by `12.92%`.
   > The diff coverage is `8.23%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #6322       +/-   ##
   =============================================
   + Coverage     31.05%   43.97%   +12.92%     
   - Complexity     2180     3329     +1149     
   =============================================
     Files           964     1021       +57     
     Lines         23384    24896     +1512     
     Branches       2263     2438      +175     
   =============================================
   + Hits           7262    10949     +3687     
   + Misses        15570    13013     -2557     
   - Partials        552      934      +382     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `24.21% <0.00%> (+15.34%)` | `4.00 <0.00> (+3.00)` | |
   | [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `23.52% <0.00%> (+5.01%)` | `1.00 <0.00> (-1.00)` | :arrow_up: |
   | [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `55.55% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `59.61% <0.00%> (ø)` | `6.00 <0.00> (ø)` | |
   | [...iver/envoy/als/mx/MetaExchangeALSHTTPAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L01ldGFFeGNoYW5nZUFMU0hUVFBBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../receiver/envoy/als/mx/ServiceMetaInfoAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L1NlcnZpY2VNZXRhSW5mb0FkYXB0ZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | ... and [353 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [6bc3ba0...91e7ed7](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (45dc5d6) into [master](https://codecov.io/gh/apache/skywalking/commit/6bc3ba025f889b0682d651d07f5b8037f41fff9c?el=desc) (6bc3ba0) will **increase** coverage by `18.86%`.
   > The diff coverage is `15.29%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #6322       +/-   ##
   =============================================
   + Coverage     31.05%   49.92%   +18.86%     
   - Complexity     2180     3591     +1411     
   =============================================
     Files           964      985       +21     
     Lines         23384    24239      +855     
     Branches       2263     2344       +81     
   =============================================
   + Hits           7262    12101     +4839     
   + Misses        15570    11130     -4440     
   - Partials        552     1008      +456     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `8.04% <0.00%> (-0.82%)` | `1.00 <0.00> (ø)` | |
   | [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `23.52% <0.00%> (+5.01%)` | `1.00 <0.00> (-1.00)` | :arrow_up: |
   | [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `55.55% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `59.61% <0.00%> (ø)` | `6.00 <0.00> (ø)` | |
   | [...iver/envoy/als/mx/MetaExchangeALSHTTPAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L01ldGFFeGNoYW5nZUFMU0hUVFBBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../receiver/envoy/als/mx/ServiceMetaInfoAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L1NlcnZpY2VNZXRhSW5mb0FkYXB0ZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/persistence/LogsPersistence.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvcGVyc2lzdGVuY2UvTG9nc1BlcnNpc3RlbmNlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | ... and [385 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [6bc3ba0...d501f73](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (8190912) into [master](https://codecov.io/gh/apache/skywalking/commit/b1a8238c159eaebda35771cd7c9c548e5eedfee1?el=desc) (b1a8238) will **increase** coverage by `3.67%`.
   > The diff coverage is `8.23%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6322      +/-   ##
   ============================================
   + Coverage     41.42%   45.10%   +3.67%     
   + Complexity     2959     2635     -324     
   ============================================
     Files           953      805     -148     
     Lines         23209    19746    -3463     
     Branches       2262     1868     -394     
   ============================================
   - Hits           9614     8906     -708     
   + Misses        12754    10147    -2607     
   + Partials        841      693     -148     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `8.04% <0.00%> (-0.82%)` | `1.00 <0.00> (ø)` | |
   | [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `23.52% <0.00%> (+5.01%)` | `1.00 <0.00> (-1.00)` | :arrow_up: |
   | [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `53.33% <0.00%> (+53.33%)` | `1.00 <0.00> (+1.00)` | |
   | [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `55.55% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `59.61% <0.00%> (ø)` | `6.00 <0.00> (ø)` | |
   | [...iver/envoy/als/mx/MetaExchangeALSHTTPAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L01ldGFFeGNoYW5nZUFMU0hUVFBBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../receiver/envoy/als/mx/ServiceMetaInfoAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L1NlcnZpY2VNZXRhSW5mb0FkYXB0ZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | ... and [316 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [b1a8238...dbd6ae9](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (4aa0aa8) into [master](https://codecov.io/gh/apache/skywalking/commit/b1a8238c159eaebda35771cd7c9c548e5eedfee1?el=desc) (b1a8238) will **increase** coverage by `0.13%`.
   > The diff coverage is `8.23%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6322      +/-   ##
   ============================================
   + Coverage     41.42%   41.55%   +0.13%     
   + Complexity     2959     2536     -423     
   ============================================
     Files           953      835     -118     
     Lines         23209    20549    -2660     
     Branches       2262     1929     -333     
   ============================================
   - Hits           9614     8540    -1074     
   + Misses        12754    11363    -1391     
   + Partials        841      646     -195     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `8.04% <0.00%> (-0.82%)` | `1.00 <0.00> (ø)` | |
   | [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `23.52% <0.00%> (+5.01%)` | `1.00 <0.00> (-1.00)` | :arrow_up: |
   | [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `55.55% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `59.61% <0.00%> (ø)` | `6.00 <0.00> (ø)` | |
   | [...iver/envoy/als/mx/MetaExchangeALSHTTPAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L01ldGFFeGNoYW5nZUFMU0hUVFBBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../receiver/envoy/als/mx/ServiceMetaInfoAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L1NlcnZpY2VNZXRhSW5mb0FkYXB0ZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | ... and [317 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [b1a8238...dbd6ae9](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (8190912) into [master](https://codecov.io/gh/apache/skywalking/commit/b1a8238c159eaebda35771cd7c9c548e5eedfee1?el=desc) (b1a8238) will **increase** coverage by `6.46%`.
   > The diff coverage is `8.23%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6322      +/-   ##
   ============================================
   + Coverage     41.42%   47.88%   +6.46%     
   - Complexity     2959     3399     +440     
   ============================================
     Files           953      956       +3     
     Lines         23209    23364     +155     
     Branches       2262     2275      +13     
   ============================================
   + Hits           9614    11188    +1574     
   + Misses        12754    11199    -1555     
   - Partials        841      977     +136     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `8.04% <0.00%> (-0.82%)` | `1.00 <0.00> (ø)` | |
   | [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `23.52% <0.00%> (+5.01%)` | `1.00 <0.00> (-1.00)` | :arrow_up: |
   | [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `53.33% <0.00%> (+53.33%)` | `1.00 <0.00> (+1.00)` | |
   | [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `55.55% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `59.61% <0.00%> (ø)` | `6.00 <0.00> (ø)` | |
   | [...iver/envoy/als/mx/MetaExchangeALSHTTPAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L01ldGFFeGNoYW5nZUFMU0hUVFBBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../receiver/envoy/als/mx/ServiceMetaInfoAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L1NlcnZpY2VNZXRhSW5mb0FkYXB0ZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | ... and [168 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [b1a8238...dbd6ae9](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (8190912) into [master](https://codecov.io/gh/apache/skywalking/commit/b1a8238c159eaebda35771cd7c9c548e5eedfee1?el=desc) (b1a8238) will **increase** coverage by `6.55%`.
   > The diff coverage is `8.23%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6322      +/-   ##
   ============================================
   + Coverage     41.42%   47.97%   +6.55%     
   - Complexity     2959     3408     +449     
   ============================================
     Files           953      956       +3     
     Lines         23209    23364     +155     
     Branches       2262     2275      +13     
   ============================================
   + Hits           9614    11209    +1595     
   + Misses        12754    11179    -1575     
   - Partials        841      976     +135     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `8.04% <0.00%> (-0.82%)` | `1.00 <0.00> (ø)` | |
   | [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `23.52% <0.00%> (+5.01%)` | `1.00 <0.00> (-1.00)` | :arrow_up: |
   | [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `53.33% <0.00%> (+53.33%)` | `1.00 <0.00> (+1.00)` | |
   | [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `55.55% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `59.61% <0.00%> (ø)` | `6.00 <0.00> (ø)` | |
   | [...iver/envoy/als/mx/MetaExchangeALSHTTPAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L01ldGFFeGNoYW5nZUFMU0hUVFBBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../receiver/envoy/als/mx/ServiceMetaInfoAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L1NlcnZpY2VNZXRhSW5mb0FkYXB0ZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | ... and [175 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [b1a8238...dbd6ae9](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (5876350) into [master](https://codecov.io/gh/apache/skywalking/commit/6bc3ba025f889b0682d651d07f5b8037f41fff9c?el=desc) (6bc3ba0) will **decrease** coverage by `31.05%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #6322       +/-   ##
   ============================================
   - Coverage     31.05%   0.00%   -31.06%     
   ============================================
     Files           964     199      -765     
     Lines         23384    4797    -18587     
     Branches       2263     556     -1707     
   ============================================
   - Hits           7262       0     -7262     
   + Misses        15570    4797    -10773     
   + Partials        552       0      -552     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...apm/commons/datacarrier/buffer/BufferStrategy.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXJTdHJhdGVneS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | [...skywalking/apm/util/PropertyPlaceholderHelper.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUHJvcGVydHlQbGFjZWhvbGRlckhlbHBlci5qYXZh) | `0.00% <0.00%> (-80.29%)` | `0.00% <0.00%> (-15.00%)` | |
   | [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-77.78%)` | `0.00% <0.00%> (-2.00%)` | |
   | [...atacarrier/partition/SimpleRollingPartitioner.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL3BhcnRpdGlvbi9TaW1wbGVSb2xsaW5nUGFydGl0aW9uZXIuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | [...m/commons/datacarrier/consumer/ConsumerThread.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVyVGhyZWFkLmphdmE=) | `0.00% <0.00%> (-60.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | [...kywalking/apm/commons/datacarrier/DataCarrier.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0RhdGFDYXJyaWVyLmphdmE=) | `0.00% <0.00%> (-53.85%)` | `0.00% <0.00%> (-8.00%)` | |
   | [...lking/apm/commons/datacarrier/buffer/Channels.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9DaGFubmVscy5qYXZh) | `0.00% <0.00%> (-50.00%)` | `0.00% <0.00%> (-6.00%)` | |
   | [...pm/commons/datacarrier/consumer/ConsumeDriver.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVEcml2ZXIuamF2YQ==) | `0.00% <0.00%> (-48.98%)` | `0.00% <0.00%> (-7.00%)` | |
   | [...he/skywalking/apm/commons/datacarrier/EnvUtil.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0VudlV0aWwuamF2YQ==) | `0.00% <0.00%> (-20.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | [...ava/org/apache/skywalking/apm/util/StringUtil.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvU3RyaW5nVXRpbC5qYXZh) | `0.00% <0.00%> (-14.64%)` | `0.00% <0.00%> (-10.00%)` | |
   | ... and [795 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [6bc3ba0...91e7ed7](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (3287a8b) into [master](https://codecov.io/gh/apache/skywalking/commit/63bfb8d9ed90319553671b15627fa067db084996?el=desc) (63bfb8d) will **decrease** coverage by `1.88%`.
   > The diff coverage is `19.35%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6322      +/-   ##
   ============================================
   - Coverage     58.16%   56.27%   -1.89%     
   + Complexity     4059     3961      -98     
   ============================================
     Files           984      986       +2     
     Lines         24336    24394      +58     
     Branches       2365     2371       +6     
   ============================================
   - Hits          14155    13728     -427     
   - Misses         8947     9476     +529     
   + Partials       1234     1190      -44     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...king/apm/agent/core/remote/GRPCChannelManager.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsTWFuYWdlci5qYXZh) | `48.88% <ø> (ø)` | `12.00 <0.00> (ø)` | |
   | [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `24.21% <0.00%> (-2.23%)` | `4.00 <0.00> (ø)` | |
   | [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `23.52% <0.00%> (+5.01%)` | `1.00 <0.00> (-1.00)` | :arrow_up: |
   | [...lking/oap/server/core/source/EndpointRelation.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0VuZHBvaW50UmVsYXRpb24uamF2YQ==) | `100.00% <ø> (ø)` | `4.00 <0.00> (ø)` | |
   | [...ap/server/core/source/ServiceInstanceRelation.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL1NlcnZpY2VJbnN0YW5jZVJlbGF0aW9uLmphdmE=) | `100.00% <ø> (ø)` | `5.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `55.55% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `59.61% <0.00%> (ø)` | `6.00 <0.00> (ø)` | |
   | ... and [70 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [5289996...8875f7e](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] wu-sheng commented on a change in pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#discussion_r585344132



##########
File path: oap-server/server-bootstrap/src/main/resources/lal/envoy-als.yaml
##########
@@ -0,0 +1,47 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+rules:
+  - name: envoy-als
+    dsl: |
+      filter {
+        json {
+        }
+        // only collect abnormal logs (http status code >= 300, or commonProperties?.responseFlags is not empty)
+        if (parsed?.response?.responseCode < 300 && !parsed?.commonProperties?.responseFlags) {

Review comment:
       ```suggestion
           if (parsed?.response?.responseCode < 400 && !parsed?.commonProperties?.responseFlags) {
   ```
   What do you think about 300 VS 400? @hanahmily @kezhenxu94 Do things like 302 matter?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] kezhenxu94 commented on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-788956136


   Because the failed test is unrelated to this PR, I'll merge this first and investigate it in another PR (with some other tests stuff)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (5d644ce) into [master](https://codecov.io/gh/apache/skywalking/commit/6bc3ba025f889b0682d651d07f5b8037f41fff9c?el=desc) (6bc3ba0) will **increase** coverage by `24.24%`.
   > The diff coverage is `15.29%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #6322       +/-   ##
   =============================================
   + Coverage     31.05%   55.29%   +24.24%     
   - Complexity     2180     3936     +1756     
   =============================================
     Files           964      986       +22     
     Lines         23384    24366      +982     
     Branches       2263     2351       +88     
   =============================================
   + Hits           7262    13474     +6212     
   + Misses        15570     9716     -5854     
   - Partials        552     1176      +624     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `24.21% <0.00%> (+15.34%)` | `4.00 <0.00> (+3.00)` | |
   | [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `23.52% <0.00%> (+5.01%)` | `1.00 <0.00> (-1.00)` | :arrow_up: |
   | [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `55.55% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `59.61% <0.00%> (ø)` | `6.00 <0.00> (ø)` | |
   | [...iver/envoy/als/mx/MetaExchangeALSHTTPAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L01ldGFFeGNoYW5nZUFMU0hUVFBBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../receiver/envoy/als/mx/ServiceMetaInfoAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L1NlcnZpY2VNZXRhSW5mb0FkYXB0ZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/persistence/LogsPersistence.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvcGVyc2lzdGVuY2UvTG9nc1BlcnNpc3RlbmNlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | ... and [445 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [6bc3ba0...91e7ed7](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (c76eaff) into [master](https://codecov.io/gh/apache/skywalking/commit/5289996e4c65c9eb6cfa5565560ab0b3e5ba5822?el=desc) (5289996) will **decrease** coverage by `5.08%`.
   > The diff coverage is `8.23%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6322      +/-   ##
   ============================================
   - Coverage     42.09%   37.01%   -5.09%     
   - Complexity      432     2181    +1749     
   ============================================
     Files          1772      805     -967     
     Lines         37594    19646   -17948     
     Branches       4585     1843    -2742     
   ============================================
   - Hits          15824     7271    -8553     
   + Misses        20781    11822    -8959     
   + Partials        989      553     -436     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `8.04% <0.00%> (ø)` | `1.00 <0.00> (+1.00)` | |
   | [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `23.52% <0.00%> (+5.01%)` | `1.00 <0.00> (+1.00)` | |
   | [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (-80.00%)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `55.55% <ø> (+37.69%)` | `2.00 <0.00> (+2.00)` | |
   | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (-50.00%)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (-50.46%)` | `0.00 <0.00> (ø)` | |
   | [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (-67.65%)` | `0.00 <0.00> (ø)` | |
   | [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `59.61% <0.00%> (-29.07%)` | `6.00 <0.00> (+5.00)` | :arrow_down: |
   | [...iver/envoy/als/mx/MetaExchangeALSHTTPAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L01ldGFFeGNoYW5nZUFMU0hUVFBBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../receiver/envoy/als/mx/ServiceMetaInfoAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L1NlcnZpY2VNZXRhSW5mb0FkYXB0ZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | ... and [1321 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [5289996...08605b4](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (b9cf4d4) into [master](https://codecov.io/gh/apache/skywalking/commit/b1a8238c159eaebda35771cd7c9c548e5eedfee1?el=desc) (b1a8238) will **increase** coverage by `2.20%`.
   > The diff coverage is `14.60%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6322      +/-   ##
   ============================================
   + Coverage     48.94%   51.15%   +2.20%     
   + Complexity     3488     3087     -401     
   ============================================
     Files           983     1777     +794     
     Lines         24096    37687   +13591     
     Branches       2347     4313    +1966     
   ============================================
   + Hits          11794    19279    +7485     
   - Misses        11313    17427    +6114     
   + Partials        989      981       -8     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `24.21% <0.00%> (+15.34%)` | `4.00 <0.00> (+3.00)` | |
   | [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `23.52% <0.00%> (+5.01%)` | `1.00 <0.00> (-1.00)` | :arrow_up: |
   | [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `18.51% <0.00%> (-37.04%)` | `2.00 <0.00> (ø)` | |
   | [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `65.71% <0.00%> (+65.71%)` | `0.00 <0.00> (ø)` | |
   | [...iver/envoy/als/mx/MetaExchangeALSHTTPAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L01ldGFFeGNoYW5nZUFMU0hUVFBBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../receiver/envoy/als/mx/ServiceMetaInfoAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L1NlcnZpY2VNZXRhSW5mb0FkYXB0ZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/persistence/LogsPersistence.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvcGVyc2lzdGVuY2UvTG9nc1BlcnNpc3RlbmNlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `31.81% <50.00%> (-61.04%)` | `3.00 <0.00> (ø)` | |
   | [...ver/receiver/envoy/ServiceMetaInfoFactoryImpl.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvU2VydmljZU1ldGFJbmZvRmFjdG9yeUltcGwuamF2YQ==) | `50.00% <50.00%> (ø)` | `2.00 <2.00> (?)` | |
   | ... and [1276 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [b1a8238...dbd6ae9](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (b9cf4d4) into [master](https://codecov.io/gh/apache/skywalking/commit/b1a8238c159eaebda35771cd7c9c548e5eedfee1?el=desc) (b1a8238) will **increase** coverage by `0.09%`.
   > The diff coverage is `21.34%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6322      +/-   ##
   ============================================
   + Coverage     53.20%   53.29%   +0.09%     
   + Complexity     3755     3397     -358     
   ============================================
     Files           984     1777     +793     
     Lines         24276    37757   +13481     
     Branches       2364     4321    +1957     
   ============================================
   + Hits          12915    20124    +7209     
   - Misses        10311    16649    +6338     
   + Partials       1050      984      -66     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `24.21% <0.00%> (+15.34%)` | `4.00 <0.00> (+3.00)` | |
   | [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `23.52% <0.00%> (+5.01%)` | `1.00 <0.00> (-1.00)` | :arrow_up: |
   | [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `18.51% <0.00%> (-37.04%)` | `2.00 <0.00> (ø)` | |
   | [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `65.71% <0.00%> (+65.71%)` | `0.00 <0.00> (ø)` | |
   | [...iver/envoy/als/mx/MetaExchangeALSHTTPAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L01ldGFFeGNoYW5nZUFMU0hUVFBBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../receiver/envoy/als/mx/ServiceMetaInfoAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L1NlcnZpY2VNZXRhSW5mb0FkYXB0ZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/persistence/LogsPersistence.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvcGVyc2lzdGVuY2UvTG9nc1BlcnNpc3RlbmNlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `31.81% <50.00%> (-61.04%)` | `3.00 <0.00> (ø)` | |
   | [...ver/receiver/envoy/ServiceMetaInfoFactoryImpl.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvU2VydmljZU1ldGFJbmZvRmFjdG9yeUltcGwuamF2YQ==) | `50.00% <50.00%> (ø)` | `2.00 <2.00> (?)` | |
   | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `50.00% <50.00%> (+50.00%)` | `0.00 <0.00> (ø)` | |
   | ... and [1274 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [b1a8238...dbd6ae9](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (8190912) into [master](https://codecov.io/gh/apache/skywalking/commit/b1a8238c159eaebda35771cd7c9c548e5eedfee1?el=desc) (b1a8238) will **increase** coverage by `12.20%`.
   > The diff coverage is `21.34%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #6322       +/-   ##
   =============================================
   + Coverage     41.42%   53.62%   +12.20%     
   - Complexity     2959     4021     +1062     
   =============================================
     Files           953     1777      +824     
     Lines         23209    37755    +14546     
     Branches       2262     4153     +1891     
   =============================================
   + Hits           9614    20247    +10633     
   - Misses        12754    16524     +3770     
   - Partials        841      984      +143     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `24.21% <0.00%> (+15.34%)` | `4.00 <0.00> (+3.00)` | |
   | [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `23.52% <0.00%> (+5.01%)` | `1.00 <0.00> (-1.00)` | :arrow_up: |
   | [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `18.51% <0.00%> (-37.04%)` | `2.00 <0.00> (ø)` | |
   | [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `65.71% <0.00%> (+65.71%)` | `0.00 <0.00> (ø)` | |
   | [...iver/envoy/als/mx/MetaExchangeALSHTTPAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L01ldGFFeGNoYW5nZUFMU0hUVFBBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../receiver/envoy/als/mx/ServiceMetaInfoAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L1NlcnZpY2VNZXRhSW5mb0FkYXB0ZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/persistence/LogsPersistence.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvcGVyc2lzdGVuY2UvTG9nc1BlcnNpc3RlbmNlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `31.81% <50.00%> (-61.04%)` | `3.00 <0.00> (ø)` | |
   | [...ver/receiver/envoy/ServiceMetaInfoFactoryImpl.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvU2VydmljZU1ldGFJbmZvRmFjdG9yeUltcGwuamF2YQ==) | `50.00% <50.00%> (ø)` | `2.00 <2.00> (?)` | |
   | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `50.00% <50.00%> (+50.00%)` | `0.00 <0.00> (ø)` | |
   | ... and [1358 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [b1a8238...dbd6ae9](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (4aa0aa8) into [master](https://codecov.io/gh/apache/skywalking/commit/b1a8238c159eaebda35771cd7c9c548e5eedfee1?el=desc) (b1a8238) will **decrease** coverage by `15.18%`.
   > The diff coverage is `8.23%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #6322       +/-   ##
   =============================================
   - Coverage     41.42%   26.23%   -15.19%     
   + Complexity     2959     1699     -1260     
   =============================================
     Files           953      834      -119     
     Lines         23209    20337     -2872     
     Branches       2262     1892      -370     
   =============================================
   - Hits           9614     5336     -4278     
   - Misses        12754    14626     +1872     
   + Partials        841      375      -466     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `8.04% <0.00%> (-0.82%)` | `1.00 <0.00> (ø)` | |
   | [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `23.52% <0.00%> (+5.01%)` | `1.00 <0.00> (-1.00)` | :arrow_up: |
   | [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `55.55% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `59.61% <0.00%> (ø)` | `6.00 <0.00> (ø)` | |
   | [...iver/envoy/als/mx/MetaExchangeALSHTTPAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L01ldGFFeGNoYW5nZUFMU0hUVFBBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../receiver/envoy/als/mx/ServiceMetaInfoAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L1NlcnZpY2VNZXRhSW5mb0FkYXB0ZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | ... and [462 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [b1a8238...dbd6ae9](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (b9cf4d4) into [master](https://codecov.io/gh/apache/skywalking/commit/b1a8238c159eaebda35771cd7c9c548e5eedfee1?el=desc) (b1a8238) will **increase** coverage by `0.05%`.
   > The diff coverage is `14.60%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6322      +/-   ##
   ============================================
   + Coverage     51.70%   51.75%   +0.05%     
   + Complexity     3672     3151     -521     
   ============================================
     Files           984     1777     +793     
     Lines         24248    37689   +13441     
     Branches       2359     4313    +1954     
   ============================================
   + Hits          12537    19507    +6970     
   - Misses        10677    17202    +6525     
   + Partials       1034      980      -54     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `24.21% <0.00%> (+15.34%)` | `4.00 <0.00> (+3.00)` | |
   | [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `23.52% <0.00%> (+5.01%)` | `1.00 <0.00> (-1.00)` | :arrow_up: |
   | [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (-90.00%)` | `0.00 <0.00> (-2.00)` | |
   | [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `18.51% <0.00%> (-37.04%)` | `2.00 <0.00> (ø)` | |
   | [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `65.71% <0.00%> (+65.71%)` | `0.00 <0.00> (ø)` | |
   | [...iver/envoy/als/mx/MetaExchangeALSHTTPAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L01ldGFFeGNoYW5nZUFMU0hUVFBBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../receiver/envoy/als/mx/ServiceMetaInfoAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L1NlcnZpY2VNZXRhSW5mb0FkYXB0ZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/persistence/LogsPersistence.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvcGVyc2lzdGVuY2UvTG9nc1BlcnNpc3RlbmNlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `31.81% <50.00%> (-61.04%)` | `3.00 <0.00> (ø)` | |
   | [...ver/receiver/envoy/ServiceMetaInfoFactoryImpl.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvU2VydmljZU1ldGFJbmZvRmFjdG9yeUltcGwuamF2YQ==) | `50.00% <50.00%> (ø)` | `2.00 <2.00> (?)` | |
   | ... and [1272 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [b1a8238...dbd6ae9](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (3287a8b) into [master](https://codecov.io/gh/apache/skywalking/commit/63bfb8d9ed90319553671b15627fa067db084996?el=desc) (63bfb8d) will **increase** coverage by `0.17%`.
   > The diff coverage is `19.35%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6322      +/-   ##
   ============================================
   + Coverage     58.16%   58.34%   +0.17%     
   - Complexity     4059     4064       +5     
   ============================================
     Files           984      986       +2     
     Lines         24336    24394      +58     
     Branches       2365     2371       +6     
   ============================================
   + Hits          14155    14232      +77     
   + Misses         8947     8927      -20     
   - Partials       1234     1235       +1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...king/apm/agent/core/remote/GRPCChannelManager.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsTWFuYWdlci5qYXZh) | `48.88% <ø> (ø)` | `12.00 <0.00> (ø)` | |
   | [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `24.21% <0.00%> (-2.23%)` | `4.00 <0.00> (ø)` | |
   | [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `23.52% <0.00%> (+5.01%)` | `1.00 <0.00> (-1.00)` | :arrow_up: |
   | [...lking/oap/server/core/source/EndpointRelation.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0VuZHBvaW50UmVsYXRpb24uamF2YQ==) | `100.00% <ø> (ø)` | `4.00 <0.00> (ø)` | |
   | [...ap/server/core/source/ServiceInstanceRelation.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL1NlcnZpY2VJbnN0YW5jZVJlbGF0aW9uLmphdmE=) | `100.00% <ø> (ø)` | `5.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `55.55% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `59.61% <0.00%> (ø)` | `6.00 <0.00> (ø)` | |
   | ... and [44 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [5289996...8875f7e](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (45dc5d6) into [master](https://codecov.io/gh/apache/skywalking/commit/6bc3ba025f889b0682d651d07f5b8037f41fff9c?el=desc) (6bc3ba0) will **increase** coverage by `25.26%`.
   > The diff coverage is `15.29%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #6322       +/-   ##
   =============================================
   + Coverage     31.05%   56.31%   +25.26%     
   - Complexity     2180     3962     +1782     
   =============================================
     Files           964      986       +22     
     Lines         23384    24371      +987     
     Branches       2263     2370      +107     
   =============================================
   + Hits           7262    13725     +6463     
   + Misses        15570     9466     -6104     
   - Partials        552     1180      +628     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `24.21% <0.00%> (+15.34%)` | `4.00 <0.00> (+3.00)` | |
   | [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `23.52% <0.00%> (+5.01%)` | `1.00 <0.00> (-1.00)` | :arrow_up: |
   | [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `55.55% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `59.61% <0.00%> (ø)` | `6.00 <0.00> (ø)` | |
   | [...iver/envoy/als/mx/MetaExchangeALSHTTPAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L01ldGFFeGNoYW5nZUFMU0hUVFBBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../receiver/envoy/als/mx/ServiceMetaInfoAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L1NlcnZpY2VNZXRhSW5mb0FkYXB0ZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/persistence/LogsPersistence.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvcGVyc2lzdGVuY2UvTG9nc1BlcnNpc3RlbmNlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | ... and [464 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [6bc3ba0...d501f73](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (45c1b75) into [master](https://codecov.io/gh/apache/skywalking/commit/d12d3f201a315241bd7aeb5cc97c2d5103e67c02?el=desc) (d12d3f2) will **increase** coverage by `1.44%`.
   > The diff coverage is `30.95%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6322      +/-   ##
   ============================================
   + Coverage     53.22%   54.66%   +1.44%     
   + Complexity     3845     3735     -110     
   ============================================
     Files          1731      947     -784     
     Lines         36905    23546   -13359     
     Branches       4076     2297    -1779     
   ============================================
   - Hits          19642    12872    -6770     
   + Misses        16288     9534    -6754     
   - Partials        975     1140     +165     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...erver/core/analysis/data/MergableBufferedData.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9NZXJnYWJsZUJ1ZmZlcmVkRGF0YS5qYXZh) | `76.92% <0.00%> (-7.70%)` | `4.00 <0.00> (ø)` | |
   | [...lysis/manual/networkalias/NetworkAddressAlias.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL25ldHdvcmthbGlhcy9OZXR3b3JrQWRkcmVzc0FsaWFzLmphdmE=) | `2.43% <0.00%> (-56.10%)` | `0.00 <0.00> (-5.00)` | |
   | [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (-56.25%)` | `0.00 <0.00> (ø)` | |
   | [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-12.20%)` | `0.00 <0.00> (ø)` | |
   | [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-62.80%)` | `0.00 <0.00> (ø)` | |
   | [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <0.00%> (-58.14%)` | `0.00 <0.00> (ø)` | |
   | [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-50.00%)` | `0.00 <0.00> (ø)` | |
   | [...oap/server/core/analysis/metrics/CountMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Db3VudE1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (-85.72%)` | `0.00 <0.00> (ø)` | |
   | [...server/core/analysis/metrics/MaxDoubleMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhEb3VibGVNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...p/server/core/analysis/metrics/MaxLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhMb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-87.50%)` | `0.00 <0.00> (ø)` | |
   | ... and [1262 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [1e78a0a...ad99d9b](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (b9cf4d4) into [master](https://codecov.io/gh/apache/skywalking/commit/b1a8238c159eaebda35771cd7c9c548e5eedfee1?el=desc) (b1a8238) will **increase** coverage by `2.39%`.
   > The diff coverage is `14.60%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6322      +/-   ##
   ============================================
   + Coverage     49.17%   51.56%   +2.39%     
   + Complexity     3505     3112     -393     
   ============================================
     Files           984     1777     +793     
     Lines         24141    37687   +13546     
     Branches       2351     4313    +1962     
   ============================================
   + Hits          11871    19433    +7562     
   - Misses        11272    17273    +6001     
   + Partials        998      981      -17     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `24.21% <0.00%> (+15.34%)` | `4.00 <0.00> (+3.00)` | |
   | [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `23.52% <0.00%> (+5.01%)` | `1.00 <0.00> (-1.00)` | :arrow_up: |
   | [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `18.51% <0.00%> (-37.04%)` | `2.00 <0.00> (ø)` | |
   | [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `65.71% <0.00%> (+65.71%)` | `0.00 <0.00> (ø)` | |
   | [...iver/envoy/als/mx/MetaExchangeALSHTTPAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L01ldGFFeGNoYW5nZUFMU0hUVFBBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../receiver/envoy/als/mx/ServiceMetaInfoAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L1NlcnZpY2VNZXRhSW5mb0FkYXB0ZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/persistence/LogsPersistence.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvcGVyc2lzdGVuY2UvTG9nc1BlcnNpc3RlbmNlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `31.81% <50.00%> (-61.04%)` | `3.00 <0.00> (ø)` | |
   | [...ver/receiver/envoy/ServiceMetaInfoFactoryImpl.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvU2VydmljZU1ldGFJbmZvRmFjdG9yeUltcGwuamF2YQ==) | `50.00% <50.00%> (ø)` | `2.00 <2.00> (?)` | |
   | ... and [1272 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [b1a8238...dbd6ae9](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (5d644ce) into [master](https://codecov.io/gh/apache/skywalking/commit/6bc3ba025f889b0682d651d07f5b8037f41fff9c?el=desc) (6bc3ba0) will **increase** coverage by `22.08%`.
   > The diff coverage is `15.29%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #6322       +/-   ##
   =============================================
   + Coverage     31.05%   53.13%   +22.08%     
   - Complexity     2180     3771     +1591     
   =============================================
     Files           964      986       +22     
     Lines         23384    24348      +964     
     Branches       2263     2350       +87     
   =============================================
   + Hits           7262    12938     +5676     
   + Misses        15570    10294     -5276     
   - Partials        552     1116      +564     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `24.21% <0.00%> (+15.34%)` | `4.00 <0.00> (+3.00)` | |
   | [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `23.52% <0.00%> (+5.01%)` | `1.00 <0.00> (-1.00)` | :arrow_up: |
   | [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `55.55% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `59.61% <0.00%> (ø)` | `6.00 <0.00> (ø)` | |
   | [...iver/envoy/als/mx/MetaExchangeALSHTTPAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L01ldGFFeGNoYW5nZUFMU0hUVFBBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../receiver/envoy/als/mx/ServiceMetaInfoAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L1NlcnZpY2VNZXRhSW5mb0FkYXB0ZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/persistence/LogsPersistence.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvcGVyc2lzdGVuY2UvTG9nc1BlcnNpc3RlbmNlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | ... and [405 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [6bc3ba0...91e7ed7](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (dbd6ae9) into [master](https://codecov.io/gh/apache/skywalking/commit/b1a8238c159eaebda35771cd7c9c548e5eedfee1?el=desc) (b1a8238) will **decrease** coverage by `10.05%`.
   > The diff coverage is `8.23%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #6322       +/-   ##
   =============================================
   - Coverage     57.07%   47.02%   -10.06%     
   + Complexity     3998     2811     -1187     
   =============================================
     Files           984      835      -149     
     Lines         24317    20559     -3758     
     Branches       2366     1930      -436     
   =============================================
   - Hits          13879     9667     -4212     
   - Misses         9285    10135      +850     
   + Partials       1153      757      -396     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `8.04% <0.00%> (-0.82%)` | `1.00 <0.00> (ø)` | |
   | [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `23.52% <0.00%> (+5.01%)` | `1.00 <0.00> (-1.00)` | :arrow_up: |
   | [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (-90.00%)` | `0.00 <0.00> (-2.00)` | |
   | [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `55.55% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `59.61% <0.00%> (ø)` | `6.00 <0.00> (ø)` | |
   | [...iver/envoy/als/mx/MetaExchangeALSHTTPAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L01ldGFFeGNoYW5nZUFMU0hUVFBBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../receiver/envoy/als/mx/ServiceMetaInfoAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L1NlcnZpY2VNZXRhSW5mb0FkYXB0ZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | ... and [316 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [b1a8238...dbd6ae9](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (8190912) into [master](https://codecov.io/gh/apache/skywalking/commit/b1a8238c159eaebda35771cd7c9c548e5eedfee1?el=desc) (b1a8238) will **increase** coverage by `14.37%`.
   > The diff coverage is `8.23%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #6322       +/-   ##
   =============================================
   + Coverage     41.42%   55.79%   +14.37%     
   - Complexity     2959     3936      +977     
   =============================================
     Files           953      986       +33     
     Lines         23209    24336     +1127     
     Branches       2262     2365      +103     
   =============================================
   + Hits           9614    13579     +3965     
   + Misses        12754     9562     -3192     
   - Partials        841     1195      +354     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `24.21% <0.00%> (+15.34%)` | `4.00 <0.00> (+3.00)` | |
   | [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `23.52% <0.00%> (+5.01%)` | `1.00 <0.00> (-1.00)` | :arrow_up: |
   | [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `53.33% <0.00%> (+53.33%)` | `1.00 <0.00> (+1.00)` | |
   | [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `55.55% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `59.61% <0.00%> (ø)` | `6.00 <0.00> (ø)` | |
   | [...iver/envoy/als/mx/MetaExchangeALSHTTPAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L01ldGFFeGNoYW5nZUFMU0hUVFBBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../receiver/envoy/als/mx/ServiceMetaInfoAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L1NlcnZpY2VNZXRhSW5mb0FkYXB0ZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | ... and [267 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [b1a8238...dbd6ae9](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#discussion_r585183364



##########
File path: docs/en/setup/envoy/als_setting.md
##########
@@ -87,3 +88,14 @@ this analyzer requires Istio to enable the metadata exchange plugin (you can ena
 or if you're using Istio 1.7+ and installing it with profile `demo`/`preview`, it should be enabled then).
 
 The [blog](https://skywalking.apache.org/blog/obs-service-mesh-vm-with-sw-and-als/) illustrates the detail of how it works, and a step-by-step tutorial to apply it into the [Online Boutique](https://github.com/GoogleCloudPlatform/microservices-demo) system.
+
+### `persistence`
+
+`persistence` analyzer adapts the Envoy access log format to
+SkyWalking's [native log format](https://github.com/apache/skywalking-data-collect-protocol/blob/master/logging/Logging.proto)
+, and forwards the formatted logs to [LAL](../../concepts-and-designs/lal.md), where you can configure persistent
+conditions, such as `sampler`, only persist error logs, etc.
+
+**Attention**: because `persistence` analyzer also needs a mechanism to map the logs into responding services, hence,
+you need to configure at least one of `k8s-mesh` or `mx-mesh` as its antecedent so that `persistence` analyzer knows which service the
+logs belong to.

Review comment:
       > Do you mean, we need to set `SW_ENVOY_METRIC_ALS_HTTP_ANALYSIS=k8s-mesh,persistence`?
   
   Yes, something like `k8s-mesh,persistence`, `mx-mesh,persistence`, or `k8s-mesh,mx-mesh,persistence`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (b9cf4d4) into [master](https://codecov.io/gh/apache/skywalking/commit/b1a8238c159eaebda35771cd7c9c548e5eedfee1?el=desc) (b1a8238) will **increase** coverage by `5.55%`.
   > The diff coverage is `14.60%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6322      +/-   ##
   ============================================
   + Coverage     41.42%   46.97%   +5.55%     
   + Complexity     2959     2773     -186     
   ============================================
     Files           953     1767     +814     
     Lines         23209    37355   +14146     
     Branches       2262     4303    +2041     
   ============================================
   + Hits           9614    17547    +7933     
   - Misses        12754    18823    +6069     
   - Partials        841      985     +144     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `24.21% <0.00%> (+15.34%)` | `4.00 <0.00> (+3.00)` | |
   | [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `23.52% <0.00%> (+5.01%)` | `1.00 <0.00> (-1.00)` | :arrow_up: |
   | [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `18.51% <0.00%> (-37.04%)` | `2.00 <0.00> (ø)` | |
   | [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `65.71% <0.00%> (+65.71%)` | `0.00 <0.00> (ø)` | |
   | [...iver/envoy/als/mx/MetaExchangeALSHTTPAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L01ldGFFeGNoYW5nZUFMU0hUVFBBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../receiver/envoy/als/mx/ServiceMetaInfoAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L1NlcnZpY2VNZXRhSW5mb0FkYXB0ZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/persistence/LogsPersistence.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvcGVyc2lzdGVuY2UvTG9nc1BlcnNpc3RlbmNlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `31.81% <50.00%> (-61.04%)` | `3.00 <0.00> (ø)` | |
   | [...ver/receiver/envoy/ServiceMetaInfoFactoryImpl.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvU2VydmljZU1ldGFJbmZvRmFjdG9yeUltcGwuamF2YQ==) | `50.00% <50.00%> (ø)` | `2.00 <2.00> (?)` | |
   | ... and [1355 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [b1a8238...dbd6ae9](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (45dc5d6) into [master](https://codecov.io/gh/apache/skywalking/commit/6bc3ba025f889b0682d651d07f5b8037f41fff9c?el=desc) (6bc3ba0) will **increase** coverage by `24.28%`.
   > The diff coverage is `15.29%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #6322       +/-   ##
   =============================================
   + Coverage     31.05%   55.34%   +24.28%     
   - Complexity     2180     3907     +1727     
   =============================================
     Files           964      986       +22     
     Lines         23384    24349      +965     
     Branches       2263     2369      +106     
   =============================================
   + Hits           7262    13475     +6213     
   + Misses        15570     9745     -5825     
   - Partials        552     1129      +577     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `8.04% <0.00%> (-0.82%)` | `1.00 <0.00> (ø)` | |
   | [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `23.52% <0.00%> (+5.01%)` | `1.00 <0.00> (-1.00)` | :arrow_up: |
   | [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `55.55% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `59.61% <0.00%> (ø)` | `6.00 <0.00> (ø)` | |
   | [...iver/envoy/als/mx/MetaExchangeALSHTTPAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L01ldGFFeGNoYW5nZUFMU0hUVFBBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../receiver/envoy/als/mx/ServiceMetaInfoAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L1NlcnZpY2VNZXRhSW5mb0FkYXB0ZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/persistence/LogsPersistence.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvcGVyc2lzdGVuY2UvTG9nc1BlcnNpc3RlbmNlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | ... and [452 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [6bc3ba0...d501f73](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (dbd6ae9) into [master](https://codecov.io/gh/apache/skywalking/commit/b1a8238c159eaebda35771cd7c9c548e5eedfee1?el=desc) (b1a8238) will **decrease** coverage by `0.55%`.
   > The diff coverage is `8.23%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6322      +/-   ##
   ============================================
   - Coverage     41.42%   40.86%   -0.56%     
   + Complexity     2959     2365     -594     
   ============================================
     Files           953      805     -148     
     Lines         23209    19671    -3538     
     Branches       2262     1844     -418     
   ============================================
   - Hits           9614     8039    -1575     
   + Misses        12754    11006    -1748     
   + Partials        841      626     -215     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `8.04% <0.00%> (-0.82%)` | `1.00 <0.00> (ø)` | |
   | [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `23.52% <0.00%> (+5.01%)` | `1.00 <0.00> (-1.00)` | :arrow_up: |
   | [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `55.55% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `59.61% <0.00%> (ø)` | `6.00 <0.00> (ø)` | |
   | [...iver/envoy/als/mx/MetaExchangeALSHTTPAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L01ldGFFeGNoYW5nZUFMU0hUVFBBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../receiver/envoy/als/mx/ServiceMetaInfoAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L1NlcnZpY2VNZXRhSW5mb0FkYXB0ZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | ... and [250 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [b1a8238...dbd6ae9](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (45c1b75) into [master](https://codecov.io/gh/apache/skywalking/commit/d12d3f201a315241bd7aeb5cc97c2d5103e67c02?el=desc) (d12d3f2) will **decrease** coverage by `0.40%`.
   > The diff coverage is `30.95%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6322      +/-   ##
   ============================================
   - Coverage     53.22%   52.82%   -0.41%     
   + Complexity     3845     3643     -202     
   ============================================
     Files          1731      947     -784     
     Lines         36905    23546   -13359     
     Branches       4076     2297    -1779     
   ============================================
   - Hits          19642    12437    -7205     
   + Misses        16288     9982    -6306     
   - Partials        975     1127     +152     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...erver/core/analysis/data/MergableBufferedData.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9NZXJnYWJsZUJ1ZmZlcmVkRGF0YS5qYXZh) | `76.92% <0.00%> (-7.70%)` | `4.00 <0.00> (ø)` | |
   | [...lysis/manual/networkalias/NetworkAddressAlias.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL25ldHdvcmthbGlhcy9OZXR3b3JrQWRkcmVzc0FsaWFzLmphdmE=) | `2.43% <0.00%> (-56.10%)` | `0.00 <0.00> (-5.00)` | |
   | [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (-56.25%)` | `0.00 <0.00> (ø)` | |
   | [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-12.20%)` | `0.00 <0.00> (ø)` | |
   | [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-62.80%)` | `0.00 <0.00> (ø)` | |
   | [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <0.00%> (-58.14%)` | `0.00 <0.00> (ø)` | |
   | [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-50.00%)` | `0.00 <0.00> (ø)` | |
   | [...oap/server/core/analysis/metrics/CountMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Db3VudE1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (-85.72%)` | `0.00 <0.00> (ø)` | |
   | [...server/core/analysis/metrics/MaxDoubleMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhEb3VibGVNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...p/server/core/analysis/metrics/MaxLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhMb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-87.50%)` | `0.00 <0.00> (ø)` | |
   | ... and [1271 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [1e78a0a...ad99d9b](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (45c1b75) into [master](https://codecov.io/gh/apache/skywalking/commit/d12d3f201a315241bd7aeb5cc97c2d5103e67c02?el=desc) (d12d3f2) will **increase** coverage by `0.87%`.
   > The diff coverage is `30.95%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6322      +/-   ##
   ============================================
   + Coverage     53.22%   54.09%   +0.87%     
   + Complexity     3845     3693     -152     
   ============================================
     Files          1731      947     -784     
     Lines         36905    23546   -13359     
     Branches       4076     2297    -1779     
   ============================================
   - Hits          19642    12737    -6905     
   + Misses        16288     9677    -6611     
   - Partials        975     1132     +157     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...erver/core/analysis/data/MergableBufferedData.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9NZXJnYWJsZUJ1ZmZlcmVkRGF0YS5qYXZh) | `76.92% <0.00%> (-7.70%)` | `4.00 <0.00> (ø)` | |
   | [...lysis/manual/networkalias/NetworkAddressAlias.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL25ldHdvcmthbGlhcy9OZXR3b3JrQWRkcmVzc0FsaWFzLmphdmE=) | `2.43% <0.00%> (-56.10%)` | `0.00 <0.00> (-5.00)` | |
   | [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (-56.25%)` | `0.00 <0.00> (ø)` | |
   | [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-12.20%)` | `0.00 <0.00> (ø)` | |
   | [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-62.80%)` | `0.00 <0.00> (ø)` | |
   | [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <0.00%> (-58.14%)` | `0.00 <0.00> (ø)` | |
   | [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-50.00%)` | `0.00 <0.00> (ø)` | |
   | [...oap/server/core/analysis/metrics/CountMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Db3VudE1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (-85.72%)` | `0.00 <0.00> (ø)` | |
   | [...server/core/analysis/metrics/MaxDoubleMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhEb3VibGVNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...p/server/core/analysis/metrics/MaxLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhMb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-87.50%)` | `0.00 <0.00> (ø)` | |
   | ... and [1266 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [1e78a0a...ad99d9b](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (45dc5d6) into [master](https://codecov.io/gh/apache/skywalking/commit/6bc3ba025f889b0682d651d07f5b8037f41fff9c?el=desc) (6bc3ba0) will **increase** coverage by `24.76%`.
   > The diff coverage is `15.29%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #6322       +/-   ##
   =============================================
   + Coverage     31.05%   55.82%   +24.76%     
   - Complexity     2180     3946     +1766     
   =============================================
     Files           964      986       +22     
     Lines         23384    24371      +987     
     Branches       2263     2370      +107     
   =============================================
   + Hits           7262    13605     +6343     
   + Misses        15570     9619     -5951     
   - Partials        552     1147      +595     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `24.21% <0.00%> (+15.34%)` | `4.00 <0.00> (+3.00)` | |
   | [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `23.52% <0.00%> (+5.01%)` | `1.00 <0.00> (-1.00)` | :arrow_up: |
   | [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `55.55% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `59.61% <0.00%> (ø)` | `6.00 <0.00> (ø)` | |
   | [...iver/envoy/als/mx/MetaExchangeALSHTTPAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L01ldGFFeGNoYW5nZUFMU0hUVFBBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../receiver/envoy/als/mx/ServiceMetaInfoAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L1NlcnZpY2VNZXRhSW5mb0FkYXB0ZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/persistence/LogsPersistence.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvcGVyc2lzdGVuY2UvTG9nc1BlcnNpc3RlbmNlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | ... and [463 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [6bc3ba0...d501f73](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] kezhenxu94 commented on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773280179


   > > @wu-sheng can we discuss what else tags should be extracted?
   > 
   > What tags do you have for now?
   
   None 😂


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (8190912) into [master](https://codecov.io/gh/apache/skywalking/commit/b1a8238c159eaebda35771cd7c9c548e5eedfee1?el=desc) (b1a8238) will **increase** coverage by `12.66%`.
   > The diff coverage is `8.23%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #6322       +/-   ##
   =============================================
   + Coverage     41.42%   54.08%   +12.66%     
   - Complexity     2959     3823      +864     
   =============================================
     Files           953      986       +33     
     Lines         23209    24232     +1023     
     Branches       2262     2357       +95     
   =============================================
   + Hits           9614    13106     +3492     
   + Misses        12754     9972     -2782     
   - Partials        841     1154      +313     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `24.21% <0.00%> (+15.34%)` | `4.00 <0.00> (+3.00)` | |
   | [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `23.52% <0.00%> (+5.01%)` | `1.00 <0.00> (-1.00)` | :arrow_up: |
   | [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `53.33% <0.00%> (+53.33%)` | `1.00 <0.00> (+1.00)` | |
   | [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `55.55% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `59.61% <0.00%> (ø)` | `6.00 <0.00> (ø)` | |
   | [...iver/envoy/als/mx/MetaExchangeALSHTTPAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L01ldGFFeGNoYW5nZUFMU0hUVFBBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../receiver/envoy/als/mx/ServiceMetaInfoAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L1NlcnZpY2VNZXRhSW5mb0FkYXB0ZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | ... and [269 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [b1a8238...dbd6ae9](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (b9cf4d4) into [master](https://codecov.io/gh/apache/skywalking/commit/b1a8238c159eaebda35771cd7c9c548e5eedfee1?el=desc) (b1a8238) will **decrease** coverage by `0.02%`.
   > The diff coverage is `8.23%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6322      +/-   ##
   ============================================
   - Coverage     41.42%   41.39%   -0.03%     
   + Complexity     2959     2479     -480     
   ============================================
     Files           953      835     -118     
     Lines         23209    20424    -2785     
     Branches       2262     1899     -363     
   ============================================
   - Hits           9614     8455    -1159     
   + Misses        12754    11343    -1411     
   + Partials        841      626     -215     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `24.21% <0.00%> (+15.34%)` | `4.00 <0.00> (+3.00)` | |
   | [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `23.52% <0.00%> (+5.01%)` | `1.00 <0.00> (-1.00)` | :arrow_up: |
   | [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `55.55% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `59.61% <0.00%> (ø)` | `6.00 <0.00> (ø)` | |
   | [...iver/envoy/als/mx/MetaExchangeALSHTTPAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L01ldGFFeGNoYW5nZUFMU0hUVFBBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../receiver/envoy/als/mx/ServiceMetaInfoAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L1NlcnZpY2VNZXRhSW5mb0FkYXB0ZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | ... and [382 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [b1a8238...dbd6ae9](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#discussion_r585408847



##########
File path: oap-server/server-bootstrap/src/main/resources/lal/envoy-als.yaml
##########
@@ -0,0 +1,47 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+rules:
+  - name: envoy-als
+    dsl: |
+      filter {
+        json {
+        }
+        // only collect abnormal logs (http status code >= 300, or commonProperties?.responseFlags is not empty)
+        if (parsed?.response?.responseCode < 300 && !parsed?.commonProperties?.responseFlags) {
+          abort {}
+        }
+        extractor {
+          tag 'status.code': parsed?.response?.responseCode as int
+          tag 'response.flag': parsed?.commonProperties?.responseFlags?.keySet()
+        }
+        sink {
+          sampler {
+            if (parsed?.commonProperties?.responseFlags) {
+              // use service:errorCode as sampler id so that each service:errorCode has its own sampler,
+              // e.g. checkoutservice:[upstreamConnectionFailure], checkoutservice:[upstreamRetryLimitExceeded]
+              rateLimit("${log.service}:${parsed?.commonProperties?.responseFlags?.keySet()}") {

Review comment:
       > Got it. I have some self-doubt whether I am too paranoid to worry about OOM. Let's keep this for now. This at least makes sure we don't miss important error logs.
   
   In terms of the samplers, they are rather light-weight actually, a sampler only holds a field `volatile int qps` and a field `AtomicInteger factor`.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (3287a8b) into [master](https://codecov.io/gh/apache/skywalking/commit/63bfb8d9ed90319553671b15627fa067db084996?el=desc) (63bfb8d) will **decrease** coverage by `10.31%`.
   > The diff coverage is `12.90%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #6322       +/-   ##
   =============================================
   - Coverage     58.16%   47.84%   -10.32%     
   + Complexity     4059     2777     -1282     
   =============================================
     Files           984      805      -179     
     Lines         24336    19871     -4465     
     Branches       2365     1863      -502     
   =============================================
   - Hits          14155     9508     -4647     
   - Misses         8947     9614      +667     
   + Partials       1234      749      -485     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `24.21% <0.00%> (-2.23%)` | `4.00 <0.00> (ø)` | |
   | [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `23.52% <0.00%> (+5.01%)` | `1.00 <0.00> (-1.00)` | :arrow_up: |
   | [...lking/oap/server/core/source/EndpointRelation.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0VuZHBvaW50UmVsYXRpb24uamF2YQ==) | `100.00% <ø> (ø)` | `4.00 <0.00> (ø)` | |
   | [...ap/server/core/source/ServiceInstanceRelation.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL1NlcnZpY2VJbnN0YW5jZVJlbGF0aW9uLmphdmE=) | `100.00% <ø> (ø)` | `5.00 <0.00> (ø)` | |
   | [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (-90.00%)` | `0.00 <0.00> (-2.00)` | |
   | [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `55.55% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `59.61% <0.00%> (ø)` | `6.00 <0.00> (ø)` | |
   | ... and [354 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [5289996...8875f7e](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (d501f73) into [master](https://codecov.io/gh/apache/skywalking/commit/6bc3ba025f889b0682d651d07f5b8037f41fff9c?el=desc) (6bc3ba0) will **increase** coverage by `3.48%`.
   > The diff coverage is `8.23%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6322      +/-   ##
   ============================================
   + Coverage     31.05%   34.54%   +3.48%     
   - Complexity     2180     2196      +16     
   ============================================
     Files           964      834     -130     
     Lines         23384    20471    -2913     
     Branches       2263     1921     -342     
   ============================================
   - Hits           7262     7071     -191     
   + Misses        15570    12844    -2726     
   - Partials        552      556       +4     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `8.04% <0.00%> (-0.82%)` | `1.00 <0.00> (ø)` | |
   | [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `23.52% <0.00%> (+5.01%)` | `1.00 <0.00> (-1.00)` | :arrow_up: |
   | [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `55.55% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `59.61% <0.00%> (ø)` | `6.00 <0.00> (ø)` | |
   | [...iver/envoy/als/mx/MetaExchangeALSHTTPAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L01ldGFFeGNoYW5nZUFMU0hUVFBBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../receiver/envoy/als/mx/ServiceMetaInfoAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L1NlcnZpY2VNZXRhSW5mb0FkYXB0ZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | ... and [397 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [6bc3ba0...d501f73](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (8190912) into [master](https://codecov.io/gh/apache/skywalking/commit/b1a8238c159eaebda35771cd7c9c548e5eedfee1?el=desc) (b1a8238) will **increase** coverage by `9.26%`.
   > The diff coverage is `8.23%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6322      +/-   ##
   ============================================
   + Coverage     41.42%   50.69%   +9.26%     
   - Complexity     2959     3639     +680     
   ============================================
     Files           953      986      +33     
     Lines         23209    24213    +1004     
     Branches       2262     2357      +95     
   ============================================
   + Hits           9614    12274    +2660     
   + Misses        12754    10857    -1897     
   - Partials        841     1082     +241     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `24.21% <0.00%> (+15.34%)` | `4.00 <0.00> (+3.00)` | |
   | [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `23.52% <0.00%> (+5.01%)` | `1.00 <0.00> (-1.00)` | :arrow_up: |
   | [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `53.33% <0.00%> (+53.33%)` | `1.00 <0.00> (+1.00)` | |
   | [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `55.55% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `59.61% <0.00%> (ø)` | `6.00 <0.00> (ø)` | |
   | [...iver/envoy/als/mx/MetaExchangeALSHTTPAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L01ldGFFeGNoYW5nZUFMU0hUVFBBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../receiver/envoy/als/mx/ServiceMetaInfoAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L1NlcnZpY2VNZXRhSW5mb0FkYXB0ZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | ... and [241 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [b1a8238...dbd6ae9](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (8190912) into [master](https://codecov.io/gh/apache/skywalking/commit/b1a8238c159eaebda35771cd7c9c548e5eedfee1?el=desc) (b1a8238) will **increase** coverage by `6.47%`.
   > The diff coverage is `8.23%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6322      +/-   ##
   ============================================
   + Coverage     41.42%   47.89%   +6.47%     
   - Complexity     2959     3400     +441     
   ============================================
     Files           953      956       +3     
     Lines         23209    23364     +155     
     Branches       2262     2275      +13     
   ============================================
   + Hits           9614    11190    +1576     
   + Misses        12754    11199    -1555     
   - Partials        841      975     +134     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `8.04% <0.00%> (-0.82%)` | `1.00 <0.00> (ø)` | |
   | [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `23.52% <0.00%> (+5.01%)` | `1.00 <0.00> (-1.00)` | :arrow_up: |
   | [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `53.33% <0.00%> (+53.33%)` | `1.00 <0.00> (+1.00)` | |
   | [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `55.55% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `59.61% <0.00%> (ø)` | `6.00 <0.00> (ø)` | |
   | [...iver/envoy/als/mx/MetaExchangeALSHTTPAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L01ldGFFeGNoYW5nZUFMU0hUVFBBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../receiver/envoy/als/mx/ServiceMetaInfoAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L1NlcnZpY2VNZXRhSW5mb0FkYXB0ZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | ... and [170 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [b1a8238...dbd6ae9](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (5d644ce) into [master](https://codecov.io/gh/apache/skywalking/commit/6bc3ba025f889b0682d651d07f5b8037f41fff9c?el=desc) (6bc3ba0) will **increase** coverage by `5.61%`.
   > The diff coverage is `8.23%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6322      +/-   ##
   ============================================
   + Coverage     31.05%   36.67%   +5.61%     
   + Complexity     2180     2159      -21     
   ============================================
     Files           964      805     -159     
     Lines         23384    19671    -3713     
     Branches       2263     1844     -419     
   ============================================
   - Hits           7262     7214      -48     
   + Misses        15570    11910    -3660     
   + Partials        552      547       -5     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `8.04% <0.00%> (-0.82%)` | `1.00 <0.00> (ø)` | |
   | [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `23.52% <0.00%> (+5.01%)` | `1.00 <0.00> (-1.00)` | :arrow_up: |
   | [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `55.55% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `59.61% <0.00%> (ø)` | `6.00 <0.00> (ø)` | |
   | [...iver/envoy/als/mx/MetaExchangeALSHTTPAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L01ldGFFeGNoYW5nZUFMU0hUVFBBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../receiver/envoy/als/mx/ServiceMetaInfoAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L1NlcnZpY2VNZXRhSW5mb0FkYXB0ZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | ... and [194 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [6bc3ba0...91e7ed7](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (5d644ce) into [master](https://codecov.io/gh/apache/skywalking/commit/6bc3ba025f889b0682d651d07f5b8037f41fff9c?el=desc) (6bc3ba0) will **increase** coverage by `22.02%`.
   > The diff coverage is `15.29%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #6322       +/-   ##
   =============================================
   + Coverage     31.05%   53.08%   +22.02%     
   - Complexity     2180     3765     +1585     
   =============================================
     Files           964      986       +22     
     Lines         23384    24348      +964     
     Branches       2263     2350       +87     
   =============================================
   + Hits           7262    12924     +5662     
   + Misses        15570    10311     -5259     
   - Partials        552     1113      +561     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `24.21% <0.00%> (+15.34%)` | `4.00 <0.00> (+3.00)` | |
   | [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `23.52% <0.00%> (+5.01%)` | `1.00 <0.00> (-1.00)` | :arrow_up: |
   | [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `55.55% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `59.61% <0.00%> (ø)` | `6.00 <0.00> (ø)` | |
   | [...iver/envoy/als/mx/MetaExchangeALSHTTPAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L01ldGFFeGNoYW5nZUFMU0hUVFBBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../receiver/envoy/als/mx/ServiceMetaInfoAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L1NlcnZpY2VNZXRhSW5mb0FkYXB0ZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/persistence/LogsPersistence.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvcGVyc2lzdGVuY2UvTG9nc1BlcnNpc3RlbmNlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | ... and [405 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [6bc3ba0...91e7ed7](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (45c1b75) into [master](https://codecov.io/gh/apache/skywalking/commit/d12d3f201a315241bd7aeb5cc97c2d5103e67c02?el=desc) (d12d3f2) will **decrease** coverage by `24.33%`.
   > The diff coverage is `16.66%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #6322       +/-   ##
   =============================================
   - Coverage     53.22%   28.89%   -24.34%     
   + Complexity     3845     1790     -2055     
   =============================================
     Files          1731      795      -936     
     Lines         36905    19678    -17227     
     Branches       4076     1839     -2237     
   =============================================
   - Hits          19642     5685    -13957     
   + Misses        16288    13584     -2704     
   + Partials        975      409      -566     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...erver/core/analysis/data/MergableBufferedData.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9NZXJnYWJsZUJ1ZmZlcmVkRGF0YS5qYXZh) | `76.92% <0.00%> (-7.70%)` | `4.00 <0.00> (ø)` | |
   | [...lysis/manual/networkalias/NetworkAddressAlias.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL25ldHdvcmthbGlhcy9OZXR3b3JrQWRkcmVzc0FsaWFzLmphdmE=) | `2.43% <0.00%> (-56.10%)` | `0.00 <0.00> (-5.00)` | |
   | [...on/endpoint/EndpointRelationServerSideMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3JlbGF0aW9uL2VuZHBvaW50L0VuZHBvaW50UmVsYXRpb25TZXJ2ZXJTaWRlTWV0cmljcy5qYXZh) | `1.92% <0.00%> (-73.08%)` | `0.00 <0.00> (-7.00)` | |
   | [...ance/ServiceInstanceRelationClientSideMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3JlbGF0aW9uL2luc3RhbmNlL1NlcnZpY2VJbnN0YW5jZVJlbGF0aW9uQ2xpZW50U2lkZU1ldHJpY3MuamF2YQ==) | `1.69% <0.00%> (-69.50%)` | `0.00 <0.00> (-7.00)` | |
   | [...ance/ServiceInstanceRelationServerSideMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3JlbGF0aW9uL2luc3RhbmNlL1NlcnZpY2VJbnN0YW5jZVJlbGF0aW9uU2VydmVyU2lkZU1ldHJpY3MuamF2YQ==) | `1.69% <0.00%> (-69.50%)` | `0.00 <0.00> (-7.00)` | |
   | [...tion/service/ServiceRelationClientSideMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3JlbGF0aW9uL3NlcnZpY2UvU2VydmljZVJlbGF0aW9uQ2xpZW50U2lkZU1ldHJpY3MuamF2YQ==) | `2.12% <0.00%> (-70.22%)` | `0.00 <0.00> (-7.00)` | |
   | [...tion/service/ServiceRelationServerSideMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3JlbGF0aW9uL3NlcnZpY2UvU2VydmljZVJlbGF0aW9uU2VydmVyU2lkZU1ldHJpY3MuamF2YQ==) | `2.12% <0.00%> (-70.22%)` | `0.00 <0.00> (-7.00)` | |
   | [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (-56.25%)` | `0.00 <0.00> (ø)` | |
   | [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-12.20%)` | `0.00 <0.00> (ø)` | |
   | [.../core/analysis/meter/function/avg/AvgFunction.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0Z1bmN0aW9uLmphdmE=) | `4.10% <0.00%> (-67.52%)` | `2.00 <0.00> (-12.00)` | |
   | ... and [1437 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [1e78a0a...ad99d9b](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (5876350) into [master](https://codecov.io/gh/apache/skywalking/commit/6bc3ba025f889b0682d651d07f5b8037f41fff9c?el=desc) (6bc3ba0) will **increase** coverage by `13.99%`.
   > The diff coverage is `8.23%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #6322       +/-   ##
   =============================================
   + Coverage     31.05%   45.04%   +13.99%     
   - Complexity     2180     3385     +1205     
   =============================================
     Files           964     1021       +57     
     Lines         23384    24909     +1525     
     Branches       2263     2438      +175     
   =============================================
   + Hits           7262    11221     +3959     
   + Misses        15570    12725     -2845     
   - Partials        552      963      +411     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `24.21% <0.00%> (+15.34%)` | `4.00 <0.00> (+3.00)` | |
   | [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `23.52% <0.00%> (+5.01%)` | `1.00 <0.00> (-1.00)` | :arrow_up: |
   | [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `55.55% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `59.61% <0.00%> (ø)` | `6.00 <0.00> (ø)` | |
   | [...iver/envoy/als/mx/MetaExchangeALSHTTPAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L01ldGFFeGNoYW5nZUFMU0hUVFBBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../receiver/envoy/als/mx/ServiceMetaInfoAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L1NlcnZpY2VNZXRhSW5mb0FkYXB0ZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | ... and [364 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [6bc3ba0...91e7ed7](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (4aa0aa8) into [master](https://codecov.io/gh/apache/skywalking/commit/b1a8238c159eaebda35771cd7c9c548e5eedfee1?el=desc) (b1a8238) will **decrease** coverage by `0.11%`.
   > The diff coverage is `8.23%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6322      +/-   ##
   ============================================
   - Coverage     41.42%   41.31%   -0.12%     
   + Complexity     2959     2528     -431     
   ============================================
     Files           953      835     -118     
     Lines         23209    20549    -2660     
     Branches       2262     1929     -333     
   ============================================
   - Hits           9614     8489    -1125     
   + Misses        12754    11415    -1339     
   + Partials        841      645     -196     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `8.04% <0.00%> (-0.82%)` | `1.00 <0.00> (ø)` | |
   | [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `23.52% <0.00%> (+5.01%)` | `1.00 <0.00> (-1.00)` | :arrow_up: |
   | [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `55.55% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `59.61% <0.00%> (ø)` | `6.00 <0.00> (ø)` | |
   | [...iver/envoy/als/mx/MetaExchangeALSHTTPAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L01ldGFFeGNoYW5nZUFMU0hUVFBBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../receiver/envoy/als/mx/ServiceMetaInfoAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L1NlcnZpY2VNZXRhSW5mb0FkYXB0ZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | ... and [315 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [b1a8238...dbd6ae9](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (371efc5) into [master](https://codecov.io/gh/apache/skywalking/commit/6bc3ba025f889b0682d651d07f5b8037f41fff9c?el=desc) (6bc3ba0) will **increase** coverage by `8.70%`.
   > The diff coverage is `8.23%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6322      +/-   ##
   ============================================
   + Coverage     31.05%   39.75%   +8.70%     
   - Complexity     2180     2309     +129     
   ============================================
     Files           964      805     -159     
     Lines         23384    19727    -3657     
     Branches       2263     1864     -399     
   ============================================
   + Hits           7262     7843     +581     
   + Misses        15570    11307    -4263     
   - Partials        552      577      +25     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `8.04% <0.00%> (-0.82%)` | `1.00 <0.00> (ø)` | |
   | [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `23.52% <0.00%> (+5.01%)` | `1.00 <0.00> (-1.00)` | :arrow_up: |
   | [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `55.55% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `59.61% <0.00%> (ø)` | `6.00 <0.00> (ø)` | |
   | [...iver/envoy/als/mx/MetaExchangeALSHTTPAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L01ldGFFeGNoYW5nZUFMU0hUVFBBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../receiver/envoy/als/mx/ServiceMetaInfoAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L1NlcnZpY2VNZXRhSW5mb0FkYXB0ZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | ... and [234 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [6bc3ba0...91e7ed7](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (45dc5d6) into [master](https://codecov.io/gh/apache/skywalking/commit/6bc3ba025f889b0682d651d07f5b8037f41fff9c?el=desc) (6bc3ba0) will **increase** coverage by `21.18%`.
   > The diff coverage is `15.29%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #6322       +/-   ##
   =============================================
   + Coverage     31.05%   52.24%   +21.18%     
   - Complexity     2180     3759     +1579     
   =============================================
     Files           964      986       +22     
     Lines         23384    24302      +918     
     Branches       2263     2349       +86     
   =============================================
   + Hits           7262    12696     +5434     
   + Misses        15570    10516     -5054     
   - Partials        552     1090      +538     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `8.04% <0.00%> (-0.82%)` | `1.00 <0.00> (ø)` | |
   | [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `23.52% <0.00%> (+5.01%)` | `1.00 <0.00> (-1.00)` | :arrow_up: |
   | [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `55.55% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `59.61% <0.00%> (ø)` | `6.00 <0.00> (ø)` | |
   | [...iver/envoy/als/mx/MetaExchangeALSHTTPAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L01ldGFFeGNoYW5nZUFMU0hUVFBBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../receiver/envoy/als/mx/ServiceMetaInfoAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L1NlcnZpY2VNZXRhSW5mb0FkYXB0ZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/persistence/LogsPersistence.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvcGVyc2lzdGVuY2UvTG9nc1BlcnNpc3RlbmNlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | ... and [425 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [6bc3ba0...d501f73](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (8190912) into [master](https://codecov.io/gh/apache/skywalking/commit/b1a8238c159eaebda35771cd7c9c548e5eedfee1?el=desc) (b1a8238) will **increase** coverage by `8.14%`.
   > The diff coverage is `8.23%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6322      +/-   ##
   ============================================
   + Coverage     41.42%   49.56%   +8.14%     
   - Complexity     2959     3590     +631     
   ============================================
     Files           953      986      +33     
     Lines         23209    24213    +1004     
     Branches       2262     2357      +95     
   ============================================
   + Hits           9614    12002    +2388     
   + Misses        12754    11164    -1590     
   - Partials        841     1047     +206     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `24.21% <0.00%> (+15.34%)` | `4.00 <0.00> (+3.00)` | |
   | [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `23.52% <0.00%> (+5.01%)` | `1.00 <0.00> (-1.00)` | :arrow_up: |
   | [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `53.33% <0.00%> (+53.33%)` | `1.00 <0.00> (+1.00)` | |
   | [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `55.55% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `59.61% <0.00%> (ø)` | `6.00 <0.00> (ø)` | |
   | [...iver/envoy/als/mx/MetaExchangeALSHTTPAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L01ldGFFeGNoYW5nZUFMU0hUVFBBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../receiver/envoy/als/mx/ServiceMetaInfoAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L1NlcnZpY2VNZXRhSW5mb0FkYXB0ZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | ... and [237 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [b1a8238...dbd6ae9](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (aeefe63) into [master](https://codecov.io/gh/apache/skywalking/commit/5289996e4c65c9eb6cfa5565560ab0b3e5ba5822?el=desc) (5289996) will **increase** coverage by `12.05%`.
   > The diff coverage is `8.23%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #6322       +/-   ##
   =============================================
   + Coverage     42.09%   54.14%   +12.05%     
   - Complexity      432     3808     +3376     
   =============================================
     Files          1772      986      -786     
     Lines         37594    24262    -13332     
     Branches       4585     2358     -2227     
   =============================================
   - Hits          15824    13137     -2687     
   + Misses        20781     9967    -10814     
   - Partials        989     1158      +169     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `24.21% <0.00%> (+16.16%)` | `4.00 <0.00> (+4.00)` | |
   | [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `23.52% <0.00%> (+5.01%)` | `1.00 <0.00> (+1.00)` | |
   | [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (-80.00%)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `55.55% <ø> (+37.69%)` | `2.00 <0.00> (+2.00)` | |
   | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (-50.00%)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (-50.46%)` | `0.00 <0.00> (ø)` | |
   | [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (-67.65%)` | `0.00 <0.00> (ø)` | |
   | [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `59.61% <0.00%> (-29.07%)` | `6.00 <0.00> (+5.00)` | :arrow_down: |
   | [...iver/envoy/als/mx/MetaExchangeALSHTTPAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L01ldGFFeGNoYW5nZUFMU0hUVFBBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../receiver/envoy/als/mx/ServiceMetaInfoAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L1NlcnZpY2VNZXRhSW5mb0FkYXB0ZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | ... and [1354 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [5289996...08605b4](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (91e7ed7) into [master](https://codecov.io/gh/apache/skywalking/commit/6bc3ba025f889b0682d651d07f5b8037f41fff9c?el=desc) (6bc3ba0) will **increase** coverage by `12.27%`.
   > The diff coverage is `8.23%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #6322       +/-   ##
   =============================================
   + Coverage     31.05%   43.33%   +12.27%     
   - Complexity     2180     2603      +423     
   =============================================
     Files           964      835      -129     
     Lines         23384    20522     -2862     
     Branches       2263     1928      -335     
   =============================================
   + Hits           7262     8893     +1631     
   + Misses        15570    10958     -4612     
   - Partials        552      671      +119     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `8.04% <0.00%> (-0.82%)` | `1.00 <0.00> (ø)` | |
   | [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `23.52% <0.00%> (+5.01%)` | `1.00 <0.00> (-1.00)` | :arrow_up: |
   | [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `55.55% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `59.61% <0.00%> (ø)` | `6.00 <0.00> (ø)` | |
   | [...iver/envoy/als/mx/MetaExchangeALSHTTPAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L01ldGFFeGNoYW5nZUFMU0hUVFBBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../receiver/envoy/als/mx/ServiceMetaInfoAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L1NlcnZpY2VNZXRhSW5mb0FkYXB0ZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | ... and [321 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [6bc3ba0...91e7ed7](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (8190912) into [master](https://codecov.io/gh/apache/skywalking/commit/b1a8238c159eaebda35771cd7c9c548e5eedfee1?el=desc) (b1a8238) will **decrease** coverage by `0.07%`.
   > The diff coverage is `8.23%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6322      +/-   ##
   ============================================
   - Coverage     41.42%   41.34%   -0.08%     
   + Complexity     2959     2414     -545     
   ============================================
     Files           953      805     -148     
     Lines         23209    19594    -3615     
     Branches       2262     1819     -443     
   ============================================
   - Hits           9614     8101    -1513     
   + Misses        12754    10881    -1873     
   + Partials        841      612     -229     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `8.04% <0.00%> (-0.82%)` | `1.00 <0.00> (ø)` | |
   | [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `23.52% <0.00%> (+5.01%)` | `1.00 <0.00> (-1.00)` | :arrow_up: |
   | [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `53.33% <0.00%> (+53.33%)` | `1.00 <0.00> (+1.00)` | |
   | [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `55.55% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `59.61% <0.00%> (ø)` | `6.00 <0.00> (ø)` | |
   | [...iver/envoy/als/mx/MetaExchangeALSHTTPAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L01ldGFFeGNoYW5nZUFMU0hUVFBBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../receiver/envoy/als/mx/ServiceMetaInfoAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L1NlcnZpY2VNZXRhSW5mb0FkYXB0ZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | ... and [368 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [b1a8238...dbd6ae9](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (b9cf4d4) into [master](https://codecov.io/gh/apache/skywalking/commit/b1a8238c159eaebda35771cd7c9c548e5eedfee1?el=desc) (b1a8238) will **increase** coverage by `1.98%`.
   > The diff coverage is `14.60%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6322      +/-   ##
   ============================================
   + Coverage     49.16%   51.15%   +1.98%     
   + Complexity     3505     3087     -418     
   ============================================
     Files           984     1777     +793     
     Lines         24141    37687   +13546     
     Branches       2351     4313    +1962     
   ============================================
   + Hits          11870    19279    +7409     
   - Misses        11272    17427    +6155     
   + Partials        999      981      -18     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `24.21% <0.00%> (+15.34%)` | `4.00 <0.00> (+3.00)` | |
   | [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `23.52% <0.00%> (+5.01%)` | `1.00 <0.00> (-1.00)` | :arrow_up: |
   | [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `18.51% <0.00%> (-37.04%)` | `2.00 <0.00> (ø)` | |
   | [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `65.71% <0.00%> (+65.71%)` | `0.00 <0.00> (ø)` | |
   | [...iver/envoy/als/mx/MetaExchangeALSHTTPAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L01ldGFFeGNoYW5nZUFMU0hUVFBBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../receiver/envoy/als/mx/ServiceMetaInfoAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L1NlcnZpY2VNZXRhSW5mb0FkYXB0ZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/persistence/LogsPersistence.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvcGVyc2lzdGVuY2UvTG9nc1BlcnNpc3RlbmNlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `31.81% <50.00%> (-61.04%)` | `3.00 <0.00> (ø)` | |
   | [...ver/receiver/envoy/ServiceMetaInfoFactoryImpl.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvU2VydmljZU1ldGFJbmZvRmFjdG9yeUltcGwuamF2YQ==) | `50.00% <50.00%> (ø)` | `2.00 <2.00> (?)` | |
   | ... and [1275 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [b1a8238...dbd6ae9](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (8190912) into [master](https://codecov.io/gh/apache/skywalking/commit/b1a8238c159eaebda35771cd7c9c548e5eedfee1?el=desc) (b1a8238) will **increase** coverage by `13.35%`.
   > The diff coverage is `8.23%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #6322       +/-   ##
   =============================================
   + Coverage     41.42%   54.78%   +13.35%     
   - Complexity     2959     3866      +907     
   =============================================
     Files           953      986       +33     
     Lines         23209    24232     +1023     
     Branches       2262     2357       +95     
   =============================================
   + Hits           9614    13275     +3661     
   + Misses        12754     9786     -2968     
   - Partials        841     1171      +330     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `24.21% <0.00%> (+15.34%)` | `4.00 <0.00> (+3.00)` | |
   | [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `23.52% <0.00%> (+5.01%)` | `1.00 <0.00> (-1.00)` | :arrow_up: |
   | [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `53.33% <0.00%> (+53.33%)` | `1.00 <0.00> (+1.00)` | |
   | [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `55.55% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `59.61% <0.00%> (ø)` | `6.00 <0.00> (ø)` | |
   | [...iver/envoy/als/mx/MetaExchangeALSHTTPAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L01ldGFFeGNoYW5nZUFMU0hUVFBBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../receiver/envoy/als/mx/ServiceMetaInfoAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L1NlcnZpY2VNZXRhSW5mb0FkYXB0ZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | ... and [252 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [b1a8238...dbd6ae9](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (8190912) into [master](https://codecov.io/gh/apache/skywalking/commit/b1a8238c159eaebda35771cd7c9c548e5eedfee1?el=desc) (b1a8238) will **increase** coverage by `8.41%`.
   > The diff coverage is `8.23%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6322      +/-   ##
   ============================================
   + Coverage     41.42%   49.84%   +8.41%     
   - Complexity     2959     3604     +645     
   ============================================
     Files           953      986      +33     
     Lines         23209    24213    +1004     
     Branches       2262     2357      +95     
   ============================================
   + Hits           9614    12068    +2454     
   + Misses        12754    11089    -1665     
   - Partials        841     1056     +215     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `24.21% <0.00%> (+15.34%)` | `4.00 <0.00> (+3.00)` | |
   | [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `23.52% <0.00%> (+5.01%)` | `1.00 <0.00> (-1.00)` | :arrow_up: |
   | [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `53.33% <0.00%> (+53.33%)` | `1.00 <0.00> (+1.00)` | |
   | [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `55.55% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `59.61% <0.00%> (ø)` | `6.00 <0.00> (ø)` | |
   | [...iver/envoy/als/mx/MetaExchangeALSHTTPAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L01ldGFFeGNoYW5nZUFMU0hUVFBBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../receiver/envoy/als/mx/ServiceMetaInfoAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L1NlcnZpY2VNZXRhSW5mb0FkYXB0ZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | ... and [237 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [b1a8238...dbd6ae9](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (45dc5d6) into [master](https://codecov.io/gh/apache/skywalking/commit/6bc3ba025f889b0682d651d07f5b8037f41fff9c?el=desc) (6bc3ba0) will **increase** coverage by `6.26%`.
   > The diff coverage is `8.23%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6322      +/-   ##
   ============================================
   + Coverage     31.05%   37.32%   +6.26%     
   - Complexity     2180     2209      +29     
   ============================================
     Files           964      805     -159     
     Lines         23384    19708    -3676     
     Branches       2263     1849     -414     
   ============================================
   + Hits           7262     7356      +94     
   + Misses        15570    11799    -3771     
   - Partials        552      553       +1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `8.04% <0.00%> (-0.82%)` | `1.00 <0.00> (ø)` | |
   | [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `23.52% <0.00%> (+5.01%)` | `1.00 <0.00> (-1.00)` | :arrow_up: |
   | [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `55.55% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `59.61% <0.00%> (ø)` | `6.00 <0.00> (ø)` | |
   | [...iver/envoy/als/mx/MetaExchangeALSHTTPAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L01ldGFFeGNoYW5nZUFMU0hUVFBBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../receiver/envoy/als/mx/ServiceMetaInfoAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L1NlcnZpY2VNZXRhSW5mb0FkYXB0ZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | ... and [208 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [6bc3ba0...d501f73](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (8190912) into [master](https://codecov.io/gh/apache/skywalking/commit/b1a8238c159eaebda35771cd7c9c548e5eedfee1?el=desc) (b1a8238) will **increase** coverage by `12.52%`.
   > The diff coverage is `21.34%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #6322       +/-   ##
   =============================================
   + Coverage     41.42%   53.95%   +12.52%     
   - Complexity     2959     4070     +1111     
   =============================================
     Files           953     1777      +824     
     Lines         23209    37757    +14548     
     Branches       2262     4153     +1891     
   =============================================
   + Hits           9614    20370    +10756     
   - Misses        12754    16404     +3650     
   - Partials        841      983      +142     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `24.21% <0.00%> (+15.34%)` | `4.00 <0.00> (+3.00)` | |
   | [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `23.52% <0.00%> (+5.01%)` | `1.00 <0.00> (-1.00)` | :arrow_up: |
   | [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `18.51% <0.00%> (-37.04%)` | `2.00 <0.00> (ø)` | |
   | [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `65.71% <0.00%> (+65.71%)` | `0.00 <0.00> (ø)` | |
   | [...iver/envoy/als/mx/MetaExchangeALSHTTPAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L01ldGFFeGNoYW5nZUFMU0hUVFBBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../receiver/envoy/als/mx/ServiceMetaInfoAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L1NlcnZpY2VNZXRhSW5mb0FkYXB0ZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/persistence/LogsPersistence.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvcGVyc2lzdGVuY2UvTG9nc1BlcnNpc3RlbmNlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `31.81% <50.00%> (-61.04%)` | `3.00 <0.00> (ø)` | |
   | [...ver/receiver/envoy/ServiceMetaInfoFactoryImpl.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvU2VydmljZU1ldGFJbmZvRmFjdG9yeUltcGwuamF2YQ==) | `50.00% <50.00%> (ø)` | `2.00 <2.00> (?)` | |
   | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `50.00% <50.00%> (+50.00%)` | `0.00 <0.00> (ø)` | |
   | ... and [1365 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [b1a8238...dbd6ae9](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (8190912) into [master](https://codecov.io/gh/apache/skywalking/commit/b1a8238c159eaebda35771cd7c9c548e5eedfee1?el=desc) (b1a8238) will **increase** coverage by `10.67%`.
   > The diff coverage is `8.23%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #6322       +/-   ##
   =============================================
   + Coverage     41.42%   52.10%   +10.67%     
   - Complexity     2959     3715      +756     
   =============================================
     Files           953      986       +33     
     Lines         23209    24213     +1004     
     Branches       2262     2357       +95     
   =============================================
   + Hits           9614    12615     +3001     
   + Misses        12754    10482     -2272     
   - Partials        841     1116      +275     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `24.21% <0.00%> (+15.34%)` | `4.00 <0.00> (+3.00)` | |
   | [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `23.52% <0.00%> (+5.01%)` | `1.00 <0.00> (-1.00)` | :arrow_up: |
   | [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `53.33% <0.00%> (+53.33%)` | `1.00 <0.00> (+1.00)` | |
   | [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `55.55% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `59.61% <0.00%> (ø)` | `6.00 <0.00> (ø)` | |
   | [...iver/envoy/als/mx/MetaExchangeALSHTTPAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L01ldGFFeGNoYW5nZUFMU0hUVFBBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../receiver/envoy/als/mx/ServiceMetaInfoAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L1NlcnZpY2VNZXRhSW5mb0FkYXB0ZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | ... and [251 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [b1a8238...dbd6ae9](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (5876350) into [master](https://codecov.io/gh/apache/skywalking/commit/6bc3ba025f889b0682d651d07f5b8037f41fff9c?el=desc) (6bc3ba0) will **decrease** coverage by `31.05%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #6322       +/-   ##
   ============================================
   - Coverage     31.05%   0.00%   -31.06%     
   ============================================
     Files           964     170      -794     
     Lines         23384    4195    -19189     
     Branches       2263     489     -1774     
   ============================================
   - Hits           7262       0     -7262     
   + Misses        15570    4195    -11375     
   + Partials        552       0      -552     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...apm/commons/datacarrier/buffer/BufferStrategy.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXJTdHJhdGVneS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | [...skywalking/apm/util/PropertyPlaceholderHelper.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUHJvcGVydHlQbGFjZWhvbGRlckhlbHBlci5qYXZh) | `0.00% <0.00%> (-80.29%)` | `0.00% <0.00%> (-15.00%)` | |
   | [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-77.78%)` | `0.00% <0.00%> (-2.00%)` | |
   | [...atacarrier/partition/SimpleRollingPartitioner.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL3BhcnRpdGlvbi9TaW1wbGVSb2xsaW5nUGFydGl0aW9uZXIuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | [...m/commons/datacarrier/consumer/ConsumerThread.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVyVGhyZWFkLmphdmE=) | `0.00% <0.00%> (-60.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | [...kywalking/apm/commons/datacarrier/DataCarrier.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0RhdGFDYXJyaWVyLmphdmE=) | `0.00% <0.00%> (-53.85%)` | `0.00% <0.00%> (-8.00%)` | |
   | [...lking/apm/commons/datacarrier/buffer/Channels.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9DaGFubmVscy5qYXZh) | `0.00% <0.00%> (-50.00%)` | `0.00% <0.00%> (-6.00%)` | |
   | [...pm/commons/datacarrier/consumer/ConsumeDriver.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVEcml2ZXIuamF2YQ==) | `0.00% <0.00%> (-48.98%)` | `0.00% <0.00%> (-7.00%)` | |
   | [...he/skywalking/apm/commons/datacarrier/EnvUtil.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0VudlV0aWwuamF2YQ==) | `0.00% <0.00%> (-20.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | [...ava/org/apache/skywalking/apm/util/StringUtil.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvU3RyaW5nVXRpbC5qYXZh) | `0.00% <0.00%> (-14.64%)` | `0.00% <0.00%> (-10.00%)` | |
   | ... and [780 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [6bc3ba0...91e7ed7](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] wu-sheng commented on a change in pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#discussion_r585160922



##########
File path: oap-server/server-receiver-plugin/envoy-metrics-receiver-plugin/src/main/java/org/apache/skywalking/oap/server/receiver/envoy/persistence/LogsPersistence.java
##########
@@ -0,0 +1,117 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.oap.server.receiver.envoy.persistence;
+
+import com.google.protobuf.TextFormat;
+import io.envoyproxy.envoy.data.accesslog.v3.HTTPAccessLogEntry;
+import io.envoyproxy.envoy.service.accesslog.v3.StreamAccessLogsMessage;
+import java.io.IOException;
+import java.util.List;
+import lombok.extern.slf4j.Slf4j;
+import org.apache.skywalking.apm.network.common.v3.DetectPoint;
+import org.apache.skywalking.apm.network.logging.v3.JSONLog;
+import org.apache.skywalking.apm.network.logging.v3.LogData;
+import org.apache.skywalking.apm.network.logging.v3.LogDataBody;
+import org.apache.skywalking.apm.network.servicemesh.v3.ServiceMeshMetric;
+import org.apache.skywalking.oap.log.analyzer.module.LogAnalyzerModule;
+import org.apache.skywalking.oap.log.analyzer.provider.log.ILogAnalyzerService;
+import org.apache.skywalking.oap.server.library.module.ModuleManager;
+import org.apache.skywalking.oap.server.library.module.ModuleStartException;
+import org.apache.skywalking.oap.server.receiver.envoy.EnvoyMetricReceiverConfig;
+import org.apache.skywalking.oap.server.receiver.envoy.als.ALSHTTPAnalysis;
+import org.apache.skywalking.oap.server.receiver.envoy.als.Role;
+
+import static org.apache.skywalking.oap.server.library.util.ProtoBufJsonUtils.toJSON;
+
+/**
+ * {@code LogsPersistence} analyzes the error logs and persists them to the log system.
+ */
+@Slf4j
+public class LogsPersistence implements ALSHTTPAnalysis {
+    private ILogAnalyzerService logAnalyzerService;
+
+    @Override
+    public String name() {
+        return "persistence";
+    }
+
+    @Override
+    public void init(final ModuleManager manager, final EnvoyMetricReceiverConfig config) throws ModuleStartException {
+        logAnalyzerService = manager.find(LogAnalyzerModule.NAME)
+                                    .provider()
+                                    .getService(ILogAnalyzerService.class);

Review comment:
       Whether we should add an API in the `ILogAnalyzerService` to load `lal/envoy.yaml`?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (5876350) into [master](https://codecov.io/gh/apache/skywalking/commit/6bc3ba025f889b0682d651d07f5b8037f41fff9c?el=desc) (6bc3ba0) will **decrease** coverage by `5.75%`.
   > The diff coverage is `8.23%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6322      +/-   ##
   ============================================
   - Coverage     31.05%   25.29%   -5.76%     
   + Complexity     2180     1814     -366     
   ============================================
     Files           964      990      +26     
     Lines         23384    23814     +430     
     Branches       2263     2295      +32     
   ============================================
   - Hits           7262     6024    -1238     
   - Misses        15570    17366    +1796     
   + Partials        552      424     -128     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `8.04% <0.00%> (-0.82%)` | `1.00 <0.00> (ø)` | |
   | [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `23.52% <0.00%> (+5.01%)` | `1.00 <0.00> (-1.00)` | :arrow_up: |
   | [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `55.55% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `59.61% <0.00%> (ø)` | `6.00 <0.00> (ø)` | |
   | [...iver/envoy/als/mx/MetaExchangeALSHTTPAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L01ldGFFeGNoYW5nZUFMU0hUVFBBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../receiver/envoy/als/mx/ServiceMetaInfoAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L1NlcnZpY2VNZXRhSW5mb0FkYXB0ZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | ... and [157 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [6bc3ba0...91e7ed7](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (8190912) into [master](https://codecov.io/gh/apache/skywalking/commit/b1a8238c159eaebda35771cd7c9c548e5eedfee1?el=desc) (b1a8238) will **increase** coverage by `8.40%`.
   > The diff coverage is `8.23%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6322      +/-   ##
   ============================================
   + Coverage     41.42%   49.82%   +8.40%     
   - Complexity     2959     3602     +643     
   ============================================
     Files           953      986      +33     
     Lines         23209    24213    +1004     
     Branches       2262     2357      +95     
   ============================================
   + Hits           9614    12065    +2451     
   + Misses        12754    11092    -1662     
   - Partials        841     1056     +215     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `24.21% <0.00%> (+15.34%)` | `4.00 <0.00> (+3.00)` | |
   | [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `23.52% <0.00%> (+5.01%)` | `1.00 <0.00> (-1.00)` | :arrow_up: |
   | [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `53.33% <0.00%> (+53.33%)` | `1.00 <0.00> (+1.00)` | |
   | [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `55.55% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `59.61% <0.00%> (ø)` | `6.00 <0.00> (ø)` | |
   | [...iver/envoy/als/mx/MetaExchangeALSHTTPAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L01ldGFFeGNoYW5nZUFMU0hUVFBBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../receiver/envoy/als/mx/ServiceMetaInfoAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L1NlcnZpY2VNZXRhSW5mb0FkYXB0ZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | ... and [237 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [b1a8238...dbd6ae9](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (b9cf4d4) into [master](https://codecov.io/gh/apache/skywalking/commit/b1a8238c159eaebda35771cd7c9c548e5eedfee1?el=desc) (b1a8238) will **decrease** coverage by `1.22%`.
   > The diff coverage is `14.60%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6322      +/-   ##
   ============================================
   - Coverage     53.20%   51.97%   -1.23%     
   + Complexity     3755     3194     -561     
   ============================================
     Files           984     1777     +793     
     Lines         24276    37689   +13413     
     Branches       2364     4313    +1949     
   ============================================
   + Hits          12915    19588    +6673     
   - Misses        10311    17122    +6811     
   + Partials       1050      979      -71     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `24.21% <0.00%> (+15.34%)` | `4.00 <0.00> (+3.00)` | |
   | [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `23.52% <0.00%> (+5.01%)` | `1.00 <0.00> (-1.00)` | :arrow_up: |
   | [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (-90.00%)` | `0.00 <0.00> (-2.00)` | |
   | [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `18.51% <0.00%> (-37.04%)` | `2.00 <0.00> (ø)` | |
   | [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `65.71% <0.00%> (+65.71%)` | `0.00 <0.00> (ø)` | |
   | [...iver/envoy/als/mx/MetaExchangeALSHTTPAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L01ldGFFeGNoYW5nZUFMU0hUVFBBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../receiver/envoy/als/mx/ServiceMetaInfoAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L1NlcnZpY2VNZXRhSW5mb0FkYXB0ZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/persistence/LogsPersistence.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvcGVyc2lzdGVuY2UvTG9nc1BlcnNpc3RlbmNlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `31.81% <50.00%> (-61.04%)` | `3.00 <0.00> (ø)` | |
   | [...ver/receiver/envoy/ServiceMetaInfoFactoryImpl.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvU2VydmljZU1ldGFJbmZvRmFjdG9yeUltcGwuamF2YQ==) | `50.00% <50.00%> (ø)` | `2.00 <2.00> (?)` | |
   | ... and [1260 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [b1a8238...dbd6ae9](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] wu-sheng commented on a change in pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#discussion_r585341891



##########
File path: oap-server/server-bootstrap/src/main/resources/lal/envoy-als.yaml
##########
@@ -0,0 +1,47 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+rules:
+  - name: envoy-als
+    dsl: |
+      filter {
+        json {
+        }
+        // only collect abnormal logs (http status code >= 300, or commonProperties?.responseFlags is not empty)
+        if (parsed?.response?.responseCode < 300 && !parsed?.commonProperties?.responseFlags) {
+          abort {}
+        }
+        extractor {
+          tag 'status.code': parsed?.response?.responseCode as int
+          tag 'response.flag': parsed?.commonProperties?.responseFlags?.keySet()
+        }
+        sink {
+          sampler {
+            if (parsed?.commonProperties?.responseFlags) {
+              // use service:errorCode as sampler id so that each service:errorCode has its own sampler,
+              // e.g. checkoutservice:[upstreamConnectionFailure], checkoutservice:[upstreamRetryLimitExceeded]
+              rateLimit("${log.service}:${parsed?.commonProperties?.responseFlags?.keySet()}") {
+                qps 100
+              }
+            } else {
+              // use service:responseCode as sampler id so that each service:responseCode has its own sampler,
+              // e.g. checkoutservice:500, checkoutservice:404.
+              rateLimit("${log.service}:${parsed?.response?.responseCode}") {

Review comment:
       This means collect less than 100/s per error http response code?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (5d644ce) into [master](https://codecov.io/gh/apache/skywalking/commit/6bc3ba025f889b0682d651d07f5b8037f41fff9c?el=desc) (6bc3ba0) will **increase** coverage by `22.13%`.
   > The diff coverage is `21.34%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #6322       +/-   ##
   =============================================
   + Coverage     31.05%   53.19%   +22.13%     
   - Complexity     2180     4017     +1837     
   =============================================
     Files           964     1777      +813     
     Lines         23384    37753    +14369     
     Branches       2263     4147     +1884     
   =============================================
   + Hits           7262    20082    +12820     
   - Misses        15570    16688     +1118     
   - Partials        552      983      +431     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `24.21% <0.00%> (+15.34%)` | `4.00 <0.00> (+3.00)` | |
   | [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `23.52% <0.00%> (+5.01%)` | `1.00 <0.00> (-1.00)` | :arrow_up: |
   | [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `18.51% <0.00%> (-37.04%)` | `2.00 <0.00> (ø)` | |
   | [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `65.71% <0.00%> (+65.71%)` | `0.00 <0.00> (ø)` | |
   | [...iver/envoy/als/mx/MetaExchangeALSHTTPAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L01ldGFFeGNoYW5nZUFMU0hUVFBBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../receiver/envoy/als/mx/ServiceMetaInfoAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L1NlcnZpY2VNZXRhSW5mb0FkYXB0ZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/persistence/LogsPersistence.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvcGVyc2lzdGVuY2UvTG9nc1BlcnNpc3RlbmNlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `31.81% <50.00%> (-61.04%)` | `3.00 <0.00> (ø)` | |
   | [...ver/receiver/envoy/ServiceMetaInfoFactoryImpl.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvU2VydmljZU1ldGFJbmZvRmFjdG9yeUltcGwuamF2YQ==) | `50.00% <50.00%> (ø)` | `2.00 <2.00> (?)` | |
   | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `50.00% <50.00%> (+50.00%)` | `0.00 <0.00> (ø)` | |
   | ... and [1425 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [6bc3ba0...d501f73](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (3287a8b) into [master](https://codecov.io/gh/apache/skywalking/commit/63bfb8d9ed90319553671b15627fa067db084996?el=desc) (63bfb8d) will **increase** coverage by `0.28%`.
   > The diff coverage is `19.35%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6322      +/-   ##
   ============================================
   + Coverage     58.16%   58.44%   +0.28%     
   - Complexity     4059     4074      +15     
   ============================================
     Files           984      986       +2     
     Lines         24336    24394      +58     
     Branches       2365     2371       +6     
   ============================================
   + Hits          14155    14258     +103     
   + Misses         8947     8902      -45     
     Partials       1234     1234              
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...king/apm/agent/core/remote/GRPCChannelManager.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsTWFuYWdlci5qYXZh) | `48.88% <ø> (ø)` | `12.00 <0.00> (ø)` | |
   | [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `24.21% <0.00%> (-2.23%)` | `4.00 <0.00> (ø)` | |
   | [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `23.52% <0.00%> (+5.01%)` | `1.00 <0.00> (-1.00)` | :arrow_up: |
   | [...lking/oap/server/core/source/EndpointRelation.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0VuZHBvaW50UmVsYXRpb24uamF2YQ==) | `100.00% <ø> (ø)` | `4.00 <0.00> (ø)` | |
   | [...ap/server/core/source/ServiceInstanceRelation.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL1NlcnZpY2VJbnN0YW5jZVJlbGF0aW9uLmphdmE=) | `100.00% <ø> (ø)` | `5.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `55.55% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `59.61% <0.00%> (ø)` | `6.00 <0.00> (ø)` | |
   | ... and [37 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [5289996...a34b9fd](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (8190912) into [master](https://codecov.io/gh/apache/skywalking/commit/b1a8238c159eaebda35771cd7c9c548e5eedfee1?el=desc) (b1a8238) will **decrease** coverage by `8.50%`.
   > The diff coverage is `8.23%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6322      +/-   ##
   ============================================
   - Coverage     41.42%   32.91%   -8.51%     
   + Complexity     2959     1978     -981     
   ============================================
     Files           953      804     -149     
     Lines         23209    19529    -3680     
     Branches       2262     1812     -450     
   ============================================
   - Hits           9614     6428    -3186     
   + Misses        12754    12636     -118     
   + Partials        841      465     -376     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `8.04% <0.00%> (-0.82%)` | `1.00 <0.00> (ø)` | |
   | [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `23.52% <0.00%> (+5.01%)` | `1.00 <0.00> (-1.00)` | :arrow_up: |
   | [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `55.55% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `59.61% <0.00%> (ø)` | `6.00 <0.00> (ø)` | |
   | [...iver/envoy/als/mx/MetaExchangeALSHTTPAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L01ldGFFeGNoYW5nZUFMU0hUVFBBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../receiver/envoy/als/mx/ServiceMetaInfoAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L1NlcnZpY2VNZXRhSW5mb0FkYXB0ZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | ... and [452 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [b1a8238...dbd6ae9](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (45dc5d6) into [master](https://codecov.io/gh/apache/skywalking/commit/6bc3ba025f889b0682d651d07f5b8037f41fff9c?el=desc) (6bc3ba0) will **increase** coverage by `14.57%`.
   > The diff coverage is `15.29%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #6322       +/-   ##
   =============================================
   + Coverage     31.05%   45.62%   +14.57%     
   - Complexity     2180     3325     +1145     
   =============================================
     Files           964      985       +21     
     Lines         23384    24239      +855     
     Branches       2263     2344       +81     
   =============================================
   + Hits           7262    11060     +3798     
   + Misses        15570    12263     -3307     
   - Partials        552      916      +364     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `8.04% <0.00%> (-0.82%)` | `1.00 <0.00> (ø)` | |
   | [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `23.52% <0.00%> (+5.01%)` | `1.00 <0.00> (-1.00)` | :arrow_up: |
   | [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `55.55% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `59.61% <0.00%> (ø)` | `6.00 <0.00> (ø)` | |
   | [...iver/envoy/als/mx/MetaExchangeALSHTTPAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L01ldGFFeGNoYW5nZUFMU0hUVFBBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../receiver/envoy/als/mx/ServiceMetaInfoAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L1NlcnZpY2VNZXRhSW5mb0FkYXB0ZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/persistence/LogsPersistence.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvcGVyc2lzdGVuY2UvTG9nc1BlcnNpc3RlbmNlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | ... and [332 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [6bc3ba0...d501f73](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (b9cf4d4) into [master](https://codecov.io/gh/apache/skywalking/commit/b1a8238c159eaebda35771cd7c9c548e5eedfee1?el=desc) (b1a8238) will **increase** coverage by `2.38%`.
   > The diff coverage is `14.60%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6322      +/-   ##
   ============================================
   + Coverage     49.17%   51.55%   +2.38%     
   + Complexity     3505     3110     -395     
   ============================================
     Files           984     1777     +793     
     Lines         24141    37687   +13546     
     Branches       2351     4313    +1962     
   ============================================
   + Hits          11871    19430    +7559     
   - Misses        11272    17276    +6004     
   + Partials        998      981      -17     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `24.21% <0.00%> (+15.34%)` | `4.00 <0.00> (+3.00)` | |
   | [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `23.52% <0.00%> (+5.01%)` | `1.00 <0.00> (-1.00)` | :arrow_up: |
   | [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `18.51% <0.00%> (-37.04%)` | `2.00 <0.00> (ø)` | |
   | [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `65.71% <0.00%> (+65.71%)` | `0.00 <0.00> (ø)` | |
   | [...iver/envoy/als/mx/MetaExchangeALSHTTPAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L01ldGFFeGNoYW5nZUFMU0hUVFBBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../receiver/envoy/als/mx/ServiceMetaInfoAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L1NlcnZpY2VNZXRhSW5mb0FkYXB0ZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/persistence/LogsPersistence.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvcGVyc2lzdGVuY2UvTG9nc1BlcnNpc3RlbmNlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `31.81% <50.00%> (-61.04%)` | `3.00 <0.00> (ø)` | |
   | [...ver/receiver/envoy/ServiceMetaInfoFactoryImpl.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvU2VydmljZU1ldGFJbmZvRmFjdG9yeUltcGwuamF2YQ==) | `50.00% <50.00%> (ø)` | `2.00 <2.00> (?)` | |
   | ... and [1273 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [b1a8238...dbd6ae9](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (aeefe63) into [master](https://codecov.io/gh/apache/skywalking/commit/5289996e4c65c9eb6cfa5565560ab0b3e5ba5822?el=desc) (5289996) will **increase** coverage by `10.11%`.
   > The diff coverage is `14.60%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #6322       +/-   ##
   =============================================
   + Coverage     42.09%   52.20%   +10.11%     
   - Complexity      432     3812     +3380     
   =============================================
     Files          1772     1777        +5     
     Lines         37594    37687       +93     
     Branches       4585     4145      -440     
   =============================================
   + Hits          15824    19674     +3850     
   + Misses        20781    17033     -3748     
   + Partials        989      980        -9     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `24.21% <0.00%> (+16.16%)` | `4.00 <0.00> (+4.00)` | |
   | [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `23.52% <0.00%> (+5.01%)` | `1.00 <0.00> (+1.00)` | |
   | [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (-80.00%)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `18.51% <0.00%> (+0.66%)` | `2.00 <0.00> (+2.00)` | |
   | [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `65.71% <0.00%> (-1.94%)` | `0.00 <0.00> (ø)` | |
   | [...iver/envoy/als/mx/MetaExchangeALSHTTPAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L01ldGFFeGNoYW5nZUFMU0hUVFBBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../receiver/envoy/als/mx/ServiceMetaInfoAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L1NlcnZpY2VNZXRhSW5mb0FkYXB0ZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/persistence/LogsPersistence.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvcGVyc2lzdGVuY2UvTG9nc1BlcnNpc3RlbmNlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `31.81% <50.00%> (+1.58%)` | `3.00 <0.00> (+3.00)` | |
   | [...ver/receiver/envoy/ServiceMetaInfoFactoryImpl.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvU2VydmljZU1ldGFJbmZvRmFjdG9yeUltcGwuamF2YQ==) | `50.00% <50.00%> (ø)` | `2.00 <2.00> (?)` | |
   | ... and [319 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [5289996...08605b4](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (b9cf4d4) into [master](https://codecov.io/gh/apache/skywalking/commit/b1a8238c159eaebda35771cd7c9c548e5eedfee1?el=desc) (b1a8238) will **increase** coverage by `7.68%`.
   > The diff coverage is `14.60%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6322      +/-   ##
   ============================================
   + Coverage     41.42%   49.10%   +7.68%     
   + Complexity     2959     2933      -26     
   ============================================
     Files           953     1777     +824     
     Lines         23209    37686   +14477     
     Branches       2262     4313    +2051     
   ============================================
   + Hits           9614    18507    +8893     
   - Misses        12754    18197    +5443     
   - Partials        841      982     +141     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `24.21% <0.00%> (+15.34%)` | `4.00 <0.00> (+3.00)` | |
   | [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `23.52% <0.00%> (+5.01%)` | `1.00 <0.00> (-1.00)` | :arrow_up: |
   | [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `18.51% <0.00%> (-37.04%)` | `2.00 <0.00> (ø)` | |
   | [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `65.71% <0.00%> (+65.71%)` | `0.00 <0.00> (ø)` | |
   | [...iver/envoy/als/mx/MetaExchangeALSHTTPAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L01ldGFFeGNoYW5nZUFMU0hUVFBBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../receiver/envoy/als/mx/ServiceMetaInfoAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L1NlcnZpY2VNZXRhSW5mb0FkYXB0ZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/persistence/LogsPersistence.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvcGVyc2lzdGVuY2UvTG9nc1BlcnNpc3RlbmNlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `31.81% <50.00%> (-61.04%)` | `3.00 <0.00> (ø)` | |
   | [...ver/receiver/envoy/ServiceMetaInfoFactoryImpl.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvU2VydmljZU1ldGFJbmZvRmFjdG9yeUltcGwuamF2YQ==) | `50.00% <50.00%> (ø)` | `2.00 <2.00> (?)` | |
   | ... and [1316 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [b1a8238...dbd6ae9](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (3287a8b) into [master](https://codecov.io/gh/apache/skywalking/commit/63bfb8d9ed90319553671b15627fa067db084996?el=desc) (63bfb8d) will **decrease** coverage by `10.27%`.
   > The diff coverage is `12.90%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #6322       +/-   ##
   =============================================
   - Coverage     58.16%   47.89%   -10.28%     
   + Complexity     4059     2874     -1185     
   =============================================
     Files           984      835      -149     
     Lines         24336    20691     -3645     
     Branches       2365     1943      -422     
   =============================================
   - Hits          14155     9909     -4246     
   - Misses         8947    10005     +1058     
   + Partials       1234      777      -457     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `24.21% <0.00%> (-2.23%)` | `4.00 <0.00> (ø)` | |
   | [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `23.52% <0.00%> (+5.01%)` | `1.00 <0.00> (-1.00)` | :arrow_up: |
   | [...lking/oap/server/core/source/EndpointRelation.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0VuZHBvaW50UmVsYXRpb24uamF2YQ==) | `100.00% <ø> (ø)` | `4.00 <0.00> (ø)` | |
   | [...ap/server/core/source/ServiceInstanceRelation.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL1NlcnZpY2VJbnN0YW5jZVJlbGF0aW9uLmphdmE=) | `100.00% <ø> (ø)` | `5.00 <0.00> (ø)` | |
   | [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (-90.00%)` | `0.00 <0.00> (-2.00)` | |
   | [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `55.55% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `59.61% <0.00%> (ø)` | `6.00 <0.00> (ø)` | |
   | ... and [310 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [5289996...8875f7e](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] kezhenxu94 commented on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773279087


   @wu-sheng can we discuss what else tags should be extracted?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (3287a8b) into [master](https://codecov.io/gh/apache/skywalking/commit/63bfb8d9ed90319553671b15627fa067db084996?el=desc) (63bfb8d) will **decrease** coverage by `5.37%`.
   > The diff coverage is `19.35%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6322      +/-   ##
   ============================================
   - Coverage     58.16%   52.78%   -5.38%     
   + Complexity     4059     3792     -267     
   ============================================
     Files           984      986       +2     
     Lines         24336    24345       +9     
     Branches       2365     2370       +5     
   ============================================
   - Hits          14155    12851    -1304     
   - Misses         8947    10374    +1427     
   + Partials       1234     1120     -114     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...king/apm/agent/core/remote/GRPCChannelManager.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsTWFuYWdlci5qYXZh) | `48.88% <ø> (ø)` | `12.00 <0.00> (ø)` | |
   | [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `24.21% <0.00%> (-2.23%)` | `4.00 <0.00> (ø)` | |
   | [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `23.52% <0.00%> (+5.01%)` | `1.00 <0.00> (-1.00)` | :arrow_up: |
   | [...lking/oap/server/core/source/EndpointRelation.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0VuZHBvaW50UmVsYXRpb24uamF2YQ==) | `100.00% <ø> (ø)` | `4.00 <0.00> (ø)` | |
   | [...ap/server/core/source/ServiceInstanceRelation.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL1NlcnZpY2VJbnN0YW5jZVJlbGF0aW9uLmphdmE=) | `100.00% <ø> (ø)` | `5.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `55.55% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `59.61% <0.00%> (ø)` | `6.00 <0.00> (ø)` | |
   | ... and [115 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [5289996...8875f7e](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (b9cf4d4) into [master](https://codecov.io/gh/apache/skywalking/commit/b1a8238c159eaebda35771cd7c9c548e5eedfee1?el=desc) (b1a8238) will **increase** coverage by `9.07%`.
   > The diff coverage is `14.60%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6322      +/-   ##
   ============================================
   + Coverage     41.42%   50.50%   +9.07%     
   - Complexity     2959     3028      +69     
   ============================================
     Files           953     1777     +824     
     Lines         23209    37687   +14478     
     Branches       2262     4313    +2051     
   ============================================
   + Hits           9614    19032    +9418     
   - Misses        12754    17673    +4919     
   - Partials        841      982     +141     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `24.21% <0.00%> (+15.34%)` | `4.00 <0.00> (+3.00)` | |
   | [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `23.52% <0.00%> (+5.01%)` | `1.00 <0.00> (-1.00)` | :arrow_up: |
   | [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `18.51% <0.00%> (-37.04%)` | `2.00 <0.00> (ø)` | |
   | [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `65.71% <0.00%> (+65.71%)` | `0.00 <0.00> (ø)` | |
   | [...iver/envoy/als/mx/MetaExchangeALSHTTPAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L01ldGFFeGNoYW5nZUFMU0hUVFBBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../receiver/envoy/als/mx/ServiceMetaInfoAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L1NlcnZpY2VNZXRhSW5mb0FkYXB0ZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/persistence/LogsPersistence.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvcGVyc2lzdGVuY2UvTG9nc1BlcnNpc3RlbmNlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `31.81% <50.00%> (-61.04%)` | `3.00 <0.00> (ø)` | |
   | [...ver/receiver/envoy/ServiceMetaInfoFactoryImpl.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvU2VydmljZU1ldGFJbmZvRmFjdG9yeUltcGwuamF2YQ==) | `50.00% <50.00%> (ø)` | `2.00 <2.00> (?)` | |
   | ... and [1327 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [b1a8238...dbd6ae9](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (3287a8b) into [master](https://codecov.io/gh/apache/skywalking/commit/63bfb8d9ed90319553671b15627fa067db084996?el=desc) (63bfb8d) will **decrease** coverage by `32.62%`.
   > The diff coverage is `7.52%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #6322       +/-   ##
   =============================================
   - Coverage     58.16%   25.53%   -32.63%     
   + Complexity     4059     1550     -2509     
   =============================================
     Files           984      804      -180     
     Lines         24336    19446     -4890     
     Branches       2365     1780      -585     
   =============================================
   - Hits          14155     4966     -9189     
   - Misses         8947    14143     +5196     
   + Partials       1234      337      -897     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...e/parser/listener/MultiScopesAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9NdWx0aVNjb3Blc0FuYWx5c2lzTGlzdGVuZXIuamF2YQ==) | `4.76% <0.00%> (-66.21%)` | `0.00 <0.00> (-25.00)` | |
   | [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `8.04% <0.00%> (-18.40%)` | `1.00 <0.00> (-3.00)` | |
   | [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `23.52% <0.00%> (+5.01%)` | `1.00 <0.00> (-1.00)` | :arrow_up: |
   | [...lking/oap/server/core/source/EndpointRelation.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0VuZHBvaW50UmVsYXRpb24uamF2YQ==) | `33.33% <ø> (-66.67%)` | `2.00 <0.00> (-2.00)` | |
   | [...ap/server/core/source/ServiceInstanceRelation.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL1NlcnZpY2VJbnN0YW5jZVJlbGF0aW9uLmphdmE=) | `27.27% <ø> (-72.73%)` | `2.00 <0.00> (-3.00)` | |
   | [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (-90.00%)` | `0.00 <0.00> (-2.00)` | |
   | [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `55.55% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | ... and [600 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [5289996...8875f7e](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (b9cf4d4) into [master](https://codecov.io/gh/apache/skywalking/commit/b1a8238c159eaebda35771cd7c9c548e5eedfee1?el=desc) (b1a8238) will **increase** coverage by `0.62%`.
   > The diff coverage is `14.60%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6322      +/-   ##
   ============================================
   + Coverage     50.99%   51.62%   +0.62%     
   + Complexity     3623     3121     -502     
   ============================================
     Files           984     1777     +793     
     Lines         24248    37687   +13439     
     Branches       2359     4313    +1954     
   ============================================
   + Hits          12366    19457    +7091     
   - Misses        10860    17249    +6389     
   + Partials       1022      981      -41     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `24.21% <0.00%> (+15.34%)` | `4.00 <0.00> (+3.00)` | |
   | [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `23.52% <0.00%> (+5.01%)` | `1.00 <0.00> (-1.00)` | :arrow_up: |
   | [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (-90.00%)` | `0.00 <0.00> (-2.00)` | |
   | [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `18.51% <0.00%> (-37.04%)` | `2.00 <0.00> (ø)` | |
   | [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `65.71% <0.00%> (+65.71%)` | `0.00 <0.00> (ø)` | |
   | [...iver/envoy/als/mx/MetaExchangeALSHTTPAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L01ldGFFeGNoYW5nZUFMU0hUVFBBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../receiver/envoy/als/mx/ServiceMetaInfoAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L1NlcnZpY2VNZXRhSW5mb0FkYXB0ZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/persistence/LogsPersistence.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvcGVyc2lzdGVuY2UvTG9nc1BlcnNpc3RlbmNlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `31.81% <50.00%> (-61.04%)` | `3.00 <0.00> (ø)` | |
   | [...ver/receiver/envoy/ServiceMetaInfoFactoryImpl.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvU2VydmljZU1ldGFJbmZvRmFjdG9yeUltcGwuamF2YQ==) | `50.00% <50.00%> (ø)` | `2.00 <2.00> (?)` | |
   | ... and [1274 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [b1a8238...dbd6ae9](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (5d644ce) into [master](https://codecov.io/gh/apache/skywalking/commit/6bc3ba025f889b0682d651d07f5b8037f41fff9c?el=desc) (6bc3ba0) will **increase** coverage by `20.37%`.
   > The diff coverage is `8.23%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #6322       +/-   ##
   =============================================
   + Coverage     31.05%   51.42%   +20.37%     
   - Complexity     2180     3679     +1499     
   =============================================
     Files           964      986       +22     
     Lines         23384    24338      +954     
     Branches       2263     2349       +86     
   =============================================
   + Hits           7262    12517     +5255     
   + Misses        15570    10737     -4833     
   - Partials        552     1084      +532     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `24.21% <0.00%> (+15.34%)` | `4.00 <0.00> (+3.00)` | |
   | [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `23.52% <0.00%> (+5.01%)` | `1.00 <0.00> (-1.00)` | :arrow_up: |
   | [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `55.55% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `59.61% <0.00%> (ø)` | `6.00 <0.00> (ø)` | |
   | [...iver/envoy/als/mx/MetaExchangeALSHTTPAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L01ldGFFeGNoYW5nZUFMU0hUVFBBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../receiver/envoy/als/mx/ServiceMetaInfoAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L1NlcnZpY2VNZXRhSW5mb0FkYXB0ZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | ... and [378 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [6bc3ba0...91e7ed7](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (45dc5d6) into [master](https://codecov.io/gh/apache/skywalking/commit/6bc3ba025f889b0682d651d07f5b8037f41fff9c?el=desc) (6bc3ba0) will **increase** coverage by `25.27%`.
   > The diff coverage is `15.29%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #6322       +/-   ##
   =============================================
   + Coverage     31.05%   56.32%   +25.27%     
   - Complexity     2180     3964     +1784     
   =============================================
     Files           964      986       +22     
     Lines         23384    24371      +987     
     Branches       2263     2370      +107     
   =============================================
   + Hits           7262    13728     +6466     
   + Misses        15570     9463     -6107     
   - Partials        552     1180      +628     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `24.21% <0.00%> (+15.34%)` | `4.00 <0.00> (+3.00)` | |
   | [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `23.52% <0.00%> (+5.01%)` | `1.00 <0.00> (-1.00)` | :arrow_up: |
   | [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `55.55% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `59.61% <0.00%> (ø)` | `6.00 <0.00> (ø)` | |
   | [...iver/envoy/als/mx/MetaExchangeALSHTTPAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L01ldGFFeGNoYW5nZUFMU0hUVFBBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../receiver/envoy/als/mx/ServiceMetaInfoAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L1NlcnZpY2VNZXRhSW5mb0FkYXB0ZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/persistence/LogsPersistence.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvcGVyc2lzdGVuY2UvTG9nc1BlcnNpc3RlbmNlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | ... and [464 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [6bc3ba0...d501f73](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (45c1b75) into [master](https://codecov.io/gh/apache/skywalking/commit/d12d3f201a315241bd7aeb5cc97c2d5103e67c02?el=desc) (d12d3f2) will **decrease** coverage by `14.24%`.
   > The diff coverage is `28.57%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #6322       +/-   ##
   =============================================
   - Coverage     53.22%   38.98%   -14.25%     
   + Complexity     3845     2307     -1538     
   =============================================
     Files          1731      796      -935     
     Lines         36905    19733    -17172     
     Branches       4076     1844     -2232     
   =============================================
   - Hits          19642     7692    -11950     
   + Misses        16288    11443     -4845     
   + Partials        975      598      -377     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...erver/core/analysis/data/MergableBufferedData.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9NZXJnYWJsZUJ1ZmZlcmVkRGF0YS5qYXZh) | `76.92% <0.00%> (-7.70%)` | `4.00 <0.00> (ø)` | |
   | [...lysis/manual/networkalias/NetworkAddressAlias.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL25ldHdvcmthbGlhcy9OZXR3b3JrQWRkcmVzc0FsaWFzLmphdmE=) | `2.43% <0.00%> (-56.10%)` | `0.00 <0.00> (-5.00)` | |
   | [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (-56.25%)` | `0.00 <0.00> (ø)` | |
   | [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-12.20%)` | `0.00 <0.00> (ø)` | |
   | [.../core/analysis/meter/function/avg/AvgFunction.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0Z1bmN0aW9uLmphdmE=) | `49.31% <0.00%> (-22.31%)` | `10.00 <0.00> (-4.00)` | |
   | [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-62.80%)` | `0.00 <0.00> (ø)` | |
   | [...r/function/avg/AvgHistogramPercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbVBlcmNlbnRpbGVGdW5jdGlvbi5qYXZh) | `0.00% <0.00%> (-62.12%)` | `0.00 <0.00> (-25.00)` | |
   | [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <0.00%> (-58.14%)` | `0.00 <0.00> (ø)` | |
   | [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-50.00%)` | `0.00 <0.00> (ø)` | |
   | [...oap/server/core/analysis/metrics/CountMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Db3VudE1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (-85.72%)` | `0.00 <0.00> (ø)` | |
   | ... and [1382 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [1e78a0a...ad99d9b](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (5876350) into [master](https://codecov.io/gh/apache/skywalking/commit/6bc3ba025f889b0682d651d07f5b8037f41fff9c?el=desc) (6bc3ba0) will **increase** coverage by `14.28%`.
   > The diff coverage is `8.23%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #6322       +/-   ##
   =============================================
   + Coverage     31.05%   45.33%   +14.28%     
   - Complexity     2180     3394     +1214     
   =============================================
     Files           964     1021       +57     
     Lines         23384    24909     +1525     
     Branches       2263     2438      +175     
   =============================================
   + Hits           7262    11293     +4031     
   + Misses        15570    12636     -2934     
   - Partials        552      980      +428     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `24.21% <0.00%> (+15.34%)` | `4.00 <0.00> (+3.00)` | |
   | [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `23.52% <0.00%> (+5.01%)` | `1.00 <0.00> (-1.00)` | :arrow_up: |
   | [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `55.55% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `59.61% <0.00%> (ø)` | `6.00 <0.00> (ø)` | |
   | [...iver/envoy/als/mx/MetaExchangeALSHTTPAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L01ldGFFeGNoYW5nZUFMU0hUVFBBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../receiver/envoy/als/mx/ServiceMetaInfoAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L1NlcnZpY2VNZXRhSW5mb0FkYXB0ZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | ... and [364 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [6bc3ba0...91e7ed7](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (8190912) into [master](https://codecov.io/gh/apache/skywalking/commit/b1a8238c159eaebda35771cd7c9c548e5eedfee1?el=desc) (b1a8238) will **increase** coverage by `16.16%`.
   > The diff coverage is `15.29%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #6322       +/-   ##
   =============================================
   + Coverage     41.42%   57.58%   +16.16%     
   - Complexity     2959     4017     +1058     
   =============================================
     Files           953      986       +33     
     Lines         23209    24366     +1157     
     Branches       2262     2366      +104     
   =============================================
   + Hits           9614    14031     +4417     
   + Misses        12754     9132     -3622     
   - Partials        841     1203      +362     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `24.21% <0.00%> (+15.34%)` | `4.00 <0.00> (+3.00)` | |
   | [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `23.52% <0.00%> (+5.01%)` | `1.00 <0.00> (-1.00)` | :arrow_up: |
   | [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `55.55% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `59.61% <0.00%> (ø)` | `6.00 <0.00> (ø)` | |
   | [...iver/envoy/als/mx/MetaExchangeALSHTTPAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L01ldGFFeGNoYW5nZUFMU0hUVFBBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../receiver/envoy/als/mx/ServiceMetaInfoAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L1NlcnZpY2VNZXRhSW5mb0FkYXB0ZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/persistence/LogsPersistence.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvcGVyc2lzdGVuY2UvTG9nc1BlcnNpc3RlbmNlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | ... and [280 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [b1a8238...dbd6ae9](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (5d644ce) into [master](https://codecov.io/gh/apache/skywalking/commit/6bc3ba025f889b0682d651d07f5b8037f41fff9c?el=desc) (6bc3ba0) will **increase** coverage by `8.79%`.
   > The diff coverage is `8.23%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6322      +/-   ##
   ============================================
   + Coverage     31.05%   39.84%   +8.79%     
   - Complexity     2180     2332     +152     
   ============================================
     Files           964      805     -159     
     Lines         23384    19716    -3668     
     Branches       2263     1847     -416     
   ============================================
   + Hits           7262     7856     +594     
   + Misses        15570    11270    -4300     
   - Partials        552      590      +38     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `8.04% <0.00%> (-0.82%)` | `1.00 <0.00> (ø)` | |
   | [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `23.52% <0.00%> (+5.01%)` | `1.00 <0.00> (-1.00)` | :arrow_up: |
   | [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `55.55% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `59.61% <0.00%> (ø)` | `6.00 <0.00> (ø)` | |
   | [...iver/envoy/als/mx/MetaExchangeALSHTTPAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L01ldGFFeGNoYW5nZUFMU0hUVFBBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../receiver/envoy/als/mx/ServiceMetaInfoAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L1NlcnZpY2VNZXRhSW5mb0FkYXB0ZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | ... and [253 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [6bc3ba0...91e7ed7](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (5876350) into [master](https://codecov.io/gh/apache/skywalking/commit/6bc3ba025f889b0682d651d07f5b8037f41fff9c?el=desc) (6bc3ba0) will **decrease** coverage by `31.05%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #6322       +/-   ##
   ============================================
   - Coverage     31.05%   0.00%   -31.06%     
   ============================================
     Files           964     202      -762     
     Lines         23384    4829    -18555     
     Branches       2263     556     -1707     
   ============================================
   - Hits           7262       0     -7262     
   + Misses        15570    4829    -10741     
   + Partials        552       0      -552     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...apm/commons/datacarrier/buffer/BufferStrategy.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXJTdHJhdGVneS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | [...skywalking/apm/util/PropertyPlaceholderHelper.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUHJvcGVydHlQbGFjZWhvbGRlckhlbHBlci5qYXZh) | `0.00% <0.00%> (-80.29%)` | `0.00% <0.00%> (-15.00%)` | |
   | [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-77.78%)` | `0.00% <0.00%> (-2.00%)` | |
   | [...atacarrier/partition/SimpleRollingPartitioner.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL3BhcnRpdGlvbi9TaW1wbGVSb2xsaW5nUGFydGl0aW9uZXIuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | [...m/commons/datacarrier/consumer/ConsumerThread.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVyVGhyZWFkLmphdmE=) | `0.00% <0.00%> (-60.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | [...kywalking/apm/commons/datacarrier/DataCarrier.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0RhdGFDYXJyaWVyLmphdmE=) | `0.00% <0.00%> (-53.85%)` | `0.00% <0.00%> (-8.00%)` | |
   | [...lking/apm/commons/datacarrier/buffer/Channels.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9DaGFubmVscy5qYXZh) | `0.00% <0.00%> (-50.00%)` | `0.00% <0.00%> (-6.00%)` | |
   | [...pm/commons/datacarrier/consumer/ConsumeDriver.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVEcml2ZXIuamF2YQ==) | `0.00% <0.00%> (-48.98%)` | `0.00% <0.00%> (-7.00%)` | |
   | [...he/skywalking/apm/commons/datacarrier/EnvUtil.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0VudlV0aWwuamF2YQ==) | `0.00% <0.00%> (-20.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | [...ava/org/apache/skywalking/apm/util/StringUtil.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvU3RyaW5nVXRpbC5qYXZh) | `0.00% <0.00%> (-14.64%)` | `0.00% <0.00%> (-10.00%)` | |
   | ... and [798 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [6bc3ba0...91e7ed7](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (5876350) into [master](https://codecov.io/gh/apache/skywalking/commit/6bc3ba025f889b0682d651d07f5b8037f41fff9c?el=desc) (6bc3ba0) will **decrease** coverage by `31.05%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #6322       +/-   ##
   ============================================
   - Coverage     31.05%   0.00%   -31.06%     
   ============================================
     Files           964     201      -763     
     Lines         23384    4803    -18581     
     Branches       2263     556     -1707     
   ============================================
   - Hits           7262       0     -7262     
   + Misses        15570    4803    -10767     
   + Partials        552       0      -552     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...apm/commons/datacarrier/buffer/BufferStrategy.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXJTdHJhdGVneS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | [...skywalking/apm/util/PropertyPlaceholderHelper.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUHJvcGVydHlQbGFjZWhvbGRlckhlbHBlci5qYXZh) | `0.00% <0.00%> (-80.29%)` | `0.00% <0.00%> (-15.00%)` | |
   | [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-77.78%)` | `0.00% <0.00%> (-2.00%)` | |
   | [...atacarrier/partition/SimpleRollingPartitioner.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL3BhcnRpdGlvbi9TaW1wbGVSb2xsaW5nUGFydGl0aW9uZXIuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | [...m/commons/datacarrier/consumer/ConsumerThread.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVyVGhyZWFkLmphdmE=) | `0.00% <0.00%> (-60.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | [...kywalking/apm/commons/datacarrier/DataCarrier.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0RhdGFDYXJyaWVyLmphdmE=) | `0.00% <0.00%> (-53.85%)` | `0.00% <0.00%> (-8.00%)` | |
   | [...lking/apm/commons/datacarrier/buffer/Channels.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9DaGFubmVscy5qYXZh) | `0.00% <0.00%> (-50.00%)` | `0.00% <0.00%> (-6.00%)` | |
   | [...pm/commons/datacarrier/consumer/ConsumeDriver.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVEcml2ZXIuamF2YQ==) | `0.00% <0.00%> (-48.98%)` | `0.00% <0.00%> (-7.00%)` | |
   | [...he/skywalking/apm/commons/datacarrier/EnvUtil.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0VudlV0aWwuamF2YQ==) | `0.00% <0.00%> (-20.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | [...ava/org/apache/skywalking/apm/util/StringUtil.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvU3RyaW5nVXRpbC5qYXZh) | `0.00% <0.00%> (-14.64%)` | `0.00% <0.00%> (-10.00%)` | |
   | ... and [797 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [6bc3ba0...91e7ed7](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (5876350) into [master](https://codecov.io/gh/apache/skywalking/commit/6bc3ba025f889b0682d651d07f5b8037f41fff9c?el=desc) (6bc3ba0) will **increase** coverage by `15.14%`.
   > The diff coverage is `8.23%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #6322       +/-   ##
   =============================================
   + Coverage     31.05%   46.19%   +15.14%     
   - Complexity     2180     3428     +1248     
   =============================================
     Files           964     1021       +57     
     Lines         23384    24919     +1535     
     Branches       2263     2439      +176     
   =============================================
   + Hits           7262    11512     +4250     
   + Misses        15570    12415     -3155     
   - Partials        552      992      +440     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `24.21% <0.00%> (+15.34%)` | `4.00 <0.00> (+3.00)` | |
   | [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `23.52% <0.00%> (+5.01%)` | `1.00 <0.00> (-1.00)` | :arrow_up: |
   | [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `55.55% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `59.61% <0.00%> (ø)` | `6.00 <0.00> (ø)` | |
   | [...iver/envoy/als/mx/MetaExchangeALSHTTPAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L01ldGFFeGNoYW5nZUFMU0hUVFBBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../receiver/envoy/als/mx/ServiceMetaInfoAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L1NlcnZpY2VNZXRhSW5mb0FkYXB0ZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | ... and [372 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [6bc3ba0...91e7ed7](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] wu-sheng commented on a change in pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#discussion_r585293139



##########
File path: oap-server/server-bootstrap/src/main/resources/lal/envoy-als.yaml
##########
@@ -0,0 +1,39 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+rules:
+  - name: envoy-als
+    dsl: |
+      filter {
+        json {
+        }
+        // only collect error logs
+        if (parsed?.response?.responseCode < 300 && !parsed?.commonProperties?.responseFlags) {

Review comment:
       I think this still is not perfect. If there is many upstream error mixing with some internal error, most likely those logs wouldn't be collected ever.
   I think we need 2 `rateLimit` sampling branches?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] wu-sheng commented on a change in pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#discussion_r585161842



##########
File path: oap-server/server-bootstrap/src/main/resources/lal/envoy.yaml
##########
@@ -0,0 +1,39 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+rules:
+  - name: envoy
+    dsl: |
+      filter {
+        json {
+        }
+        // only collect error logs
+        if (parsed?.response?.responseCode < 500 && !parsed?.commonProperties?.responseFlags) {

Review comment:
       We should set the sampling mechanism separated for responseFlags is null or not null when `parsed?.response?.responseCode < 500`, because upstream service error matters too.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#discussion_r585310135



##########
File path: test/e2e/e2e-test/src/test/resources/expected/als/endpoints-productpage.yml
##########
@@ -15,4 +15,4 @@
 
 endpoints:
   - key: not null
-    label: /productpage
+    label: GET:/productpage

Review comment:
       > When do we change this? If this pull request? I remember we had this before.
   
   No. In this PR, not before




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] kezhenxu94 edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
kezhenxu94 edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773279087


   
   <img width="1792" alt="Screen Shot 2021-02-04 at 20 35 48" src="https://user-images.githubusercontent.com/15965696/106894537-11cf0780-672a-11eb-874d-f9d30c5e0966.png">
   
   <img width="1792" alt="Screen Shot 2021-02-04 at 20 35 33" src="https://user-images.githubusercontent.com/15965696/106894554-1693bb80-672a-11eb-866b-80ebf2ee6ac9.png">
   
   
   @wu-sheng can we discuss what else tags should be extracted?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (45c1b75) into [master](https://codecov.io/gh/apache/skywalking/commit/d12d3f201a315241bd7aeb5cc97c2d5103e67c02?el=desc) (d12d3f2) will **decrease** coverage by `4.72%`.
   > The diff coverage is `30.95%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6322      +/-   ##
   ============================================
   - Coverage     53.22%   48.49%   -4.73%     
   + Complexity     3845     3439     -406     
   ============================================
     Files          1731      947     -784     
     Lines         36905    23491   -13414     
     Branches       4076     2280    -1796     
   ============================================
   - Hits          19642    11392    -8250     
   + Misses        16288    11059    -5229     
   - Partials        975     1040      +65     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...erver/core/analysis/data/MergableBufferedData.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9NZXJnYWJsZUJ1ZmZlcmVkRGF0YS5qYXZh) | `76.92% <0.00%> (-7.70%)` | `4.00 <0.00> (ø)` | |
   | [...lysis/manual/networkalias/NetworkAddressAlias.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL25ldHdvcmthbGlhcy9OZXR3b3JrQWRkcmVzc0FsaWFzLmphdmE=) | `2.43% <0.00%> (-56.10%)` | `0.00 <0.00> (-5.00)` | |
   | [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (-56.25%)` | `0.00 <0.00> (ø)` | |
   | [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-12.20%)` | `0.00 <0.00> (ø)` | |
   | [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-62.80%)` | `0.00 <0.00> (ø)` | |
   | [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <0.00%> (-58.14%)` | `0.00 <0.00> (ø)` | |
   | [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-50.00%)` | `0.00 <0.00> (ø)` | |
   | [...oap/server/core/analysis/metrics/CountMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Db3VudE1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (-85.72%)` | `0.00 <0.00> (ø)` | |
   | [...server/core/analysis/metrics/MaxDoubleMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhEb3VibGVNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...p/server/core/analysis/metrics/MaxLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhMb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-87.50%)` | `0.00 <0.00> (ø)` | |
   | ... and [1283 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [1e78a0a...ad99d9b](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (45c1b75) into [master](https://codecov.io/gh/apache/skywalking/commit/d12d3f201a315241bd7aeb5cc97c2d5103e67c02?el=desc) (d12d3f2) will **decrease** coverage by `8.52%`.
   > The diff coverage is `29.76%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6322      +/-   ##
   ============================================
   - Coverage     53.22%   44.69%   -8.53%     
   + Complexity     3845     3168     -677     
   ============================================
     Files          1731      947     -784     
     Lines         36905    23350   -13555     
     Branches       4076     2250    -1826     
   ============================================
   - Hits          19642    10437    -9205     
   + Misses        16288    11980    -4308     
   + Partials        975      933      -42     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...erver/core/analysis/data/MergableBufferedData.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9NZXJnYWJsZUJ1ZmZlcmVkRGF0YS5qYXZh) | `76.92% <0.00%> (-7.70%)` | `4.00 <0.00> (ø)` | |
   | [...lysis/manual/networkalias/NetworkAddressAlias.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL25ldHdvcmthbGlhcy9OZXR3b3JrQWRkcmVzc0FsaWFzLmphdmE=) | `2.43% <0.00%> (-56.10%)` | `0.00 <0.00> (-5.00)` | |
   | [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (-56.25%)` | `0.00 <0.00> (ø)` | |
   | [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-12.20%)` | `0.00 <0.00> (ø)` | |
   | [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-62.80%)` | `0.00 <0.00> (ø)` | |
   | [...r/function/avg/AvgHistogramPercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbVBlcmNlbnRpbGVGdW5jdGlvbi5qYXZh) | `0.00% <0.00%> (-62.12%)` | `0.00 <0.00> (-25.00)` | |
   | [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <0.00%> (-58.14%)` | `0.00 <0.00> (ø)` | |
   | [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-50.00%)` | `0.00 <0.00> (ø)` | |
   | [...oap/server/core/analysis/metrics/CountMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Db3VudE1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (-85.72%)` | `0.00 <0.00> (ø)` | |
   | [...server/core/analysis/metrics/MaxDoubleMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhEb3VibGVNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | ... and [1305 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [1e78a0a...ad99d9b](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (45c1b75) into [master](https://codecov.io/gh/apache/skywalking/commit/d12d3f201a315241bd7aeb5cc97c2d5103e67c02?el=desc) (d12d3f2) will **decrease** coverage by `21.16%`.
   > The diff coverage is `16.66%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #6322       +/-   ##
   =============================================
   - Coverage     53.22%   32.06%   -21.17%     
   + Complexity     3845     1951     -1894     
   =============================================
     Files          1731      795      -936     
     Lines         36905    19678    -17227     
     Branches       4076     1839     -2237     
   =============================================
   - Hits          19642     6309    -13333     
   + Misses        16288    12894     -3394     
   + Partials        975      475      -500     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...erver/core/analysis/data/MergableBufferedData.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9NZXJnYWJsZUJ1ZmZlcmVkRGF0YS5qYXZh) | `76.92% <0.00%> (-7.70%)` | `4.00 <0.00> (ø)` | |
   | [...lysis/manual/networkalias/NetworkAddressAlias.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL25ldHdvcmthbGlhcy9OZXR3b3JrQWRkcmVzc0FsaWFzLmphdmE=) | `2.43% <0.00%> (-56.10%)` | `0.00 <0.00> (-5.00)` | |
   | [...on/endpoint/EndpointRelationServerSideMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3JlbGF0aW9uL2VuZHBvaW50L0VuZHBvaW50UmVsYXRpb25TZXJ2ZXJTaWRlTWV0cmljcy5qYXZh) | `1.92% <0.00%> (-73.08%)` | `0.00 <0.00> (-7.00)` | |
   | [...ance/ServiceInstanceRelationClientSideMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3JlbGF0aW9uL2luc3RhbmNlL1NlcnZpY2VJbnN0YW5jZVJlbGF0aW9uQ2xpZW50U2lkZU1ldHJpY3MuamF2YQ==) | `1.69% <0.00%> (-69.50%)` | `0.00 <0.00> (-7.00)` | |
   | [...ance/ServiceInstanceRelationServerSideMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3JlbGF0aW9uL2luc3RhbmNlL1NlcnZpY2VJbnN0YW5jZVJlbGF0aW9uU2VydmVyU2lkZU1ldHJpY3MuamF2YQ==) | `1.69% <0.00%> (-69.50%)` | `0.00 <0.00> (-7.00)` | |
   | [...tion/service/ServiceRelationClientSideMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3JlbGF0aW9uL3NlcnZpY2UvU2VydmljZVJlbGF0aW9uQ2xpZW50U2lkZU1ldHJpY3MuamF2YQ==) | `2.12% <0.00%> (-70.22%)` | `0.00 <0.00> (-7.00)` | |
   | [...tion/service/ServiceRelationServerSideMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3JlbGF0aW9uL3NlcnZpY2UvU2VydmljZVJlbGF0aW9uU2VydmVyU2lkZU1ldHJpY3MuamF2YQ==) | `2.12% <0.00%> (-70.22%)` | `0.00 <0.00> (-7.00)` | |
   | [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (-56.25%)` | `0.00 <0.00> (ø)` | |
   | [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-12.20%)` | `0.00 <0.00> (ø)` | |
   | [.../core/analysis/meter/function/avg/AvgFunction.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0Z1bmN0aW9uLmphdmE=) | `4.10% <0.00%> (-67.52%)` | `2.00 <0.00> (-12.00)` | |
   | ... and [1428 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [1e78a0a...ad99d9b](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (5d644ce) into [master](https://codecov.io/gh/apache/skywalking/commit/6bc3ba025f889b0682d651d07f5b8037f41fff9c?el=desc) (6bc3ba0) will **increase** coverage by `23.81%`.
   > The diff coverage is `15.29%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #6322       +/-   ##
   =============================================
   + Coverage     31.05%   54.86%   +23.81%     
   - Complexity     2180     3904     +1724     
   =============================================
     Files           964      986       +22     
     Lines         23384    24366      +982     
     Branches       2263     2351       +88     
   =============================================
   + Hits           7262    13369     +6107     
   + Misses        15570     9831     -5739     
   - Partials        552     1166      +614     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `24.21% <0.00%> (+15.34%)` | `4.00 <0.00> (+3.00)` | |
   | [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `23.52% <0.00%> (+5.01%)` | `1.00 <0.00> (-1.00)` | :arrow_up: |
   | [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `55.55% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `59.61% <0.00%> (ø)` | `6.00 <0.00> (ø)` | |
   | [...iver/envoy/als/mx/MetaExchangeALSHTTPAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L01ldGFFeGNoYW5nZUFMU0hUVFBBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../receiver/envoy/als/mx/ServiceMetaInfoAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L1NlcnZpY2VNZXRhSW5mb0FkYXB0ZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/persistence/LogsPersistence.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvcGVyc2lzdGVuY2UvTG9nc1BlcnNpc3RlbmNlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | ... and [435 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [6bc3ba0...91e7ed7](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (45dc5d6) into [master](https://codecov.io/gh/apache/skywalking/commit/6bc3ba025f889b0682d651d07f5b8037f41fff9c?el=desc) (6bc3ba0) will **increase** coverage by `9.41%`.
   > The diff coverage is `15.29%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6322      +/-   ##
   ============================================
   + Coverage     31.05%   40.47%   +9.41%     
   - Complexity     2180     2367     +187     
   ============================================
     Files           964      805     -159     
     Lines         23384    19815    -3569     
     Branches       2263     1857     -406     
   ============================================
   + Hits           7262     8020     +758     
   + Misses        15570    11207    -4363     
   - Partials        552      588      +36     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `8.04% <0.00%> (-0.82%)` | `1.00 <0.00> (ø)` | |
   | [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `23.52% <0.00%> (+5.01%)` | `1.00 <0.00> (-1.00)` | :arrow_up: |
   | [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `55.55% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `59.61% <0.00%> (ø)` | `6.00 <0.00> (ø)` | |
   | [...iver/envoy/als/mx/MetaExchangeALSHTTPAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L01ldGFFeGNoYW5nZUFMU0hUVFBBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../receiver/envoy/als/mx/ServiceMetaInfoAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L1NlcnZpY2VNZXRhSW5mb0FkYXB0ZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/persistence/LogsPersistence.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvcGVyc2lzdGVuY2UvTG9nc1BlcnNpc3RlbmNlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | ... and [263 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [6bc3ba0...d501f73](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (c76eaff) into [master](https://codecov.io/gh/apache/skywalking/commit/5289996e4c65c9eb6cfa5565560ab0b3e5ba5822?el=desc) (5289996) will **decrease** coverage by `5.08%`.
   > The diff coverage is `8.23%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6322      +/-   ##
   ============================================
   - Coverage     42.09%   37.01%   -5.09%     
   - Complexity      432     2181    +1749     
   ============================================
     Files          1772      805     -967     
     Lines         37594    19646   -17948     
     Branches       4585     1843    -2742     
   ============================================
   - Hits          15824     7271    -8553     
   + Misses        20781    11822    -8959     
   + Partials        989      553     -436     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `8.04% <0.00%> (ø)` | `1.00 <0.00> (+1.00)` | |
   | [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `23.52% <0.00%> (+5.01%)` | `1.00 <0.00> (+1.00)` | |
   | [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (-80.00%)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `55.55% <ø> (+37.69%)` | `2.00 <0.00> (+2.00)` | |
   | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (-50.00%)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (-50.46%)` | `0.00 <0.00> (ø)` | |
   | [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (-67.65%)` | `0.00 <0.00> (ø)` | |
   | [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `59.61% <0.00%> (-29.07%)` | `6.00 <0.00> (+5.00)` | :arrow_down: |
   | [...iver/envoy/als/mx/MetaExchangeALSHTTPAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L01ldGFFeGNoYW5nZUFMU0hUVFBBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../receiver/envoy/als/mx/ServiceMetaInfoAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L1NlcnZpY2VNZXRhSW5mb0FkYXB0ZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | ... and [1321 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [5289996...a34b9fd](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (ad99d9b) into [master](https://codecov.io/gh/apache/skywalking/commit/d12d3f201a315241bd7aeb5cc97c2d5103e67c02?el=desc) (d12d3f2) will **decrease** coverage by `15.77%`.
   > The diff coverage is `29.76%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #6322       +/-   ##
   =============================================
   - Coverage     53.22%   37.45%   -15.78%     
   + Complexity     3845     2126     -1719     
   =============================================
     Files          1731      767      -964     
     Lines         36905    19006    -17899     
     Branches       4076     1777     -2299     
   =============================================
   - Hits          19642     7118    -12524     
   + Misses        16288    11336     -4952     
   + Partials        975      552      -423     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...erver/core/analysis/data/MergableBufferedData.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9NZXJnYWJsZUJ1ZmZlcmVkRGF0YS5qYXZh) | `76.92% <0.00%> (-7.70%)` | `4.00 <0.00> (ø)` | |
   | [...lysis/manual/networkalias/NetworkAddressAlias.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL25ldHdvcmthbGlhcy9OZXR3b3JrQWRkcmVzc0FsaWFzLmphdmE=) | `2.43% <0.00%> (-56.10%)` | `0.00 <0.00> (-5.00)` | |
   | [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (-56.25%)` | `0.00 <0.00> (ø)` | |
   | [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-12.20%)` | `0.00 <0.00> (ø)` | |
   | [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-62.80%)` | `0.00 <0.00> (ø)` | |
   | [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <0.00%> (-58.14%)` | `0.00 <0.00> (ø)` | |
   | [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-50.00%)` | `0.00 <0.00> (ø)` | |
   | [...oap/server/core/analysis/metrics/CountMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Db3VudE1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (-85.72%)` | `0.00 <0.00> (ø)` | |
   | [...server/core/analysis/metrics/MaxDoubleMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhEb3VibGVNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...p/server/core/analysis/metrics/MaxLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhMb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-87.50%)` | `0.00 <0.00> (ø)` | |
   | ... and [1418 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [1e78a0a...ad99d9b](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (8190912) into [master](https://codecov.io/gh/apache/skywalking/commit/b1a8238c159eaebda35771cd7c9c548e5eedfee1?el=desc) (b1a8238) will **increase** coverage by `15.80%`.
   > The diff coverage is `15.29%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #6322       +/-   ##
   =============================================
   + Coverage     41.42%   57.22%   +15.80%     
   - Complexity     2959     3996     +1037     
   =============================================
     Files           953      986       +33     
     Lines         23209    24353     +1144     
     Branches       2262     2366      +104     
   =============================================
   + Hits           9614    13937     +4323     
   + Misses        12754     9224     -3530     
   - Partials        841     1192      +351     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `24.21% <0.00%> (+15.34%)` | `4.00 <0.00> (+3.00)` | |
   | [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `23.52% <0.00%> (+5.01%)` | `1.00 <0.00> (-1.00)` | :arrow_up: |
   | [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `55.55% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `59.61% <0.00%> (ø)` | `6.00 <0.00> (ø)` | |
   | [...iver/envoy/als/mx/MetaExchangeALSHTTPAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L01ldGFFeGNoYW5nZUFMU0hUVFBBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../receiver/envoy/als/mx/ServiceMetaInfoAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L1NlcnZpY2VNZXRhSW5mb0FkYXB0ZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/persistence/LogsPersistence.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvcGVyc2lzdGVuY2UvTG9nc1BlcnNpc3RlbmNlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | ... and [274 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [b1a8238...dbd6ae9](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (b9cf4d4) into [master](https://codecov.io/gh/apache/skywalking/commit/b1a8238c159eaebda35771cd7c9c548e5eedfee1?el=desc) (b1a8238) will **increase** coverage by `0.44%`.
   > The diff coverage is `8.23%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6322      +/-   ##
   ============================================
   + Coverage     41.42%   41.87%   +0.44%     
   + Complexity     2959     2411     -548     
   ============================================
     Files           953      805     -148     
     Lines         23209    19607    -3602     
     Branches       2262     1819     -443     
   ============================================
   - Hits           9614     8210    -1404     
   + Misses        12754    10788    -1966     
   + Partials        841      609     -232     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `24.21% <0.00%> (+15.34%)` | `4.00 <0.00> (+3.00)` | |
   | [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `23.52% <0.00%> (+5.01%)` | `1.00 <0.00> (-1.00)` | :arrow_up: |
   | [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `55.55% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `59.61% <0.00%> (ø)` | `6.00 <0.00> (ø)` | |
   | [...iver/envoy/als/mx/MetaExchangeALSHTTPAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L01ldGFFeGNoYW5nZUFMU0hUVFBBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../receiver/envoy/als/mx/ServiceMetaInfoAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L1NlcnZpY2VNZXRhSW5mb0FkYXB0ZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | ... and [351 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [b1a8238...dbd6ae9](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] wu-sheng commented on a change in pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#discussion_r585292260



##########
File path: docs/en/setup/envoy/als_setting.md
##########
@@ -87,3 +88,20 @@ this analyzer requires Istio to enable the metadata exchange plugin (you can ena
 or if you're using Istio 1.7+ and installing it with profile `demo`/`preview`, it should be enabled then).
 
 The [blog](https://skywalking.apache.org/blog/obs-service-mesh-vm-with-sw-and-als/) illustrates the detail of how it works, and a step-by-step tutorial to apply it into the [Online Boutique](https://github.com/GoogleCloudPlatform/microservices-demo) system.
+
+### `persistence`
+
+`persistence` analyzer adapts the Envoy access log format to
+SkyWalking's [native log format](https://github.com/apache/skywalking-data-collect-protocol/blob/master/logging/Logging.proto)
+, and forwards the formatted logs to [LAL](../../concepts-and-designs/lal.md), where you can configure persistent
+conditions, such as `sampler`, only persist error logs, etc. SkyWalking provides a default configuration
+file [`envoy-als.yaml`](../../../../oap-server/server-bootstrap/src/main/resources/lal/envoy-als.yaml) that you can
+adjust as per your needs. Please make sure to activate this rule via adding the rule name `envoy-als`
+into config item `log-analyzer/default/lalFiles` (or environment variable `SW_LOG_LAL_FILES`,
+e.g. `SW_LOG_LAL_FILES=envoy-als`).
+
+**Attention**: because `persistence` analyzer also needs a mechanism to map the logs into responding services, hence,
+you need to configure at least one of `k8s-mesh` or `mx-mesh` as its antecedent so that `persistence` analyzer knows
+which service the logs belong to. For example, you should set `envoy-metric/default/alsHTTPAnalysis` (or environment
+variable `SW_ENVOY_METRIC_ALS_HTTP_ANALYSIS`) to something like `k8s-mesh,persistence`, `mx-mesh,persistence`
+or `k8s-mesh,mx-mesh,persistence`.

Review comment:
       ```suggestion
   or `mx-mesh,k8s-mesh,persistence`.
   ```
   I think this is a recommended order if you add both analyzers?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] wu-sheng commented on a change in pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#discussion_r585199507



##########
File path: oap-server/server-receiver-plugin/envoy-metrics-receiver-plugin/src/main/java/org/apache/skywalking/oap/server/receiver/envoy/persistence/LogsPersistence.java
##########
@@ -0,0 +1,117 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.oap.server.receiver.envoy.persistence;
+
+import com.google.protobuf.TextFormat;
+import io.envoyproxy.envoy.data.accesslog.v3.HTTPAccessLogEntry;
+import io.envoyproxy.envoy.service.accesslog.v3.StreamAccessLogsMessage;
+import java.io.IOException;
+import java.util.List;
+import lombok.extern.slf4j.Slf4j;
+import org.apache.skywalking.apm.network.common.v3.DetectPoint;
+import org.apache.skywalking.apm.network.logging.v3.JSONLog;
+import org.apache.skywalking.apm.network.logging.v3.LogData;
+import org.apache.skywalking.apm.network.logging.v3.LogDataBody;
+import org.apache.skywalking.apm.network.servicemesh.v3.ServiceMeshMetric;
+import org.apache.skywalking.oap.log.analyzer.module.LogAnalyzerModule;
+import org.apache.skywalking.oap.log.analyzer.provider.log.ILogAnalyzerService;
+import org.apache.skywalking.oap.server.library.module.ModuleManager;
+import org.apache.skywalking.oap.server.library.module.ModuleStartException;
+import org.apache.skywalking.oap.server.receiver.envoy.EnvoyMetricReceiverConfig;
+import org.apache.skywalking.oap.server.receiver.envoy.als.ALSHTTPAnalysis;
+import org.apache.skywalking.oap.server.receiver.envoy.als.Role;
+
+import static org.apache.skywalking.oap.server.library.util.ProtoBufJsonUtils.toJSON;
+
+/**
+ * {@code LogsPersistence} analyzes the error logs and persists them to the log system.
+ */
+@Slf4j
+public class LogsPersistence implements ALSHTTPAnalysis {
+    private ILogAnalyzerService logAnalyzerService;
+
+    @Override
+    public String name() {
+        return "persistence";
+    }
+
+    @Override
+    public void init(final ModuleManager manager, final EnvoyMetricReceiverConfig config) throws ModuleStartException {
+        logAnalyzerService = manager.find(LogAnalyzerModule.NAME)
+                                    .provider()
+                                    .getService(ILogAnalyzerService.class);

Review comment:
       My point is, does user know? I notice there is not doc in the `als_setting` says you need to set this configuration, how should user know this should be activated?
   I know activating through API is challenge, but at least, we need this to be clear for the end user.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (5d644ce) into [master](https://codecov.io/gh/apache/skywalking/commit/6bc3ba025f889b0682d651d07f5b8037f41fff9c?el=desc) (6bc3ba0) will **increase** coverage by `11.54%`.
   > The diff coverage is `8.23%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #6322       +/-   ##
   =============================================
   + Coverage     31.05%   42.59%   +11.54%     
   - Complexity     2180     2587      +407     
   =============================================
     Files           964      835      -129     
     Lines         23384    20533     -2851     
     Branches       2263     1927      -336     
   =============================================
   + Hits           7262     8747     +1485     
   + Misses        15570    11139     -4431     
   - Partials        552      647       +95     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `8.04% <0.00%> (-0.82%)` | `1.00 <0.00> (ø)` | |
   | [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `23.52% <0.00%> (+5.01%)` | `1.00 <0.00> (-1.00)` | :arrow_up: |
   | [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `55.55% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `59.61% <0.00%> (ø)` | `6.00 <0.00> (ø)` | |
   | [...iver/envoy/als/mx/MetaExchangeALSHTTPAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L01ldGFFeGNoYW5nZUFMU0hUVFBBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../receiver/envoy/als/mx/ServiceMetaInfoAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L1NlcnZpY2VNZXRhSW5mb0FkYXB0ZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | ... and [315 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [6bc3ba0...91e7ed7](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (5876350) into [master](https://codecov.io/gh/apache/skywalking/commit/6bc3ba025f889b0682d651d07f5b8037f41fff9c?el=desc) (6bc3ba0) will **decrease** coverage by `0.95%`.
   > The diff coverage is `8.23%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6322      +/-   ##
   ============================================
   - Coverage     31.05%   30.09%   -0.96%     
   + Complexity     2180     2151      -29     
   ============================================
     Files           964      991      +27     
     Lines         23384    23891     +507     
     Branches       2263     2305      +42     
   ============================================
   - Hits           7262     7191      -71     
   - Misses        15570    16175     +605     
   + Partials        552      525      -27     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `24.21% <0.00%> (+15.34%)` | `4.00 <0.00> (+3.00)` | |
   | [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `23.52% <0.00%> (+5.01%)` | `1.00 <0.00> (-1.00)` | :arrow_up: |
   | [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `55.55% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `59.61% <0.00%> (ø)` | `6.00 <0.00> (ø)` | |
   | [...iver/envoy/als/mx/MetaExchangeALSHTTPAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L01ldGFFeGNoYW5nZUFMU0hUVFBBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../receiver/envoy/als/mx/ServiceMetaInfoAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L1NlcnZpY2VNZXRhSW5mb0FkYXB0ZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | ... and [165 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [6bc3ba0...91e7ed7](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (8190912) into [master](https://codecov.io/gh/apache/skywalking/commit/b1a8238c159eaebda35771cd7c9c548e5eedfee1?el=desc) (b1a8238) will **increase** coverage by `10.82%`.
   > The diff coverage is `8.23%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #6322       +/-   ##
   =============================================
   + Coverage     41.42%   52.24%   +10.82%     
   - Complexity     2959     3727      +768     
   =============================================
     Files           953      986       +33     
     Lines         23209    24213     +1004     
     Branches       2262     2357       +95     
   =============================================
   + Hits           9614    12651     +3037     
   + Misses        12754    10446     -2308     
   - Partials        841     1116      +275     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `24.21% <0.00%> (+15.34%)` | `4.00 <0.00> (+3.00)` | |
   | [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `23.52% <0.00%> (+5.01%)` | `1.00 <0.00> (-1.00)` | :arrow_up: |
   | [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `53.33% <0.00%> (+53.33%)` | `1.00 <0.00> (+1.00)` | |
   | [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `55.55% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `59.61% <0.00%> (ø)` | `6.00 <0.00> (ø)` | |
   | [...iver/envoy/als/mx/MetaExchangeALSHTTPAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L01ldGFFeGNoYW5nZUFMU0hUVFBBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../receiver/envoy/als/mx/ServiceMetaInfoAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L1NlcnZpY2VNZXRhSW5mb0FkYXB0ZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | ... and [254 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [b1a8238...dbd6ae9](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (5876350) into [master](https://codecov.io/gh/apache/skywalking/commit/6bc3ba025f889b0682d651d07f5b8037f41fff9c?el=desc) (6bc3ba0) will **increase** coverage by `14.11%`.
   > The diff coverage is `8.23%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #6322       +/-   ##
   =============================================
   + Coverage     31.05%   45.17%   +14.11%     
   - Complexity     2180     3388     +1208     
   =============================================
     Files           964     1021       +57     
     Lines         23384    24909     +1525     
     Branches       2263     2438      +175     
   =============================================
   + Hits           7262    11252     +3990     
   + Misses        15570    12686     -2884     
   - Partials        552      971      +419     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `24.21% <0.00%> (+15.34%)` | `4.00 <0.00> (+3.00)` | |
   | [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `23.52% <0.00%> (+5.01%)` | `1.00 <0.00> (-1.00)` | :arrow_up: |
   | [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `55.55% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `59.61% <0.00%> (ø)` | `6.00 <0.00> (ø)` | |
   | [...iver/envoy/als/mx/MetaExchangeALSHTTPAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L01ldGFFeGNoYW5nZUFMU0hUVFBBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../receiver/envoy/als/mx/ServiceMetaInfoAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L1NlcnZpY2VNZXRhSW5mb0FkYXB0ZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | ... and [364 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [6bc3ba0...91e7ed7](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#discussion_r585183090



##########
File path: oap-server/server-bootstrap/src/main/resources/lal/envoy.yaml
##########
@@ -0,0 +1,39 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+rules:
+  - name: envoy
+    dsl: |
+      filter {
+        json {
+        }
+        // only collect error logs
+        if (parsed?.response?.responseCode < 500 && !parsed?.commonProperties?.responseFlags) {

Review comment:
       Do you want to also sample those logs when `parsed?.response?.responseCode < 500`, like 404, 302?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (b9cf4d4) into [master](https://codecov.io/gh/apache/skywalking/commit/b1a8238c159eaebda35771cd7c9c548e5eedfee1?el=desc) (b1a8238) will **increase** coverage by `5.62%`.
   > The diff coverage is `14.60%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6322      +/-   ##
   ============================================
   + Coverage     41.42%   47.05%   +5.62%     
   + Complexity     2959     2776     -183     
   ============================================
     Files           953     1767     +814     
     Lines         23209    37355   +14146     
     Branches       2262     4303    +2041     
   ============================================
   + Hits           9614    17576    +7962     
   - Misses        12754    18794    +6040     
   - Partials        841      985     +144     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `24.21% <0.00%> (+15.34%)` | `4.00 <0.00> (+3.00)` | |
   | [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `23.52% <0.00%> (+5.01%)` | `1.00 <0.00> (-1.00)` | :arrow_up: |
   | [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `18.51% <0.00%> (-37.04%)` | `2.00 <0.00> (ø)` | |
   | [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `65.71% <0.00%> (+65.71%)` | `0.00 <0.00> (ø)` | |
   | [...iver/envoy/als/mx/MetaExchangeALSHTTPAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L01ldGFFeGNoYW5nZUFMU0hUVFBBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../receiver/envoy/als/mx/ServiceMetaInfoAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L1NlcnZpY2VNZXRhSW5mb0FkYXB0ZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/persistence/LogsPersistence.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvcGVyc2lzdGVuY2UvTG9nc1BlcnNpc3RlbmNlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `31.81% <50.00%> (-61.04%)` | `3.00 <0.00> (ø)` | |
   | [...ver/receiver/envoy/ServiceMetaInfoFactoryImpl.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvU2VydmljZU1ldGFJbmZvRmFjdG9yeUltcGwuamF2YQ==) | `50.00% <50.00%> (ø)` | `2.00 <2.00> (?)` | |
   | ... and [1355 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [b1a8238...dbd6ae9](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] wu-sheng commented on a change in pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#discussion_r585340637



##########
File path: oap-server/server-bootstrap/src/main/resources/lal/envoy-als.yaml
##########
@@ -0,0 +1,47 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+rules:
+  - name: envoy-als
+    dsl: |
+      filter {
+        json {
+        }
+        // only collect abnormal logs (http status code >= 300, or commonProperties?.responseFlags is not empty)
+        if (parsed?.response?.responseCode < 300 && !parsed?.commonProperties?.responseFlags) {
+          abort {}
+        }
+        extractor {
+          tag 'status.code': parsed?.response?.responseCode as int
+          tag 'response.flag': parsed?.commonProperties?.responseFlags?.keySet()
+        }
+        sink {
+          sampler {
+            if (parsed?.commonProperties?.responseFlags) {
+              // use service:errorCode as sampler id so that each service:errorCode has its own sampler,
+              // e.g. checkoutservice:[upstreamConnectionFailure], checkoutservice:[upstreamRetryLimitExceeded]
+              rateLimit("${log.service}:${parsed?.commonProperties?.responseFlags?.keySet()}") {

Review comment:
       From my understanding, this means collect less than 100/s per error response flag  ?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (4aa0aa8) into [master](https://codecov.io/gh/apache/skywalking/commit/b1a8238c159eaebda35771cd7c9c548e5eedfee1?el=desc) (b1a8238) will **decrease** coverage by `15.18%`.
   > The diff coverage is `8.23%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #6322       +/-   ##
   =============================================
   - Coverage     41.42%   26.23%   -15.19%     
   + Complexity     2959     1699     -1260     
   =============================================
     Files           953      834      -119     
     Lines         23209    20337     -2872     
     Branches       2262     1892      -370     
   =============================================
   - Hits           9614     5336     -4278     
   - Misses        12754    14626     +1872     
   + Partials        841      375      -466     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `8.04% <0.00%> (-0.82%)` | `1.00 <0.00> (ø)` | |
   | [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `23.52% <0.00%> (+5.01%)` | `1.00 <0.00> (-1.00)` | :arrow_up: |
   | [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `55.55% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `59.61% <0.00%> (ø)` | `6.00 <0.00> (ø)` | |
   | [...iver/envoy/als/mx/MetaExchangeALSHTTPAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L01ldGFFeGNoYW5nZUFMU0hUVFBBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../receiver/envoy/als/mx/ServiceMetaInfoAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L1NlcnZpY2VNZXRhSW5mb0FkYXB0ZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | ... and [462 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [b1a8238...dbd6ae9](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (45c1b75) into [master](https://codecov.io/gh/apache/skywalking/commit/d12d3f201a315241bd7aeb5cc97c2d5103e67c02?el=desc) (d12d3f2) will **decrease** coverage by `3.52%`.
   > The diff coverage is `30.95%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6322      +/-   ##
   ============================================
   - Coverage     53.22%   49.69%   -3.53%     
   + Complexity     3845     3490     -355     
   ============================================
     Files          1731      947     -784     
     Lines         36905    23500   -13405     
     Branches       4076     2295    -1781     
   ============================================
   - Hits          19642    11679    -7963     
   + Misses        16288    10743    -5545     
   - Partials        975     1078     +103     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...erver/core/analysis/data/MergableBufferedData.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9NZXJnYWJsZUJ1ZmZlcmVkRGF0YS5qYXZh) | `76.92% <0.00%> (-7.70%)` | `4.00 <0.00> (ø)` | |
   | [...lysis/manual/networkalias/NetworkAddressAlias.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL25ldHdvcmthbGlhcy9OZXR3b3JrQWRkcmVzc0FsaWFzLmphdmE=) | `2.43% <0.00%> (-56.10%)` | `0.00 <0.00> (-5.00)` | |
   | [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (-56.25%)` | `0.00 <0.00> (ø)` | |
   | [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-12.20%)` | `0.00 <0.00> (ø)` | |
   | [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-62.80%)` | `0.00 <0.00> (ø)` | |
   | [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <0.00%> (-58.14%)` | `0.00 <0.00> (ø)` | |
   | [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-50.00%)` | `0.00 <0.00> (ø)` | |
   | [...oap/server/core/analysis/metrics/CountMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Db3VudE1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (-85.72%)` | `0.00 <0.00> (ø)` | |
   | [...server/core/analysis/metrics/MaxDoubleMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhEb3VibGVNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...p/server/core/analysis/metrics/MaxLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhMb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-87.50%)` | `0.00 <0.00> (ø)` | |
   | ... and [1274 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [1e78a0a...ad99d9b](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (5876350) into [master](https://codecov.io/gh/apache/skywalking/commit/6bc3ba025f889b0682d651d07f5b8037f41fff9c?el=desc) (6bc3ba0) will **decrease** coverage by `0.62%`.
   > The diff coverage is `8.23%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6322      +/-   ##
   ============================================
   - Coverage     31.05%   30.42%   -0.63%     
   + Complexity     2180     2161      -19     
   ============================================
     Files           964      991      +27     
     Lines         23384    23891     +507     
     Branches       2263     2305      +42     
   ============================================
   + Hits           7262     7270       +8     
   - Misses        15570    16083     +513     
   + Partials        552      538      -14     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `24.21% <0.00%> (+15.34%)` | `4.00 <0.00> (+3.00)` | |
   | [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `23.52% <0.00%> (+5.01%)` | `1.00 <0.00> (-1.00)` | :arrow_up: |
   | [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `55.55% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `59.61% <0.00%> (ø)` | `6.00 <0.00> (ø)` | |
   | [...iver/envoy/als/mx/MetaExchangeALSHTTPAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L01ldGFFeGNoYW5nZUFMU0hUVFBBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../receiver/envoy/als/mx/ServiceMetaInfoAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L1NlcnZpY2VNZXRhSW5mb0FkYXB0ZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | ... and [164 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [6bc3ba0...91e7ed7](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (45c1b75) into [master](https://codecov.io/gh/apache/skywalking/commit/d12d3f201a315241bd7aeb5cc97c2d5103e67c02?el=desc) (d12d3f2) will **decrease** coverage by `2.26%`.
   > The diff coverage is `30.95%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6322      +/-   ##
   ============================================
   - Coverage     53.22%   50.95%   -2.27%     
   + Complexity     3845     3550     -295     
   ============================================
     Files          1731      947     -784     
     Lines         36905    23510   -13395     
     Branches       4076     2296    -1780     
   ============================================
   - Hits          19642    11980    -7662     
   + Misses        16288    10437    -5851     
   - Partials        975     1093     +118     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...erver/core/analysis/data/MergableBufferedData.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9NZXJnYWJsZUJ1ZmZlcmVkRGF0YS5qYXZh) | `76.92% <0.00%> (-7.70%)` | `4.00 <0.00> (ø)` | |
   | [...lysis/manual/networkalias/NetworkAddressAlias.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL25ldHdvcmthbGlhcy9OZXR3b3JrQWRkcmVzc0FsaWFzLmphdmE=) | `2.43% <0.00%> (-56.10%)` | `0.00 <0.00> (-5.00)` | |
   | [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (-56.25%)` | `0.00 <0.00> (ø)` | |
   | [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-12.20%)` | `0.00 <0.00> (ø)` | |
   | [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-62.80%)` | `0.00 <0.00> (ø)` | |
   | [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <0.00%> (-58.14%)` | `0.00 <0.00> (ø)` | |
   | [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-50.00%)` | `0.00 <0.00> (ø)` | |
   | [...oap/server/core/analysis/metrics/CountMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Db3VudE1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (-85.72%)` | `0.00 <0.00> (ø)` | |
   | [...server/core/analysis/metrics/MaxDoubleMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhEb3VibGVNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...p/server/core/analysis/metrics/MaxLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhMb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-87.50%)` | `0.00 <0.00> (ø)` | |
   | ... and [1278 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [1e78a0a...ad99d9b](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (45c1b75) into [master](https://codecov.io/gh/apache/skywalking/commit/d12d3f201a315241bd7aeb5cc97c2d5103e67c02?el=desc) (d12d3f2) will **decrease** coverage by `3.15%`.
   > The diff coverage is `30.95%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6322      +/-   ##
   ============================================
   - Coverage     53.22%   50.07%   -3.16%     
   + Complexity     3845     3517     -328     
   ============================================
     Files          1731      947     -784     
     Lines         36905    23500   -13405     
     Branches       4076     2295    -1781     
   ============================================
   - Hits          19642    11767    -7875     
   + Misses        16288    10658    -5630     
   - Partials        975     1075     +100     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...erver/core/analysis/data/MergableBufferedData.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9NZXJnYWJsZUJ1ZmZlcmVkRGF0YS5qYXZh) | `76.92% <0.00%> (-7.70%)` | `4.00 <0.00> (ø)` | |
   | [...lysis/manual/networkalias/NetworkAddressAlias.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL25ldHdvcmthbGlhcy9OZXR3b3JrQWRkcmVzc0FsaWFzLmphdmE=) | `2.43% <0.00%> (-56.10%)` | `0.00 <0.00> (-5.00)` | |
   | [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (-56.25%)` | `0.00 <0.00> (ø)` | |
   | [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-12.20%)` | `0.00 <0.00> (ø)` | |
   | [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-62.80%)` | `0.00 <0.00> (ø)` | |
   | [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <0.00%> (-58.14%)` | `0.00 <0.00> (ø)` | |
   | [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-50.00%)` | `0.00 <0.00> (ø)` | |
   | [...oap/server/core/analysis/metrics/CountMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Db3VudE1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (-85.72%)` | `0.00 <0.00> (ø)` | |
   | [...server/core/analysis/metrics/MaxDoubleMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhEb3VibGVNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...p/server/core/analysis/metrics/MaxLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhMb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-87.50%)` | `0.00 <0.00> (ø)` | |
   | ... and [1278 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [1e78a0a...ad99d9b](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (ad99d9b) into [master](https://codecov.io/gh/apache/skywalking/commit/d12d3f201a315241bd7aeb5cc97c2d5103e67c02?el=desc) (d12d3f2) will **decrease** coverage by `13.32%`.
   > The diff coverage is `29.76%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #6322       +/-   ##
   =============================================
   - Coverage     53.22%   39.89%   -13.33%     
   + Complexity     3845     2340     -1505     
   =============================================
     Files          1731      796      -935     
     Lines         36905    19847    -17058     
     Branches       4076     1873     -2203     
   =============================================
   - Hits          19642     7918    -11724     
   + Misses        16288    11331     -4957     
   + Partials        975      598      -377     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...erver/core/analysis/data/MergableBufferedData.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9NZXJnYWJsZUJ1ZmZlcmVkRGF0YS5qYXZh) | `76.92% <0.00%> (-7.70%)` | `4.00 <0.00> (ø)` | |
   | [...lysis/manual/networkalias/NetworkAddressAlias.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL25ldHdvcmthbGlhcy9OZXR3b3JrQWRkcmVzc0FsaWFzLmphdmE=) | `2.43% <0.00%> (-56.10%)` | `0.00 <0.00> (-5.00)` | |
   | [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (-56.25%)` | `0.00 <0.00> (ø)` | |
   | [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-12.20%)` | `0.00 <0.00> (ø)` | |
   | [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-62.80%)` | `0.00 <0.00> (ø)` | |
   | [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <0.00%> (-58.14%)` | `0.00 <0.00> (ø)` | |
   | [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-50.00%)` | `0.00 <0.00> (ø)` | |
   | [...oap/server/core/analysis/metrics/CountMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Db3VudE1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (-85.72%)` | `0.00 <0.00> (ø)` | |
   | [...server/core/analysis/metrics/MaxDoubleMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhEb3VibGVNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...p/server/core/analysis/metrics/MaxLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhMb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-87.50%)` | `0.00 <0.00> (ø)` | |
   | ... and [1383 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [1e78a0a...ad99d9b](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] wu-sheng commented on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773279566


   > @wu-sheng can we discuss what else tags should be extracted?
   
   What tags do you have for now?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (45c1b75) into [master](https://codecov.io/gh/apache/skywalking/commit/d12d3f201a315241bd7aeb5cc97c2d5103e67c02?el=desc) (d12d3f2) will **decrease** coverage by `2.29%`.
   > The diff coverage is `30.95%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6322      +/-   ##
   ============================================
   - Coverage     53.22%   50.92%   -2.30%     
   + Complexity     3845     3547     -298     
   ============================================
     Files          1731      947     -784     
     Lines         36905    23510   -13395     
     Branches       4076     2296    -1780     
   ============================================
   - Hits          19642    11973    -7669     
   + Misses        16288    10444    -5844     
   - Partials        975     1093     +118     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...erver/core/analysis/data/MergableBufferedData.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9NZXJnYWJsZUJ1ZmZlcmVkRGF0YS5qYXZh) | `76.92% <0.00%> (-7.70%)` | `4.00 <0.00> (ø)` | |
   | [...lysis/manual/networkalias/NetworkAddressAlias.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL25ldHdvcmthbGlhcy9OZXR3b3JrQWRkcmVzc0FsaWFzLmphdmE=) | `2.43% <0.00%> (-56.10%)` | `0.00 <0.00> (-5.00)` | |
   | [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (-56.25%)` | `0.00 <0.00> (ø)` | |
   | [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-12.20%)` | `0.00 <0.00> (ø)` | |
   | [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-62.80%)` | `0.00 <0.00> (ø)` | |
   | [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <0.00%> (-58.14%)` | `0.00 <0.00> (ø)` | |
   | [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-50.00%)` | `0.00 <0.00> (ø)` | |
   | [...oap/server/core/analysis/metrics/CountMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Db3VudE1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (-85.72%)` | `0.00 <0.00> (ø)` | |
   | [...server/core/analysis/metrics/MaxDoubleMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhEb3VibGVNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...p/server/core/analysis/metrics/MaxLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhMb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-87.50%)` | `0.00 <0.00> (ø)` | |
   | ... and [1278 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [1e78a0a...ad99d9b](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (45c1b75) into [master](https://codecov.io/gh/apache/skywalking/commit/d12d3f201a315241bd7aeb5cc97c2d5103e67c02?el=desc) (d12d3f2) will **increase** coverage by `0.88%`.
   > The diff coverage is `30.95%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6322      +/-   ##
   ============================================
   + Coverage     53.22%   54.10%   +0.88%     
   + Complexity     3845     3695     -150     
   ============================================
     Files          1731      947     -784     
     Lines         36905    23546   -13359     
     Branches       4076     2297    -1779     
   ============================================
   - Hits          19642    12740    -6902     
   + Misses        16288     9674    -6614     
   - Partials        975     1132     +157     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...erver/core/analysis/data/MergableBufferedData.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9NZXJnYWJsZUJ1ZmZlcmVkRGF0YS5qYXZh) | `76.92% <0.00%> (-7.70%)` | `4.00 <0.00> (ø)` | |
   | [...lysis/manual/networkalias/NetworkAddressAlias.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL25ldHdvcmthbGlhcy9OZXR3b3JrQWRkcmVzc0FsaWFzLmphdmE=) | `2.43% <0.00%> (-56.10%)` | `0.00 <0.00> (-5.00)` | |
   | [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (-56.25%)` | `0.00 <0.00> (ø)` | |
   | [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-12.20%)` | `0.00 <0.00> (ø)` | |
   | [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-62.80%)` | `0.00 <0.00> (ø)` | |
   | [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <0.00%> (-58.14%)` | `0.00 <0.00> (ø)` | |
   | [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-50.00%)` | `0.00 <0.00> (ø)` | |
   | [...oap/server/core/analysis/metrics/CountMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Db3VudE1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (-85.72%)` | `0.00 <0.00> (ø)` | |
   | [...server/core/analysis/metrics/MaxDoubleMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhEb3VibGVNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...p/server/core/analysis/metrics/MaxLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhMb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-87.50%)` | `0.00 <0.00> (ø)` | |
   | ... and [1265 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [1e78a0a...ad99d9b](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (45dc5d6) into [master](https://codecov.io/gh/apache/skywalking/commit/6bc3ba025f889b0682d651d07f5b8037f41fff9c?el=desc) (6bc3ba0) will **increase** coverage by `25.89%`.
   > The diff coverage is `15.29%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #6322       +/-   ##
   =============================================
   + Coverage     31.05%   56.95%   +25.89%     
   - Complexity     2180     3987     +1807     
   =============================================
     Files           964      986       +22     
     Lines         23384    24381      +997     
     Branches       2263     2371      +108     
   =============================================
   + Hits           7262    13886     +6624     
   + Misses        15570     9298     -6272     
   - Partials        552     1197      +645     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `24.21% <0.00%> (+15.34%)` | `4.00 <0.00> (+3.00)` | |
   | [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `23.52% <0.00%> (+5.01%)` | `1.00 <0.00> (-1.00)` | :arrow_up: |
   | [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `55.55% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `59.61% <0.00%> (ø)` | `6.00 <0.00> (ø)` | |
   | [...iver/envoy/als/mx/MetaExchangeALSHTTPAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L01ldGFFeGNoYW5nZUFMU0hUVFBBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../receiver/envoy/als/mx/ServiceMetaInfoAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L1NlcnZpY2VNZXRhSW5mb0FkYXB0ZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/persistence/LogsPersistence.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvcGVyc2lzdGVuY2UvTG9nc1BlcnNpc3RlbmNlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | ... and [467 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [6bc3ba0...d501f73](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (3287a8b) into [master](https://codecov.io/gh/apache/skywalking/commit/63bfb8d9ed90319553671b15627fa067db084996?el=desc) (63bfb8d) will **decrease** coverage by `17.81%`.
   > The diff coverage is `12.90%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #6322       +/-   ##
   =============================================
   - Coverage     58.16%   40.34%   -17.82%     
   + Complexity     4059     2352     -1707     
   =============================================
     Files           984      805      -179     
     Lines         24336    19797     -4539     
     Branches       2365     1857      -508     
   =============================================
   - Hits          14155     7988     -6167     
   - Misses         8947    11220     +2273     
   + Partials       1234      589      -645     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `8.04% <0.00%> (-18.40%)` | `1.00 <0.00> (-3.00)` | |
   | [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `23.52% <0.00%> (+5.01%)` | `1.00 <0.00> (-1.00)` | :arrow_up: |
   | [...lking/oap/server/core/source/EndpointRelation.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0VuZHBvaW50UmVsYXRpb24uamF2YQ==) | `100.00% <ø> (ø)` | `4.00 <0.00> (ø)` | |
   | [...ap/server/core/source/ServiceInstanceRelation.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL1NlcnZpY2VJbnN0YW5jZVJlbGF0aW9uLmphdmE=) | `100.00% <ø> (ø)` | `5.00 <0.00> (ø)` | |
   | [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (-90.00%)` | `0.00 <0.00> (-2.00)` | |
   | [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `55.55% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `59.61% <0.00%> (ø)` | `6.00 <0.00> (ø)` | |
   | ... and [431 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [5289996...8875f7e](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (5d644ce) into [master](https://codecov.io/gh/apache/skywalking/commit/6bc3ba025f889b0682d651d07f5b8037f41fff9c?el=desc) (6bc3ba0) will **increase** coverage by `26.11%`.
   > The diff coverage is `15.29%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #6322       +/-   ##
   =============================================
   + Coverage     31.05%   57.17%   +26.11%     
   - Complexity     2180     4015     +1835     
   =============================================
     Files           964      986       +22     
     Lines         23384    24383      +999     
     Branches       2263     2352       +89     
   =============================================
   + Hits           7262    13940     +6678     
   + Misses        15570     9230     -6340     
   - Partials        552     1213      +661     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `24.21% <0.00%> (+15.34%)` | `4.00 <0.00> (+3.00)` | |
   | [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `23.52% <0.00%> (+5.01%)` | `1.00 <0.00> (-1.00)` | :arrow_up: |
   | [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `55.55% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `59.61% <0.00%> (ø)` | `6.00 <0.00> (ø)` | |
   | [...iver/envoy/als/mx/MetaExchangeALSHTTPAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L01ldGFFeGNoYW5nZUFMU0hUVFBBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../receiver/envoy/als/mx/ServiceMetaInfoAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L1NlcnZpY2VNZXRhSW5mb0FkYXB0ZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/persistence/LogsPersistence.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvcGVyc2lzdGVuY2UvTG9nc1BlcnNpc3RlbmNlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | ... and [455 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [6bc3ba0...91e7ed7](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (b9cf4d4) into [master](https://codecov.io/gh/apache/skywalking/commit/b1a8238c159eaebda35771cd7c9c548e5eedfee1?el=desc) (b1a8238) will **increase** coverage by `1.31%`.
   > The diff coverage is `14.60%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6322      +/-   ##
   ============================================
   + Coverage     50.31%   51.62%   +1.31%     
   + Complexity     3584     3121     -463     
   ============================================
     Files           984     1777     +793     
     Lines         24245    37687   +13442     
     Branches       2359     4313    +1954     
   ============================================
   + Hits          12199    19457    +7258     
   - Misses        11024    17249    +6225     
   + Partials       1022      981      -41     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `24.21% <0.00%> (+15.34%)` | `4.00 <0.00> (+3.00)` | |
   | [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `23.52% <0.00%> (+5.01%)` | `1.00 <0.00> (-1.00)` | :arrow_up: |
   | [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `18.51% <0.00%> (-37.04%)` | `2.00 <0.00> (ø)` | |
   | [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `65.71% <0.00%> (+65.71%)` | `0.00 <0.00> (ø)` | |
   | [...iver/envoy/als/mx/MetaExchangeALSHTTPAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L01ldGFFeGNoYW5nZUFMU0hUVFBBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../receiver/envoy/als/mx/ServiceMetaInfoAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L1NlcnZpY2VNZXRhSW5mb0FkYXB0ZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/persistence/LogsPersistence.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvcGVyc2lzdGVuY2UvTG9nc1BlcnNpc3RlbmNlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `31.81% <50.00%> (-61.04%)` | `3.00 <0.00> (ø)` | |
   | [...ver/receiver/envoy/ServiceMetaInfoFactoryImpl.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvU2VydmljZU1ldGFJbmZvRmFjdG9yeUltcGwuamF2YQ==) | `50.00% <50.00%> (ø)` | `2.00 <2.00> (?)` | |
   | ... and [1274 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [b1a8238...dbd6ae9](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (5d644ce) into [master](https://codecov.io/gh/apache/skywalking/commit/6bc3ba025f889b0682d651d07f5b8037f41fff9c?el=desc) (6bc3ba0) will **increase** coverage by `10.05%`.
   > The diff coverage is `8.23%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #6322       +/-   ##
   =============================================
   + Coverage     31.05%   41.10%   +10.05%     
   - Complexity     2180     2502      +322     
   =============================================
     Files           964      835      -129     
     Lines         23384    20533     -2851     
     Branches       2263     1927      -336     
   =============================================
   + Hits           7262     8441     +1179     
   + Misses        15570    11457     -4113     
   - Partials        552      635       +83     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `8.04% <0.00%> (-0.82%)` | `1.00 <0.00> (ø)` | |
   | [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `23.52% <0.00%> (+5.01%)` | `1.00 <0.00> (-1.00)` | :arrow_up: |
   | [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `55.55% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `59.61% <0.00%> (ø)` | `6.00 <0.00> (ø)` | |
   | [...iver/envoy/als/mx/MetaExchangeALSHTTPAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L01ldGFFeGNoYW5nZUFMU0hUVFBBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../receiver/envoy/als/mx/ServiceMetaInfoAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L1NlcnZpY2VNZXRhSW5mb0FkYXB0ZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | ... and [315 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [6bc3ba0...91e7ed7](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] wu-sheng commented on a change in pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#discussion_r585308600



##########
File path: test/e2e/e2e-test/src/test/resources/expected/als/endpoints-productpage.yml
##########
@@ -15,4 +15,4 @@
 
 endpoints:
   - key: not null
-    label: /productpage
+    label: GET:/productpage

Review comment:
       When do we change this? If this pull request? I remember we had this before.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (5d644ce) into [master](https://codecov.io/gh/apache/skywalking/commit/6bc3ba025f889b0682d651d07f5b8037f41fff9c?el=desc) (6bc3ba0) will **increase** coverage by `18.87%`.
   > The diff coverage is `8.23%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #6322       +/-   ##
   =============================================
   + Coverage     31.05%   49.93%   +18.87%     
   - Complexity     2180     3569     +1389     
   =============================================
     Files           964      986       +22     
     Lines         23384    24206      +822     
     Branches       2263     2336       +73     
   =============================================
   + Hits           7262    12087     +4825     
   + Misses        15570    11064     -4506     
   - Partials        552     1055      +503     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `24.21% <0.00%> (+15.34%)` | `4.00 <0.00> (+3.00)` | |
   | [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `23.52% <0.00%> (+5.01%)` | `1.00 <0.00> (-1.00)` | :arrow_up: |
   | [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `55.55% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `59.61% <0.00%> (ø)` | `6.00 <0.00> (ø)` | |
   | [...iver/envoy/als/mx/MetaExchangeALSHTTPAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L01ldGFFeGNoYW5nZUFMU0hUVFBBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../receiver/envoy/als/mx/ServiceMetaInfoAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L1NlcnZpY2VNZXRhSW5mb0FkYXB0ZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | ... and [352 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [6bc3ba0...91e7ed7](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (45dc5d6) into [master](https://codecov.io/gh/apache/skywalking/commit/6bc3ba025f889b0682d651d07f5b8037f41fff9c?el=desc) (6bc3ba0) will **increase** coverage by `22.94%`.
   > The diff coverage is `15.29%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #6322       +/-   ##
   =============================================
   + Coverage     31.05%   54.00%   +22.94%     
   - Complexity     2180     3851     +1671     
   =============================================
     Files           964      986       +22     
     Lines         23384    24349      +965     
     Branches       2263     2369      +106     
   =============================================
   + Hits           7262    13149     +5887     
   + Misses        15570    10077     -5493     
   - Partials        552     1123      +571     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `8.04% <0.00%> (-0.82%)` | `1.00 <0.00> (ø)` | |
   | [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `23.52% <0.00%> (+5.01%)` | `1.00 <0.00> (-1.00)` | :arrow_up: |
   | [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `55.55% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `59.61% <0.00%> (ø)` | `6.00 <0.00> (ø)` | |
   | [...iver/envoy/als/mx/MetaExchangeALSHTTPAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L01ldGFFeGNoYW5nZUFMU0hUVFBBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../receiver/envoy/als/mx/ServiceMetaInfoAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L1NlcnZpY2VNZXRhSW5mb0FkYXB0ZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/persistence/LogsPersistence.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvcGVyc2lzdGVuY2UvTG9nc1BlcnNpc3RlbmNlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | ... and [449 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [6bc3ba0...d501f73](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (5d644ce) into [master](https://codecov.io/gh/apache/skywalking/commit/6bc3ba025f889b0682d651d07f5b8037f41fff9c?el=desc) (6bc3ba0) will **increase** coverage by `18.97%`.
   > The diff coverage is `8.23%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #6322       +/-   ##
   =============================================
   + Coverage     31.05%   50.03%   +18.97%     
   - Complexity     2180     3578     +1398     
   =============================================
     Files           964      986       +22     
     Lines         23384    24206      +822     
     Branches       2263     2336       +73     
   =============================================
   + Hits           7262    12111     +4849     
   + Misses        15570    11040     -4530     
   - Partials        552     1055      +503     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `24.21% <0.00%> (+15.34%)` | `4.00 <0.00> (+3.00)` | |
   | [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `23.52% <0.00%> (+5.01%)` | `1.00 <0.00> (-1.00)` | :arrow_up: |
   | [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `55.55% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `59.61% <0.00%> (ø)` | `6.00 <0.00> (ø)` | |
   | [...iver/envoy/als/mx/MetaExchangeALSHTTPAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L01ldGFFeGNoYW5nZUFMU0hUVFBBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../receiver/envoy/als/mx/ServiceMetaInfoAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L1NlcnZpY2VNZXRhSW5mb0FkYXB0ZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | ... and [357 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [6bc3ba0...91e7ed7](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (8190912) into [master](https://codecov.io/gh/apache/skywalking/commit/b1a8238c159eaebda35771cd7c9c548e5eedfee1?el=desc) (b1a8238) will **increase** coverage by `12.37%`.
   > The diff coverage is `21.34%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #6322       +/-   ##
   =============================================
   + Coverage     41.42%   53.79%   +12.37%     
   - Complexity     2959     4036     +1077     
   =============================================
     Files           953     1777      +824     
     Lines         23209    37755    +14546     
     Branches       2262     4153     +1891     
   =============================================
   + Hits           9614    20311    +10697     
   - Misses        12754    16460     +3706     
   - Partials        841      984      +143     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `24.21% <0.00%> (+15.34%)` | `4.00 <0.00> (+3.00)` | |
   | [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `23.52% <0.00%> (+5.01%)` | `1.00 <0.00> (-1.00)` | :arrow_up: |
   | [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `18.51% <0.00%> (-37.04%)` | `2.00 <0.00> (ø)` | |
   | [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `65.71% <0.00%> (+65.71%)` | `0.00 <0.00> (ø)` | |
   | [...iver/envoy/als/mx/MetaExchangeALSHTTPAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L01ldGFFeGNoYW5nZUFMU0hUVFBBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../receiver/envoy/als/mx/ServiceMetaInfoAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L1NlcnZpY2VNZXRhSW5mb0FkYXB0ZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/persistence/LogsPersistence.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvcGVyc2lzdGVuY2UvTG9nc1BlcnNpc3RlbmNlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `31.81% <50.00%> (-61.04%)` | `3.00 <0.00> (ø)` | |
   | [...ver/receiver/envoy/ServiceMetaInfoFactoryImpl.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvU2VydmljZU1ldGFJbmZvRmFjdG9yeUltcGwuamF2YQ==) | `50.00% <50.00%> (ø)` | `2.00 <2.00> (?)` | |
   | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `50.00% <50.00%> (+50.00%)` | `0.00 <0.00> (ø)` | |
   | ... and [1360 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [b1a8238...dbd6ae9](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (ad99d9b) into [master](https://codecov.io/gh/apache/skywalking/commit/b1a8238c159eaebda35771cd7c9c548e5eedfee1?el=desc) (b1a8238) will **decrease** coverage by `1.28%`.
   > The diff coverage is `17.07%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6322      +/-   ##
   ============================================
   - Coverage     41.42%   40.14%   -1.29%     
   + Complexity     2959     2348     -611     
   ============================================
     Files           953      796     -157     
     Lines         23209    19847    -3362     
     Branches       2262     1873     -389     
   ============================================
   - Hits           9614     7967    -1647     
   + Misses        12754    11281    -1473     
   + Partials        841      599     -242     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...g/oap/server/receiver/envoy/ErrorLogsAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRXJyb3JMb2dzQW5hbHl6ZXIuamF2YQ==) | `17.64% <17.64%> (ø)` | `2.00 <2.00> (?)` | |
   | [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `57.89% <100.00%> (+2.33%)` | `2.00 <0.00> (ø)` | |
   | [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | [.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=) | `0.00% <0.00%> (-98.86%)` | `0.00% <0.00%> (-1.00%)` | |
   | [...apm/network/trace/component/OfficialComponent.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9PZmZpY2lhbENvbXBvbmVudC5qYXZh) | `0.00% <0.00%> (-83.34%)` | `0.00% <0.00%> (-2.00%)` | |
   | [...er/storage/plugin/jdbc/h2/dao/H2AlarmQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyQWxhcm1RdWVyeURBTy5qYXZh) | `0.00% <0.00%> (-79.07%)` | `0.00% <0.00%> (-5.00%)` | |
   | [...rver/storage/plugin/jdbc/h2/H2StorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvSDJTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `7.46% <0.00%> (-78.05%)` | `3.00% <0.00%> (-6.00%)` | |
   | [...ap/server/core/alarm/AlarmStandardPersistence.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1TdGFuZGFyZFBlcnNpc3RlbmNlLmphdmE=) | `11.76% <0.00%> (-76.48%)` | `2.00% <0.00%> (-2.00%)` | |
   | [...er/core/alarm/provider/CompositeRuleEvaluator.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Db21wb3NpdGVSdWxlRXZhbHVhdG9yLmphdmE=) | `9.52% <0.00%> (-73.81%)` | `1.00% <0.00%> (-6.00%)` | |
   | ... and [379 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [b1a8238...dbd6ae9](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (5d644ce) into [master](https://codecov.io/gh/apache/skywalking/commit/6bc3ba025f889b0682d651d07f5b8037f41fff9c?el=desc) (6bc3ba0) will **increase** coverage by `18.86%`.
   > The diff coverage is `8.23%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #6322       +/-   ##
   =============================================
   + Coverage     31.05%   49.91%   +18.86%     
   - Complexity     2180     3568     +1388     
   =============================================
     Files           964      986       +22     
     Lines         23384    24206      +822     
     Branches       2263     2336       +73     
   =============================================
   + Hits           7262    12083     +4821     
   + Misses        15570    11068     -4502     
   - Partials        552     1055      +503     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `24.21% <0.00%> (+15.34%)` | `4.00 <0.00> (+3.00)` | |
   | [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `23.52% <0.00%> (+5.01%)` | `1.00 <0.00> (-1.00)` | :arrow_up: |
   | [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `55.55% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `59.61% <0.00%> (ø)` | `6.00 <0.00> (ø)` | |
   | [...iver/envoy/als/mx/MetaExchangeALSHTTPAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L01ldGFFeGNoYW5nZUFMU0hUVFBBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../receiver/envoy/als/mx/ServiceMetaInfoAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L1NlcnZpY2VNZXRhSW5mb0FkYXB0ZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | ... and [352 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [6bc3ba0...91e7ed7](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (45c1b75) into [master](https://codecov.io/gh/apache/skywalking/commit/d12d3f201a315241bd7aeb5cc97c2d5103e67c02?el=desc) (d12d3f2) will **decrease** coverage by `3.33%`.
   > The diff coverage is `30.95%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6322      +/-   ##
   ============================================
   - Coverage     53.22%   49.88%   -3.34%     
   + Complexity     3845     3505     -340     
   ============================================
     Files          1731      947     -784     
     Lines         36905    23500   -13405     
     Branches       4076     2295    -1781     
   ============================================
   - Hits          19642    11724    -7918     
   + Misses        16288    10701    -5587     
   - Partials        975     1075     +100     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...erver/core/analysis/data/MergableBufferedData.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9NZXJnYWJsZUJ1ZmZlcmVkRGF0YS5qYXZh) | `76.92% <0.00%> (-7.70%)` | `4.00 <0.00> (ø)` | |
   | [...lysis/manual/networkalias/NetworkAddressAlias.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL25ldHdvcmthbGlhcy9OZXR3b3JrQWRkcmVzc0FsaWFzLmphdmE=) | `2.43% <0.00%> (-56.10%)` | `0.00 <0.00> (-5.00)` | |
   | [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (-56.25%)` | `0.00 <0.00> (ø)` | |
   | [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-12.20%)` | `0.00 <0.00> (ø)` | |
   | [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-62.80%)` | `0.00 <0.00> (ø)` | |
   | [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <0.00%> (-58.14%)` | `0.00 <0.00> (ø)` | |
   | [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-50.00%)` | `0.00 <0.00> (ø)` | |
   | [...oap/server/core/analysis/metrics/CountMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Db3VudE1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (-85.72%)` | `0.00 <0.00> (ø)` | |
   | [...server/core/analysis/metrics/MaxDoubleMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhEb3VibGVNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...p/server/core/analysis/metrics/MaxLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhMb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-87.50%)` | `0.00 <0.00> (ø)` | |
   | ... and [1274 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [1e78a0a...ad99d9b](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (3287a8b) into [master](https://codecov.io/gh/apache/skywalking/commit/63bfb8d9ed90319553671b15627fa067db084996?el=desc) (63bfb8d) will **decrease** coverage by `4.67%`.
   > The diff coverage is `19.35%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6322      +/-   ##
   ============================================
   - Coverage     58.16%   53.48%   -4.68%     
   + Complexity     4059     3824     -235     
   ============================================
     Files           984      986       +2     
     Lines         24336    24345       +9     
     Branches       2365     2370       +5     
   ============================================
   - Hits          14155    13021    -1134     
   - Misses         8947    10187    +1240     
   + Partials       1234     1137      -97     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...king/apm/agent/core/remote/GRPCChannelManager.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsTWFuYWdlci5qYXZh) | `48.88% <ø> (ø)` | `12.00 <0.00> (ø)` | |
   | [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `24.21% <0.00%> (-2.23%)` | `4.00 <0.00> (ø)` | |
   | [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `23.52% <0.00%> (+5.01%)` | `1.00 <0.00> (-1.00)` | :arrow_up: |
   | [...lking/oap/server/core/source/EndpointRelation.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0VuZHBvaW50UmVsYXRpb24uamF2YQ==) | `100.00% <ø> (ø)` | `4.00 <0.00> (ø)` | |
   | [...ap/server/core/source/ServiceInstanceRelation.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL1NlcnZpY2VJbnN0YW5jZVJlbGF0aW9uLmphdmE=) | `100.00% <ø> (ø)` | `5.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `55.55% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `59.61% <0.00%> (ø)` | `6.00 <0.00> (ø)` | |
   | ... and [104 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [5289996...8875f7e](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (d501f73) into [master](https://codecov.io/gh/apache/skywalking/commit/6bc3ba025f889b0682d651d07f5b8037f41fff9c?el=desc) (6bc3ba0) will **increase** coverage by `11.18%`.
   > The diff coverage is `14.60%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #6322       +/-   ##
   =============================================
   + Coverage     31.05%   42.23%   +11.18%     
   - Complexity     2180     2320      +140     
   =============================================
     Files           964     1767      +803     
     Lines         23384    37338    +13954     
     Branches       2263     4297     +2034     
   =============================================
   + Hits           7262    15771     +8509     
   - Misses        15570    20574     +5004     
   - Partials        552      993      +441     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `7.36% <0.00%> (-1.50%)` | `1.00 <0.00> (ø)` | |
   | [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `23.52% <0.00%> (+5.01%)` | `1.00 <0.00> (-1.00)` | :arrow_up: |
   | [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `18.51% <0.00%> (-37.04%)` | `2.00 <0.00> (ø)` | |
   | [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `65.71% <0.00%> (+65.71%)` | `0.00 <0.00> (ø)` | |
   | [...iver/envoy/als/mx/MetaExchangeALSHTTPAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L01ldGFFeGNoYW5nZUFMU0hUVFBBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../receiver/envoy/als/mx/ServiceMetaInfoAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L1NlcnZpY2VNZXRhSW5mb0FkYXB0ZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/persistence/LogsPersistence.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvcGVyc2lzdGVuY2UvTG9nc1BlcnNpc3RlbmNlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `31.81% <50.00%> (-61.04%)` | `3.00 <0.00> (ø)` | |
   | [...ver/receiver/envoy/ServiceMetaInfoFactoryImpl.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvU2VydmljZU1ldGFJbmZvRmFjdG9yeUltcGwuamF2YQ==) | `50.00% <50.00%> (ø)` | `2.00 <2.00> (?)` | |
   | ... and [1394 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [6bc3ba0...d501f73](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (45dc5d6) into [master](https://codecov.io/gh/apache/skywalking/commit/6bc3ba025f889b0682d651d07f5b8037f41fff9c?el=desc) (6bc3ba0) will **increase** coverage by `21.10%`.
   > The diff coverage is `15.29%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #6322       +/-   ##
   =============================================
   + Coverage     31.05%   52.16%   +21.10%     
   - Complexity     2180     3756     +1576     
   =============================================
     Files           964      986       +22     
     Lines         23384    24302      +918     
     Branches       2263     2349       +86     
   =============================================
   + Hits           7262    12677     +5415     
   + Misses        15570    10542     -5028     
   - Partials        552     1083      +531     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `8.04% <0.00%> (-0.82%)` | `1.00 <0.00> (ø)` | |
   | [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `23.52% <0.00%> (+5.01%)` | `1.00 <0.00> (-1.00)` | :arrow_up: |
   | [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `55.55% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `59.61% <0.00%> (ø)` | `6.00 <0.00> (ø)` | |
   | [...iver/envoy/als/mx/MetaExchangeALSHTTPAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L01ldGFFeGNoYW5nZUFMU0hUVFBBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../receiver/envoy/als/mx/ServiceMetaInfoAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L1NlcnZpY2VNZXRhSW5mb0FkYXB0ZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/persistence/LogsPersistence.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvcGVyc2lzdGVuY2UvTG9nc1BlcnNpc3RlbmNlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | ... and [425 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [6bc3ba0...d501f73](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (45dc5d6) into [master](https://codecov.io/gh/apache/skywalking/commit/6bc3ba025f889b0682d651d07f5b8037f41fff9c?el=desc) (6bc3ba0) will **increase** coverage by `12.74%`.
   > The diff coverage is `15.29%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #6322       +/-   ##
   =============================================
   + Coverage     31.05%   43.80%   +12.74%     
   - Complexity     2180     3120      +940     
   =============================================
     Files           964      955        -9     
     Lines         23384    23388        +4     
     Branches       2263     2260        -3     
   =============================================
   + Hits           7262    10244     +2982     
   + Misses        15570    12279     -3291     
   - Partials        552      865      +313     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `8.04% <0.00%> (-0.82%)` | `1.00 <0.00> (ø)` | |
   | [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `23.52% <0.00%> (+5.01%)` | `1.00 <0.00> (-1.00)` | :arrow_up: |
   | [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `55.55% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `59.61% <0.00%> (ø)` | `6.00 <0.00> (ø)` | |
   | [...iver/envoy/als/mx/MetaExchangeALSHTTPAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L01ldGFFeGNoYW5nZUFMU0hUVFBBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../receiver/envoy/als/mx/ServiceMetaInfoAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L1NlcnZpY2VNZXRhSW5mb0FkYXB0ZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/persistence/LogsPersistence.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvcGVyc2lzdGVuY2UvTG9nc1BlcnNpc3RlbmNlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | ... and [266 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [6bc3ba0...d501f73](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (5876350) into [master](https://codecov.io/gh/apache/skywalking/commit/6bc3ba025f889b0682d651d07f5b8037f41fff9c?el=desc) (6bc3ba0) will **increase** coverage by `14.31%`.
   > The diff coverage is `8.23%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #6322       +/-   ##
   =============================================
   + Coverage     31.05%   45.36%   +14.31%     
   - Complexity     2180     3395     +1215     
   =============================================
     Files           964     1021       +57     
     Lines         23384    24909     +1525     
     Branches       2263     2438      +175     
   =============================================
   + Hits           7262    11301     +4039     
   + Misses        15570    12628     -2942     
   - Partials        552      980      +428     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `24.21% <0.00%> (+15.34%)` | `4.00 <0.00> (+3.00)` | |
   | [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `23.52% <0.00%> (+5.01%)` | `1.00 <0.00> (-1.00)` | :arrow_up: |
   | [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `55.55% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `59.61% <0.00%> (ø)` | `6.00 <0.00> (ø)` | |
   | [...iver/envoy/als/mx/MetaExchangeALSHTTPAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L01ldGFFeGNoYW5nZUFMU0hUVFBBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../receiver/envoy/als/mx/ServiceMetaInfoAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L1NlcnZpY2VNZXRhSW5mb0FkYXB0ZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | ... and [364 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [6bc3ba0...91e7ed7](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (45c1b75) into [master](https://codecov.io/gh/apache/skywalking/commit/d12d3f201a315241bd7aeb5cc97c2d5103e67c02?el=desc) (d12d3f2) will **decrease** coverage by `8.34%`.
   > The diff coverage is `29.76%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6322      +/-   ##
   ============================================
   - Coverage     53.22%   44.87%   -8.35%     
   + Complexity     3845     3183     -662     
   ============================================
     Files          1731      947     -784     
     Lines         36905    23350   -13555     
     Branches       4076     2250    -1826     
   ============================================
   - Hits          19642    10479    -9163     
   + Misses        16288    11939    -4349     
   + Partials        975      932      -43     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...erver/core/analysis/data/MergableBufferedData.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9NZXJnYWJsZUJ1ZmZlcmVkRGF0YS5qYXZh) | `76.92% <0.00%> (-7.70%)` | `4.00 <0.00> (ø)` | |
   | [...lysis/manual/networkalias/NetworkAddressAlias.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL25ldHdvcmthbGlhcy9OZXR3b3JrQWRkcmVzc0FsaWFzLmphdmE=) | `2.43% <0.00%> (-56.10%)` | `0.00 <0.00> (-5.00)` | |
   | [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (-56.25%)` | `0.00 <0.00> (ø)` | |
   | [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-12.20%)` | `0.00 <0.00> (ø)` | |
   | [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-62.80%)` | `0.00 <0.00> (ø)` | |
   | [...r/function/avg/AvgHistogramPercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbVBlcmNlbnRpbGVGdW5jdGlvbi5qYXZh) | `0.00% <0.00%> (-62.12%)` | `0.00 <0.00> (-25.00)` | |
   | [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <0.00%> (-58.14%)` | `0.00 <0.00> (ø)` | |
   | [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-50.00%)` | `0.00 <0.00> (ø)` | |
   | [...oap/server/core/analysis/metrics/CountMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Db3VudE1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (-85.72%)` | `0.00 <0.00> (ø)` | |
   | [...server/core/analysis/metrics/MaxDoubleMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhEb3VibGVNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | ... and [1305 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [1e78a0a...ad99d9b](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (45dc5d6) into [master](https://codecov.io/gh/apache/skywalking/commit/6bc3ba025f889b0682d651d07f5b8037f41fff9c?el=desc) (6bc3ba0) will **increase** coverage by `26.27%`.
   > The diff coverage is `15.29%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #6322       +/-   ##
   =============================================
   + Coverage     31.05%   57.33%   +26.27%     
   - Complexity     2180     4009     +1829     
   =============================================
     Files           964      986       +22     
     Lines         23384    24394     +1010     
     Branches       2263     2371      +108     
   =============================================
   + Hits           7262    13986     +6724     
   + Misses        15570     9199     -6371     
   - Partials        552     1209      +657     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `24.21% <0.00%> (+15.34%)` | `4.00 <0.00> (+3.00)` | |
   | [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `23.52% <0.00%> (+5.01%)` | `1.00 <0.00> (-1.00)` | :arrow_up: |
   | [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `55.55% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `59.61% <0.00%> (ø)` | `6.00 <0.00> (ø)` | |
   | [...iver/envoy/als/mx/MetaExchangeALSHTTPAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L01ldGFFeGNoYW5nZUFMU0hUVFBBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../receiver/envoy/als/mx/ServiceMetaInfoAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L1NlcnZpY2VNZXRhSW5mb0FkYXB0ZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/persistence/LogsPersistence.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvcGVyc2lzdGVuY2UvTG9nc1BlcnNpc3RlbmNlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | ... and [473 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [6bc3ba0...d501f73](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#discussion_r585357042



##########
File path: oap-server/server-bootstrap/src/main/resources/lal/envoy-als.yaml
##########
@@ -0,0 +1,47 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+rules:
+  - name: envoy-als
+    dsl: |
+      filter {
+        json {
+        }
+        // only collect abnormal logs (http status code >= 300, or commonProperties?.responseFlags is not empty)
+        if (parsed?.response?.responseCode < 300 && !parsed?.commonProperties?.responseFlags) {

Review comment:
       I'd say >=300 <400 is normal cause the proxy will follow the redirect URL (query against the URL returned by 301, 302, or similar)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (5d644ce) into [master](https://codecov.io/gh/apache/skywalking/commit/6bc3ba025f889b0682d651d07f5b8037f41fff9c?el=desc) (6bc3ba0) will **increase** coverage by `26.12%`.
   > The diff coverage is `15.29%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #6322       +/-   ##
   =============================================
   + Coverage     31.05%   57.18%   +26.12%     
   - Complexity     2180     4017     +1837     
   =============================================
     Files           964      986       +22     
     Lines         23384    24383      +999     
     Branches       2263     2352       +89     
   =============================================
   + Hits           7262    13943     +6681     
   + Misses        15570     9227     -6343     
   - Partials        552     1213      +661     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `24.21% <0.00%> (+15.34%)` | `4.00 <0.00> (+3.00)` | |
   | [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `23.52% <0.00%> (+5.01%)` | `1.00 <0.00> (-1.00)` | :arrow_up: |
   | [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `55.55% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `59.61% <0.00%> (ø)` | `6.00 <0.00> (ø)` | |
   | [...iver/envoy/als/mx/MetaExchangeALSHTTPAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L01ldGFFeGNoYW5nZUFMU0hUVFBBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../receiver/envoy/als/mx/ServiceMetaInfoAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L1NlcnZpY2VNZXRhSW5mb0FkYXB0ZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/persistence/LogsPersistence.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvcGVyc2lzdGVuY2UvTG9nc1BlcnNpc3RlbmNlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | ... and [455 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [6bc3ba0...d501f73](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (5876350) into [master](https://codecov.io/gh/apache/skywalking/commit/6bc3ba025f889b0682d651d07f5b8037f41fff9c?el=desc) (6bc3ba0) will **increase** coverage by `13.65%`.
   > The diff coverage is `8.23%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #6322       +/-   ##
   =============================================
   + Coverage     31.05%   44.70%   +13.65%     
   - Complexity     2180     3366     +1186     
   =============================================
     Files           964     1021       +57     
     Lines         23384    24896     +1512     
     Branches       2263     2438      +175     
   =============================================
   + Hits           7262    11131     +3869     
   + Misses        15570    12813     -2757     
   - Partials        552      952      +400     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `24.21% <0.00%> (+15.34%)` | `4.00 <0.00> (+3.00)` | |
   | [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `23.52% <0.00%> (+5.01%)` | `1.00 <0.00> (-1.00)` | :arrow_up: |
   | [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `55.55% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `59.61% <0.00%> (ø)` | `6.00 <0.00> (ø)` | |
   | [...iver/envoy/als/mx/MetaExchangeALSHTTPAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L01ldGFFeGNoYW5nZUFMU0hUVFBBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../receiver/envoy/als/mx/ServiceMetaInfoAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L1NlcnZpY2VNZXRhSW5mb0FkYXB0ZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | ... and [358 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [6bc3ba0...91e7ed7](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (dbd6ae9) into [master](https://codecov.io/gh/apache/skywalking/commit/b1a8238c159eaebda35771cd7c9c548e5eedfee1?el=desc) (b1a8238) will **decrease** coverage by `4.41%`.
   > The diff coverage is `8.23%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6322      +/-   ##
   ============================================
   - Coverage     41.42%   37.00%   -4.42%     
   + Complexity     2959     2179     -780     
   ============================================
     Files           953      805     -148     
     Lines         23209    19646    -3563     
     Branches       2262     1843     -419     
   ============================================
   - Hits           9614     7270    -2344     
   + Misses        12754    11822     -932     
   + Partials        841      554     -287     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `8.04% <0.00%> (-0.82%)` | `1.00 <0.00> (ø)` | |
   | [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `23.52% <0.00%> (+5.01%)` | `1.00 <0.00> (-1.00)` | :arrow_up: |
   | [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `55.55% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `59.61% <0.00%> (ø)` | `6.00 <0.00> (ø)` | |
   | [...iver/envoy/als/mx/MetaExchangeALSHTTPAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L01ldGFFeGNoYW5nZUFMU0hUVFBBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../receiver/envoy/als/mx/ServiceMetaInfoAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L1NlcnZpY2VNZXRhSW5mb0FkYXB0ZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | ... and [225 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [b1a8238...dbd6ae9](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (dbd6ae9) into [master](https://codecov.io/gh/apache/skywalking/commit/b1a8238c159eaebda35771cd7c9c548e5eedfee1?el=desc) (b1a8238) will **increase** coverage by `0.80%`.
   > The diff coverage is `8.23%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6322      +/-   ##
   ============================================
   + Coverage     41.42%   42.22%   +0.80%     
   + Complexity     2959     2445     -514     
   ============================================
     Files           953      805     -148     
     Lines         23209    19671    -3538     
     Branches       2262     1844     -418     
   ============================================
   - Hits           9614     8306    -1308     
   + Misses        12754    10731    -2023     
   + Partials        841      634     -207     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `8.04% <0.00%> (-0.82%)` | `1.00 <0.00> (ø)` | |
   | [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `23.52% <0.00%> (+5.01%)` | `1.00 <0.00> (-1.00)` | :arrow_up: |
   | [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `55.55% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `59.61% <0.00%> (ø)` | `6.00 <0.00> (ø)` | |
   | [...iver/envoy/als/mx/MetaExchangeALSHTTPAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L01ldGFFeGNoYW5nZUFMU0hUVFBBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../receiver/envoy/als/mx/ServiceMetaInfoAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L1NlcnZpY2VNZXRhSW5mb0FkYXB0ZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | ... and [272 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [b1a8238...dbd6ae9](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (45dc5d6) into [master](https://codecov.io/gh/apache/skywalking/commit/6bc3ba025f889b0682d651d07f5b8037f41fff9c?el=desc) (6bc3ba0) will **increase** coverage by `21.17%`.
   > The diff coverage is `15.29%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #6322       +/-   ##
   =============================================
   + Coverage     31.05%   52.22%   +21.17%     
   - Complexity     2180     3758     +1578     
   =============================================
     Files           964      986       +22     
     Lines         23384    24302      +918     
     Branches       2263     2349       +86     
   =============================================
   + Hits           7262    12692     +5430     
   + Misses        15570    10520     -5050     
   - Partials        552     1090      +538     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `8.04% <0.00%> (-0.82%)` | `1.00 <0.00> (ø)` | |
   | [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `23.52% <0.00%> (+5.01%)` | `1.00 <0.00> (-1.00)` | :arrow_up: |
   | [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `55.55% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `59.61% <0.00%> (ø)` | `6.00 <0.00> (ø)` | |
   | [...iver/envoy/als/mx/MetaExchangeALSHTTPAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L01ldGFFeGNoYW5nZUFMU0hUVFBBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../receiver/envoy/als/mx/ServiceMetaInfoAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L1NlcnZpY2VNZXRhSW5mb0FkYXB0ZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/persistence/LogsPersistence.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvcGVyc2lzdGVuY2UvTG9nc1BlcnNpc3RlbmNlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | ... and [425 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [6bc3ba0...d501f73](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (b9cf4d4) into [master](https://codecov.io/gh/apache/skywalking/commit/b1a8238c159eaebda35771cd7c9c548e5eedfee1?el=desc) (b1a8238) will **increase** coverage by `0.27%`.
   > The diff coverage is `8.23%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6322      +/-   ##
   ============================================
   + Coverage     41.42%   41.70%   +0.27%     
   + Complexity     2959     2487     -472     
   ============================================
     Files           953      835     -118     
     Lines         23209    20424    -2785     
     Branches       2262     1899     -363     
   ============================================
   - Hits           9614     8517    -1097     
   + Misses        12754    11265    -1489     
   + Partials        841      642     -199     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `24.21% <0.00%> (+15.34%)` | `4.00 <0.00> (+3.00)` | |
   | [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `23.52% <0.00%> (+5.01%)` | `1.00 <0.00> (-1.00)` | :arrow_up: |
   | [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `55.55% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `59.61% <0.00%> (ø)` | `6.00 <0.00> (ø)` | |
   | [...iver/envoy/als/mx/MetaExchangeALSHTTPAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L01ldGFFeGNoYW5nZUFMU0hUVFBBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../receiver/envoy/als/mx/ServiceMetaInfoAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L1NlcnZpY2VNZXRhSW5mb0FkYXB0ZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | ... and [382 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [b1a8238...dbd6ae9](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (3287a8b) into [master](https://codecov.io/gh/apache/skywalking/commit/63bfb8d9ed90319553671b15627fa067db084996?el=desc) (63bfb8d) will **decrease** coverage by `0.06%`.
   > The diff coverage is `19.35%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6322      +/-   ##
   ============================================
   - Coverage     58.16%   58.10%   -0.07%     
   + Complexity     4059     4048      -11     
   ============================================
     Files           984      986       +2     
     Lines         24336    24394      +58     
     Branches       2365     2371       +6     
   ============================================
   + Hits          14155    14174      +19     
   - Misses         8947     8985      +38     
   - Partials       1234     1235       +1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...king/apm/agent/core/remote/GRPCChannelManager.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsTWFuYWdlci5qYXZh) | `48.88% <ø> (ø)` | `12.00 <0.00> (ø)` | |
   | [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `24.21% <0.00%> (-2.23%)` | `4.00 <0.00> (ø)` | |
   | [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `23.52% <0.00%> (+5.01%)` | `1.00 <0.00> (-1.00)` | :arrow_up: |
   | [...lking/oap/server/core/source/EndpointRelation.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0VuZHBvaW50UmVsYXRpb24uamF2YQ==) | `100.00% <ø> (ø)` | `4.00 <0.00> (ø)` | |
   | [...ap/server/core/source/ServiceInstanceRelation.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL1NlcnZpY2VJbnN0YW5jZVJlbGF0aW9uLmphdmE=) | `100.00% <ø> (ø)` | `5.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `55.55% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `59.61% <0.00%> (ø)` | `6.00 <0.00> (ø)` | |
   | ... and [52 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [5289996...8875f7e](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (b9cf4d4) into [master](https://codecov.io/gh/apache/skywalking/commit/b1a8238c159eaebda35771cd7c9c548e5eedfee1?el=desc) (b1a8238) will **increase** coverage by `9.32%`.
   > The diff coverage is `14.60%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6322      +/-   ##
   ============================================
   + Coverage     41.42%   50.74%   +9.32%     
   - Complexity     2959     3060     +101     
   ============================================
     Files           953     1777     +824     
     Lines         23209    37687   +14478     
     Branches       2262     4313    +2051     
   ============================================
   + Hits           9614    19125    +9511     
   - Misses        12754    17580    +4826     
   - Partials        841      982     +141     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `24.21% <0.00%> (+15.34%)` | `4.00 <0.00> (+3.00)` | |
   | [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `23.52% <0.00%> (+5.01%)` | `1.00 <0.00> (-1.00)` | :arrow_up: |
   | [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `18.51% <0.00%> (-37.04%)` | `2.00 <0.00> (ø)` | |
   | [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `65.71% <0.00%> (+65.71%)` | `0.00 <0.00> (ø)` | |
   | [...iver/envoy/als/mx/MetaExchangeALSHTTPAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L01ldGFFeGNoYW5nZUFMU0hUVFBBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../receiver/envoy/als/mx/ServiceMetaInfoAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L1NlcnZpY2VNZXRhSW5mb0FkYXB0ZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/persistence/LogsPersistence.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvcGVyc2lzdGVuY2UvTG9nc1BlcnNpc3RlbmNlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `31.81% <50.00%> (-61.04%)` | `3.00 <0.00> (ø)` | |
   | [...ver/receiver/envoy/ServiceMetaInfoFactoryImpl.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvU2VydmljZU1ldGFJbmZvRmFjdG9yeUltcGwuamF2YQ==) | `50.00% <50.00%> (ø)` | `2.00 <2.00> (?)` | |
   | ... and [1336 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [b1a8238...dbd6ae9](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] wu-sheng commented on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-788449465


   e2e seems fail, please recheck.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (3287a8b) into [master](https://codecov.io/gh/apache/skywalking/commit/63bfb8d9ed90319553671b15627fa067db084996?el=desc) (63bfb8d) will **decrease** coverage by `20.19%`.
   > The diff coverage is `12.90%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #6322       +/-   ##
   =============================================
   - Coverage     58.16%   37.96%   -20.20%     
   + Complexity     4059     2235     -1824     
   =============================================
     Files           984      805      -179     
     Lines         24336    19787     -4549     
     Branches       2365     1856      -509     
   =============================================
   - Hits          14155     7513     -6642     
   - Misses         8947    11710     +2763     
   + Partials       1234      564      -670     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `8.04% <0.00%> (-18.40%)` | `1.00 <0.00> (-3.00)` | |
   | [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `23.52% <0.00%> (+5.01%)` | `1.00 <0.00> (-1.00)` | :arrow_up: |
   | [...lking/oap/server/core/source/EndpointRelation.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0VuZHBvaW50UmVsYXRpb24uamF2YQ==) | `100.00% <ø> (ø)` | `4.00 <0.00> (ø)` | |
   | [...ap/server/core/source/ServiceInstanceRelation.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL1NlcnZpY2VJbnN0YW5jZVJlbGF0aW9uLmphdmE=) | `100.00% <ø> (ø)` | `5.00 <0.00> (ø)` | |
   | [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (-90.00%)` | `0.00 <0.00> (-2.00)` | |
   | [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `55.55% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `59.61% <0.00%> (ø)` | `6.00 <0.00> (ø)` | |
   | ... and [462 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [5289996...8875f7e](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (5d644ce) into [master](https://codecov.io/gh/apache/skywalking/commit/6bc3ba025f889b0682d651d07f5b8037f41fff9c?el=desc) (6bc3ba0) will **increase** coverage by `21.06%`.
   > The diff coverage is `8.23%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #6322       +/-   ##
   =============================================
   + Coverage     31.05%   52.11%   +21.06%     
   - Complexity     2180     3722     +1542     
   =============================================
     Files           964      986       +22     
     Lines         23384    24338      +954     
     Branches       2263     2349       +86     
   =============================================
   + Hits           7262    12684     +5422     
   + Misses        15570    10554     -5016     
   - Partials        552     1100      +548     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `24.21% <0.00%> (+15.34%)` | `4.00 <0.00> (+3.00)` | |
   | [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `23.52% <0.00%> (+5.01%)` | `1.00 <0.00> (-1.00)` | :arrow_up: |
   | [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `55.55% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `59.61% <0.00%> (ø)` | `6.00 <0.00> (ø)` | |
   | [...iver/envoy/als/mx/MetaExchangeALSHTTPAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L01ldGFFeGNoYW5nZUFMU0hUVFBBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../receiver/envoy/als/mx/ServiceMetaInfoAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L1NlcnZpY2VNZXRhSW5mb0FkYXB0ZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | ... and [395 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [6bc3ba0...91e7ed7](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (b9cf4d4) into [master](https://codecov.io/gh/apache/skywalking/commit/b1a8238c159eaebda35771cd7c9c548e5eedfee1?el=desc) (b1a8238) will **increase** coverage by `1.00%`.
   > The diff coverage is `8.23%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6322      +/-   ##
   ============================================
   + Coverage     41.42%   42.43%   +1.00%     
   + Complexity     2959     2529     -430     
   ============================================
     Files           953      835     -118     
     Lines         23209    20424    -2785     
     Branches       2262     1899     -363     
   ============================================
   - Hits           9614     8666     -948     
   + Misses        12754    11114    -1640     
   + Partials        841      644     -197     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `24.21% <0.00%> (+15.34%)` | `4.00 <0.00> (+3.00)` | |
   | [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `23.52% <0.00%> (+5.01%)` | `1.00 <0.00> (-1.00)` | :arrow_up: |
   | [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `55.55% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `59.61% <0.00%> (ø)` | `6.00 <0.00> (ø)` | |
   | [...iver/envoy/als/mx/MetaExchangeALSHTTPAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L01ldGFFeGNoYW5nZUFMU0hUVFBBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../receiver/envoy/als/mx/ServiceMetaInfoAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L1NlcnZpY2VNZXRhSW5mb0FkYXB0ZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | ... and [392 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [b1a8238...dbd6ae9](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (d501f73) into [master](https://codecov.io/gh/apache/skywalking/commit/6bc3ba025f889b0682d651d07f5b8037f41fff9c?el=desc) (6bc3ba0) will **increase** coverage by `14.25%`.
   > The diff coverage is `14.60%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #6322       +/-   ##
   =============================================
   + Coverage     31.05%   45.30%   +14.25%     
   - Complexity     2180     2611      +431     
   =============================================
     Files           964     1767      +803     
     Lines         23384    37339    +13955     
     Branches       2263     4297     +2034     
   =============================================
   + Hits           7262    16918     +9656     
   - Misses        15570    19431     +3861     
   - Partials        552      990      +438     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `7.36% <0.00%> (-1.50%)` | `1.00 <0.00> (ø)` | |
   | [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `23.52% <0.00%> (+5.01%)` | `1.00 <0.00> (-1.00)` | :arrow_up: |
   | [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `18.51% <0.00%> (-37.04%)` | `2.00 <0.00> (ø)` | |
   | [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `65.71% <0.00%> (+65.71%)` | `0.00 <0.00> (ø)` | |
   | [...iver/envoy/als/mx/MetaExchangeALSHTTPAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L01ldGFFeGNoYW5nZUFMU0hUVFBBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../receiver/envoy/als/mx/ServiceMetaInfoAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L1NlcnZpY2VNZXRhSW5mb0FkYXB0ZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/persistence/LogsPersistence.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvcGVyc2lzdGVuY2UvTG9nc1BlcnNpc3RlbmNlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `31.81% <50.00%> (-61.04%)` | `3.00 <0.00> (ø)` | |
   | [...ver/receiver/envoy/ServiceMetaInfoFactoryImpl.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvU2VydmljZU1ldGFJbmZvRmFjdG9yeUltcGwuamF2YQ==) | `50.00% <50.00%> (ø)` | `2.00 <2.00> (?)` | |
   | ... and [1353 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [6bc3ba0...d501f73](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (8190912) into [master](https://codecov.io/gh/apache/skywalking/commit/b1a8238c159eaebda35771cd7c9c548e5eedfee1?el=desc) (b1a8238) will **increase** coverage by `6.46%`.
   > The diff coverage is `8.23%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6322      +/-   ##
   ============================================
   + Coverage     41.42%   47.88%   +6.46%     
   - Complexity     2959     3400     +441     
   ============================================
     Files           953      956       +3     
     Lines         23209    23364     +155     
     Branches       2262     2275      +13     
   ============================================
   + Hits           9614    11189    +1575     
   + Misses        12754    11199    -1555     
   - Partials        841      976     +135     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `8.04% <0.00%> (-0.82%)` | `1.00 <0.00> (ø)` | |
   | [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `23.52% <0.00%> (+5.01%)` | `1.00 <0.00> (-1.00)` | :arrow_up: |
   | [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `53.33% <0.00%> (+53.33%)` | `1.00 <0.00> (+1.00)` | |
   | [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `55.55% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `59.61% <0.00%> (ø)` | `6.00 <0.00> (ø)` | |
   | [...iver/envoy/als/mx/MetaExchangeALSHTTPAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L01ldGFFeGNoYW5nZUFMU0hUVFBBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../receiver/envoy/als/mx/ServiceMetaInfoAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L1NlcnZpY2VNZXRhSW5mb0FkYXB0ZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | ... and [169 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [b1a8238...dbd6ae9](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (b9cf4d4) into [master](https://codecov.io/gh/apache/skywalking/commit/b1a8238c159eaebda35771cd7c9c548e5eedfee1?el=desc) (b1a8238) will **decrease** coverage by `4.02%`.
   > The diff coverage is `21.34%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6322      +/-   ##
   ============================================
   - Coverage     57.47%   53.44%   -4.03%     
   + Complexity     4009     3412     -597     
   ============================================
     Files           984     1777     +793     
     Lines         24317    37757   +13440     
     Branches       2366     4321    +1955     
   ============================================
   + Hits          13976    20181    +6205     
   - Misses         9157    16593    +7436     
   + Partials       1184      983     -201     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `24.21% <0.00%> (+15.34%)` | `4.00 <0.00> (+3.00)` | |
   | [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `23.52% <0.00%> (+5.01%)` | `1.00 <0.00> (-1.00)` | :arrow_up: |
   | [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `18.51% <0.00%> (-37.04%)` | `2.00 <0.00> (ø)` | |
   | [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `65.71% <0.00%> (+65.71%)` | `0.00 <0.00> (ø)` | |
   | [...iver/envoy/als/mx/MetaExchangeALSHTTPAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L01ldGFFeGNoYW5nZUFMU0hUVFBBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../receiver/envoy/als/mx/ServiceMetaInfoAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L1NlcnZpY2VNZXRhSW5mb0FkYXB0ZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/persistence/LogsPersistence.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvcGVyc2lzdGVuY2UvTG9nc1BlcnNpc3RlbmNlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `31.81% <50.00%> (-61.04%)` | `3.00 <0.00> (ø)` | |
   | [...ver/receiver/envoy/ServiceMetaInfoFactoryImpl.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvU2VydmljZU1ldGFJbmZvRmFjdG9yeUltcGwuamF2YQ==) | `50.00% <50.00%> (ø)` | `2.00 <2.00> (?)` | |
   | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `50.00% <50.00%> (+50.00%)` | `0.00 <0.00> (ø)` | |
   | ... and [1250 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [b1a8238...dbd6ae9](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (8190912) into [master](https://codecov.io/gh/apache/skywalking/commit/b1a8238c159eaebda35771cd7c9c548e5eedfee1?el=desc) (b1a8238) will **increase** coverage by `7.09%`.
   > The diff coverage is `8.23%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6322      +/-   ##
   ============================================
   + Coverage     41.42%   48.51%   +7.09%     
   - Complexity     2959     3538     +579     
   ============================================
     Files           953      986      +33     
     Lines         23209    24191     +982     
     Branches       2262     2356      +94     
   ============================================
   + Hits           9614    11737    +2123     
   + Misses        12754    11447    -1307     
   - Partials        841     1007     +166     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `8.04% <0.00%> (-0.82%)` | `1.00 <0.00> (ø)` | |
   | [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `23.52% <0.00%> (+5.01%)` | `1.00 <0.00> (-1.00)` | :arrow_up: |
   | [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `53.33% <0.00%> (+53.33%)` | `1.00 <0.00> (+1.00)` | |
   | [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `55.55% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `59.61% <0.00%> (ø)` | `6.00 <0.00> (ø)` | |
   | [...iver/envoy/als/mx/MetaExchangeALSHTTPAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L01ldGFFeGNoYW5nZUFMU0hUVFBBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../receiver/envoy/als/mx/ServiceMetaInfoAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L1NlcnZpY2VNZXRhSW5mb0FkYXB0ZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | ... and [223 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [b1a8238...dbd6ae9](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (b9cf4d4) into [master](https://codecov.io/gh/apache/skywalking/commit/b1a8238c159eaebda35771cd7c9c548e5eedfee1?el=desc) (b1a8238) will **increase** coverage by `3.70%`.
   > The diff coverage is `14.60%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6322      +/-   ##
   ============================================
   + Coverage     41.42%   45.12%   +3.70%     
   + Complexity     2959     2529     -430     
   ============================================
     Files           953     1767     +814     
     Lines         23209    37316   +14107     
     Branches       2262     4292    +2030     
   ============================================
   + Hits           9614    16839    +7225     
   - Misses        12754    19527    +6773     
   - Partials        841      950     +109     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `24.21% <0.00%> (+15.34%)` | `4.00 <0.00> (+3.00)` | |
   | [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `23.52% <0.00%> (+5.01%)` | `1.00 <0.00> (-1.00)` | :arrow_up: |
   | [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `18.51% <0.00%> (-37.04%)` | `2.00 <0.00> (ø)` | |
   | [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `65.71% <0.00%> (+65.71%)` | `0.00 <0.00> (ø)` | |
   | [...iver/envoy/als/mx/MetaExchangeALSHTTPAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L01ldGFFeGNoYW5nZUFMU0hUVFBBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../receiver/envoy/als/mx/ServiceMetaInfoAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L1NlcnZpY2VNZXRhSW5mb0FkYXB0ZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/persistence/LogsPersistence.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvcGVyc2lzdGVuY2UvTG9nc1BlcnNpc3RlbmNlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `31.81% <50.00%> (-61.04%)` | `3.00 <0.00> (ø)` | |
   | [...ver/receiver/envoy/ServiceMetaInfoFactoryImpl.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvU2VydmljZU1ldGFJbmZvRmFjdG9yeUltcGwuamF2YQ==) | `50.00% <50.00%> (ø)` | `2.00 <2.00> (?)` | |
   | ... and [1365 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [b1a8238...dbd6ae9](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (5876350) into [master](https://codecov.io/gh/apache/skywalking/commit/6bc3ba025f889b0682d651d07f5b8037f41fff9c?el=desc) (6bc3ba0) will **decrease** coverage by `0.93%`.
   > The diff coverage is `8.23%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6322      +/-   ##
   ============================================
   - Coverage     31.05%   30.11%   -0.94%     
   + Complexity     2180     2151      -29     
   ============================================
     Files           964      990      +26     
     Lines         23384    23875     +491     
     Branches       2263     2301      +38     
   ============================================
   - Hits           7262     7191      -71     
   - Misses        15570    16159     +589     
   + Partials        552      525      -27     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `24.21% <0.00%> (+15.34%)` | `4.00 <0.00> (+3.00)` | |
   | [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `23.52% <0.00%> (+5.01%)` | `1.00 <0.00> (-1.00)` | :arrow_up: |
   | [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `55.55% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `59.61% <0.00%> (ø)` | `6.00 <0.00> (ø)` | |
   | [...iver/envoy/als/mx/MetaExchangeALSHTTPAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L01ldGFFeGNoYW5nZUFMU0hUVFBBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../receiver/envoy/als/mx/ServiceMetaInfoAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L1NlcnZpY2VNZXRhSW5mb0FkYXB0ZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | ... and [164 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [6bc3ba0...91e7ed7](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (d501f73) into [master](https://codecov.io/gh/apache/skywalking/commit/63bfb8d9ed90319553671b15627fa067db084996?el=desc) (63bfb8d) will **decrease** coverage by `9.08%`.
   > The diff coverage is `18.55%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6322      +/-   ##
   ============================================
   - Coverage     58.16%   49.08%   -9.09%     
   + Complexity     4059     2929    -1130     
   ============================================
     Files           984     1777     +793     
     Lines         24336    37682   +13346     
     Branches       2365     4307    +1942     
   ============================================
   + Hits          14155    18495    +4340     
   - Misses         8947    18204    +9257     
   + Partials       1234      983     -251     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...king/apm/agent/core/remote/GRPCChannelManager.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsTWFuYWdlci5qYXZh) | `58.88% <ø> (+10.00%)` | `0.00 <0.00> (-12.00)` | :arrow_up: |
   | [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `7.36% <0.00%> (-19.07%)` | `1.00 <0.00> (-3.00)` | |
   | [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `23.52% <0.00%> (+5.01%)` | `1.00 <0.00> (-1.00)` | :arrow_up: |
   | [...lking/oap/server/core/source/EndpointRelation.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0VuZHBvaW50UmVsYXRpb24uamF2YQ==) | `100.00% <ø> (ø)` | `4.00 <0.00> (ø)` | |
   | [...ap/server/core/source/ServiceInstanceRelation.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL1NlcnZpY2VJbnN0YW5jZVJlbGF0aW9uLmphdmE=) | `100.00% <ø> (ø)` | `5.00 <0.00> (ø)` | |
   | [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (-90.00%)` | `0.00 <0.00> (-2.00)` | |
   | [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `18.51% <0.00%> (-37.04%)` | `2.00 <0.00> (ø)` | |
   | [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `65.71% <0.00%> (+65.71%)` | `0.00 <0.00> (ø)` | |
   | [...iver/envoy/als/mx/MetaExchangeALSHTTPAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L01ldGFFeGNoYW5nZUFMU0hUVFBBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../receiver/envoy/als/mx/ServiceMetaInfoAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L1NlcnZpY2VNZXRhSW5mb0FkYXB0ZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | ... and [1305 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [5289996...8875f7e](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (8190912) into [master](https://codecov.io/gh/apache/skywalking/commit/b1a8238c159eaebda35771cd7c9c548e5eedfee1?el=desc) (b1a8238) will **increase** coverage by `12.50%`.
   > The diff coverage is `21.34%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #6322       +/-   ##
   =============================================
   + Coverage     41.42%   53.92%   +12.50%     
   - Complexity     2959     4066     +1107     
   =============================================
     Files           953     1777      +824     
     Lines         23209    37757    +14548     
     Branches       2262     4153     +1891     
   =============================================
   + Hits           9614    20361    +10747     
   - Misses        12754    16413     +3659     
   - Partials        841      983      +142     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `24.21% <0.00%> (+15.34%)` | `4.00 <0.00> (+3.00)` | |
   | [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `23.52% <0.00%> (+5.01%)` | `1.00 <0.00> (-1.00)` | :arrow_up: |
   | [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `18.51% <0.00%> (-37.04%)` | `2.00 <0.00> (ø)` | |
   | [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `65.71% <0.00%> (+65.71%)` | `0.00 <0.00> (ø)` | |
   | [...iver/envoy/als/mx/MetaExchangeALSHTTPAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L01ldGFFeGNoYW5nZUFMU0hUVFBBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../receiver/envoy/als/mx/ServiceMetaInfoAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L1NlcnZpY2VNZXRhSW5mb0FkYXB0ZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/persistence/LogsPersistence.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvcGVyc2lzdGVuY2UvTG9nc1BlcnNpc3RlbmNlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `31.81% <50.00%> (-61.04%)` | `3.00 <0.00> (ø)` | |
   | [...ver/receiver/envoy/ServiceMetaInfoFactoryImpl.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvU2VydmljZU1ldGFJbmZvRmFjdG9yeUltcGwuamF2YQ==) | `50.00% <50.00%> (ø)` | `2.00 <2.00> (?)` | |
   | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `50.00% <50.00%> (+50.00%)` | `0.00 <0.00> (ø)` | |
   | ... and [1363 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [b1a8238...dbd6ae9](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] wu-sheng commented on a change in pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#discussion_r585193674



##########
File path: docs/en/setup/envoy/als_setting.md
##########
@@ -87,3 +88,14 @@ this analyzer requires Istio to enable the metadata exchange plugin (you can ena
 or if you're using Istio 1.7+ and installing it with profile `demo`/`preview`, it should be enabled then).
 
 The [blog](https://skywalking.apache.org/blog/obs-service-mesh-vm-with-sw-and-als/) illustrates the detail of how it works, and a step-by-step tutorial to apply it into the [Online Boutique](https://github.com/GoogleCloudPlatform/microservices-demo) system.
+
+### `persistence`
+
+`persistence` analyzer adapts the Envoy access log format to
+SkyWalking's [native log format](https://github.com/apache/skywalking-data-collect-protocol/blob/master/logging/Logging.proto)
+, and forwards the formatted logs to [LAL](../../concepts-and-designs/lal.md), where you can configure persistent
+conditions, such as `sampler`, only persist error logs, etc.
+
+**Attention**: because `persistence` analyzer also needs a mechanism to map the logs into responding services, hence,
+you need to configure at least one of `k8s-mesh` or `mx-mesh` as its antecedent so that `persistence` analyzer knows which service the
+logs belong to.

Review comment:
       Let's add this as an example in the doc. I assume this, because I know how this config works, but for the end users, I think they don't know what it means by `at least one of `k8s-mesh` or `mx-mesh` as its antecedent`.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (5d644ce) into [master](https://codecov.io/gh/apache/skywalking/commit/6bc3ba025f889b0682d651d07f5b8037f41fff9c?el=desc) (6bc3ba0) will **increase** coverage by `8.93%`.
   > The diff coverage is `8.23%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6322      +/-   ##
   ============================================
   + Coverage     31.05%   39.99%   +8.93%     
   - Complexity     2180     2335     +155     
   ============================================
     Files           964      805     -159     
     Lines         23384    19716    -3668     
     Branches       2263     1847     -416     
   ============================================
   + Hits           7262     7885     +623     
   + Misses        15570    11232    -4338     
   - Partials        552      599      +47     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `8.04% <0.00%> (-0.82%)` | `1.00 <0.00> (ø)` | |
   | [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `23.52% <0.00%> (+5.01%)` | `1.00 <0.00> (-1.00)` | :arrow_up: |
   | [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `55.55% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `59.61% <0.00%> (ø)` | `6.00 <0.00> (ø)` | |
   | [...iver/envoy/als/mx/MetaExchangeALSHTTPAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L01ldGFFeGNoYW5nZUFMU0hUVFBBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../receiver/envoy/als/mx/ServiceMetaInfoAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L1NlcnZpY2VNZXRhSW5mb0FkYXB0ZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | ... and [254 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [6bc3ba0...91e7ed7](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (8190912) into [master](https://codecov.io/gh/apache/skywalking/commit/b1a8238c159eaebda35771cd7c9c548e5eedfee1?el=desc) (b1a8238) will **decrease** coverage by `12.00%`.
   > The diff coverage is `8.23%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #6322       +/-   ##
   =============================================
   - Coverage     41.42%   29.41%   -12.01%     
   + Complexity     2959     1787     -1172     
   =============================================
     Files           953      804      -149     
     Lines         23209    19391     -3818     
     Branches       2262     1777      -485     
   =============================================
   - Hits           9614     5704     -3910     
   - Misses        12754    13265      +511     
   + Partials        841      422      -419     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `8.04% <0.00%> (-0.82%)` | `1.00 <0.00> (ø)` | |
   | [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `23.52% <0.00%> (+5.01%)` | `1.00 <0.00> (-1.00)` | :arrow_up: |
   | [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `55.55% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `59.61% <0.00%> (ø)` | `6.00 <0.00> (ø)` | |
   | [...iver/envoy/als/mx/MetaExchangeALSHTTPAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L01ldGFFeGNoYW5nZUFMU0hUVFBBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../receiver/envoy/als/mx/ServiceMetaInfoAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L1NlcnZpY2VNZXRhSW5mb0FkYXB0ZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | ... and [408 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [b1a8238...dbd6ae9](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (8190912) into [master](https://codecov.io/gh/apache/skywalking/commit/b1a8238c159eaebda35771cd7c9c548e5eedfee1?el=desc) (b1a8238) will **increase** coverage by `10.02%`.
   > The diff coverage is `8.23%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #6322       +/-   ##
   =============================================
   + Coverage     41.42%   51.45%   +10.02%     
   - Complexity     2959     3672      +713     
   =============================================
     Files           953      986       +33     
     Lines         23209    24213     +1004     
     Branches       2262     2357       +95     
   =============================================
   + Hits           9614    12458     +2844     
   + Misses        12754    10651     -2103     
   - Partials        841     1104      +263     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `24.21% <0.00%> (+15.34%)` | `4.00 <0.00> (+3.00)` | |
   | [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `23.52% <0.00%> (+5.01%)` | `1.00 <0.00> (-1.00)` | :arrow_up: |
   | [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `53.33% <0.00%> (+53.33%)` | `1.00 <0.00> (+1.00)` | |
   | [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `55.55% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `59.61% <0.00%> (ø)` | `6.00 <0.00> (ø)` | |
   | [...iver/envoy/als/mx/MetaExchangeALSHTTPAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L01ldGFFeGNoYW5nZUFMU0hUVFBBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../receiver/envoy/als/mx/ServiceMetaInfoAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L1NlcnZpY2VNZXRhSW5mb0FkYXB0ZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | ... and [242 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [b1a8238...dbd6ae9](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (371efc5) into [master](https://codecov.io/gh/apache/skywalking/commit/6bc3ba025f889b0682d651d07f5b8037f41fff9c?el=desc) (6bc3ba0) will **increase** coverage by `5.60%`.
   > The diff coverage is `8.23%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6322      +/-   ##
   ============================================
   + Coverage     31.05%   36.66%   +5.60%     
   + Complexity     2180     2160      -20     
   ============================================
     Files           964      805     -159     
     Lines         23384    19673    -3711     
     Branches       2263     1844     -419     
   ============================================
   - Hits           7262     7213      -49     
   + Misses        15570    11913    -3657     
   + Partials        552      547       -5     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `8.04% <0.00%> (-0.82%)` | `1.00 <0.00> (ø)` | |
   | [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `23.52% <0.00%> (+5.01%)` | `1.00 <0.00> (-1.00)` | :arrow_up: |
   | [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `55.55% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `59.61% <0.00%> (ø)` | `6.00 <0.00> (ø)` | |
   | [...iver/envoy/als/mx/MetaExchangeALSHTTPAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L01ldGFFeGNoYW5nZUFMU0hUVFBBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../receiver/envoy/als/mx/ServiceMetaInfoAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L1NlcnZpY2VNZXRhSW5mb0FkYXB0ZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | ... and [198 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [6bc3ba0...91e7ed7](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (5d644ce) into [master](https://codecov.io/gh/apache/skywalking/commit/6bc3ba025f889b0682d651d07f5b8037f41fff9c?el=desc) (6bc3ba0) will **increase** coverage by `19.33%`.
   > The diff coverage is `8.23%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #6322       +/-   ##
   =============================================
   + Coverage     31.05%   50.38%   +19.33%     
   - Complexity     2180     3608     +1428     
   =============================================
     Files           964      986       +22     
     Lines         23384    24234      +850     
     Branches       2263     2341       +78     
   =============================================
   + Hits           7262    12211     +4949     
   + Misses        15570    10962     -4608     
   - Partials        552     1061      +509     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...log/analyzer/dsl/spec/extractor/ExtractorSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9leHRyYWN0b3IvRXh0cmFjdG9yU3BlYy5qYXZh) | `24.21% <0.00%> (+15.34%)` | `4.00 <0.00> (+3.00)` | |
   | [...ng/oap/log/analyzer/dsl/spec/sink/SamplerSpec.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9zaW5rL1NhbXBsZXJTcGVjLmphdmE=) | `23.52% <0.00%> (+5.01%)` | `1.00 <0.00> (-1.00)` | :arrow_up: |
   | [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `55.55% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `59.61% <0.00%> (ø)` | `6.00 <0.00> (ø)` | |
   | [...iver/envoy/als/mx/MetaExchangeALSHTTPAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L01ldGFFeGNoYW5nZUFMU0hUVFBBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../receiver/envoy/als/mx/ServiceMetaInfoAdapter.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L1NlcnZpY2VNZXRhSW5mb0FkYXB0ZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | ... and [363 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [6bc3ba0...91e7ed7](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (45c1b75) into [master](https://codecov.io/gh/apache/skywalking/commit/d12d3f201a315241bd7aeb5cc97c2d5103e67c02?el=desc) (d12d3f2) will **decrease** coverage by `8.87%`.
   > The diff coverage is `29.76%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6322      +/-   ##
   ============================================
   - Coverage     53.22%   44.35%   -8.88%     
   + Complexity     3845     3151     -694     
   ============================================
     Files          1731      947     -784     
     Lines         36905    23350   -13555     
     Branches       4076     2250    -1826     
   ============================================
   - Hits          19642    10356    -9286     
   + Misses        16288    12070    -4218     
   + Partials        975      924      -51     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...erver/core/analysis/data/MergableBufferedData.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9NZXJnYWJsZUJ1ZmZlcmVkRGF0YS5qYXZh) | `76.92% <0.00%> (-7.70%)` | `4.00 <0.00> (ø)` | |
   | [...lysis/manual/networkalias/NetworkAddressAlias.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL25ldHdvcmthbGlhcy9OZXR3b3JrQWRkcmVzc0FsaWFzLmphdmE=) | `2.43% <0.00%> (-56.10%)` | `0.00 <0.00> (-5.00)` | |
   | [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (-56.25%)` | `0.00 <0.00> (ø)` | |
   | [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-12.20%)` | `0.00 <0.00> (ø)` | |
   | [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-62.80%)` | `0.00 <0.00> (ø)` | |
   | [...r/function/avg/AvgHistogramPercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbVBlcmNlbnRpbGVGdW5jdGlvbi5qYXZh) | `0.00% <0.00%> (-62.12%)` | `0.00 <0.00> (-25.00)` | |
   | [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <0.00%> (-58.14%)` | `0.00 <0.00> (ø)` | |
   | [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-50.00%)` | `0.00 <0.00> (ø)` | |
   | [...oap/server/core/analysis/metrics/CountMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Db3VudE1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (-85.72%)` | `0.00 <0.00> (ø)` | |
   | [...server/core/analysis/metrics/MaxDoubleMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhEb3VibGVNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | ... and [1307 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [1e78a0a...ad99d9b](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6322: Save Envoy http access logs when error occurs

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6322:
URL: https://github.com/apache/skywalking/pull/6322#issuecomment-773342473


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=h1) Report
   > Merging [#6322](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=desc) (45c1b75) into [master](https://codecov.io/gh/apache/skywalking/commit/d12d3f201a315241bd7aeb5cc97c2d5103e67c02?el=desc) (d12d3f2) will **decrease** coverage by `8.49%`.
   > The diff coverage is `29.76%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6322/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6322      +/-   ##
   ============================================
   - Coverage     53.22%   44.73%   -8.50%     
   + Complexity     3845     3170     -675     
   ============================================
     Files          1731      947     -784     
     Lines         36905    23350   -13555     
     Branches       4076     2250    -1826     
   ============================================
   - Hits          19642    10445    -9197     
   + Misses        16288    11971    -4317     
   + Partials        975      934      -41     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...erver/core/analysis/data/MergableBufferedData.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9NZXJnYWJsZUJ1ZmZlcmVkRGF0YS5qYXZh) | `76.92% <0.00%> (-7.70%)` | `4.00 <0.00> (ø)` | |
   | [...lysis/manual/networkalias/NetworkAddressAlias.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL25ldHdvcmthbGlhcy9OZXR3b3JrQWRkcmVzc0FsaWFzLmphdmE=) | `2.43% <0.00%> (-56.10%)` | `0.00 <0.00> (-5.00)` | |
   | [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (-56.25%)` | `0.00 <0.00> (ø)` | |
   | [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-12.20%)` | `0.00 <0.00> (ø)` | |
   | [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-62.80%)` | `0.00 <0.00> (ø)` | |
   | [...r/function/avg/AvgHistogramPercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbVBlcmNlbnRpbGVGdW5jdGlvbi5qYXZh) | `0.00% <0.00%> (-62.12%)` | `0.00 <0.00> (-25.00)` | |
   | [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <0.00%> (-58.14%)` | `0.00 <0.00> (ø)` | |
   | [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-50.00%)` | `0.00 <0.00> (ø)` | |
   | [...oap/server/core/analysis/metrics/CountMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Db3VudE1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (-85.72%)` | `0.00 <0.00> (ø)` | |
   | [...server/core/analysis/metrics/MaxDoubleMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhEb3VibGVNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | ... and [1304 more](https://codecov.io/gh/apache/skywalking/pull/6322/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=footer). Last update [1e78a0a...ad99d9b](https://codecov.io/gh/apache/skywalking/pull/6322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org