You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2020/09/15 13:31:23 UTC
[GitHub] [incubator-iotdb] qiaojialin commented on a change in pull request #1732: [IOTDB-829] Accelerate delete timeseries
qiaojialin commented on a change in pull request #1732:
URL: https://github.com/apache/incubator-iotdb/pull/1732#discussion_r488666511
##########
File path: server/src/main/java/org/apache/iotdb/db/engine/StorageEngine.java
##########
@@ -447,27 +447,36 @@ public void update(String deviceId, String measurementId, long startTime, long e
// TODO
}
+ public void delete(PartialPath path, long startTime, long endTime)
+ throws StorageEngineException {
+ StorageGroupProcessor storageGroupProcessor = getProcessor(path);
Review comment:
what if the path is root.*?
##########
File path: server/src/main/java/org/apache/iotdb/db/engine/StorageEngine.java
##########
@@ -447,27 +447,36 @@ public void update(String deviceId, String measurementId, long startTime, long e
// TODO
}
+ public void delete(PartialPath path, long startTime, long endTime)
+ throws StorageEngineException {
+ StorageGroupProcessor storageGroupProcessor = getProcessor(path);
+ try {
+ storageGroupProcessor.delete(path, startTime, endTime);
+ } catch (IOException e) {
+ throw new StorageEngineException(e.getMessage());
+ }
+ }
/**
* delete data of timeseries "{deviceId}.{measurementId}" with time <= timestamp.
*/
- public void delete(PartialPath deviceId, String measurementId, long startTime, long endTime)
Review comment:
remove this
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org