You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "wyr8899 (via GitHub)" <gi...@apache.org> on 2024/01/26 02:28:57 UTC

[PR] rptun: extract rptun char to rpmsg/rpmsg.c [nuttx]

wyr8899 opened a new pull request, #11603:
URL: https://github.com/apache/nuttx/pull/11603

   ## Summary
   Ioctl is commom part in rpmsg, so extract rptun char to rpmsg/rpmsg.c.
   ## Impact
   The frameworks of rpmsg and rptun are clearer.
   ## Testing
   Tested in sim vela and 86 panel.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] rptun: extract rptun char to rpmsg/rpmsg.c [nuttx]

Posted by "anchao (via GitHub)" <gi...@apache.org>.
anchao commented on code in PR #11603:
URL: https://github.com/apache/nuttx/pull/11603#discussion_r1467215337


##########
drivers/rpmsg/rpmsg.c:
##########
@@ -74,6 +91,16 @@ rpmsg_get_by_rdev(FAR struct rpmsg_device *rdev)
   return metal_container_of(rdev, struct rpmsg_s, rdev);
 }
 
+static int rpmsg_dev_ioctl(FAR struct file *filep, int cmd,
+                           unsigned long arg)
+{
+  FAR struct rpmsg_s *rpmsg;
+
+  rpmsg = (FAR struct rpmsg_s *)filep->f_inode->i_private;

Review Comment:
   ```suggestion
     FAR struct rpmsg_s *rpmsg = filep->f_inode->i_private;
   ```



##########
drivers/rptun/rptun.c:
##########
@@ -963,18 +910,19 @@ int rptun_initialize(FAR struct rptun_dev_s *dev)
                        CONFIG_RPTUN_STACKSIZE, rptun_thread, argv);
   if (ret < 0)
     {
-      unregister_driver(name);
       nxsem_destroy(&priv->semtx);

Review Comment:
   move to line 923



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] rptun: extract rptun char to rpmsg/rpmsg.c [nuttx]

Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 merged PR #11603:
URL: https://github.com/apache/nuttx/pull/11603


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org