You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Sven Meier (JIRA)" <ji...@apache.org> on 2017/09/21 21:45:03 UTC
[jira] [Resolved] (WICKET-6471) FileSystemResource file descriptor
leak
[ https://issues.apache.org/jira/browse/WICKET-6471?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sven Meier resolved WICKET-6471.
--------------------------------
Resolution: Fixed
Assignee: Sven Meier
Fix Version/s: 8.0.0-M8
7.9.0
FileSystemResource didn't close the inputstream.
Many thanks for your investigation and quickstart!
> FileSystemResource file descriptor leak
> ---------------------------------------
>
> Key: WICKET-6471
> URL: https://issues.apache.org/jira/browse/WICKET-6471
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 7.9.0
> Reporter: Boris Goldowsky
> Assignee: Sven Meier
> Fix For: 7.9.0, 8.0.0-M8
>
> Attachments: frquickstart.zip
>
>
> FileSystemResource does not appear to close the InputStream that it creates.
> I believe it should call setClose(true) on the PartWriterCallback.
> To verify the problem, see the attached quick start. Change the filename in HomePage.java to point to some valid image file on your system. After viewing the home page in a browser, check for files that the jetty process has open, eg:
> {noformat}
> lsof -p PID | grep logo
> {noformat}
> If you load the home page a few more times, using Shift-reload to avoid simply loading from cache, you can see many file descriptors pointing to the image file are kept open:
> {noformat}
> java 87278 borisgoldowsky txt REG 1,4 12244 103583676 /Users/borisgoldowsky/idea/frquickstart/src/main/webapp/logo.png
> java 87278 borisgoldowsky 175r REG 1,4 12244 103583676 /Users/borisgoldowsky/idea/frquickstart/src/main/webapp/logo.png
> java 87278 borisgoldowsky 180r REG 1,4 12244 103583676 /Users/borisgoldowsky/idea/frquickstart/src/main/webapp/logo.png
> java 87278 borisgoldowsky 181r REG 1,4 12244 103583676 /Users/borisgoldowsky/idea/frquickstart/src/main/webapp/logo.png
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)