You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org> on 2022/01/08 01:21:07 UTC

[native-toolchain-CR] IMPALA-10951 (part 1): Upgrade protobuf library in toolchain

Wenzhe Zhou has uploaded a new patch set (#10). ( http://gerrit.cloudera.org:8080/17946 )

Change subject: IMPALA-10951 (part 1): Upgrade protobuf library in toolchain
......................................................................

IMPALA-10951 (part 1): Upgrade protobuf library in toolchain

Third party libraries - Boost, glog and protobuf in Impala native
tool-chains are be older than the corresponding libraries used by Kudu.
We need to upgrade these three libraries before rebase be/src/kudu.

This patch upgrade protobuf library from 3.5.1 to 3.14.0.
Since google::protobuf::MessageLite::ByteSize() is deprecated in
protobuf v3.14.0, we have to generate a patch for orc library to
replace the API with google::protobuf::MessageLite::ByteSizeLong().

Add a patch for protobuf which remove "sanitizer/asan_interface.h"
from protobuf/arena_impl.h and add AddressSanitizer annotations
from asan_interface.h. This avoid the compiling error in Impala
ASAN build.
Also add a patch to compile rotobuf::internal::call_once() with "-O1".
This fix the linking issue for Cland build.
Two tarballs of protobuf 3.14.0 are built - one without patches
for normal build, one with patches for Clang build.

Bump up Kudu to the latest version 67ba3cae45 which use 2.17.1 log4j.

Testing:
 - Built native toolchain with Jenkins job.
 - Built Impala with upgraded toolchain for normal and ASAN builds.

Change-Id: I6700d4f8956fb2bdff5fea3bef2572352f175f67
---
M buildall.sh
A source/orc/orc-1.7.0-patches/0005-Replace-protobuf-MessageLite-ByteSize-with-ByteSizeL.patch
A source/protobuf/protobuf-3.14.0-patches/0001-Add-AddressSanitizer-annotations-from-LLVM-asan_inte.patch
A source/protobuf/protobuf-3.14.0-patches/0002-Compile-call_once-with-optimization-O1.patch
4 files changed, 133 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/46/17946/10
-- 
To view, visit http://gerrit.cloudera.org:8080/17946
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6700d4f8956fb2bdff5fea3bef2572352f175f67
Gerrit-Change-Number: 17946
Gerrit-PatchSet: 10
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>