You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@griffin.apache.org by toyboxman <gi...@git.apache.org> on 2018/07/02 07:11:16 UTC

[GitHub] incubator-griffin pull request #331: refactor dead test cases

GitHub user toyboxman opened a pull request:

    https://github.com/apache/incubator-griffin/pull/331

    refactor dead test cases

    1.active KafkaSchemaServiceImplTest and resolve failures

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/toyboxman/incubator-griffin testcases

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-griffin/pull/331.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #331
    
----
commit c7b02f92334e78448461bf1fed92e52475795ce0
Author: Eugene <to...@...>
Date:   2018-07-02T07:07:58Z

    refactor dead test cases
    
    1.active KafkaSchemaServiceImplTest and resolve failures

----


---

[GitHub] incubator-griffin pull request #331: refactor dead test cases

Posted by toyboxman <gi...@git.apache.org>.

Github user toyboxman closed the pull request at:

    https://github.com/apache/incubator-griffin/pull/331


---

[GitHub] incubator-griffin issue #331: refactor dead test cases

Posted by guoyuepeng <gi...@git.apache.org>.

Github user guoyuepeng commented on the issue:

    https://github.com/apache/incubator-griffin/pull/331
  
    hi Jin,
    
    Could you check why build failed?
    
    Tests in error:
      JobInstanceBeanRepoTest.testFindByActiveState » IllegalState Failed to load Ap...
      JobInstanceBeanRepoTest.testFindByJobIdWithPageable » IllegalState Failed to l...
      JobInstanceRepoTest.testDeleteByExpireTimestamp » IllegalState Failed to load ...
      JobInstanceRepoTest.testFindByActiveState » IllegalState Failed to load Applic...
      JobInstanceRepoTest.testFindByExpireTmsLessThanEqual » IllegalState Failed to ...
      JobInstanceRepoTest.testFindByPredicateName » IllegalState Failed to load Appl...
      JobRepoTest.findByIdAndDeleted » IllegalState Failed to load ApplicationContex...
      JobRepoTest.findByJobNameAndDeleted » IllegalState Failed to load ApplicationC...
      JobRepoTest.findByMeasureIdAndDeleted » IllegalState Failed to load Applicatio...
      JobRepoTest.testCountByJobNameAndDeleted » IllegalState Failed to load Applica...
      JobRepoTest.testFindByDeleted » IllegalState Failed to load ApplicationContext
      DataConnectorRepoTest.testFindByConnectorNames » IllegalState Failed to load A...
      DataConnectorRepoTest.testFindByConnectorNamesWithEmpty » IllegalState Failed ...
      MeasureRepoTest.testFindByDeleted » IllegalState Failed to load ApplicationCon...
      MeasureRepoTest.testFindByIdAndDeleted » IllegalState Failed to load Applicati...
      MeasureRepoTest.testFindByNameAndDeleted » IllegalState Failed to load Applica...
      MeasureRepoTest.testFindByOwnerAndDeleted » IllegalState Failed to load Applic...
      MeasureRepoTest.testFindNameByOrganization » IllegalState Failed to load Appli...
      MeasureRepoTest.testFindOrganizations » IllegalState Failed to load Applicatio...
    
    Tests run: 141, Failures: 0, Errors: 19, Skipped: 0
    
    [INFO] ------------------------------------------------------------------------
    [INFO] BUILD FAILURE
    
    Thanks,
    William


---

[GitHub] incubator-griffin issue #331: refactor dead test cases

Posted by toyboxman <gi...@git.apache.org>.

Github user toyboxman commented on the issue:

    https://github.com/apache/incubator-griffin/pull/331
  
    root cause is about spring context association in different testcases, let me remove it and submit again


---

[GitHub] incubator-griffin issue #331: refactor dead test cases

Posted by toyboxman <gi...@git.apache.org>.

Github user toyboxman commented on the issue:

    https://github.com/apache/incubator-griffin/pull/331
  
    I don't touch those testcases, just add some test cases for kafka service.  I need to check it later


---