You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@shardingsphere.apache.org by "terrymanu (via GitHub)" <gi...@apache.org> on 2026/10/09 10:24:56 UTC

[PR] Fix encrypt example metadata constructor [shardingsphere]

terrymanu opened a new pull request, #40113:
URL: https://github.com/apache/shardingsphere/pull/40113

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Fix encrypt example metadata constructor [shardingsphere]

Posted by "terrymanu (via GitHub)" <gi...@apache.org>.

terrymanu commented on PR #40113:
URL: https://github.com/apache/shardingsphere/pull/40113#issuecomment-6079032703

   ### Result
   
   **Review Result: Mergeable**
   
   Fixed the encryption example template by adding `String.class` to the metadata constructor.
   
   ### Evidence
   
   - The fourth argument matches the algorithm’s string output; existing capability flags remain unchanged.
   - Generated the encrypt/JDBC/standalone/local example and successfully compiled all 10 Java source files.
   - Both Maven commands and `git diff --check` passed.
   - Independent review found no functional or performance regressions and no added defensive code.
   
   ### Coverage
   
   - Standalone local change based on `7c0c43316ac769ae484c2af5755a2ae26724aadb`.
   - Only one template line changed; no API or SPI changes.
   - Checkstyle and Spotless do not cover `.ftl` files. RAT was not triggered.
   - GitHub CI and database execution were not rerun. No commit was created.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Fix encrypt example metadata constructor [shardingsphere]

Posted by "terrymanu (via GitHub)" <gi...@apache.org>.

terrymanu merged PR #40113:
URL: https://github.com/apache/shardingsphere/pull/40113


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org