You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/08/23 01:50:26 UTC

[GitHub] [tvm] mehrdadh commented on a diff in pull request #12512: [bug fix] fix split filter in conv1d and conv2d to avoid empty search space

mehrdadh commented on code in PR #12512:
URL: https://github.com/apache/tvm/pull/12512#discussion_r952065783


##########
python/tvm/topi/arm_cpu/mprofile/dsp/conv1d.py:
##########
@@ -105,7 +106,12 @@ def conv1d_nwc_dsp_compute(cfg, data, kernel, strides, padding, dilation, out_dt
         policy="factors",
         num_outputs=2,
         # TODO: check case with in_channels.value % 4 != 0 with AutoTVM
-        filter=None if cfg.is_fallback else lambda x: x.size[-1] % 4 == 0,

Review Comment:
   I have a better suggestion for this which I was gonna try on dense layer, let me try it today and get back to you



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org