You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2020/05/29 09:25:32 UTC

[GitHub] [fineract] thesmallstar edited a comment on pull request #943: FINERACT-1006 Added spotless to auto format source code

thesmallstar edited a comment on pull request #943:
URL: https://github.com/apache/fineract/pull/943#issuecomment-635871955


   Update:
   1. I have decided to go with google-checks instead of our old XML, since it is more complete. As suggested by @vorburger I have updated the indentation to 4.
   2. I have commented all the checks that formats "comments/javadocs"
   3. Spotless loves to add trailing spaces, so I have added action(see spotless section) in build.gradle and asked it to fix itself ;) 
   4. If this is merged many hard-to-implement checkstyles like, the one related to spaces and line-wraps can be directly added (I have verified spaces checkstyles)
   5. Indentation checkstyle still do not directly match with what spotless offers, but spotless can take good care of indentation (I believe).
   
   What do you think @vorburger  @awasum  @xurror 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org