You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by "damccorm (via GitHub)" <gi...@apache.org> on 2023/09/13 20:56:49 UTC

[GitHub] [beam] damccorm commented on a diff in pull request #28440: Fix Java PreCommit Action correct branch to run

damccorm commented on code in PR #28440:
URL: https://github.com/apache/beam/pull/28440#discussion_r1325070157


##########
.github/workflows/beam_PreCommit_Java.yml:
##########
@@ -172,10 +173,11 @@ jobs:
             -PdisableSpotlessCheck=true \
             -PdisableCheckStyle=true \
       - name: Upload test report
+        if: failure()

Review Comment:
   Should this be `if: always()`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org