You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by robpaveza <gi...@git.apache.org> on 2015/05/02 00:04:47 UTC
[GitHub] cordova-js pull request: Experimental addition for CB-8674: Create...
GitHub user robpaveza opened a pull request:
https://github.com/apache/cordova-js/pull/108
Experimental addition for CB-8674: Creates a 'cordova.env' object, and
Creates a 'cordova.env' object, and then on Windows hangs the activation arguments off of cordova.env.args. This should allow plugins to capture the activation arguments even though the 'activated' event fires before plugins load on Windows.
Before merging, let's make sure the change satisfies the bug.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-js CB-8674
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-js/pull/108.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #108
----
commit 6e05b62f3dee3cda3ed4d307dc1008c79d6131e2
Author: Rob Paveza <ro...@microsoft.com>
Date: 2015-05-01T21:58:46Z
Experimental addition for CB-8674: Creates a 'cordova.env' object, and
then on Windows hangs the activation arguments off of cordova.env.args.
This should allow plugins to capture the activation arguments even though
the 'activated' event fires before plugins load on Windows.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-js pull request: CB-8674: Creates a 'cordova.env' object.....
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-js/pull/108
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
Re: [GitHub] cordova-js pull request: CB-8674: Creates a 'cordova.env' object.....
Posted by Jesse <pu...@gmail.com>.
Looking.
> On May 5, 2015, at 6:12 PM, nikhilkh <gi...@git.apache.org> wrote:
>
> Github user nikhilkh commented on the pull request:
>
> https://github.com/apache/cordova-js/pull/108#issuecomment-99280031
>
> LGTM. @purplecabbage - Thoughts?
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
> with INFRA.
> ---
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> For additional commands, e-mail: dev-help@cordova.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-js pull request: CB-8674: Creates a 'cordova.env' object.....
Posted by nikhilkh <gi...@git.apache.org>.
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-js/pull/108#issuecomment-99280031
LGTM. @purplecabbage - Thoughts?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org