You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pegasus.apache.org by GitBox <gi...@apache.org> on 2022/08/26 03:04:50 UTC
[GitHub] [incubator-pegasus] hycdong opened a new pull request, #1139: feat(backup): 7. replica upload backup files
hycdong opened a new pull request, #1139:
URL: https://github.com/apache/incubator-pegasus/pull/1139
https://github.com/apache/incubator-pegasus/issues/1081
This pr is about that replica server receive `backup_request` with uploading status.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] acelyc111 commented on a diff in pull request #1139: feat(backup): 7. replica upload backup files
Posted by GitBox <gi...@apache.org>.
acelyc111 commented on code in PR #1139:
URL: https://github.com/apache/incubator-pegasus/pull/1139#discussion_r961540213
##########
src/rdsn/src/replica/backup/replica_backup_manager.h:
##########
@@ -102,8 +134,13 @@ class replica_backup_manager : replica_base
backup_status::type _status{backup_status::UNINITIALIZED};
int64_t _backup_id{0};
error_code _checkpoint_err{ERR_OK};
+ error_code _upload_err{ERR_IO_PENDING};
Review Comment:
Is it OK to initialize it to 'ERR_OK'?
##########
src/rdsn/src/replica/backup/replica_backup_manager.h:
##########
@@ -59,14 +59,40 @@ class replica_backup_manager : replica_base
private:
void try_to_checkpoint(const int64_t &backup_id, /*out*/ backup_response &response);
+ void try_to_upload(const std::string &provider_type,
+ const std::string &root_path,
+ const std::string app_name,
Review Comment:
`const std::string &app_name`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] hycdong merged pull request #1139: feat(backup): 7. replica upload backup files
Posted by GitBox <gi...@apache.org>.
hycdong merged PR #1139:
URL: https://github.com/apache/incubator-pegasus/pull/1139
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org