You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@libcloud.apache.org by zym-ustc <gi...@git.apache.org> on 2017/11/09 07:54:37 UTC

[GitHub] libcloud pull request #1140: Modify XML for Aliyun ECS: describe_security_gr...

GitHub user zym-ustc opened a pull request:

    https://github.com/apache/libcloud/pull/1140

    Modify XML for Aliyun ECS: describe_security_group_attributes

    ## Aliyun ECS: Modify describe_security_group_attributes.xml
    
    ### Description
    
    When I read the code in ecs.py, I find [describe_security_group_attributes.xml](https://github.com/apache/libcloud/blob/trunk/libcloud/test/compute/fixtures/ecs/describe_security_group_attributes.xml) doesn't match its title.
    Then I replace the content with the actual result.
    
    Reference: [Aliyun API Doc - DescribeSecurityGroupAttribute](https://help.aliyun.com/document_detail/25555.html?spm=5176.doc25556.6.893.9yP6oY)
    
    ### Status
    
    done, ready for review
    
    ### Checklist (tick everything that applies)
    
    - [ ] [Code linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide) (required, can be done after the PR checks)
    - [ ] Documentation
    - [x] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html)
    - [ ] [ICLA](http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes) (required for bigger changes)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zym-ustc/libcloud trunk

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/libcloud/pull/1140.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1140
    
----
commit 67f4411dde4cf77e8c5b89aee39bc87ff37e417b
Author: root <ro...@localhost.localdomain>
Date:   2017-11-09T07:18:46Z

    modify XML for Aliyun ECS: describe_security_group_attributes

----


---

[GitHub] libcloud pull request #1140: Aliyun ECS: Add support to modify attributes of...

Posted by zym-ustc <gi...@git.apache.org>.
GitHub user zym-ustc reopened a pull request:

    https://github.com/apache/libcloud/pull/1140

    Aliyun ECS: Add support to modify attributes of security group

    ## Aliyun ECS: Add support to modify attributes of security group
    
    ### Description
    
    - [describe_security_group_attributes.xml](https://github.com/apache/libcloud/blob/trunk/libcloud/test/compute/fixtures/ecs/describe_security_group_attributes.xml) doesn't match its title.
    - Can't modify security group name or description via ECS driver currently
    
    Reference: 
    [Aliyun API Doc - DescribeSecurityGroupAttribute](https://help.aliyun.com/document_detail/25555.html?spm=5176.doc25556.6.893.9yP6oY)
    [Aliyun API Doc - ModifySecurityGroupAttribute](https://help.aliyun.com/document_detail/25559.html?spm=5176.doc25555.6.897.J4hUYN)
    
    ### Status
    
    work in progress
    
    ### Checklist (tick everything that applies)
    
    - [x] [Code linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide) (required, can be done after the PR checks)
    - [ ] Documentation
    - [x] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html)
    - [ ] [ICLA](http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes) (required for bigger changes)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zym-ustc/libcloud trunk

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/libcloud/pull/1140.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1140
    
----
commit 67f4411dde4cf77e8c5b89aee39bc87ff37e417b
Author: root <ro...@localhost.localdomain>
Date:   2017-11-09T07:18:46Z

    modify XML for Aliyun ECS: describe_security_group_attributes

commit 9c6f3f0d03fe274253555f399fddd07e226df53d
Author: root <ro...@localhost.localdomain>
Date:   2017-11-09T08:05:16Z

    fix two typos

commit dd7c40c1fc09c4554fa71d511f9ea1793b5ee7ff
Author: Zhang Yiming <zy...@gmail.com>
Date:   2017-11-09T08:07:51Z

    two typos

commit 3af6715d279b5cf87cfe706a4f6448b090d5dc6e
Author: root <ro...@localhost.localdomain>
Date:   2017-11-15T02:36:47Z

    Aliyun ECS: Add support to modify attributes of security group

commit 072b5f6bb8d3cb2a6093a7f20e07a7a0dd1937a9
Author: root <ro...@localhost.localdomain>
Date:   2017-11-15T02:37:37Z

    Aliyun ECS: Add support to modify attributes of security group

commit 1c525e5b64e3bed504c493c0eb31f0fc7dcb7964
Author: root <ro...@localhost.localdomain>
Date:   2017-11-15T02:40:00Z

    Merge branch 'trunk' of https://github.com/zym-ustc/libcloud into trunk

commit 73f0dca70774feec56531c5c519899566b4d5883
Author: root <ro...@localhost.localdomain>
Date:   2017-11-15T03:20:37Z

    Aliyun ECS : format code of modify_security_group_attributes

commit f4090d17739015fc22e46536252c0271a386e85e
Author: root <ro...@localhost.localdomain>
Date:   2017-11-15T03:46:00Z

    format code of test_ecs.py

commit bff8e6f433824bdaa4b6737215270cc0c9c9dd6a
Author: root <ro...@localhost.localdomain>
Date:   2017-11-15T07:01:43Z

    roll back the change in ecs.py and test_ecs.py

commit a3b7e6214201e577851da1acdccd9212a02ffb57
Author: zym-ustc <zy...@gmail.com>
Date:   2017-11-15T07:11:03Z

    roll back in delete_security_group_by_id.xml

commit efd20479815cfd4b7898dba7a7961c37b1d55c31
Author: zym-ustc <zy...@gmail.com>
Date:   2017-11-15T07:14:32Z

    roll back modify_security_group_by_id.xml

commit 92d47512ff44b6ccc03352fb6075072c75b4b874
Author: zym-ustc <zy...@gmail.com>
Date:   2017-11-15T07:17:22Z

    roll bakc describe_security_group_attributes.xml

commit 14c078c3cb69c0b94d0e18977d472d46ec5c6d48
Author: zym-ustc <zy...@gmail.com>
Date:   2017-11-15T07:31:46Z

    reapply changes to support modify_security_group_attributes

----


---

[GitHub] libcloud pull request #1140: Aliyun ECS: Add support to modify attributes of...

Posted by zym-ustc <gi...@git.apache.org>.
Github user zym-ustc closed the pull request at:

    https://github.com/apache/libcloud/pull/1140


---

[GitHub] libcloud pull request #1140: Aliyun ECS: Add support to modify attributes of...

Posted by zym-ustc <gi...@git.apache.org>.
Github user zym-ustc closed the pull request at:

    https://github.com/apache/libcloud/pull/1140


---