CacheWriter#writeAll javadocs inconsistent with implementations ?

[Kristian Rosenvold <kr...@apache.org>]

The javadocs for CacheWriter#writeAll say

"If this operation fails (by throwing an exception) after a partial success,
the writer must remove any successfully written entries from the entries
collection so that the caching implementation knows what succeeded and can
mutate the cache."

Now it looks to me like none of the current implementations of this
method actually
obey this requirement, CacheStoreAdapter#writeAll being an example.

Is the javadoc wrong or the implementations ?


Kristian

Re: CacheWriter#writeAll javadocs inconsistent with implementations ?

[Valentin Kulichenko <va...@gmail.com>]

Hi Kristian,

I looked through your pull request and left my comments in the ticket.
Before continuing the work, please go though the page [1], write a 'Hi!'
email to the dev list with your JIRA username so that they can add you to
the contributors list, and then assign the ticket to yourself.

Thanks for your efforts!

[1] http://ignite.apache.org/community/contribute.html#contribute

-Val

On Tue, Aug 16, 2016 at 1:01 PM, vkulichenko <va...@gmail.com>
wrote:

> Hi Kristian,
>
> That's actually a good point! I see that we're handling this properly in
> the
> cache store manager, but our own implementation are not correct. I created
> a
> ticket: https://issues.apache.org/jira/browse/IGNITE-3700
>
> -Val
>
>
>
> --
> View this message in context: http://apache-ignite-users.
> 70518.x6.nabble.com/CacheWriter-writeAll-javadocs-inconsistent-with-
> implementations-tp7101p7113.html
> Sent from the Apache Ignite Users mailing list archive at Nabble.com.
>

Re: CacheWriter#writeAll javadocs inconsistent with implementations ?

[vkulichenko <va...@gmail.com>]

Hi Kristian,

That's actually a good point! I see that we're handling this properly in the
cache store manager, but our own implementation are not correct. I created a
ticket: https://issues.apache.org/jira/browse/IGNITE-3700

-Val



--
View this message in context: http://apache-ignite-users.70518.x6.nabble.com/CacheWriter-writeAll-javadocs-inconsistent-with-implementations-tp7101p7113.html
Sent from the Apache Ignite Users mailing list archive at Nabble.com.